Jeff Boek
1b1f9348dc
No Issue - Fixes warnings / compiler errors with A-C update
2019-11-28 12:45:45 +01:00
mcarare
f69eb83141
For #4219 Set url view not important for accessibility
...
Talkback rectangle for url view selection will include parent view
2019-11-27 10:11:16 -08:00
Tiger Oakes
422faaf7c0
Add toolbar helpers ( #6531 )
2019-11-25 15:36:47 -05:00
mcarare
1d36098878
For #1019 Add onboarding search suggestion hint panel
2019-11-21 14:36:14 -08:00
mcarare
5543f3272d
For #1019 Add option to enable search suggestions in private mode
2019-11-21 14:36:14 -08:00
mcarare
ef3c3de8a1
For #6625 Fix back navigation in search mode from browser
2019-11-21 14:35:12 -08:00
Jeff Boek
607c3d4c87
Adds custom search engines ( #6551 )
...
* For #5577 - Adds button to add a new search engine
* For #5577 - Adds custom engine store
* For #5577 - Creates a custom SearchEngineProvider
* For #5577 - Gives the ability to delete search engines
* For #5577 - Adds the UI to add a custom search engine
* For #5577 - Adds form to create a custom search engine
* For #5577 - Adds the ability to add a custom search engine
* For #5577 - Adds the ability to delete custom search engines
* For #5577 - Selects the first element on the add custom search engine screen
* For #5577 - Prevents adding a search engine that already exists
* For #5577 - Styles the add search engine preference
* For #5577 - Makes the name check case-insensitive
* For #5577 - Fix bug where home screen doesnt see new search engines
* For #5577 - Moves Search URL validation to its own type
* For #5577 - Fixes linting errors
* For #5577 - Adds the ability to edit a custom search engine
* For #5577 - Allows the user to edit a serach engine even when it is the last item in the list
* For #5577 - Adds an undo snackbar when deleting a search engine
* For #5577 - Moves all of the strings to be translated
* For #5577 - Fixes bug when deleting your default search engine
* For #5577 - Puts adding search engines behind a feature flag
* For #5577 - Navigate to custom search engine SUMO article when tapping learn more
* For #5577 - Fixes nits
* For #5577 - Uses concept-fetch to validate search string
* For #5577 - Adds string resources for the cannot reach error state
2019-11-19 16:30:56 -08:00
Mihai Adrian
1388156953
For #1211 Hide the keyboard when scrolling through engine suggestions ( #6474 )
2019-11-08 14:36:39 -08:00
Sebastian Kaspari
9543f38978
Use new toolbar API of AC 18.0.0.
2019-10-24 08:57:30 -07:00
shldhll
8e17ac05b1
Optimized imports. Closes #5876
2019-10-10 04:17:43 +05:30
shldhll
f907ec52f0
Removed ObsoleteCoroutinesApi in tests. Closes #5876
2019-10-10 04:04:51 +05:30
Sawyer Blatz
785b8b9519
For #5567 : Removes search shortcuts button ( #5739 )
...
* For #5567 : Removes search shortcut button
* No issue: Simplifies logic for displaying shortcuts
2019-10-03 08:53:16 -07:00
Emily Kager
3f41a4e9c6
No issue: Update navigation library
2019-09-26 17:01:13 -07:00
Tiger Oakes
8c30200ced
Only use Context.settings() function (not getter) ( #5335 )
...
Remove unused String extensions
2019-09-24 10:33:46 -07:00
Sawyer Blatz
f02603be37
For #5460 : Fixes styling of fill link from clipboard ( #5464 )
2019-09-20 15:29:16 -07:00
Sawyer Blatz
2db2d9ceae
For #1744 : Adds tests for clipboard
2019-09-19 08:24:27 -07:00
Sawyer Blatz
e961a9d63d
For #1744 : Adds clipboard provider to search engine screen
2019-09-19 08:24:27 -07:00
Tiger Oakes
284cbab9ea
Use .orEmpty()
2019-09-17 11:09:21 -07:00
Sawyer Blatz
fdd2b59fb8
For #4155 : Adds popup menu for browser toolbar
2019-09-11 09:03:17 -07:00
Mihai Adrian
a31eb1f371
Code Health #4883 : Refactored accessing settings by using Context extensions ( #4973 )
2019-09-10 10:11:58 -07:00
Sawyer Blatz
2653b5966e
For #964 : Adds ability to disable each suggestion provider ( #5096 )
...
* For #964 : Adds ability to disable each suggestion provider
* Fix nit
2019-09-05 14:45:44 -07:00
Sebastian Kaspari
61e84c161d
Rename SearchStore/State/Action to SearchFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Christian Sadilek
4cf03be236
For #2088 : Use new async API to load default search engine in HomeFragment
2019-08-30 17:56:18 -04:00
Sourabh
1afc0eacd8
For #4399 : Create LibState Controller for Search ( #4673 )
...
* For #4399 : Create LibState Controller for Search
* fix code format
* add unit tests for DefaultSearchController
* add more test
* fix unit tests
2019-08-20 09:07:00 -07:00
Yeon Taek Jeong
d4c83f9668
For #4736 : Display search shortcuts only from home or search widget
2019-08-15 12:24:54 -04:00
Yeon Taek Jeong
2f265eccbd
For #4732 : Fix search engine display issue ( #4735 )
2019-08-14 11:03:14 -07:00
Tiger Oakes
52542708aa
Consodilate private browsing code
2019-08-09 11:00:41 -07:00
Emily Kager
0b98d43c23
Closes #4602 - Add back transitions
2019-08-07 16:56:21 -07:00
Sawyer Blatz
da06b0fb15
For #4508 : Treats warnings as errors ( #4543 )
2019-08-07 14:00:53 -07:00
ValentinTimisica
59c60ef189
Fixes #4354 : Updated SearchFragment state after returning from SearchEngineFragment.
...
The user has the option to go to 'Shortcuts' -> 'Search engine settings' to
modify the default search engine. When returning from that settings screen we
need to update it to account for any changes.
For this we will check the current default engine against a previously stored
value in a newly added 'defaultEngineSource' property from SearchState class.
Also, I modified 'SearchStoreTest' by adding the new parameter to the
'SearchState' constructor.
2019-08-07 13:19:53 -07:00
Yeon Taek Jeong
6f962d3376
For #1744 : Open search shortcuts when entering search mode ( #4536 )
2019-08-05 15:07:03 -07:00
Nikit Bhandari
671727c3e8
For #4341 use camelCase for views referenced from code
2019-08-03 09:25:55 -07:00
Yeon Taek Jeong
83ceec6289
For #201 : Search Widget
2019-08-02 11:26:48 -07:00
Amaan Marfatia
4c13f45e9e
Fixes #4192 : Private keyboard in private browsing ( #4345 )
...
Sets compliant keyboards to private mode when in private browsing.
2019-07-29 18:00:48 -04:00
Tiger Oakes
c2e6e25bef
Fixes #4005 - Move getColorFromAttr to Context
2019-07-26 16:44:11 -04:00
Christian Sadilek
1846a61475
For #4096 : Use new A-C API to observe store / state changes
...
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
2019-07-26 10:40:33 -04:00
Sawyer Blatz
28eb5c541a
For #1944 & #1750 : Updates private & night mode colors ( #4232 )
2019-07-23 09:35:24 -07:00
Tiger Oakes
edb0a3ed08
For #3633 - Update StoreProvider to use a callback
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2019-07-18 18:16:49 -04:00
Christian Sadilek
c04dcec03f
Closes #4096 : IllegalStateException in SearchFragment ( #4131 )
2019-07-17 15:10:24 -05:00
Jeff Boek
ec099a6e11
For #3633 - Creates generic store provider ( #4060 )
2019-07-15 15:54:13 -07:00
Christian Sadilek
e91a2e61a2
For #3633 : Add unit tests for SearchStore
2019-07-15 13:47:01 -04:00
Jeff Boek
e4ff70c542
For #3633 - Refactors the search screen to use lib-state
...
* For #3633 - Adds SearchStore
* For #3633 - Refactors AwesomeBarUIView
* For #3633 - Refactors ToolbarUIView to use lib-state
* For #3633 - Fixes a couple of state bugs
* For #3633 - Moves all user interaction to SearchInteractor
* For #3633 - Adds kdocs to SearchStore and SearchInteractor
* For #3633 - Adds documentation for the properties on SearchState
Also removes uneccessary property
* For #3633 - Creates `StateViewModel` to handle state restoration
* For #3633 - Adds a test for onTextChanged
* For #3633 - Adds tests for SearchInteractor
* For #3633 - Fixes bugs and adds documentation
2019-07-12 16:32:00 -07:00
Emily Kager
867067537a
For #3568 - Use correct styling for QR and Share Alert Dialogs
2019-07-12 11:40:33 -07:00
Tiger Oakes
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
Jeff Boek
f323c38be0
For #981 - Adds missing Leanplum events
2019-06-14 13:27:50 -07:00
Colin Lee
d5c5587a0c
For #3209 : Disable shared element animations for crash temporarily ( #3482 )
2019-06-14 12:13:13 -05:00
Emily Kager
5eb2bc6d55
For #3138 - Sets height of toolbar in SearchFragment to match_parent ( #3400 )
2019-06-12 19:44:44 -05:00
Colin Lee
66a836cf3a
For #3314 : Toolbar and QAB unresponsive after Android 6 perms check ( #3373 )
2019-06-12 10:08:39 -05:00
Sawyer Blatz
86aac3e313
For #3176 : Hides camera options on devices without cameras ( #3273 )
2019-06-07 19:37:43 -05:00
Jonathan Almeida
f7bd39da77
For #3138 : Fix white background on search bar
2019-06-06 17:11:06 -07:00
Denys M
605a552f16
For #1366 . Update toolbar search state when typing. ( #2908 )
2019-06-06 08:16:22 -07:00
Emily Kager
8dbed67f7f
No issue: Simplify and speed up shared element transitions
2019-05-30 16:30:06 -07:00
Emily Kager
43a961fe73
For #1973 - Toggle QR button on deny permissions, fix engineView crashes
2019-05-30 16:06:37 -07:00
Emily Kager
8181705b58
Init Toolbar in edit mode so we don't see the flash
2019-05-29 12:27:48 -07:00
ekager
dee3c059dc
Adds Shared Transition between Home and Search
2019-05-29 12:27:48 -07:00
Emily Kager
a80053547e
For #2806 - navigate up from SearchFragment instead of activity back press ( #2812 )
2019-05-23 21:30:05 -07:00
Emily Kager
e534dad199
For #2028 - Pass Session ID for Custom Tab Prompts, Theme Dialogs
2019-05-20 19:24:48 -07:00
Emily Kager
028c6cad70
For #2025 - Create and theme Dialog for deleting all history
2019-05-20 19:24:48 -07:00
Sawyer Blatz
9e50b55340
For #1857 : Adds telemetry for QR scanner
2019-05-17 10:46:53 -07:00
Jeff Boek
c5e5ef4b25
Teases apart ViewModel dependencies ( #2499 )
...
* No Issue - pulls render outside of the viewmodel
* No Issue - Properly subscribes to the changesObservable
* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
Colin Lee
ccbc14a71f
For #1994 : Re-architect state handling code ( #2382 )
2019-05-09 23:06:12 +00:00
Emily Kager
e4b4934f53
For #2393 - SearchTermsTapped even on URL should search ( #2398 )
2019-05-09 16:21:33 -05:00
Sawyer Blatz
70486039c0
Closes #2147 : Refactors usage of openToBrowserAndLoad
2019-04-29 15:49:22 -07:00
Colin Lee
5b7e297adf
For #1955 : Add prompt before loading QR code ( #2096 )
2019-04-28 01:00:55 -05:00
Emily Kager
97e4f43fda
No issue: null check context on permission granted ( #2104 )
2019-04-26 22:02:50 -07:00
Sawyer Blatz
29238d6e5f
For #1954 : Hides keyboard when requesting camera permission
2019-04-26 15:53:38 -07:00
Sawyer Blatz
46924544b6
For #1975 & #1627 : Refactors getSessionById in BrowserFragment
2019-04-25 16:51:03 -07:00
Sawyer Blatz
4945805e37
For #1954 : Resolves QR scanner back press and keyboard issues ( #2036 )
2019-04-25 12:31:17 -07:00
Jeff Boek
31494a4341
Sets the search engine to the default if no shortcut is used
2019-04-23 17:39:57 -05:00
Sawyer Blatz
8a4995099f
For #1205 : Adds search term to EditToolbar
2019-04-23 09:59:48 -07:00
Colin Lee
6199d31924
For #1851 : QR code scanner doesn't load right after permission grant
2019-04-22 13:56:43 -07:00
Colin Lee
d1fd5ec879
For #113 : QR Scan
2019-04-19 14:47:53 -07:00
Jeff Boek
cb7ad32b62
For #1158 - Add search counts
2019-04-17 10:04:49 -07:00
Sawyer Blatz
f48e2b072e
No issue: Cleans up SearchShortcut changes
2019-04-17 11:20:59 -05:00
Sawyer Blatz
471b08d97a
Closes #1194 : Adds shortcut telemetry
2019-04-03 11:12:17 -05:00
Sawyer Blatz
36af5107c6
Closes #875 : Adds search shortcuts ( #882 )
...
* Closes #875 : Adds shortcuts
* Refactor and clean up
* Remove TODO
* Removes local
* Fix nits
* Refactors to add ShortcutEngineManager
2019-03-29 13:49:50 -07:00
Jeff Boek
edb197d10b
Adds search engine icon to the toolbar
2019-03-25 14:42:13 -07:00
Jeff Boek
32f8e06e98
For #959 - Adds search related telemetry
2019-03-22 17:14:35 -07:00
Colin Lee
df40ec970e
Simplify ItsNotBrokenSnack() and make resilient
...
Co-authored by: Emily Kager <ekager@mozilla.com>
2019-03-22 15:00:38 -05:00
Emily Kager
4963f7ccdb
Add Snackbar to link testers to Github issue for features
2019-03-22 15:00:38 -05:00
Sawyer Blatz
9d18bbad12
Closes #847 : Implement onCancelEditing to handle keyboard backPress ( #929 )
2019-03-13 11:12:58 -07:00
Arturo Mejia
fd4acf6e92
Upgrade AC dependency to 0.47.0-SNAPSHOT and GV to 67.0.20190312095443 ( #958 )
...
* Upgrade AC dependency to 0.47.0-SNAPSHOT and GV to 67.0.20190312095443
* Fix compliation errors
2019-03-12 08:49:22 -07:00
Sawyer Blatz
a79134fdc3
Closes #823 & Closes #835 : Refactors openToBrowserAndLoad to include fromFragment ( #833 )
2019-03-06 14:53:49 -08:00
ekager
c4674a9026
Closes #754 - Restore SearchFragment navigation logic
2019-03-01 00:02:52 -08:00
Jeff Boek
104b6fbf22
No issue - pulls logic outside of the UIView
2019-02-28 14:19:49 -06:00
Sawyer Blatz
e57aa67d60
Closes #664 & Closes #665 : Refactors load to respect private mode ( #667 )
2019-02-28 09:25:37 -08:00
Emily Kager
5b8d40e6e0
Closes #655 - Show/Hide toolbar in onResume
2019-02-25 11:45:59 -08:00
nikit19
9d6ea0ac28
disable blank searches
2019-02-24 08:29:52 -08:00
Sawyer Blatz
53f391de60
Closes #537 : Refactors private sessions ( #629 )
2019-02-22 09:49:02 -08:00
Jeff Boek
5ab49ff7cf
For #507 - Leaves a comment to explain the current state
2019-02-21 11:29:13 -08:00
Jeff Boek
bacf84678d
For #507 - Moves the loading of the URL to the fragment
2019-02-21 11:29:13 -08:00
Sawyer Blatz
797d1cc423
Fixes #566 : Clears search on new tab
2019-02-20 15:32:24 -06:00
Colin Lee
291f21aa8e
Handle listener state bugs as onViewCreated isn't always called
2019-02-19 09:08:25 -08:00
Colin Lee
6d71faa44d
Fixes #541 : Crash on Home Screen
...
The Android Lifecycle Architecture component does not have fine-grained enough lifecycle event callbacks to safely manage Rx subscriptions in Fragment lifecycles. Added autodispose to simplify.
2019-02-16 19:40:39 -08:00
Sawyer Blatz
e5fe80f928
Closes #347 : Adds private browsing logic ( #506 )
...
* For #347 : Adds private browsing logic
* For #347 : Adds private session explainer
* Adds persistence
2019-02-15 09:31:03 -08:00
Jeff Boek
4873d989a0
Moves the shared toolbar component to the components package
2019-02-12 16:25:40 -08:00
Colin Lee
f09dc2453f
Fixes #351 Create home screen component for multitasking
2019-02-09 15:52:10 -06:00
Emily Kager
77883c0f30
Closes #403 Use Fragments for Navigation, Add Toolbar to HomeActivity
2019-02-08 12:57:38 -08:00
Jeff Boek
461664ed87
For #364 - Refactors BrowserFragment to use the ToolbarComponent
...
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
Co-authored-by: Emily Kager <emilykager@gmail.com>
2019-02-04 16:44:10 -08:00
Jeff Boek
dbea570747
For #364 - Moves edit mode to be a part of the toolbar component state
...
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
Co-authored-by: Emily Kager <emilykager@gmail.com>
2019-02-04 16:44:10 -08:00