Tiger Oakes
ac6c1ec2ee
Closes #2690 - Clean up CreateCollection viewmodel ( #4731 )
2019-08-20 10:45:41 -07:00
Tiger Oakes
9ee8c00928
For #4774 - Use vector drawable compat ( #4811 )
2019-08-20 10:43:02 -07:00
Tiger Oakes
ad98b2f3ea
For #4744 - Extract private browsing button ( #4813 )
2019-08-20 10:41:18 -07:00
Tiger Oakes
090e8006b0
Color the system bars in custom tabs ( #4819 )
2019-08-20 10:13:01 -07:00
Tiger Oakes
95ef312b1e
Issue #1000 - Remove isCustomTab flag ( #4656 )
2019-08-20 10:00:49 -07:00
Sourabh
1afc0eacd8
For #4399 : Create LibState Controller for Search ( #4673 )
...
* For #4399 : Create LibState Controller for Search
* fix code format
* add unit tests for DefaultSearchController
* add more test
* fix unit tests
2019-08-20 09:07:00 -07:00
Mugurell
ab6e7dc52b
Fix 4827 - Use ktx doOnPreDraw() to restore HomeFragment's layout
...
The previous solution would result in a crash because the passed in
viewTreeObserver that would trigger onPreDraw would be invalid.
The proposed solution is simpler and ensures we'll always use the right
viewTreeObserver.
`FragmentPreDrawManager` is general enough that can be used by other Fragments
also, so I've added it to the `utils` package.
2019-08-20 13:45:55 +02:00
Tiger Oakes
b8c93107c0
For #4744 - Extract TransitionPreDrawListener ( #4812 )
2019-08-19 16:27:43 -07:00
Tiger Oakes
a632d8f1dc
For #4744 - Move search bar icon padding to dimens ( #4814 )
2019-08-19 16:22:51 -07:00
Emily Kager
fb1d655d96
Closes #4822 - Update Bookmark State in onResume ( #4823 )
2019-08-19 16:22:20 -07:00
Sawyer Blatz
0d4eceed56
For #2706 : Refactor Glean to reduce errors ( #4753 )
...
* For #2706 : Adds recording for untracked events
* For #2706 : Adds key alignment to Metrics
2019-08-19 15:25:48 -07:00
Sawyer Blatz
4731977f5d
For #4421 : Fixes issues with new glean events ( #4816 )
2019-08-19 14:49:48 -07:00
Sawyer Blatz
73e3db8fe0
For #4804 : Resolves issue with crash reporter stack
2019-08-19 16:40:41 -04:00
Arturo Mejia
210868f5bc
Use Mozilla Android Components 9.0.0-SNAPSHOT. ( #4750 )
2019-08-19 10:29:10 -07:00
Suraj Shah
806961094b
Fixes #4704 ( #4728 )
...
* Fixes #4704 . Overrides `setEnabled` for DeleteBrowsingDataItem to change view alpha when disabled and to toggle the checkbox `isEnabled` behavior based on the value provided.
* Updates CHANGELOG.md
* Removes unnecessary disabling of checkbox in DeleteBrowsingDataItem.kt
Updates CHANGELOG.md to reflect the component changed.
2019-08-19 09:23:12 -07:00
Mugurell
645674c9bd
Closes #4396 - Add a Bookmarks Controller ( #4593 )
...
* For #4396 - Rename BookmarkInteractor methods
Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.
Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.
* For #4396 - Add a BookmarkController
It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.
This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.
* For #4396 - Refactored Bookmark related tests
Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`
Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
Tiger Oakes
de14962e3f
Extract quick action sheet observer code ( #4368 )
2019-08-19 08:28:33 -07:00
Emily Kager
7d02354f4f
For #4799 #4790 - Don't use passed in sessions in BrowserToolbarController ( #4800 )
2019-08-18 20:36:40 -05:00
Colin Lee
d1aed157dd
For #4686 : Fix potential security issue ( #4764 )
2019-08-16 16:50:54 -05:00
Yeon Taek Jeong
d4c83f9668
For #4736 : Display search shortcuts only from home or search widget
2019-08-15 12:24:54 -04:00
Yeon Taek Jeong
a680d733c8
For #4384 : Hide mic icon if speech-to-text is unavailable ( #4701 )
2019-08-14 16:40:21 -07:00
Yeon Taek Jeong
2441592ef2
For #4516 : Use full width for large search widgets ( #4659 )
2019-08-14 16:00:13 -07:00
Emily Kager
f71106cb51
Closes #3860 - Update description text for collections
2019-08-14 17:13:52 -04:00
Sawyer Blatz
b7ca520787
For #4421 : Adds Leanplum events and attributes ( #4626 )
...
* For #4421 : Adds Leanplum events and attributes
* For #4421 : Adds Leanplum deep links
2019-08-14 13:48:45 -07:00
Yeon Taek Jeong
67f3b63ae5
For #4421 : Add search widget attribute to Leanplum ( #4694 )
2019-08-14 12:00:29 -07:00
Yeon Taek Jeong
f5ffe3734c
For #4457 : Adds telemetry for search widget actions ( #4714 )
2019-08-14 11:39:54 -07:00
Yeon Taek Jeong
2f265eccbd
For #4732 : Fix search engine display issue ( #4735 )
2019-08-14 11:03:14 -07:00
Michael Cooper
12371ca9c1
Add no-op experiment to test service-experiments integration ( #4551 )
...
* Add no-op experiment to test service-experiments integration
* Shorten metric name to meet schema
* Add active_experiment metric to docs
* Add approved data review
2019-08-14 12:07:41 -05:00
Tiger Oakes
3acabeb6c3
Use global navigation action for browser fragment ( #4691 )
2019-08-14 11:58:29 -05:00
Colin Lee
5b4a441bcb
For #1667 : Screen reader can't reach other UI items when QAB expanded ( #4695 )
2019-08-14 09:56:29 -07:00
Emily Kager
1328d686aa
No issue - Autoformatting ( #4715 )
2019-08-14 09:40:46 -05:00
Sourabh
42e3b2771e
fix #4633 : show toast only on first login ( #4676 )
...
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
2019-08-13 16:28:34 -05:00
(´⌣`ʃƪ)
5aac05859d
Fix #4436 : hide onboarding before navigating to settings ( #4675 )
...
* Fix #4436 : hide onboarding before navigating to settings
* No issue: Rename emitAccountChanges to emitModeChanges
2019-08-13 15:49:42 -05:00
Sebastian Kaspari
d03c15d15c
Issue #4431 : Integrate feature-media component (Nightly and debug builds only). ( #4683 )
2019-08-13 15:02:20 -05:00
Colin Lee
0c8bcd39be
For #4652 : HomeFragment Crash "Can not.. after onSaveInstanceState"
2019-08-12 15:51:49 -04:00
Jorge De Los Santos
337ad1e88e
For #3424 - Make talkback ignore ImageButton in Collection Sele… ( #3792 )
...
For #3424 - Make talkback ignore ImageButton in Collection Selection by removing contentDescription and setting importantForAccessibility=no
2019-08-12 11:49:25 -04:00
Grisha Kruglov
b38b94ed79
Closes #4671 : Fix a potential NPE in BookmarkFragment
2019-08-12 11:16:28 -04:00
Grisha Kruglov
634ee184a6
No issue: add some BookmarkFragmentInteractor tests
2019-08-09 17:27:58 -07:00
Grisha Kruglov
f323105163
No issue: reduce code duplication in BookmarkFragmentInteractor
2019-08-09 17:27:58 -07:00
Christian Sadilek
5fe05e919a
For #4125 : Suppress coroutine warning to fix release build
2019-08-09 17:30:27 -04:00
Sawyer Blatz
0ec92d716f
For #4123 : Adds telemetry for quick action open in app ( #4629 )
2019-08-09 13:51:12 -07:00
Yeon Taek Jeong
6c9ce784b1
Fix, add some tests
2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
2a6069bfb7
Fix rest of issues
2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
69434a765f
Fix most issues
2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
faf0ecbcc0
For #4125 : Migrate Sign in to Sync to Libstate
2019-08-09 13:39:51 -07:00
Colin Lee
7f07eabbd8
For #4652 : Crash "Can not perform this action after onSaveInstanceState" ( #4654 )
2019-08-09 14:46:40 -05:00
Tiger Oakes
52542708aa
Consodilate private browsing code
2019-08-09 11:00:41 -07:00
Jonathan Almeida
23f5ac0fb9
For #4066 : Create InflationAwareFeature for lazy inflation
2019-08-09 11:48:55 -04:00
Colin Lee
519c3bde5d
For #4066 : Provide lazy inflation of Find In Page View
2019-08-09 11:48:55 -04:00
Colin Lee
c9c43260c9
For #4529 : Handle crash initializing CreateCollectionViewModel late ( #4628 )
2019-08-08 17:40:55 -05:00