709588572a
For #5055 : Crash when opening bookmarks ( #5058 )
2019-08-31 17:41:50 -05:00
ffbbe119f3
For #3967 - Invoke pending deletion on back pressed
2019-08-23 15:32:27 -04:00
c1b1c2f332
For #3967 - Invokes pending deletion with more bookmark actions ( #4522 )
2019-08-21 08:36:41 -07:00
645674c9bd
Closes #4396 - Add a Bookmarks Controller ( #4593 )
...
* For #4396 - Rename BookmarkInteractor methods
Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.
Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.
* For #4396 - Add a BookmarkController
It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.
This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.
* For #4396 - Refactored Bookmark related tests
Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`
Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
b38b94ed79
Closes #4671 : Fix a potential NPE in BookmarkFragment
2019-08-12 11:16:28 -04:00
da06b0fb15
For #4508 : Treats warnings as errors ( #4543 )
2019-08-07 14:00:53 -07:00
3c1ce90f6f
Fixes #2379 - Generic library selection
2019-08-06 11:10:50 -07:00
671727c3e8
For #4341 use camelCase for views referenced from code
2019-08-03 09:25:55 -07:00
ec96d134ff
No issue: Fix breaking AccountObserver API
2019-08-02 13:40:50 -04:00
33e881ca8a
For #1539 : Only allow delete when folders multi-selected ( #4062 )
2019-08-02 10:11:21 -07:00
ccae66c08a
Issue #2379 - Use LibraryPageView in history
2019-08-01 15:59:55 -04:00
1846a61475
For #4096 : Use new A-C API to observe store / state changes
...
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
2019-07-26 10:40:33 -04:00
3dc20543e3
For #4128 : Migrate Bookmarks to LibState ( #4254 )
2019-07-25 21:55:51 -05:00
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
fe51bbcf7b
Update FxA integration to new APIs
2019-07-11 13:19:37 +02:00
21c75ca1bb
For #3478 - Add Tab sent snackbar confirmation for device sharing
2019-07-10 14:13:10 -04:00
6bb67a9de7
For #3364 : Set bookmark root titles onResume ( #3828 )
2019-07-03 13:13:53 -05:00
dbe29ebbda
For #3174 : Adds telemetry for bookmarks ( #3724 )
2019-07-02 08:41:20 -07:00
50052c9b9b
For #3551 : Tapping a bookmark/history from Library should open new tab ( #3832 )
2019-07-01 16:31:30 -05:00
7473126f7c
For #3784 : Crash loading bookmarks while detached ( #3787 )
2019-07-01 10:57:31 -05:00
386a3f3acc
For #3785 : Crash onDestroy of BookmarkFragment when detached ( #3786 )
2019-07-01 10:57:16 -05:00
9142e2279c
For #1968 - Adds menu option to add new folder in BookmarkFragment menu
2019-06-27 15:17:00 -07:00
c9962a7ad0
Closes #3701 - When deleted use bookmark title if url is null in snackbar ( #3716 )
2019-06-27 13:39:00 -05:00
77edb7afe1
For #2960 Closes #3671 - Fixes bookmark deletion with undo, wraps list
2019-06-26 18:59:13 -07:00
4994554576
No issue: Adds lint exception for when statement ( #3685 )
2019-06-26 15:52:24 -07:00
30930cdc88
Import variables referred to by path
2019-06-25 13:57:34 -07:00
d01bb8c442
Use lifecycleScope for collections fragments
2019-06-25 13:56:15 -07:00
22bcd70edc
For #3213 : Fix multi-select bookmarks on return to fragment ( #3413 )
2019-06-24 10:10:49 -07:00
f1088222b4
For #3203 : Updates edit bookmarks to have user friendly names ( #3372 )
...
Co-authored-by: Colin Lee <mncolinlee@gmail.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>"
2019-06-12 14:10:43 -05:00
b498f5559b
For #3333 : Only show desktop bookmarks if logged in ( #3356 )
2019-06-11 16:37:34 -05:00
decacbfc97
For #3323 Runs PublicSuffixList synchronously
2019-06-11 09:19:51 -07:00
82d2a0661b
Remove deprecatd support-ktx methods ( #3305 )
2019-06-10 09:12:11 -05:00
45c509fbce
For #2648 : Updates trimming of url hostname ( #3191 )
...
* For #2648 : Updates trimming of url hostname
* For #2648 : Fix nits
2019-06-07 09:33:07 -07:00
1e6da54263
For #3238 : fixes race condition crash, nav destination unknown
2019-06-06 15:46:34 -07:00
f26c402f0a
For #2395 - Properly takes you back to where you start authentication on completion
2019-06-05 10:47:21 -07:00
cd19f36b96
For #2227 : Fixes issue with bookmark selection ( #3021 )
2019-05-30 17:01:51 -05:00
b8c04e02e9
For #2327 : Fixes nits
2019-05-30 11:45:39 -07:00
fe50e88fc8
For #2327 : Adds error state syncing
2019-05-30 11:45:39 -07:00
5f42a65c2a
No issue: improve allowUndo
...
This patch fixes a few issues:
- it was an extension on a CoroutineScope, but that was quite misleading
since the Main dispatcher would be always used regardless of what dispatcher
the owning CoroutineScope was configured with.
- timing was reliant on exact value of the undocumented Snackbar.LENGTH_LONG duration
- coroutine cancellation relied on cooperation of the 'operation' suspend function,
which we can't depend on
New 'allowUndo' fully controls its timing, doesn't imply a dispatcher to its consumers,
and doesn't rely on cooperation of passed-in suspend blocks for cancellation to work.
2019-05-30 10:48:59 -07:00
9e7269214c
Closes #2835 : Do not assume bookmarks fragment is attached while processing operations
...
This is mostly necessary when we're running stuff in a coroutine, so the patch likely goes
overboard a bit with the nullability checks... but it shouldn't hurt.
2019-05-29 09:19:03 -07:00
3da6cfd98a
For #2886 : Fix sending multiple tabs to another device ( #2923 )
...
* For #2886 : Fix sending multiple tabs to another device
* Update share methods to use new API
2019-05-28 15:05:16 -07:00
2ad3a72f6f
Closes #2252 : Show "Desktop Bookmarks" in the Bookmarks library ( #2797 )
...
This patch adds in a virtual "Desktop Bookmarks" folder to the top
of the mobile root child list, and makes sure to change internal
bookmark root names to user friendly labels.
2019-05-23 19:33:06 -04:00
eb7646f073
Add custom share sheet and send tab support ( #2757 )
...
* Closes #2751 : Add custom app share sheet
* Closes #2753 : Add send tab devices to share sheet
* Closes #2752 : Add build flag for send tab
* Replace Context.share with ShareFragment
2019-05-23 10:48:22 -07:00
72d29c2a43
For #2205 & #1578 : Integrates tab collection storage ( #2478 )
...
* For #2205 : Adds TabCollectionStorage
* For #1578 : Adds delete to TabCollection
2019-05-16 14:02:24 -07:00
c5e5ef4b25
Teases apart ViewModel dependencies ( #2499 )
...
* No Issue - pulls render outside of the viewmodel
* No Issue - Properly subscribes to the changesObservable
* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
e1cdeffe8c
For #563 : Restyles history management ( #2378 )
2019-05-10 09:58:54 -07:00
ccbc14a71f
For #1994 : Re-architect state handling code ( #2382 )
2019-05-09 23:06:12 +00:00
96b68948b5
For #1710 : Create scaffolding for Robolectric tests ( #2282 )
2019-05-07 16:36:37 -05:00
548c3be51e
For #1702 : Multiple selection toolbar replaced with "fragment_home' ( #2204 )
2019-05-01 13:52:06 -05:00
eb0a10078c
No issue: refresh after undoing bookmark deletion ( #2198 )
2019-05-01 12:07:03 -05:00
c151c4b97b
For #1862 : deleting a bookmark item not hiding it immediately ( #2188 )
2019-05-01 08:14:00 -05:00
70486039c0
Closes #2147 : Refactors usage of openToBrowserAndLoad
2019-04-29 15:49:22 -07:00
f1050eaff5
For #1951 : Bookmarks library pane displays everything from root down ( #2135 )
2019-04-29 16:54:48 -05:00
46924544b6
For #1975 & #1627 : Refactors getSessionById in BrowserFragment
2019-04-25 16:51:03 -07:00
05b9df34d8
For #1922 - Open bookmark in new tab menu should open and show new tab
2019-04-23 16:03:21 -07:00
23e2b51db2
For #1759 - Try to change copy URL to plainText ( #1850 )
2019-04-20 14:15:37 -07:00
080dadcb7e
For #1817 : Multi-select toolbar changes when minimized
2019-04-19 22:35:24 -05:00
85245d7b40
Closes #1717 : Removes search button from library
2019-04-19 13:34:14 -05:00
9e2164720e
For #1596 : Bookmarks get the last used folder as parent
2019-04-19 08:11:43 -07:00
b88eea2f53
For #1701 , #1703 : Bookmark multi-select icons wrong color after deselect
2019-04-19 08:07:08 -07:00
849764d23a
For #974 : Telemetry for Bookmarks
2019-04-17 15:58:58 -07:00
3b3d4c3de5
Fixes #1646 : Changes bookmarks toolbar color ( #1651 )
2019-04-16 08:03:22 -07:00
6bff472276
No issue: Add Bookmark multi-select edit button
2019-04-15 13:31:59 -05:00
29832c5e84
For #724 : Consolidates colors
2019-04-15 12:22:03 -05:00
9b1c1b5f4d
For #1571 : Make bookmark deletion undoable
2019-04-12 19:05:04 -05:00
bc1b7e0b43
For #1539 : Add bookmark multi-select features
2019-04-12 13:35:28 -05:00
d7272d29de
For #1408 - Set Toolbar titles in code (vs in navgraph)
2019-04-09 16:36:14 -07:00
b54d4d1d58
Closes #1312 , #1236 , #1237 , #1238 , #1239 : Creating, Editing, and Deleting Bookmarks and Bookmark Folders
2019-04-08 14:48:36 -05:00
395d6f20d5
Fixes #1361 : Adds new tab when selecting history or bookmark items ( #1363 )
2019-04-05 13:11:05 -07:00
bd81e72239
Fixes #916 , fixes #917 , fixes #920 : Save, share, and delete bookmarks
2019-04-01 16:16:08 -05:00
Colin Lee