blallo
/
fenix
1
0
Fork 0
Code Releases Activity

Closes #1717: Removes search button from library

master
Sawyer Blatz 2019-04-18 11:27:30 -07:00 committed by Colin Lee
parent d1c2ed2052
commit 85245d7b40
4 changed files with 0 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/src/main/java/org/mozilla/fenix/library/LibraryFragment.kt
View File

@ -18,7 +18,6 @@ import kotlinx.android.synthetic.main.fragment_library.*
import mozilla.appservices.places.BookmarkRoot
import org.mozilla.fenix.R
import org.mozilla.fenix.library.bookmarks.BookmarkFragmentArgs
import org.mozilla.fenix.utils.ItsNotBrokenSnack
class LibraryFragment : Fragment() {
@ -67,11 +66,6 @@ class LibraryFragment : Fragment() {
Navigation.findNavController(requireActivity(), R.id.container).navigateUp()
true
}
R.id.librarySearch -> {
// TODO Library Search
ItsNotBrokenSnack(context!!).showSnackbar(issueNumber = "1118")
true
}
else -> super.onOptionsItemSelected(item)
}
}

4
app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkFragment.kt
View File

@ -314,10 +314,6 @@ class BookmarkFragment : Fragment(), CoroutineScope, BackHandler, AccountObserve
.popBackStack(R.id.libraryFragment, true)
true
}
R.id.librarySearch -> {
// TODO Library Search
true
}
R.id.open_bookmarks_in_new_tabs_multi_select -> {
getSelectedBookmarks().forEach { node ->
node.url?.let {

6
app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt
View File

@ -25,7 +25,6 @@ import mozilla.components.concept.storage.VisitType
import mozilla.components.support.base.feature.BackHandler
import org.mozilla.fenix.BrowserDirection
import org.mozilla.fenix.HomeActivity
import org.mozilla.fenix.utils.ItsNotBrokenSnack
import org.mozilla.fenix.R
import org.mozilla.fenix.ext.requireComponents
import org.mozilla.fenix.mvi.ActionBusFactory
@ -128,11 +127,6 @@ class HistoryFragment : Fragment(), CoroutineScope, BackHandler {
.popBackStack(R.id.libraryFragment, true)
true
}
R.id.librarySearch -> {
// TODO Library Search #1118
ItsNotBrokenSnack(context!!).showSnackbar(issueNumber = "1118")
true
}
else -> super.onOptionsItemSelected(item)
}
}

7
app/src/main/res/menu/library_menu.xml
View File

@ -5,13 +5,6 @@
<menu xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools">
<item
android:id="@+id/librarySearch"
android:icon="@drawable/ic_search"
android:iconTint="?primaryText"
android:title="@string/library_search"
app:showAsAction="ifRoom"
tools:targetApi="o" />
<item
android:id="@+id/libraryClose"
android:icon="@drawable/ic_close"