1
0
Fork 0
Commit Graph

41 Commits (6c2d6e65c354586bdb20bc681cc619fd66034896)

Author SHA1 Message Date
Sawyer Blatz 769c1e422d For #5694 & #6054: Allows users to change toolbar position (#6608)
* For #5694 & #6054: Adds preference screen for toolbar

* For #5694: Adds changing toolbar position functionality

* No issue: Updates telemetry links to actually work lol 😬

* For #6054: Adds toolbar position to core ping
2019-11-25 16:43:32 -08:00
Severin Rudie 6909a76bcb
4281 remove qab (#6310)
* For #4281: small ToolbarMenu refactor

This makes it easier to see how items are ordered in the menuItems list

* For 4281: add QAB buttons to menu

* For 4281: removed menu back button per mocks

I double checked with UX, and we'll be relying on the hardware back button for its functionality

* For 4281: add content descriptions for bookmarking

* For 4281: updated BrowserToolbarController for new functionality

* For 4281: provided simple dependencies to browser controller

More complex changes will be in a following commit, for review readability

* For 4281: move toolbar controller dependencies up to BaseBrowserFragment

The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones

* For 4281: removed (now unused) code related to QAB

* For 4281: fix test compilation after QAB removal

Tests still need to be expanded to include added functionality

* For 4281: updated menu to show if url is bookmarked

This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.

https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.

* For 4281: update reader mode switch

* For 4281: selectively show/hide menu items

* For 4281: add reader mode appearance

* For 4281: update bookmark button when it is clicked

* For 4281: removed unused QAB code

* For 4281: removed QAB robot, updated UI tests

* For 4281: removed QuickActionSheet metrics

Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped

* For 4281: fixed lint errors

* For 4281: add new strings for buttons added to menu

This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages

* For 4281: remove outdated TODOs

* For 4281: removed QAB container

* For 4281: removed back button reference from UI test

This button no longer exists

* For 4821: Fixes a visual defect (extra padding on top of toolbar)

* For 4281: update copy on reader mode

* For 4281: fixed review nits
2019-11-11 17:10:14 -08:00
Colin Lee 5b4a441bcb For #1667: Screen reader can't reach other UI items when QAB expanded (#4695) 2019-08-14 09:56:29 -07:00
Jonathan Almeida 23f5ac0fb9 For #4066: Create InflationAwareFeature for lazy inflation 2019-08-09 11:48:55 -04:00
Colin Lee 519c3bde5d For #4066: Provide lazy inflation of Find In Page View 2019-08-09 11:48:55 -04:00
Sawyer Blatz 29f089c414 For #2203: Polishes BrowserToolbarMenu 2019-08-02 13:40:50 -04:00
Emily Kager 5b10badc00 No issue: Remove rounded QAB corners to avoid overlapping web content 2019-07-12 09:59:19 -07:00
Emily Kager 1f108f3c88 For #3806 - Adds corner radius to QAB and dialogs 2019-07-11 12:57:27 -04:00
ekager 98a40aabd7 For #2223 , For #371 - Replace Toolbar with FIP when opened 2019-06-01 10:24:55 -07:00
Jonathan Almeida ab39a5088a For #2052: Fix BrowserToolbar overlapping web content 2019-05-30 20:40:56 -04:00
Tiger Oakes 74dd2a5f23 Issue #103 - Pull to refresh (#3020) 2019-05-30 17:05:49 -05:00
Emily Kager 40f2fe5166 For #1287 - Create animation for opening and closing tab from home 2019-05-23 13:41:00 -07:00
Emily Kager 6057c3703a For #2061 - Added Find in Page Bar No Matches Text Color (#2746) 2019-05-23 10:47:15 -07:00
Emily Kager 43843b0fb3 For #2561 - Dynamically set EngineView behavior in BrowserFragment 2019-05-16 11:22:14 -07:00
Sebastian Kaspari d894ea6702 Issue #552: Use EngineViewBottomBehavior to draw bottom-aligned web content above the toolbar. 2019-05-15 07:43:42 -07:00
Christian Sadilek 9b0422b062 Issue #910: Integrate feature-readerview component (#2269)
Closes #908, Closes #910, Closes #911, Closes #912

Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
2019-05-03 21:01:45 +00:00
Emily Kager 30ffc9fee2 For #2225 - Don't pass click events under find in page bar 2019-05-02 13:33:07 -07:00
Emily Kager b80b90c07d Closes #1879 - Create toolbar background drawable instead of view 2019-04-22 14:22:28 -07:00
ekager 316569b899 Closes #1798, Closes #1581 Corrects divider views and padding for toolbar and action sheet 2019-04-19 15:19:48 -07:00
Sawyer Blatz 29832c5e84 For #724: Consolidates colors 2019-04-15 12:22:03 -05:00
Emily Kager a2200b6335 For #208 - Dark/Night Theme 2019-04-02 22:18:11 -05:00
Colin Lee bd81e72239 Fixes #916, fixes #917, fixes #920: Save, share, and delete bookmarks 2019-04-01 16:16:08 -05:00
Sawyer Blatz 05353ee2e1 For #1072: Fixes theming 2019-03-21 12:54:08 -05:00
Sawyer Blatz 7accf07d48 For #1072: Fixes lint errors 2019-03-21 12:54:08 -05:00
Sawyer Blatz c0ceeb8cb6 For #1072: Increases touch target of grabber handle 2019-03-21 12:54:08 -05:00
Sawyer Blatz d2af87f8f8 For #1072: Adds grabber handle bounce animation 2019-03-21 12:54:08 -05:00
Sawyer Blatz 994d88542e For #1072: Adds basic view 2019-03-21 12:54:08 -05:00
Sawyer Blatz 557cb95082 Closes #1119: Removes unused crash_container 2019-03-21 09:14:54 -07:00
Sawyer Blatz 5e96b2037e
Closes #1039: Adds crash reporting (#1053)
* For #1039: Small cleanup

* Closes #1039: Adds crash reporting

* Add images

* Adds build settings back

* Fix nits
2019-03-20 10:47:22 -07:00
Emily Kager 6cc8d433fc Closes #459 - Remove redundant awesome bar in browser fragment 2019-02-12 16:39:22 -08:00
Emily Kager ed723557e9 Closes #440 - Set Find in Page colors from theme attrs 2019-02-11 16:20:16 -08:00
Colin Lee 5dcf4e5a5f Fixes #427: Browser toolbar does not auto-hide if ANY accessibility on 2019-02-11 10:27:08 -08:00
Sawyer Blatz a4fe413537 Closes #412: Enforces consistent naming in colors.xml 2019-02-08 12:53:16 -06:00
Sawyer Blatz d09dc149ed
Closes #363 & Closes #364: Adds private browsing theme (#405)
* For #345 #346 - Adds private browsing theme

Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>

* Abstracts theme management

* Theme browser toolbar

* Remove unused imports

* Begin work on sharedPreferences

* fix lint

* #346 - Refactors ThemeManager to take a callback

* Adds clean status bar and nav bar

* lint

* Themes settings icons better

* Small clean up
2019-02-08 09:43:17 -08:00
Jeff Boek 461664ed87 For #364 - Refactors BrowserFragment to use the ToolbarComponent
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
Co-authored-by: Emily Kager <emilykager@gmail.com>
2019-02-04 16:44:10 -08:00
Jeff Boek a6004fea20 Closes #146 & Closes #147: Integrates find in page
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2019-02-01 23:00:37 -08:00
Emily Kager 2e15efafe0 Part of #131 - Add Background to URL View Toolbar 2019-01-29 16:28:45 -06:00
Emily Kager 5a3fc1325f Adds toolbar with autocomplete and menu to BrowserFragment 2019-01-24 14:39:51 -08:00
Emily Kager 19572d474a Closes #134 - Collapse/show the toolbar based on browser scrolling 2019-01-23 13:23:40 -08:00
Jeff Boek 4c4f344a97 For #131 - Loads mozilla.org in the browser fragment 2019-01-18 15:47:19 -08:00
Emily Kager 4421adecbb Implement Navigation, Add Search Fragment, Add Browser Fragment 2019-01-15 14:08:37 -08:00