e247870b9f
For #5277 : Updates string for delete browsing data ( #5309 )
2019-09-13 10:18:25 -07:00
c8bc144114
For #2570 : Hide 3-dots menu when in select mode for bookmarks and history ( #5173 )
...
Show or hide overflow menu for entire list is triggered when mode is changed
For bookmarks, due to implementation of selection and diffUtil,
additional check is necessary for current item (last selected) that is redrawn
2019-09-12 13:56:39 -07:00
4acf48e817
Fixes #5212 - Change tint in onCreateOptionsMenu
...
Also fixes #5213
2019-09-12 10:30:49 -07:00
d0ef2d40c2
Move bookmark navigation listener to separate file
2019-09-10 16:53:09 -07:00
cd533854e6
No issue: Only use iconTint in XML for bookmark menus ( #5145 )
2019-09-10 09:04:05 -07:00
231924f5eb
Fix breaking services APIs changes
2019-09-05 13:38:15 +02:00
ba05d21657
Fix ktlint MaxLineLength issues.
2019-09-03 10:09:06 -07:00
38d97fda8b
Stores: Reduce visibility of reducer functions.
2019-09-03 10:09:06 -07:00
2723a55b03
Rename HistoryStore/State/Action to HistoryFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
76063e307a
Rename BookmarkStore/State/Action to BookmarkFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
709588572a
For #5055 : Crash when opening bookmarks ( #5058 )
2019-08-31 17:41:50 -05:00
66a8c04967
Fixes #4488 : Shows snackbar on bookmark deletion from edit fragment ( #4792 )
...
* Fixes #4488
Updates changelog
* Removes wildcard imports.
* Removes custom label in use, replaces with let
2019-08-28 10:12:39 -07:00
a65f220b39
For #4921 - Adds WindowFeature to BaseBrowserFragment
2019-08-27 15:33:59 -04:00
091778a4b9
For #4398 - add HistoryController ( #4837 )
2019-08-27 10:33:40 -07:00
ffbbe119f3
For #3967 - Invoke pending deletion on back pressed
2019-08-23 15:32:27 -04:00
c475bc87cf
Move classes out of top-level package
2019-08-21 13:52:30 -07:00
68f5d211d3
For #4326 - Updates codebase to support latest version of detekt
2019-08-21 13:50:51 -07:00
c1b1c2f332
For #3967 - Invokes pending deletion with more bookmark actions ( #4522 )
2019-08-21 08:36:41 -07:00
645674c9bd
Closes #4396 - Add a Bookmarks Controller ( #4593 )
...
* For #4396 - Rename BookmarkInteractor methods
Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.
Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.
* For #4396 - Add a BookmarkController
It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.
This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.
* For #4396 - Refactored Bookmark related tests
Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`
Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
b38b94ed79
Closes #4671 : Fix a potential NPE in BookmarkFragment
2019-08-12 11:16:28 -04:00
634ee184a6
No issue: add some BookmarkFragmentInteractor tests
2019-08-09 17:27:58 -07:00
f323105163
No issue: reduce code duplication in BookmarkFragmentInteractor
2019-08-09 17:27:58 -07:00
52542708aa
Consodilate private browsing code
2019-08-09 11:00:41 -07:00
da06b0fb15
For #4508 : Treats warnings as errors ( #4543 )
2019-08-07 14:00:53 -07:00
8194e0778e
For #4026 - Update BookmarkDiffUtil to update on Title or URL change
2019-08-07 00:37:16 -04:00
0604e9858d
Closes #3939 - Adds strings for delete browsing history
2019-08-06 16:06:56 -07:00
71aedc79fe
Fixes #3922 : Added accessibility announcement for history empty state.
...
Sent an announcement when the list becomes empty in order to tell the user
that there is no history.
2019-08-06 12:32:59 -07:00
23bc8f4320
Fro #4563 - Update delete button alpha when history mode changes
2019-08-06 12:26:25 -07:00
3c1ce90f6f
Fixes #2379 - Generic library selection
2019-08-06 11:10:50 -07:00
6f7ae227a8
Closes #4540 - Set correct tint for select bookmark folder icon ( #4541 )
2019-08-05 14:54:39 -07:00
a526e0fad3
For #4455 - Rename history headers by hours and days ( #4478 )
2019-08-05 11:12:22 -05:00
bfd4849064
For #1427 - enter multi select mode with single click on favicon in library
2019-08-03 16:43:51 -07:00
671727c3e8
For #4341 use camelCase for views referenced from code
2019-08-03 09:25:55 -07:00
6e2ea0750e
Issue #2379 - Use LibrarySiteItemView in history
2019-08-02 17:15:41 -07:00
bac2e40eb2
fixes #4435 - changed title of menuitem for delete and added content description
...
setting menu title should also set content description. I added the setContentDescription programmatically in order to ensure that the content description is being set. If content description matches title it won't be read twice
2019-08-02 17:09:24 -07:00
ec96d134ff
No issue: Fix breaking AccountObserver API
2019-08-02 13:40:50 -04:00
33e881ca8a
For #1539 : Only allow delete when folders multi-selected ( #4062 )
2019-08-02 10:11:21 -07:00
c342a680d8
Fix crash for bookmarks
2019-08-01 18:57:35 -04:00
d42e72fd8b
Closes #4462 - Adjust layout params of select bookmark folder view
2019-08-01 13:31:13 -07:00
ccae66c08a
Issue #2379 - Use LibraryPageView in history
2019-08-01 15:59:55 -04:00
2813a3cff7
For #4441 - Keeps the ID 0 based for the recyclerview
2019-08-01 10:45:23 -07:00
a75c2f7cfb
No Issue - Fixes the offset key to prevent endless history bug
2019-07-31 17:58:56 -07:00
af449c84d5
For #4137 - Fixes HistoryInteractorTest
2019-07-31 14:35:33 -07:00
4494e40dbc
For #4137 - Adds pagination to the history view
2019-07-31 14:35:33 -07:00
2467588c4a
Create shared custom view for library items
2019-07-30 12:26:15 -04:00
ac359f6970
Closes #1331 - Filter consecutive history items using simplified URL
2019-07-29 17:22:19 -04:00
88c05a5f43
Use glide-like image loading function
2019-07-29 10:22:23 -07:00
c2e6e25bef
Fixes #4005 - Move getColorFromAttr to Context
2019-07-26 16:44:11 -04:00
1846a61475
For #4096 : Use new A-C API to observe store / state changes
...
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
2019-07-26 10:40:33 -04:00
3dc20543e3
For #4128 : Migrate Bookmarks to LibState ( #4254 )
2019-07-25 21:55:51 -05:00
4747f2c165
Fixes #4161 : Modified style of bookmark_folders_sign_in button. ( #4291 )
...
To make this match the style of the other button I applied the same style to it
and also changed it to be a MaterialButton.
I also decided to extract the margin and padding values of the button.
2019-07-25 14:10:11 -05:00
edb0a3ed08
For #3633 - Update StoreProvider to use a callback
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2019-07-18 18:16:49 -04:00
9251597e84
For #2362 : Fixes telemetry for history ( #4156 )
2019-07-18 13:36:52 -07:00
ae3d187909
For #3987 - Convert History to Lib-State and add tests
2019-07-17 17:23:09 -07:00
8381025ac5
For #2160 - Hide Keyboard in onPause from EditBookmarkFragment
2019-07-17 09:20:28 -07:00
11d36b5a00
For #2362 : Adds telemetry for history ( #3940 )
2019-07-16 12:21:03 -07:00
6b4c160d18
Closes #4080 - Trim New Bookmark Folder Title Text
2019-07-16 11:02:36 -07:00
52d4c43916
Merge some library UIView code for toolbar
2019-07-16 09:27:30 -07:00
706f7d5961
For #3554 - Add DiffUtil to HistoryAdapter
2019-07-15 13:46:21 -07:00
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
fe51bbcf7b
Update FxA integration to new APIs
2019-07-11 13:19:37 +02:00
9e7282cf18
For #1949 - Fixes bookmark separator appearance, removes menu ( #3957 )
2019-07-10 14:23:35 -05:00
21c75ca1bb
For #3478 - Add Tab sent snackbar confirmation for device sharing
2019-07-10 14:13:10 -04:00
9901514766
Replace deprecated pxToDp ( #3932 )
2019-07-08 14:45:07 -05:00
15d887e41f
For #2251 - Add bookmark adapter diffutil ( #3936 )
...
* For #2251 - Add bookmark adapter diffutil
* For #2251 - Fix unit tests for bookmark adapter diffutil
2019-07-08 14:00:25 -05:00
6bb67a9de7
For #3364 : Set bookmark root titles onResume ( #3828 )
2019-07-03 13:13:53 -05:00
dbe29ebbda
For #3174 : Adds telemetry for bookmarks ( #3724 )
2019-07-02 08:41:20 -07:00
50052c9b9b
For #3551 : Tapping a bookmark/history from Library should open new tab ( #3832 )
2019-07-01 16:31:30 -05:00
8cd1a0cb38
Move adapter Job setup code to helper class ( #3407 )
2019-07-01 13:34:25 -05:00
7473126f7c
For #3784 : Crash loading bookmarks while detached ( #3787 )
2019-07-01 10:57:31 -05:00
386a3f3acc
For #3785 : Crash onDestroy of BookmarkFragment when detached ( #3786 )
2019-07-01 10:57:16 -05:00
9142e2279c
For #1968 - Adds menu option to add new folder in BookmarkFragment menu
2019-06-27 15:17:00 -07:00
606e66219c
No issue: Use chains for bookmark items ( #3696 )
...
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2019-06-27 13:47:42 -07:00
c9962a7ad0
Closes #3701 - When deleted use bookmark title if url is null in snackbar ( #3716 )
2019-06-27 13:39:00 -05:00
77edb7afe1
For #2960 Closes #3671 - Fixes bookmark deletion with undo, wraps list
2019-06-26 18:59:13 -07:00
4994554576
No issue: Adds lint exception for when statement ( #3685 )
2019-06-26 15:52:24 -07:00
30930cdc88
Import variables referred to by path
2019-06-25 13:57:34 -07:00
d01bb8c442
Use lifecycleScope for collections fragments
2019-06-25 13:56:15 -07:00
6bf8d6be34
Use @JvmOverloads instead of multiple constructors
2019-06-25 13:55:31 -07:00
94e99cf877
For #3364 : Edit bookmarks should show corrected bookmarks tree ( #3446 )
2019-06-25 14:19:33 -05:00
e244aae104
For #3214 - History multi-selection aborted, the same item can't be selected again ( #3607 )
2019-06-24 15:27:06 -07:00
2ebe0a2a48
Fixes #3529 - Display "Edit folder" title when editing a bookmark folder ( #3549 )
2019-06-24 13:34:15 -07:00
22bcd70edc
For #3213 : Fix multi-select bookmarks on return to fragment ( #3413 )
2019-06-24 10:10:49 -07:00
e458d8b6a1
Fixes #3365 - Set selectedFolder to null if it's already selected ( #3415 )
2019-06-13 10:52:35 -05:00
f1088222b4
For #3203 : Updates edit bookmarks to have user friendly names ( #3372 )
...
Co-authored-by: Colin Lee <mncolinlee@gmail.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>"
2019-06-12 14:10:43 -05:00
b498f5559b
For #3333 : Only show desktop bookmarks if logged in ( #3356 )
2019-06-11 16:37:34 -05:00
decacbfc97
For #3323 Runs PublicSuffixList synchronously
2019-06-11 09:19:51 -07:00
5df726715f
Revert "For #3008 , For #2162 Add Simple Logic for Menu Orientation" ( #3310 )
...
#3114
2019-06-10 10:58:18 -05:00
82d2a0661b
Remove deprecatd support-ktx methods ( #3305 )
2019-06-10 09:12:11 -05:00
45c509fbce
For #2648 : Updates trimming of url hostname ( #3191 )
...
* For #2648 : Updates trimming of url hostname
* For #2648 : Fix nits
2019-06-07 09:33:07 -07:00
1e6da54263
For #3238 : fixes race condition crash, nav destination unknown
2019-06-06 15:46:34 -07:00
f26c402f0a
For #2395 - Properly takes you back to where you start authentication on completion
2019-06-05 10:47:21 -07:00
0b3a8b7a54
For #2316 : Adds confirmation dialog to delete bookmark
2019-06-04 14:47:11 -07:00
dc0d153580
For #3008 , For #2162 Add Simple Logic for Menu Orientation ( #3114 )
...
* For #3008 - Adjust orientation of collections menu based on view location
* For #2162 - Add simple menu orientation logic to bookmark menu
2019-06-04 10:37:57 -05:00
d5a9627273
For #2941 - Remove Delete Dialog, Theme Dialogs ( #3052 )
2019-05-31 16:26:34 -05:00
a7d5cdcb9d
For #2723 - Fixes theme manager
2019-05-30 16:38:31 -07:00
cd19f36b96
For #2227 : Fixes issue with bookmark selection ( #3021 )
2019-05-30 17:01:51 -05:00
b8c04e02e9
For #2327 : Fixes nits
2019-05-30 11:45:39 -07:00
fe50e88fc8
For #2327 : Adds error state syncing
2019-05-30 11:45:39 -07:00
5f42a65c2a
No issue: improve allowUndo
...
This patch fixes a few issues:
- it was an extension on a CoroutineScope, but that was quite misleading
since the Main dispatcher would be always used regardless of what dispatcher
the owning CoroutineScope was configured with.
- timing was reliant on exact value of the undocumented Snackbar.LENGTH_LONG duration
- coroutine cancellation relied on cooperation of the 'operation' suspend function,
which we can't depend on
New 'allowUndo' fully controls its timing, doesn't imply a dispatcher to its consumers,
and doesn't rely on cooperation of passed-in suspend blocks for cancellation to work.
2019-05-30 10:48:59 -07:00
Sawyer Blatz