1
0
Fork 0
Commit Graph

2218 Commits (11c7d3eb021b9a7588092fd87420003e4671eaac)

Author SHA1 Message Date
Tiger Oakes 7e8f079269
Use ShareData with ShareFragment (#6698) 2019-11-25 11:07:21 -08:00
Christian Sadilek 8271f0f55a Fix for A-C 23.0.0: onDownloadCompleted renamed to onDownloadStopped 2019-11-23 20:25:21 -05:00
Tiger Oakes cd3e077bc9 For #6763 - Fix early view access 2019-11-23 10:55:29 -05:00
Daphne Liu 4cfbaf2dc4 Switched to AC string extensions (#6258)
* Switched to AC string extensions

* Clean up imports
2019-11-22 23:15:51 -08:00
ekager 77334b6108 For #6628 - Remove required for biometric manifest 2019-11-22 14:17:26 -08:00
ekager 45071d6fc1 For #6573 - Fixes anchor view for tab switching snackbar 2019-11-22 14:15:17 -08:00
Sawyer Blatz bcf80d0e0b
For #6436: Adds snackbar for failed download (#6648) 2019-11-22 12:46:57 -08:00
Mozilla L10n Automation Bot 5cc1ea951c Import l10n. 2019-11-22 11:14:22 -08:00
David Walsh bc56ae194a Fix 6048 - Improve alignment in Edit Bookmark screen 2019-11-22 10:14:00 -08:00
Tiger Oakes a5e9439c6e Clean up tracking protection fragment (#6532)
* Clean up exceptions fragment

* Clean up tracking protection fragment

* Move saved logins to list adapter
2019-11-22 10:38:13 -05:00
Sebastian Kaspari 8a330d413c Closes #4982: Migrate Gecko files before initializing engine. (#6738) 2019-11-22 08:18:50 -05:00
Mozilla L10n Automation Bot c5d496a35d Import l10n. 2019-11-22 14:00:39 +01:00
Stephen Tsimicalis 9869408fb4 For #4824 - Fixes onboarding telemetry events from being sent a… (#6659) 2019-11-21 17:51:55 -08:00
Mozilla L10n Automation Bot f6cc5b9387 Import l10n. 2019-11-21 16:45:05 -08:00
Pawel Obarzanek 667602f02a Closes mozilla-mobile#5458 Tests for IntentReceiverActivity to verify outcoming intent (#6130) 2019-11-21 16:44:08 -08:00
Pawel Obarzanek ee0ec6a8f8 Closes mozilla-mobile#4828 Initial tests for FragmentPreDrawMan… (#6134)
* Closes mozilla-mobile#4828 Initial tests for FragmentPreDrawManager

* Closes mozilla-mobile#4828 verify if addOnPreDrawListener was called
2019-11-21 16:23:59 -08:00
Mihai Adrian e07d09afb8 Update app/src/main/java/org/mozilla/fenix/home/HomeMenu.kt
Co-Authored-By: Tiger Oakes <contact@tigeroakes.com>
2019-11-21 15:34:01 -08:00
mcarare 9258df2c69 For #3523 Add Firefox Sync error states also to Settings in Home menu 2019-11-21 15:34:01 -08:00
isabelrios 3fc263d547 fix reviewer comments 2019-11-21 15:32:26 -08:00
isabelrios 6b7f89433a For #6322 - UI tests for Account Settings View
removing sleeps

fix ktlint errors
2019-11-21 15:32:26 -08:00
Matt McKenna c71fa11d45 Add Mozilla licensing header to gradient 2019-11-21 15:27:50 -08:00
Matt McKenna d1f70e908e Add a simple gradient to collection creation 2019-11-21 15:27:50 -08:00
matthewcmckenna afac413c98 Add ETP accessibility labels 2019-11-21 15:27:35 -08:00
Tiger Oakes 0a86676563 For #6523 - Remove close button in library 2019-11-21 15:27:18 -08:00
Patrick Martin 3e436f59e2 For #2294 - History URL is cut with a large font set (#6724)
* For #2294 - History URL is cut with a large font se

* Update HistoryRobot.kt
2019-11-21 15:05:59 -08:00
mcarare f18c047132 For #1019 Update unit tests and UI tests 2019-11-21 14:36:14 -08:00
mcarare 1d36098878 For #1019 Add onboarding search suggestion hint panel 2019-11-21 14:36:14 -08:00
mcarare 5543f3272d For #1019 Add option to enable search suggestions in private mode 2019-11-21 14:36:14 -08:00
mcarare ef3c3de8a1 For #6625 Fix back navigation in search mode from browser 2019-11-21 14:35:12 -08:00
Tiger Oakes bd475d54e5 Extract TP onboarding popup (#6700) 2019-11-21 17:23:35 -05:00
Arturo Mejia 0d6ea08de7
No issue: Remove download file provider. (#6699) 2019-11-21 14:31:03 -05:00
Johan Lorenzo de8bc2f8a5 Split UI test 2019-11-21 11:59:51 +01:00
Grisha Kruglov f099552ae3 Enable encryption of persisted FxA account state 2019-11-20 15:32:56 -08:00
Jeff Boek 54773afb68
For #2477 - Removes the feature flag for Force Enable Zoom (#6646)
* For #2477 - Removes the feature flag for Force Enable Zoom

* For #2477 - Fixes bug where zoom preference doesnt persist between launches
2019-11-20 10:32:38 -08:00
ekager dba2186e86 Add scroll to item 2019-11-20 10:23:48 -08:00
ekager 81ab082c1c For #6707 #6708 - Fix UI Tests for new Search Engine Behavior 2019-11-20 10:23:48 -08:00
Jeff Boek 607c3d4c87
Adds custom search engines (#6551)
* For #5577 - Adds button to add a new search engine

* For #5577 - Adds custom engine store

* For #5577 - Creates a custom SearchEngineProvider

* For #5577 - Gives the ability to delete search engines

* For #5577 - Adds the UI to add a custom search engine

* For #5577 - Adds form to create a custom search engine

* For #5577 - Adds the ability to add a custom search engine

*  For #5577 - Adds the ability to delete custom search engines

* For #5577 - Selects the first element on the add custom search engine screen

* For #5577 - Prevents adding a search engine that already exists

* For #5577 - Styles the add search engine preference

* For #5577 - Makes the name check case-insensitive

* For #5577 - Fix bug where home screen doesnt see new search engines

* For #5577 - Moves Search URL validation to its own type

* For #5577 - Fixes linting errors

* For #5577 - Adds the ability to edit a custom search engine

* For #5577 - Allows the user to edit a serach engine even when it is the last item in the list

* For #5577 - Adds an undo snackbar when deleting a search engine

* For #5577 - Moves all of the strings to be translated

* For #5577 - Fixes bug when deleting your default search engine

* For #5577 - Puts adding search engines behind a feature flag

* For #5577 - Navigate to custom search engine SUMO article when tapping learn more

* For #5577 - Fixes nits

* For #5577 - Uses concept-fetch to validate search string

* For #5577 - Adds string resources for the cannot reach error state
2019-11-19 16:30:56 -08:00
Patrick Martin 8abf580579 For #2294 - History URL is cut with a large font se 2019-11-19 10:50:17 -08:00
Oana Horvath c9e4303fa0
Fixed History flaky tests (#6592)
Ignoring some tests for now and left some to run
2019-11-19 11:29:35 +02:00
Mozilla L10n Automation Bot ce74a49a22 Import l10n. 2019-11-18 23:08:32 -08:00
mawen7 1e813a9609 Jump to tab overview if closed tab has no parent session 2019-11-18 22:56:42 -08:00
cesar 984d8c7b13 ktlint clean up 2019-11-18 20:07:22 -08:00
cesar 808740e4c9 Fixed Typo 2019-11-18 20:07:22 -08:00
cesar 560fa7a5b5 For #6594 - Trigger keyboard automatically when creating a bookmark folder 2019-11-18 20:07:22 -08:00
cesar d69ead201b Test for 6594 2019-11-18 20:07:22 -08:00
cesar 063115b215 For #6593 - Hide keyboard when quitting add bookmark folder flow 2019-11-18 20:07:22 -08:00
cesar d9ded1f715 Test for 6593 2019-11-18 20:07:22 -08:00
ekager ab93779369 For #6621 - Add Secure Flag to Window in Logins Fragments 2019-11-18 14:32:10 -08:00
Jeff Boek 871604f37d For #2271 - Fixes colors on dark theme 2019-11-18 14:23:54 -08:00
David Walsh 8016eb56aa Provide top padding to URL 2019-11-18 14:01:40 -08:00
David Walsh 6bd6e3035d Implement a more dynamic layout height 2019-11-18 14:01:40 -08:00
David Walsh c69e72bdba Fix 3809 - Show entire URL in security info view 2019-11-18 14:01:40 -08:00
Mozilla L10n Automation Bot ee7ea8cebf Import l10n. 2019-11-18 13:30:59 -08:00
Sawyer Blatz 6f4de48428 For #6434: Fixes downloadCompleted for paused downloads 2019-11-18 11:49:01 -08:00
Jeff Boek 77667bf724
No Issue - Fixes NPE in tests (#6673) 2019-11-18 11:29:49 -08:00
Roger Yang f3fc532e0e Closes #6440 Integrate Web Notifications Feature 2019-11-18 13:44:39 -05:00
Jeff Boek ac95510bb6
No Issue - Adds proguard rules for Lifecycle component (#6632)
This is a potential fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1596302
2019-11-15 17:10:38 -08:00
Mihai Adrian 55a200907a For #2570: Hide 3-dots menu for all library items when in select mode. (#6321)
Used notifyItemRangeChanged to redraw already drawn items.
2019-11-15 15:48:48 -08:00
Severin Rudie 8d68317388
4844 fix url elision (#6588)
* For #4844: add test cases for url elision

* For 4844: implement toShortUrl to pass test cases

* For 4844: update plumbing to use toShortUrl

* For 4844: adds/handles suggested url elision test case
2019-11-15 14:25:50 -08:00
Gabriel Luong c6562bff98 For #5583 - Adds telemetry for download notification (#6554) 2019-11-15 16:50:11 -05:00
Patrick Martin 5eb5cdf361 For #1695 - Detect HTML mime type for clipboard URL (#6612)
* For #1695 - Detect HTML mime type for clipboard URL
2019-11-15 12:23:52 -08:00
MozLando 204ead0827 Merge #6513
6513: For #5295 [A11y] Unable to tap snackbar r=kglazko a=kglazko



Co-authored-by: Kate Glazko <katglazko@gmail.com>
2019-11-15 18:43:54 +00:00
Will Hawkins 7173bdf0b1 Issue #6196: Make initialization of Glean metrics faster
setStartupMetrics is very expensive and does not need to be
done synchronously at the time the Glean Metrics Service is
initialized.
2019-11-15 10:38:08 -05:00
Emily Kager ddd484387d No issue: Check destination before popping logins fragments 2019-11-14 18:20:44 -08:00
Tiger Oakes fdd7400ccc Use ViewModel for share fragment 2019-11-14 16:25:50 -08:00
Tiger Oakes 333ff8c941 Fixes #4528 - Prevent share menu from jumping
Plus a bunch of docs and refactoring
2019-11-14 16:25:50 -08:00
Mozilla L10n Automation Bot 6b9a0d027f Import l10n. 2019-11-14 16:19:30 -08:00
Emily Kager 1c26851dea Add logins to UI test 2019-11-14 16:05:20 -08:00
ekager d85ed27a3d Add override for Core val in test 2019-11-14 16:05:20 -08:00
ekager 6e907b1106 Update BackgroundServicesTest 2019-11-14 16:05:20 -08:00
Emily Kager c43f96096e For #5074 - Sync Logins, Uses KeySharedPreferences for Passwords Encryption Key 2019-11-14 16:05:20 -08:00
Kate Glazko e038e0c41d 2019-11-14 13:54:08 -08:00
Tiger Oakes ee4e1c8f39
Fixes #5085 - Use CustomTabWindowFeature (#6603)
Opens _blank links in new custom tab
2019-11-14 12:02:27 -08:00
mozilla-l10n-automation-bot 4ae60f2cce Import l10n. (#6530) 2019-11-14 09:58:15 -08:00
Oana Horvath 0cfde5b86a Added a method to detect the UI Theme (#6542) 2019-11-13 08:52:41 -08:00
Gabriel ebdfe8184e For #5705 - Adds telemetry for media state (#6463) 2019-11-12 17:24:30 -08:00
David Walsh 9d5c03c067 Use consistent verbiage with regard to opened tabs (#6550) 2019-11-12 16:06:37 -08:00
Emily Kager cc318021cc For #5586 - Adds Logins Telemetry (#6352)
* For #5586 - Adds Logins Telemetry

* Adds Logins Sync Telemetry to PreferenceToggled event
2019-11-12 15:55:36 -08:00
mcarare f6a66562dd For #4487 Set activity title only once in Bookmark fragment
Removed label from nav_graph that caused label to be set for each navigation
Removed title setting in onCreate() called for each navigation
Changed logic for checking current root when setting UI for normal mode
2019-11-12 08:21:53 -08:00
Arturo Mejia 0275ca0693 No issue: Do not prevent trackers duplication in the tracking
protection panel.
2019-11-12 08:15:30 -08:00
mcarare 13637c59a2 For #6543 Hide keyboard when saving a new bookmarks folder 2019-11-12 08:09:55 -08:00
Severin Rudie f0468f8099
For #4281: fixed metrics.yaml for QAB removal (#6555) 2019-11-11 18:01:22 -08:00
Severin Rudie 6909a76bcb
4281 remove qab (#6310)
* For #4281: small ToolbarMenu refactor

This makes it easier to see how items are ordered in the menuItems list

* For 4281: add QAB buttons to menu

* For 4281: removed menu back button per mocks

I double checked with UX, and we'll be relying on the hardware back button for its functionality

* For 4281: add content descriptions for bookmarking

* For 4281: updated BrowserToolbarController for new functionality

* For 4281: provided simple dependencies to browser controller

More complex changes will be in a following commit, for review readability

* For 4281: move toolbar controller dependencies up to BaseBrowserFragment

The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones

* For 4281: removed (now unused) code related to QAB

* For 4281: fix test compilation after QAB removal

Tests still need to be expanded to include added functionality

* For 4281: updated menu to show if url is bookmarked

This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.

https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.

* For 4281: update reader mode switch

* For 4281: selectively show/hide menu items

* For 4281: add reader mode appearance

* For 4281: update bookmark button when it is clicked

* For 4281: removed unused QAB code

* For 4281: removed QAB robot, updated UI tests

* For 4281: removed QuickActionSheet metrics

Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped

* For 4281: fixed lint errors

* For 4281: add new strings for buttons added to menu

This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages

* For 4281: remove outdated TODOs

* For 4281: removed QAB container

* For 4281: removed back button reference from UI test

This button no longer exists

* For 4821: Fixes a visual defect (extra padding on top of toolbar)

* For 4281: update copy on reader mode

* For 4281: fixed review nits
2019-11-11 17:10:14 -08:00
mcarare 11ad1010a9 For #6323 Creating 1st collection from tab shows Name collection screen
Added a check for existence of at least a collection to select from.
2019-11-11 14:36:55 -08:00
Sawyer Blatz d6aeeb2dec
For #5958: Adds in app download notifications (#6506) 2019-11-11 14:08:51 -08:00
Mozilla L10n Automation Bot 79a9722e76 Import l10n. 2019-11-08 14:44:57 -08:00
Mihai Adrian 1388156953 For #1211 Hide the keyboard when scrolling through engine suggestions (#6474) 2019-11-08 14:36:39 -08:00
Tiger Oakes f476c624d7 For #6255 - Fix beta icon filenames (#6407) 2019-11-08 14:11:32 -08:00
RAJESH KUMAR ARUMUGAM 6ee59322b5 Added Vibration Effect On Scanning QR Code (#6129)
* Added Vibration Effect On Scanning QR Code

Added Vibration Feature for the new feature Request
Vibrate phone upon successful pairing #2928

* Added Vibration Effect On Scanning QR Code

Added Vibration Feature for the new feature Request
Vibrate phone upon successful pairing #2928

* Update PairFragment.kt

Removed unwanted blank lines

* Update PairFragment.kt

Removed the Casting with !!
2019-11-08 13:37:36 -08:00
Emily Kager d9615108ee For #6354 - Removes ETP Experiment, Removes Feature Flags, Sets Strict Default 2019-11-08 08:37:15 -08:00
mcarare 1ff5a1934e For #5709 Do not animate switch for ETP panel 2019-11-08 08:36:30 -08:00
ValentinTimisica e1f3611fdd Fixes #6408: Pop stack to homeFragment when opening bookmarks from homeFragment
When bookmark fragment is opened from homeFragment, libraryFragment does not
exists so the popBackStack(R.id.libraryFragment, true) would have failed. So
the solution for this was to pop back stack to homeFragment when the
bookmarks/history fragments are opened from homeFragment.
2019-11-07 16:00:48 -08:00
Grisha Kruglov 40047315c2 For #6490 - track abnormal FxA behaviour via Sentry 2019-11-07 15:11:41 -08:00
Emily Kager b1623cbba6 Fix components, core tests 2019-11-07 14:50:24 -08:00
Emily Kager ef7a23c875 Adds webAppShortcutManager argument 2019-11-07 14:50:24 -08:00
Tiger Oakes afda836f1f Use ManifestUpdateFeature 2019-11-07 14:50:24 -08:00
Sawyer Blatz 4183dea591 For #5547: Reuse biometricPrompt when authenticating
This fixes an issue with Samsung devices where an invisible DeviceCredentialHandler because the executor was "null" (it wasn't actually)

You *must* reuse the biometric object instead of creating a new one.
2019-11-07 13:45:41 -08:00
Emily Kager 3e2b88cc91 For #5547 - Add top level auth when accessing passwords 2019-11-07 13:45:41 -08:00
Shangeeth Sivan 218763f9be For #4556: Removed redundant code in few tests. (#6367)
* Moved some values as member variables as having them declared separately in methods seemed redundant.

* Added @Before method in logtest to avoid code duplication Fixes #4556

* Added @Before method to FragmentTest class Fixes #4556

* variable renamed and added private access specifier; removed set from member variable as it is used only once and we can convert the list to set when needed

* Fixes linter errors
2019-11-07 13:20:51 -08:00
Sawyer Blatz 284f3cf0f5 For #4456: Updates total_uri_count upload (#6482) 2019-11-06 19:10:56 -08:00