1
0
Fork 0

For #4824 - Fixes onboarding telemetry events from being sent a… (#6659)

master
Stephen Tsimicalis 2019-11-21 20:51:55 -05:00 committed by Tiger Oakes
parent f6cc5b9387
commit 9869408fb4
2 changed files with 4 additions and 5 deletions

View File

@ -260,7 +260,7 @@ class HomeFragment : Fragment() {
view.resources.getDimensionPixelSize(R.dimen.search_bar_search_engine_icon_padding)
view.toolbar_wrapper.setOnClickListener {
invokePendingDeleteJobs()
onboarding.finish()
hideOnboardingIfNeeded()
val directions = HomeFragmentDirections.actionHomeFragmentToSearchFragment(
sessionId = null
)
@ -274,7 +274,7 @@ class HomeFragment : Fragment() {
view.add_tab_button.setOnClickListener {
invokePendingDeleteJobs()
onboarding.finish()
hideOnboardingIfNeeded()
val directions = HomeFragmentDirections.actionHomeFragmentToSearchFragment(
sessionId = null
)

View File

@ -8,6 +8,7 @@ import android.content.Context
import android.content.SharedPreferences
import androidx.core.content.edit
import org.mozilla.fenix.ext.components
import org.mozilla.fenix.components.metrics.Event
class FenixOnboarding(context: Context) {
private val metrics = context.components.analytics.metrics
@ -22,9 +23,7 @@ class FenixOnboarding(context: Context) {
fun finish() {
onboardingPrefs.onboardedVersion = CURRENT_ONBOARDING_VERSION
// To be fixed in #4824
// metrics.track(Event.DismissedOnboarding)
metrics.track(Event.DismissedOnboarding)
}
fun userHasBeenOnboarded() = onboardingPrefs.onboardedVersion == CURRENT_ONBOARDING_VERSION