1
0
Fork 0

For #6707 #6708 - Fix UI Tests for new Search Engine Behavior

master
ekager 2019-11-19 22:37:17 -08:00 committed by Emily Kager
parent 607c3d4c87
commit 81ab082c1c
3 changed files with 27 additions and 19 deletions

View File

@ -63,25 +63,26 @@ class SettingsBasicsTest {
verifyBasicsHeading() verifyBasicsHeading()
verifySearchEngineButton() verifySearchEngineButton()
// drill down to submenu // drill down to submenu
}.openSearchSubMenu { }.openSearchSubMenu {
verifyDefaultSearchEngineHeader() verifyDefaultSearchEngineHeader()
verifySearchEngineList() verifySearchEngineList()
verifyShowSearchSuggestions() verifyShowSearchSuggestions()
verifyShowClipboardSuggestions() verifyShowSearchShortcuts()
verifySearchBrowsingHistory() verifyShowClipboardSuggestions()
verifySearchBookmarks() verifySearchBrowsingHistory()
}.goBack { verifySearchBookmarks()
}.openThemeSubMenu { }.goBack {
verifyThemes() }.openThemeSubMenu {
}.goBack { verifyThemes()
}.openAccessibilitySubMenu { }.goBack {
verifyAutomaticFontSizing() }.openAccessibilitySubMenu {
}.goBack { verifyAutomaticFontSizing()
}.goBack {
// drill down to submenu // drill down to submenu
}.openDefaultBrowserSubMenu { }.openDefaultBrowserSubMenu {
// verify item: set as default browser (duplicates, verify child of recyclerview) // verify item: set as default browser (duplicates, verify child of recyclerview)
// Verify label: Open links in private tab // Verify label: Open links in private tab
}.goBack { }.goBack {
} }
} }

View File

@ -22,6 +22,7 @@ class SettingsSubMenuSearchRobot {
fun verifyDefaultSearchEngineHeader() = assertDefaultSearchEngineHeader() fun verifyDefaultSearchEngineHeader() = assertDefaultSearchEngineHeader()
fun verifySearchEngineList() = assertSearchEngineList() fun verifySearchEngineList() = assertSearchEngineList()
fun verifyShowSearchSuggestions() = assertShowSearchSuggestions() fun verifyShowSearchSuggestions() = assertShowSearchSuggestions()
fun verifyShowSearchShortcuts() = assertShowSearchShortcuts()
fun verifyShowClipboardSuggestions() = assertShowClipboardSuggestions() fun verifyShowClipboardSuggestions() = assertShowClipboardSuggestions()
fun verifySearchBrowsingHistory() = assertSearchBrowsingHistory() fun verifySearchBrowsingHistory() = assertSearchBrowsingHistory()
fun verifySearchBookmarks() = assertSearchBookmarks() fun verifySearchBookmarks() = assertSearchBookmarks()
@ -54,10 +55,15 @@ private fun assertSearchEngineList() {
.check(matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE))) .check(matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE)))
onView(ViewMatchers.withText("Wikipedia")) onView(ViewMatchers.withText("Wikipedia"))
.check(matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE))) .check(matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE)))
onView(ViewMatchers.withText("Add search engine"))
.check(matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE)))
} }
private fun assertShowSearchSuggestions() = onView(ViewMatchers.withText("Show search suggestions")) private fun assertShowSearchSuggestions() = onView(ViewMatchers.withText("Show search suggestions"))
.check(matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE))) .check(matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE)))
private fun assertShowSearchShortcuts() = onView(ViewMatchers.withText("Show search shortcuts"))
.check(matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE)))
private fun assertShowClipboardSuggestions() = onView(ViewMatchers.withText("Show clipboard suggestions")) private fun assertShowClipboardSuggestions() = onView(ViewMatchers.withText("Show clipboard suggestions"))
.check(matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE))) .check(matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE)))
private fun assertSearchBrowsingHistory() = onView(ViewMatchers.withText("Search browsing history")) private fun assertSearchBrowsingHistory() = onView(ViewMatchers.withText("Search browsing history"))

View File

@ -329,7 +329,8 @@ class AwesomeBarView(
searchSuggestionProviderMap.put( searchSuggestionProviderMap.put(
engine, SearchSuggestionProvider( engine, SearchSuggestionProvider(
components.search.provider.getDefaultEngine(this), components.search.provider.installedSearchEngines(this).list.find { it.name == engine.name }
?: components.search.provider.getDefaultEngine(this),
shortcutSearchUseCase, shortcutSearchUseCase,
components.core.client, components.core.client,
limit = 3, limit = 3,