diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/SettingsBasicsTest.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/SettingsBasicsTest.kt index cbab10035..c414cd5d9 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/SettingsBasicsTest.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/SettingsBasicsTest.kt @@ -63,25 +63,26 @@ class SettingsBasicsTest { verifyBasicsHeading() verifySearchEngineButton() // drill down to submenu - }.openSearchSubMenu { - verifyDefaultSearchEngineHeader() - verifySearchEngineList() - verifyShowSearchSuggestions() - verifyShowClipboardSuggestions() - verifySearchBrowsingHistory() - verifySearchBookmarks() - }.goBack { - }.openThemeSubMenu { - verifyThemes() - }.goBack { - }.openAccessibilitySubMenu { - verifyAutomaticFontSizing() - }.goBack { + }.openSearchSubMenu { + verifyDefaultSearchEngineHeader() + verifySearchEngineList() + verifyShowSearchSuggestions() + verifyShowSearchShortcuts() + verifyShowClipboardSuggestions() + verifySearchBrowsingHistory() + verifySearchBookmarks() + }.goBack { + }.openThemeSubMenu { + verifyThemes() + }.goBack { + }.openAccessibilitySubMenu { + verifyAutomaticFontSizing() + }.goBack { // drill down to submenu - }.openDefaultBrowserSubMenu { - // verify item: set as default browser (duplicates, verify child of recyclerview) - // Verify label: Open links in private tab - }.goBack { + }.openDefaultBrowserSubMenu { + // verify item: set as default browser (duplicates, verify child of recyclerview) + // Verify label: Open links in private tab + }.goBack { } } diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuSearchRobot.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuSearchRobot.kt index 66c7105bc..b5831600f 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuSearchRobot.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuSearchRobot.kt @@ -22,6 +22,7 @@ class SettingsSubMenuSearchRobot { fun verifyDefaultSearchEngineHeader() = assertDefaultSearchEngineHeader() fun verifySearchEngineList() = assertSearchEngineList() fun verifyShowSearchSuggestions() = assertShowSearchSuggestions() + fun verifyShowSearchShortcuts() = assertShowSearchShortcuts() fun verifyShowClipboardSuggestions() = assertShowClipboardSuggestions() fun verifySearchBrowsingHistory() = assertSearchBrowsingHistory() fun verifySearchBookmarks() = assertSearchBookmarks() @@ -54,10 +55,15 @@ private fun assertSearchEngineList() { .check(matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE))) onView(ViewMatchers.withText("Wikipedia")) .check(matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE))) + onView(ViewMatchers.withText("Add search engine")) + .check(matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE))) } private fun assertShowSearchSuggestions() = onView(ViewMatchers.withText("Show search suggestions")) .check(matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE))) + +private fun assertShowSearchShortcuts() = onView(ViewMatchers.withText("Show search shortcuts")) + .check(matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE))) private fun assertShowClipboardSuggestions() = onView(ViewMatchers.withText("Show clipboard suggestions")) .check(matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE))) private fun assertSearchBrowsingHistory() = onView(ViewMatchers.withText("Search browsing history")) diff --git a/app/src/main/java/org/mozilla/fenix/search/awesomebar/AwesomeBarView.kt b/app/src/main/java/org/mozilla/fenix/search/awesomebar/AwesomeBarView.kt index 94d5eb551..04a5a0e37 100644 --- a/app/src/main/java/org/mozilla/fenix/search/awesomebar/AwesomeBarView.kt +++ b/app/src/main/java/org/mozilla/fenix/search/awesomebar/AwesomeBarView.kt @@ -329,7 +329,8 @@ class AwesomeBarView( searchSuggestionProviderMap.put( engine, SearchSuggestionProvider( - components.search.provider.getDefaultEngine(this), + components.search.provider.installedSearchEngines(this).list.find { it.name == engine.name } + ?: components.search.provider.getDefaultEngine(this), shortcutSearchUseCase, components.core.client, limit = 3,