Docker configuration #11

notisset · 2017-09-26T00:57:01+02:00

notisset commented

2017-09-26 00:57:01 +02:00

First-time contributor

notice: aiohttp must be bound to Address 0.0.0.0 (Any) in order to accept requests whilst running inside a container

**notice**: aiohttp must be bound to Address 0.0.0.0 (Any) in order to accept requests whilst running inside a container

crudo commented

2017-09-26 08:31:19 +02:00

In Dockerfile:

RUN apk update && apk add musl-dev zlib-dev jpeg-dev gcc python3 python3-dev
- Why not just apk add python3? Do our python dependencies have compile dependencies?
- I would rather run apk update && apk upgrade && python3 py-pip

In docker-compose.yml:

Why do we need docker-compose for just one container?

In docs/config_core/core_docker_sqlite.ini:

How does that work? Is that actually used by docker?
I'd rather replace that file with a sed command inside the Dockerfile:
- sed '/Address/s/= .*/= 0.0.0.0/' | tee conf/core.ini

Fix these issues and I'll squash and merge.

In `Dockerfile`: * `RUN apk update && apk add musl-dev zlib-dev jpeg-dev gcc python3 python3-dev` * Why not just apk add python3? Do our python dependencies have compile dependencies? * I would rather run `apk update && apk upgrade && python3 py-pip` In `docker-compose.yml`: * Why do we need docker-compose for just one container? In `docs/config_core/core_docker_sqlite.ini`: * How does that work? Is that actually used by docker? * I'd rather replace that file with a sed command inside the `Dockerfile`: * `sed '/Address/s/= .*/= 0.0.0.0/' | tee conf/core.ini` Fix these issues and I'll squash and merge.

notisset commented

2017-09-27 00:47:57 +02:00

First-time contributor

Ref: commit 836186f58b

commented dockerfile to explain dependencies
unable to replace it with a bash script*
fixed

*bash script failing candidate:

#!/bin/bash

docker rm -fv macao-pos
docker build -t macao-pos .
docker run -di -p 8080:8080 --name=macao-pos macao-pos

Ref: commit https://git.unit.macaomilano.org/notisset/macao-pos/commit/836186f58b1d7552fe373a6c6a6e876c0b6558e1 - commented dockerfile to explain dependencies - unable to replace it with a bash script* - fixed *bash script failing candidate: ``` #!/bin/bash docker rm -fv macao-pos docker build -t macao-pos . docker run -di -p 8080:8080 --name=macao-pos macao-pos ```

This pull request is broken due to missing fork information.

View command line instructions.