1
0
Fork 0
fenix/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders
MozLando bb22fb3092 Merge #5507 #5846
5507: For #1383 Added tab title to close button content description r=ekager a=mcarare


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

5846: For #3604 Snackbar messages for closing tabs use closed instead of deleted r=sblatz a=mcarare


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
2019-10-11 16:28:36 +00:00
..
onboarding Only use Context.settings() function (not getter) (#5335) 2019-09-24 10:33:46 -07:00
CollectionHeaderViewHolder.kt No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
CollectionViewHolder.kt For #3731 Improved UX for opening tabs from a Collection (#5427) 2019-09-20 06:41:04 -07:00
NoContentMessageViewHolder.kt No issue: Use putCompoundDrawables helper (#3982) 2019-07-15 08:24:59 -07:00
PrivateBrowsingDescriptionViewHolder.kt For #5356 Improves private browsing "common myths" link accessibility (#5479) 2019-09-24 10:46:34 -07:00
SaveTabGroupViewHolder.kt For #969: Adds more telemetry for collections (#4539) 2019-08-07 16:05:20 -07:00
TabHeaderViewHolder.kt For #3584 - Check if menu is open before showing a new one (#5674) 2019-10-10 06:37:47 -07:00
TabInCollectionViewHolder.kt Use glide-like image loading function 2019-07-29 10:22:23 -07:00
TabViewHolder.kt Merge #5507 #5846 2019-10-11 16:28:36 +00:00