1
0
Fork 0
Commit Graph

103 Commits (f49331de55194a33c2ac1a317d9fc5abf880b6e0)

Author SHA1 Message Date
ekager f49331de55 For #5544: Bare Minimum Logins UI 2019-10-24 10:29:03 -07:00
Severin Rudie aa8642f534
#4596 migrate collections (#5911)
* For #4596: move code from CollectionCreationComponent to CollectionCreationStore

Other than adding comments, no changes were made. The code will be updated in a following commit. This is in order to make the commit diff more readable.

* For 4596: update CollectionCreateStore to libstate

* For 4596: copied CollectionCreationUIView into CollectionCreationView

Otherwise, no code was changed. The next commit will update this code. This is in order to make the commit diff more readable.

* For 4596: update CollectionCreationView to LibState

Note that the minimal changes possible to enable migration were made.  Refactoring will happen in a later commit.

* For 4596: updated CollectionCreationTabListAdapter to work with the new View

* For 4596: updated SaveCollectionListAdapter to work with the new View

* For 4596: implemented CollectionCreationController

For now, it has an identical interface to the interactor. In a later commit several of its responsibilities will be moved around, some to the interactor and some to the reducer

* For 4596: copied over previous reducer code

No other changes were made. The code will be updated in the following commit. This is done to make changes more readable for the reviewer

* For 4596: update reducer code param names

Otherwise, no changes at this time

* For 4596: add arguments to CreateCollectionFragment in nav_graph

These will be used to replace the current CreateCollectionViewModel, which shares data between fragments in a way that doesn't fit within our architecture.

* For 4596: pass arguments to collection via transaction instead of VM

The VM will be removed in a later commit

* For 4596: update BrowserToolbarController to share state to collection via its Direction

* For 4596: removed CreateCollectionViewModel

* For 4596: test tab retrieval in CreateCollectionFragment

* For 4596: fix crashing CreateCollectionFragmentTest

* For 4596: removed classes create collection classes used by old architecture

* For 4596: collection interactor rename + kdoc

* For 4596: moved collection interactor interface

* For 4596: renamed CreateCollectionFragment

All related classes followed the pattern of CollectionCreationX

* For 4596: kdoc CollectionCreationController

There's no effective difference between these calls and their interactor equivalent, so I linked to them

* For 4596: fix bug that caused rename to not work

* For 4596: removed unused collection actions

These were unused before the LibState refactor

* For 4596: kdoc StepChanged

* For 4596: removed todos about moving logic to the reducer

saveTabsToCollection: this could be moved, but that would involve creating a new action. SaveCollectionStep should probably be refactored out, so adding this layer of indirection seemed counterproductive

handleBackPress: needs to be able to call dismiss(). The reducer doesn't (and shouldn't) be able to do that, so this needs to live here

stepBack: called by handleBackPress. See above

* For 4596: wrote tests for CollectionCreationController#stepback

* For 4596: fixed tests broken by changes to collections

* For 4596: small readability refactor for CollectionController#stepBack

No change to functionality (see tests)

* For 4596: broke apart CollectionView#update

There's probably a lot more that could be done here, but smaller changes were made to reduce scope

* For 4596: remove unnecessary todos

It looks like we don't follow the suggested pattern in this project

* For 4596: test CollectionCreationController#normalSessionSize

* For 4596: updated naming in CollectionCreationController per review
2019-10-22 17:33:54 -07:00
Sawyer Blatz b0d796ccee
For #5898: Default browser toggle sends user to SUMO on Android 5&6 (#5918) 2019-10-10 11:16:21 -07:00
Tiger Oakes 78bc829735 Closes #778 - Progressive Web Apps! (#4914) 2019-10-08 16:50:15 -07:00
Sawyer Blatz 371e2ac3d8
For #514 & #5742: Updates "launch links in private tab" functionality (#5721)
* For #514 & #5742: Updates "launch links in private tab" functionality

* Fixes comments
2019-10-03 12:43:33 -07:00
Sawyer Blatz 785b8b9519
For #5567: Removes search shortcuts button (#5739)
* For #5567: Removes search shortcut button

* No issue: Simplifies logic for displaying shortcuts
2019-10-03 08:53:16 -07:00
Tiger Oakes 6c30a94081 Move settings classes to packages 2019-09-20 12:36:15 -07:00
Jeff Boek 976c840047 For #3077 - Replaces connect another device dialog with a scree 2019-09-18 17:24:43 -07:00
Sawyer Blatz 50cd2920d3
For #5371: Updates search engine settings string (#5393) 2019-09-18 11:26:44 -07:00
Jeff Boek faff73b9b3 For #5047 - Creates dialog ui for naming a shortcut 2019-09-11 16:10:54 -07:00
Emily Kager e3209dcc84 For #3700 - Add Setting to Delete Data on "Quit" menu action 2019-09-11 16:06:18 -07:00
Emily Kager 9a4610f068 For #2897 - Add Action States To Share Sheet 2019-09-11 11:32:26 -07:00
Sawyer Blatz 53b3f105ca For #4155: Sets pastedText default value 2019-09-11 09:03:17 -07:00
Sawyer Blatz fdd2b59fb8 For #4155: Adds popup menu for browser toolbar 2019-09-11 09:03:17 -07:00
Emily Kager 4485b7f647 Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
mihai-adrian 8d363d68b1 For #4517: Keep Bookmarks fragment when navigating to browser
Removed popUp when navigating from bookmarks to browser
2019-09-09 20:52:36 -07:00
Sawyer Blatz 09dcdb079d For #4474: Adds what's new button to home screen menu (#5088)
* For #4474: Adds what's new button to home screen menu

* For #4474: Adds tests for what's new button
2019-09-03 15:16:29 -05:00
mihai-adrian fc8fc2b33d Fixes #4997: Changed navigation to ShareFragment
Added global navigation action to share fragment in navigation graph
Changed share action to use global navigation to ShareFragment
2019-09-03 07:08:08 -10:00
Tiger Oakes 66e14959ba Add custom tab fragment 2019-08-23 16:12:19 -04:00
Sawyer Blatz 73e3db8fe0 For #4804: Resolves issue with crash reporter stack 2019-08-19 16:40:41 -04:00
Yeon Taek Jeong d4c83f9668 For #4736: Display search shortcuts only from home or search widget 2019-08-15 12:24:54 -04:00
Sawyer Blatz b7ca520787 For #4421: Adds Leanplum events and attributes (#4626)
* For #4421: Adds Leanplum events and attributes

* For #4421: Adds Leanplum deep links
2019-08-14 13:48:45 -07:00
Yeon Taek Jeong faf0ecbcc0 For #4125: Migrate Sign in to Sync to Libstate 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong 6f962d3376
For #1744: Open search shortcuts when entering search mode (#4536) 2019-08-05 15:07:03 -07:00
Yeon Taek Jeong 83ceec6289 For #201: Search Widget 2019-08-02 11:26:48 -07:00
Colin Lee 3dc20543e3
For #4128: Migrate Bookmarks to LibState (#4254) 2019-07-25 21:55:51 -05:00
Emily Kager 9b5baa2358 For #3360 - Adds empty state for TP Exceptions 2019-07-22 17:21:06 -04:00
Sawyer Blatz e25ceafd1f No issue: Removes unnecessary fragment transitions from accounts
Co-authored-by: ekager <emilykager@gmail.com>
2019-07-18 19:56:25 -04:00
Emily Kager 13b7e64c9b For #3134 - Add confirmation dialog to sign out of FxA (#3959) 2019-07-15 16:21:13 -07:00
Emily Kager c81dd0a4a8 For #3772 - Update FXA sign in UI (#3933) 2019-07-10 21:20:06 -05:00
Emily Kager 21c75ca1bb For #3478 - Add Tab sent snackbar confirmation for device sharing 2019-07-10 14:13:10 -04:00
Emily Kager bed926c317 For #3834 - Initialize job in init 2019-07-01 16:26:46 -07:00
Emily Kager 9142e2279c For #1968 - Adds menu option to add new folder in BookmarkFragment menu 2019-06-27 15:17:00 -07:00
Andrei Teslovan 2ebe0a2a48 Fixes #3529 - Display "Edit folder" title when editing a bookmark folder (#3549) 2019-06-24 13:34:15 -07:00
Emily Kager ed39b7828b For #3234 - Updates labels of fragments in the nav graph to avoid flash (#3235) 2019-06-06 16:52:25 -05:00
Emily Kager 33eb26861d For #3141 For #3142 Do not try to fade BrowserFragment in transitions (#3195) 2019-06-05 20:37:58 -05:00
Emily Kager f48db90716 No issue: Always try to pop to browser when navigating to browser (#3043) 2019-05-31 12:57:34 -05:00
Emily Kager 18cd9e58f9 Fixes Crash: Pop up to Browser Fragment if exists when coming from Search 2019-05-30 16:30:06 -07:00
Sawyer Blatz b8c04e02e9 For #2327: Fixes nits 2019-05-30 11:45:39 -07:00
Sawyer Blatz fe50e88fc8 For #2327: Adds error state syncing 2019-05-30 11:45:39 -07:00
ekager dee3c059dc Adds Shared Transition between Home and Search 2019-05-29 12:27:48 -07:00
Jonathan Almeida 3da6cfd98a For #2886: Fix sending multiple tabs to another device (#2923)
* For #2886: Fix sending multiple tabs to another device

* Update share methods to use new API
2019-05-28 15:05:16 -07:00
Jeff Boek 51451ff002 For #225 - Deletes data on button press 2019-05-24 17:16:03 -07:00
Jeff Boek 3006b21508 For #225 - Adds list items for delete browsing data 2019-05-24 17:16:03 -07:00
Jeff Boek 182bbdf359 For #225 - Adds delete browsing data fragment 2019-05-24 17:16:03 -07:00
Jonathan Almeida 8fbbcceb21 Adds send tab functionality to UI (#2790)
* Closes #2782: Hide send tab when no devices available

* For #2752: Enabled send tab for debug and nightly builds

* For #2753: Add Send Tab functionality to UI
2019-05-23 18:38:03 -04:00
Emily Kager 467e6bda74 Add back fade in fade out pop anim 2019-05-23 13:41:00 -07:00
Emily Kager 895ba021e7 Hide toolbar in activity and remove label from home fragment 2019-05-23 13:41:00 -07:00
Emily Kager 40f2fe5166 For #1287 - Create animation for opening and closing tab from home 2019-05-23 13:41:00 -07:00
Jonathan Almeida eb7646f073 Add custom share sheet and send tab support (#2757)
* Closes #2751: Add custom app share sheet

* Closes #2753: Add send tab devices to share sheet

* Closes #2752: Add build flag for send tab

* Replace Context.share with ShareFragment
2019-05-23 10:48:22 -07:00