1
0
Fork 0
Commit Graph

214 Commits (dd5bb94f8c3c267952bd69939c7d5a21a3c337f1)

Author SHA1 Message Date
Sawyer Blatz 45c509fbce
For #2648: Updates trimming of url hostname (#3191)
* For #2648: Updates trimming of url hostname

* For #2648: Fix nits
2019-06-07 09:33:07 -07:00
Colin Lee 1e6da54263 For #3238: fixes race condition crash, nav destination unknown 2019-06-06 15:46:34 -07:00
Jeff Boek f26c402f0a For #2395 - Properly takes you back to where you start authentication on completion 2019-06-05 10:47:21 -07:00
Sawyer Blatz 0b3a8b7a54 For #2316: Adds confirmation dialog to delete bookmark 2019-06-04 14:47:11 -07:00
Emily Kager dc0d153580 For #3008, For #2162 Add Simple Logic for Menu Orientation (#3114)
* For #3008 - Adjust orientation of collections menu based on view location

* For #2162 - Add simple menu orientation logic to bookmark menu
2019-06-04 10:37:57 -05:00
Jeff Boek a7d5cdcb9d For #2723 - Fixes theme manager 2019-05-30 16:38:31 -07:00
Sawyer Blatz cd19f36b96 For #2227: Fixes issue with bookmark selection (#3021) 2019-05-30 17:01:51 -05:00
Sawyer Blatz b8c04e02e9 For #2327: Fixes nits 2019-05-30 11:45:39 -07:00
Sawyer Blatz fe50e88fc8 For #2327: Adds error state syncing 2019-05-30 11:45:39 -07:00
Grisha Kruglov 5f42a65c2a No issue: improve allowUndo
This patch fixes a few issues:
- it was an extension on a CoroutineScope, but that was quite misleading
since the Main dispatcher would be always used regardless of what dispatcher
the owning CoroutineScope was configured with.
- timing was reliant on exact value of the undocumented Snackbar.LENGTH_LONG duration
- coroutine cancellation relied on cooperation of the 'operation' suspend function,
which we can't depend on

New 'allowUndo' fully controls its timing, doesn't imply a dispatcher to its consumers,
and doesn't rely on cooperation of passed-in suspend blocks for cancellation to work.
2019-05-30 10:48:59 -07:00
Grisha Kruglov 9e7269214c Closes #2835: Do not assume bookmarks fragment is attached while processing operations
This is mostly necessary when we're running stuff in a coroutine, so the patch likely goes
overboard a bit with the nullability checks... but it shouldn't hurt.
2019-05-29 09:19:03 -07:00
Jonathan Almeida 3da6cfd98a For #2886: Fix sending multiple tabs to another device (#2923)
* For #2886: Fix sending multiple tabs to another device

* Update share methods to use new API
2019-05-28 15:05:16 -07:00
Harsh Shandilya 7d9c8726c5 treewide: Resolve compilation warnings (#2859)
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-05-27 19:04:17 +02:00
Grisha Kruglov 2ad3a72f6f Closes #2252: Show "Desktop Bookmarks" in the Bookmarks library (#2797)
This patch adds in a virtual "Desktop Bookmarks" folder to the top
of the mobile root child list, and makes sure to change internal
bookmark root names to user friendly labels.
2019-05-23 19:33:06 -04:00
Jonathan Almeida eb7646f073 Add custom share sheet and send tab support (#2757)
* Closes #2751: Add custom app share sheet

* Closes #2753: Add send tab devices to share sheet

* Closes #2752: Add build flag for send tab

* Replace Context.share with ShareFragment
2019-05-23 10:48:22 -07:00
Sören Hentzschel 04e28096b2 fixed wrongly named variable 2019-05-23 08:22:34 -07:00
Sören Hentzschel 56dec1ebfb fixed linting issues 2019-05-23 08:22:34 -07:00
Sören Hentzschel cc03aeb9f0 For #2435 - adds URL to bookmarks in library 2019-05-23 08:22:34 -07:00
Sebastian Kaspari 291df48c4e Install the "icons" WebExtension to automatically load icons for every visited website. 2019-05-20 19:34:49 -07:00
Sawyer Blatz 72d29c2a43
For #2205 & #1578: Integrates tab collection storage (#2478)
* For #2205: Adds TabCollectionStorage

* For #1578: Adds delete to TabCollection
2019-05-16 14:02:24 -07:00
Sawyer Blatz 334868c283 For #2224: Removes select bookmark and fixes crash 2019-05-15 11:46:46 -07:00
Jeff Boek c5e5ef4b25
Teases apart ViewModel dependencies (#2499)
* No Issue - pulls render outside of the viewmodel

* No Issue - Properly subscribes to the changesObservable

* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
Colin Lee 49ac62ab85 Fix ViewModel States (#2457)
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
2019-05-14 13:49:02 -07:00
Sawyer Blatz e1cdeffe8c
For #563: Restyles history management (#2378) 2019-05-10 09:58:54 -07:00
Colin Lee ccbc14a71f For #1994: Re-architect state handling code (#2382) 2019-05-09 23:06:12 +00:00
Colin Lee 96b68948b5
For #1710: Create scaffolding for Robolectric tests (#2282) 2019-05-07 16:36:37 -05:00
Colin Lee 030912bfc5
For #1966: back button from multi-selection toolbar should cancel (#2207) 2019-05-01 16:20:59 -05:00
Colin Lee 548c3be51e
For #1702: Multiple selection toolbar replaced with "fragment_home' (#2204) 2019-05-01 13:52:06 -05:00
Colin Lee a60d2c071c
For #1967: Multi-selection toolbar should disappear after deleting (#2202) 2019-05-01 13:51:37 -05:00
Colin Lee a4c201f2ee
For #1870: Copy bookmark folder does nothing (#2193) 2019-05-01 12:21:13 -05:00
Colin Lee eb0a10078c
No issue: refresh after undoing bookmark deletion (#2198) 2019-05-01 12:07:03 -05:00
Colin Lee c151c4b97b
For #1862: deleting a bookmark item not hiding it immediately (#2188) 2019-05-01 08:14:00 -05:00
Emily Kager 41bbc1ad2b Closes #2163 - Check if bookmark title is null or blank 2019-04-30 14:33:42 -07:00
Sawyer Blatz 70486039c0 Closes #2147: Refactors usage of openToBrowserAndLoad 2019-04-29 15:49:22 -07:00
Colin Lee f1050eaff5
For #1951: Bookmarks library pane displays everything from root down (#2135) 2019-04-29 16:54:48 -05:00
Sawyer Blatz 46924544b6 For #1975 & #1627: Refactors getSessionById in BrowserFragment 2019-04-25 16:51:03 -07:00
Colin Lee 688cae33c3 For #1877: Crash on edit or delete the default bookmark folders 2019-04-25 13:01:45 -07:00
Emily Kager 2162e74f76 Closes #1948 - Shows bookmark url if title is null 2019-04-23 16:05:01 -07:00
Emily Kager 05b9df34d8 For #1922 - Open bookmark in new tab menu should open and show new tab 2019-04-23 16:03:21 -07:00
Colin Lee 78abd43b3e For #1923: Title of bookmarks folder is not displayed 2019-04-23 17:37:58 -05:00
Sawyer Blatz 41e8acf05f For #724: Adds contrastText color for buttons using accent backgrounds 2019-04-23 09:57:54 -07:00
Emily Kager 23e2b51db2 For #1759 - Try to change copy URL to plainText (#1850) 2019-04-20 14:15:37 -07:00
Colin Lee 7c00c2983b No issue: Fix crash on bookmark folder selection and Snackbar color 2019-04-20 15:10:24 -05:00
Colin Lee 080dadcb7e For #1817: Multi-select toolbar changes when minimized 2019-04-19 22:35:24 -05:00
Sawyer Blatz 0f367a018a For #724: Corrects colors for all themes 2019-04-19 13:46:43 -07:00
Sawyer Blatz 85245d7b40 Closes #1717: Removes search button from library 2019-04-19 13:34:14 -05:00
Colin Lee 9e2164720e For #1596: Bookmarks get the last used folder as parent 2019-04-19 08:11:43 -07:00
Colin Lee 12614e0142 For #1555: Bookmark Overflow menu tap area should be larger 2019-04-19 08:09:26 -07:00
Colin Lee d5557b0db3 For #1598: Auto-select new created folder for moving bookmarks 2019-04-19 08:08:27 -07:00
Colin Lee b88eea2f53 For #1701, #1703: Bookmark multi-select icons wrong color after deselect 2019-04-19 08:07:08 -07:00
Colin Lee 849764d23a For #974: Telemetry for Bookmarks 2019-04-17 15:58:58 -07:00
Sawyer Blatz 3b3d4c3de5
Fixes #1646: Changes bookmarks toolbar color (#1651) 2019-04-16 08:03:22 -07:00
Colin Lee 6bff472276 No issue: Add Bookmark multi-select edit button 2019-04-15 13:31:59 -05:00
Colin Lee 5d6112da05 No issue: Missing clear button in edit bookmarks UI 2019-04-15 13:17:41 -05:00
Sawyer Blatz 29832c5e84 For #724: Consolidates colors 2019-04-15 12:22:03 -05:00
Colin Lee 9b1c1b5f4d For #1571: Make bookmark deletion undoable 2019-04-12 19:05:04 -05:00
Colin Lee bc1b7e0b43 For #1539: Add bookmark multi-select features 2019-04-12 13:35:28 -05:00
Emily Kager d7272d29de For #1408 - Set Toolbar titles in code (vs in navgraph) 2019-04-09 16:36:14 -07:00
Colin Lee 61e99ea476 Fixes #1496: Crash adding bookmark folder 2019-04-09 13:44:33 -07:00
Colin Lee b54d4d1d58 Closes #1312, #1236, #1237, #1238, #1239: Creating, Editing, and Deleting Bookmarks and Bookmark Folders 2019-04-08 14:48:36 -05:00
Sawyer Blatz 395d6f20d5
Fixes #1361: Adds new tab when selecting history or bookmark items (#1363) 2019-04-05 13:11:05 -07:00
Emily Kager a2200b6335 For #208 - Dark/Night Theme 2019-04-02 22:18:11 -05:00
Jeff Boek 31bfba3bd8 No issue - update to A-C 50 2019-04-02 15:35:23 -07:00
Colin Lee bd81e72239 Fixes #916, fixes #917, fixes #920: Save, share, and delete bookmarks 2019-04-01 16:16:08 -05:00