ekager
fb17ae2258
For #6229 - Remove all tab options from custom tab context menu
2019-10-25 13:25:31 -07:00
Sebastian Kaspari
9543f38978
Use new toolbar API of AC 18.0.0.
2019-10-24 08:57:30 -07:00
Mugurell
faddf368e1
Fix #3122 - Hide the "Bookmark saved" Snackbar when user closes BrowserFragment
...
Previously the Snackbar was being inflated in the parent of this Fragment so
surviving it being closed.
Tying the Snackbar with the Fragment from which it is shown ensures it will be
effectively hidden whenever the user navigates from the Fragment.
2019-10-18 08:11:56 +03:00
MozLando
aa1a5f3d32
Merge #6026
...
6026: For #5709 : Align ETP onboarding popup implementation with original mocks r=ekager a=mcarare
Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
2019-10-16 17:49:16 +00:00
mcarare
b82a794908
For #5709 : Align ETP onboarding popup implementation with original mocks
2019-10-15 17:07:47 +03:00
Mihai Branescu
1490c0178f
For #5749 - Update string for ETP onboarding popup
2019-10-15 15:56:59 +03:00
shldhll
8e17ac05b1
Optimized imports. Closes #5876
2019-10-10 04:17:43 +05:30
shldhll
f907ec52f0
Removed ObsoleteCoroutinesApi in tests. Closes #5876
2019-10-10 04:04:51 +05:30
ekager
24b3ed4384
For #5568 - Don't pass in Session for QuickActionSheetController
2019-09-25 13:33:38 -07:00
Tiger Oakes
8c30200ced
Only use Context.settings() function (not getter) ( #5335 )
...
Remove unused String extensions
2019-09-24 10:33:46 -07:00
Grisha Kruglov
c2fb99a73f
FxA WebChannels integration
...
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes #4971 )
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2019-09-16 19:44:13 -07:00
ekager
8cd0d8faf3
For #5304 - Align ETP Onboarding Tool Tip PopupWindow
2019-09-13 18:25:26 -07:00
Yeon Taek Jeong
3787dd7b1f
For #5254 : Fix transition to private browsing mode after sharing a page
2019-09-13 14:44:28 -07:00
Emily Kager
4485b7f647
Add Tracking Protection Info Panel
2019-09-11 07:47:13 -07:00
Tiger Oakes
16115f57d1
For #3440 - Reduce BrowserFragment require calls
2019-09-09 21:33:32 -07:00
Sebastian Kaspari
3a35233ac0
Remove ThumbnailsFeature. ( #5127 )
...
We currently do not use thumbnails anywhere in the app. Not using the feature means we are
not taking thumbnails on every page load which means we are saving memory and CPU cycles.
2019-09-05 11:05:37 -05:00
Tiger Oakes
66e14959ba
Add custom tab fragment
2019-08-23 16:12:19 -04:00
Jeff Boek
68f5d211d3
For #4326 - Updates codebase to support latest version of detekt
2019-08-21 13:50:51 -07:00
Emily Kager
fb1d655d96
Closes #4822 - Update Bookmark State in onResume ( #4823 )
2019-08-19 16:22:20 -07:00
Tiger Oakes
de14962e3f
Extract quick action sheet observer code ( #4368 )
2019-08-19 08:28:33 -07:00
Colin Lee
d1aed157dd
For #4686 : Fix potential security issue ( #4764 )
2019-08-16 16:50:54 -05:00
Emily Kager
1328d686aa
No issue - Autoformatting ( #4715 )
2019-08-14 09:40:46 -05:00
Tiger Oakes
52542708aa
Consodilate private browsing code
2019-08-09 11:00:41 -07:00
Colin Lee
ef97173cd9
For #4529 , #4427 : Resuming after restoring instance state breaks UI ( #4571 )
...
* For #4529 , #4427 : Resuming after restoring instance state breaks UI
* Clear up warnings
2019-08-08 11:05:01 -05:00
Sawyer Blatz
ff6e9bccb7
For #4451 : Adds tests for DefaultBrowserToolbarController ( #4493 )
...
* For #4451 : Adds tests for DefaultBrowserToolbarController
* Continue working
* Large refactoring of test
* Mock analytics
* Fix merge conflicts
2019-08-08 09:02:42 -07:00
Emily Kager
0b98d43c23
Closes #4602 - Add back transitions
2019-08-07 16:56:21 -07:00
Sawyer Blatz
da06b0fb15
For #4508 : Treats warnings as errors ( #4543 )
2019-08-07 14:00:53 -07:00
Tiger Oakes
631b7ba7cb
Issue #1000 - Split out common browser functions
2019-08-06 12:31:25 -07:00
Tiger Oakes
1e4399ee38
Use auto pause with BrowserFragment observers
2019-08-02 17:32:58 -07:00
Tiger Oakes
cbd811dcfb
Closes #1657 - Use Gecko for downloads ( #4296 )
2019-08-02 17:28:30 -07:00
Christian Sadilek
9887945296
For #4412 : Only consume state change when UI initialized
2019-08-01 11:51:32 -04:00
Christian Sadilek
59c0005979
For #4412 : SiteSecurityClickedListener set incorrectly
2019-07-31 19:52:53 -04:00
Christian Sadilek
76ed07bd5d
Closes #4412 : BrowserInteractor has not been initialized ( #4414 )
2019-07-31 09:14:05 -07:00
Sawyer Blatz
385dfd2f15
For #4376 : Removes usage of selectedSessionOrThrow ( #4381 )
2019-07-30 12:39:58 -07:00
Colin Lee
9bc0122ce3
For #4359 : findBookmarkedUrl blocks the main thread ( #4362 )
2019-07-29 17:01:02 -05:00
Sawyer Blatz
6fa022c2f8
For #4124 : Migrate BrowserToolbar to Libstate ( #4279 )
...
* For #4124 : Migrate BrowserToolbar to Libstate
* Restores QuickActionSheetReducer
* Improve tests
* Make QuickActionSheetController
* Finalize tests
* Breaks out QuickActionSheetState
* Fix comments
* Adds BrowserStoreTest
2019-07-29 12:39:36 -07:00
Tiger Oakes
87d8f3b037
Remove redundant super calls
2019-07-29 10:22:53 -07:00
Tiger Oakes
c2e6e25bef
Fixes #4005 - Move getColorFromAttr to Context
2019-07-26 16:44:11 -04:00
Christian Sadilek
1846a61475
For #4096 : Use new A-C API to observe store / state changes
...
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
2019-07-26 10:40:33 -04:00
Sawyer Blatz
7588251f8b
Closes #3986 & Closes #3661 : Migrate QuickActionSheet to LibState & add tests ( #4058 )
...
* Closes #3986 : Migrate QuickActionSheet to LibState
* Closes #3661 : Add tests for QuickActionSheet
Co-authored-by: boek <jeff@jeffboek.com>
* For #3986 : Fix feedback
2019-07-22 10:31:31 -07:00
Emily Kager
fc2bff0fde
For #4145 - Remove anchor view from fullscreen snackbar ( #4160 )
2019-07-19 11:18:47 -07:00
Emily Kager
9f40c25c75
For #4143 - Allow user to rotate to other landscape orientation
2019-07-19 14:12:33 -04:00
Jonathan Almeida
d298b5f2f5
Closes #4075 : Add Feature Flag class ( #4077 )
2019-07-18 17:20:12 -07:00
Sawyer Blatz
e544827e83
For #2267 : Adds telemetry for reader mode ( #3941 )
2019-07-18 15:17:15 -07:00
Tiger Oakes
981b6b5b02
For #4124 - Remove browser toolbar editing code
2019-07-18 15:40:33 -04:00
James Hugman
62850430b7
Closes AC#3695 - Add UI to open current page in external app
2019-07-18 15:33:31 -04:00
Emily Kager
9ab67557cf
For #4078 - Request landscape mode when entering fullscreen
2019-07-17 16:06:37 -07:00
James Hugman
90dd0ab469
Closes #4114 - Re-enable app-links
2019-07-17 10:39:17 -07:00
Colin Lee
8855af2234
For #3615 : Long pressing the address bar should not copy link ( #4083 )
2019-07-16 13:42:05 -05:00
Sebastian Kaspari
9b1e63224c
Closes #4052 : Remove pending intent workaround. ( #4059 )
...
Previously we needed to set a static launch function to be invoked when the find in page
integration should be launched. Now we can access the integration class directly and
can avoid the static property that caused issues when used by multiple activities.
2019-07-15 14:15:59 -05:00
Sebastian Kaspari
e4e0d45c1b
Closes #3996 : Remove workaround for opening custom tab in browser.
...
`EngineView` now allows releasing the `Session` so that it can be rendered by an
other `EngineView` instance.
2019-07-15 10:52:57 +02:00
Tiger Oakes
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
Emily Kager
21c75ca1bb
For #3478 - Add Tab sent snackbar confirmation for device sharing
2019-07-10 14:13:10 -04:00
ekager
57ca75139b
For #3201 - Update bookmark state when session selected
2019-07-03 11:38:14 -07:00
Emily Kager
ce2d597af3
For #203 - Adds find in page and request desktop site to custom tab menu ( #3835 )
2019-07-02 14:41:29 -07:00
Sawyer Blatz
ece0e30655
For #2054 : Collapses quick action bar when opening find in page ( #3837 )
2019-07-02 08:22:34 -07:00
Sawyer Blatz
7e46e71d00
For #3005 : Closes tabs when saving to collection ( #3723 )
2019-07-01 11:39:48 -05:00
ekager
7fa4cf4487
Use sessionId in FIP Integration, use pendingIntent for startActivity
2019-06-28 14:00:59 -07:00
ekager
6d0a4fdb4d
Revert "For #3609 - Remove FIP Integration, Use FIP Feature"
...
This reverts commit 428643d598e938f58a2fe4abfee417c46edec167.
2019-06-28 14:00:59 -07:00
Sawyer Blatz
66eb4fd03b
No issue: Fixes master compilation
2019-06-27 09:05:57 -07:00
Tiger Oakes
d01bb8c442
Use lifecycleScope for collections fragments
2019-06-25 13:56:15 -07:00
Emily Kager
084fab77d4
For #3609 - Remove FIP Integration, Use FIP Feature ( #3637 )
2019-06-24 15:31:32 -07:00
Emily Kager
ac5c4a0f79
Closes #3493 - Show tab saved to collection snackbar in BrowserFragment
2019-06-14 15:49:56 -07:00
Jeff Boek
7ebdfcc87b
For #1116 - Uses alias link for help
2019-06-14 15:33:34 -07:00
Jeff Boek
5540230e3d
For #1116 - Changes help link ( #3491 )
2019-06-14 15:29:10 -05:00
Colin Lee
d5c5587a0c
For #3209 : Disable shared element animations for crash temporarily ( #3482 )
2019-06-14 12:13:13 -05:00
Sawyer Blatz
381a5e6089
For #3403 : Subscribes to tab collections in BrowserFragment
2019-06-12 16:44:35 -07:00
Colin Lee
66a836cf3a
For #3314 : Toolbar and QAB unresponsive after Android 6 perms check ( #3373 )
2019-06-12 10:08:39 -05:00
Emily Kager
71f2b0bdaa
For #2253 - Use toolbar as anchorView with fullscreen snackbar
2019-06-11 15:09:07 -07:00
Christian Sadilek
ccc7c70967
For #3252 : Reader mode appearance buttons are not visible in PB
...
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2019-06-11 18:02:29 -04:00
jhugman
26d0ddda98
Fixes #3358 - disable feature-app-links ( #3359 )
2019-06-11 16:34:28 -05:00
Gabriel Luong
f05eb032d4
For #2684 : Add an extension function Session.toTab to map Session to Tab and clean up their usage
2019-06-11 13:14:23 -07:00
Sawyer Blatz
decacbfc97
For #3323 Runs PublicSuffixList synchronously
2019-06-11 09:19:51 -07:00
Emily Kager
975975e789
For #3326 - Remove open image in tab from context menu ( #3327 )
2019-06-11 08:59:00 -05:00
Tiger Oakes
82d2a0661b
Remove deprecatd support-ktx methods ( #3305 )
2019-06-10 09:12:11 -05:00
Emily Kager
bf4916418a
For #1998 - Removes stable flag in entering fullscreen navigation
2019-06-07 15:20:30 -07:00
Sawyer Blatz
45c509fbce
For #2648 : Updates trimming of url hostname ( #3191 )
...
* For #2648 : Updates trimming of url hostname
* For #2648 : Fix nits
2019-06-07 09:33:07 -07:00
Colin Lee
1e6da54263
For #3238 : fixes race condition crash, nav destination unknown
2019-06-06 15:46:34 -07:00
Jonathan Almeida
0a3b001abe
For #3167 : Show help page in browser menu ( #3230 )
2019-06-06 16:55:15 -05:00
Emily Kager
93a5456785
For #2253 - Shorten Fullscreen snackbar length ( #3190 )
2019-06-05 20:36:13 -05:00
Sawyer Blatz
0b3a8b7a54
For #2316 : Adds confirmation dialog to delete bookmark
2019-06-04 14:47:11 -07:00
Emily Kager
ef0618a3d1
For #3103 - Exit fullscreen on pause ( #3112 )
2019-06-04 10:36:16 -05:00
Colin Lee
04a759f0b0
For #2693 : Launching Fenix via adb with URL crashes ( #3099 )
2019-06-03 16:24:37 -05:00
Tiger Oakes
94c4013810
Closes #3091 - Hide Pull to Refresh under flag ( #3092 )
...
This was merged in after feature freeze so we're pulling it out for
now. Pull to refresh will continue to work in debug mode so that the
design can be iterated on easily.
2019-06-03 14:10:53 -05:00
Colin Lee
04bbeb5ae6
For #3073 'Open in Firefox Preview' no longer opens in app
...
Saving and restoring the custom tab session ID fixed one problem while causing another. I added code to only restore the ID if the session has a customTabConfig associated.
2019-06-03 10:04:17 -07:00
ekager
d285e799b9
Clean up logic to return margin pairs for readability
2019-06-03 10:00:00 -04:00
ekager
14fe356d62
For #2794 - Adjust engine margins when enter/exit fullscreen
2019-06-03 10:00:00 -04:00
ekager
98a40aabd7
For #2223 , For #371 - Replace Toolbar with FIP when opened
2019-06-01 10:24:55 -07:00
Colin Lee
532483498a
No issue: Store the Custom Tab Session ID to avoid a crash ( #3062 )
2019-05-31 17:03:58 -05:00
Emily Kager
0327b1146b
For #2977 - Update add new collections flow ( #2991 )
...
* For #2977 - Update add new collections flow
* Rename shared elements to be more general
* Make tab list not clickable in other modes
* For #2577 - Stop Flickering in List
* Add extensions function for next step with collections list size
2019-05-31 12:59:51 -05:00
James Hugman
060cd646c8
Fixes #1570 - Enable app-links feature
2019-05-31 10:39:47 -07:00
Emily Kager
1bb4d72fd1
For #3027 , For #2858 Pass in Fenix Snackbar for Context Menu Candidate ( #3028 )
2019-05-31 10:16:08 -05:00
Jonathan Almeida
ab39a5088a
For #2052 : Fix BrowserToolbar overlapping web content
2019-05-30 20:40:56 -04:00
Jeff Boek
f9d70dbc92
For #2723 - Creates callbacks to wire up the mode and theme manager together
2019-05-30 16:38:31 -07:00
Jeff Boek
a7d5cdcb9d
For #2723 - Fixes theme manager
2019-05-30 16:38:31 -07:00
Emily Kager
18cd9e58f9
Fixes Crash: Pop up to Browser Fragment if exists when coming from Search
2019-05-30 16:30:06 -07:00
Emily Kager
8dbed67f7f
No issue: Simplify and speed up shared element transitions
2019-05-30 16:30:06 -07:00
Emily Kager
43a961fe73
For #1973 - Toggle QR button on deny permissions, fix engineView crashes
2019-05-30 16:06:37 -07:00
Tiger Oakes
74dd2a5f23
Issue #103 - Pull to refresh ( #3020 )
2019-05-30 17:05:49 -05:00
Sawyer Blatz
9e0e5d95d9
For #2931 : Show browser snackbar above quick action sheet
2019-05-30 14:52:09 -07:00