1
0
Fork 0
Commit Graph

90 Commits (d4c83f96681eaf20d173e3bd35b2d88f1f099782)

Author SHA1 Message Date
Yeon Taek Jeong d4c83f9668 For #4736: Display search shortcuts only from home or search widget 2019-08-15 12:24:54 -04:00
Yeon Taek Jeong 2f265eccbd
For #4732: Fix search engine display issue (#4735) 2019-08-14 11:03:14 -07:00
Tiger Oakes 52542708aa Consodilate private browsing code 2019-08-09 11:00:41 -07:00
Emily Kager 0b98d43c23 Closes #4602 - Add back transitions 2019-08-07 16:56:21 -07:00
Sawyer Blatz da06b0fb15
For #4508: Treats warnings as errors (#4543) 2019-08-07 14:00:53 -07:00
ValentinTimisica 59c60ef189 Fixes #4354: Updated SearchFragment state after returning from SearchEngineFragment.
The user has the option to go to 'Shortcuts' -> 'Search engine settings' to
modify the default search engine. When returning from that settings screen we
need to update it to account for any changes.
For this we will check the current default engine against a previously stored
value in a newly added 'defaultEngineSource' property from SearchState class.
Also, I modified 'SearchStoreTest' by adding the new parameter to the
'SearchState' constructor.
2019-08-07 13:19:53 -07:00
Yeon Taek Jeong 6f962d3376
For #1744: Open search shortcuts when entering search mode (#4536) 2019-08-05 15:07:03 -07:00
Nikit Bhandari 671727c3e8 For #4341 use camelCase for views referenced from code 2019-08-03 09:25:55 -07:00
Yeon Taek Jeong 83ceec6289 For #201: Search Widget 2019-08-02 11:26:48 -07:00
Amaan Marfatia 4c13f45e9e Fixes #4192: Private keyboard in private browsing (#4345)
Sets compliant keyboards to private mode when in private browsing.
2019-07-29 18:00:48 -04:00
Tiger Oakes c2e6e25bef Fixes #4005 - Move getColorFromAttr to Context 2019-07-26 16:44:11 -04:00
Christian Sadilek 1846a61475 For #4096: Use new A-C API to observe store / state changes
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
2019-07-26 10:40:33 -04:00
Sawyer Blatz 28eb5c541a
For #1944 & #1750: Updates private & night mode colors (#4232) 2019-07-23 09:35:24 -07:00
Tiger Oakes edb0a3ed08 For #3633 - Update StoreProvider to use a callback
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2019-07-18 18:16:49 -04:00
Christian Sadilek c04dcec03f Closes #4096: IllegalStateException in SearchFragment (#4131) 2019-07-17 15:10:24 -05:00
Jeff Boek ec099a6e11
For #3633 - Creates generic store provider (#4060) 2019-07-15 15:54:13 -07:00
Christian Sadilek e91a2e61a2 For #3633: Add unit tests for SearchStore 2019-07-15 13:47:01 -04:00
Jeff Boek e4ff70c542
For #3633 - Refactors the search screen to use lib-state
* For #3633 - Adds SearchStore

* For #3633 - Refactors AwesomeBarUIView

* For #3633 - Refactors ToolbarUIView to use lib-state

* For #3633 - Fixes a couple of state bugs

* For #3633 - Moves all user interaction to SearchInteractor

* For #3633 - Adds kdocs to SearchStore and SearchInteractor

* For #3633 - Adds documentation for the properties on SearchState
Also removes uneccessary property

* For #3633 - Creates `StateViewModel` to handle state restoration

* For #3633 - Adds a test for onTextChanged

* For #3633 - Adds tests for SearchInteractor

* For #3633 - Fixes bugs and adds documentation
2019-07-12 16:32:00 -07:00
Emily Kager 867067537a For #3568 - Use correct styling for QR and Share Alert Dialogs 2019-07-12 11:40:33 -07:00
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
Jeff Boek f323c38be0 For #981 - Adds missing Leanplum events 2019-06-14 13:27:50 -07:00
Colin Lee d5c5587a0c
For #3209: Disable shared element animations for crash temporarily (#3482) 2019-06-14 12:13:13 -05:00
Emily Kager 5eb2bc6d55 For #3138 - Sets height of toolbar in SearchFragment to match_parent (#3400) 2019-06-12 19:44:44 -05:00
Colin Lee 66a836cf3a
For #3314: Toolbar and QAB unresponsive after Android 6 perms check (#3373) 2019-06-12 10:08:39 -05:00
Sawyer Blatz 86aac3e313 For #3176: Hides camera options on devices without cameras (#3273) 2019-06-07 19:37:43 -05:00
Jonathan Almeida f7bd39da77 For #3138: Fix white background on search bar 2019-06-06 17:11:06 -07:00
Denys M 605a552f16 For #1366. Update toolbar search state when typing. (#2908) 2019-06-06 08:16:22 -07:00
Emily Kager 8dbed67f7f No issue: Simplify and speed up shared element transitions 2019-05-30 16:30:06 -07:00
Emily Kager 43a961fe73 For #1973 - Toggle QR button on deny permissions, fix engineView crashes 2019-05-30 16:06:37 -07:00
Emily Kager 8181705b58 Init Toolbar in edit mode so we don't see the flash 2019-05-29 12:27:48 -07:00
ekager dee3c059dc Adds Shared Transition between Home and Search 2019-05-29 12:27:48 -07:00
Emily Kager a80053547e For #2806 - navigate up from SearchFragment instead of activity back press (#2812) 2019-05-23 21:30:05 -07:00
Emily Kager e534dad199 For #2028 - Pass Session ID for Custom Tab Prompts, Theme Dialogs 2019-05-20 19:24:48 -07:00
Emily Kager 028c6cad70 For #2025 - Create and theme Dialog for deleting all history 2019-05-20 19:24:48 -07:00
Sawyer Blatz 9e50b55340 For #1857: Adds telemetry for QR scanner 2019-05-17 10:46:53 -07:00
Jeff Boek c5e5ef4b25
Teases apart ViewModel dependencies (#2499)
* No Issue - pulls render outside of the viewmodel

* No Issue - Properly subscribes to the changesObservable

* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
Colin Lee ccbc14a71f For #1994: Re-architect state handling code (#2382) 2019-05-09 23:06:12 +00:00
Emily Kager e4b4934f53 For #2393 - SearchTermsTapped even on URL should search (#2398) 2019-05-09 16:21:33 -05:00
Sawyer Blatz 70486039c0 Closes #2147: Refactors usage of openToBrowserAndLoad 2019-04-29 15:49:22 -07:00
Colin Lee 5b7e297adf
For #1955: Add prompt before loading QR code (#2096) 2019-04-28 01:00:55 -05:00
Emily Kager 97e4f43fda No issue: null check context on permission granted (#2104) 2019-04-26 22:02:50 -07:00
Sawyer Blatz 29238d6e5f For #1954: Hides keyboard when requesting camera permission 2019-04-26 15:53:38 -07:00
Sawyer Blatz 46924544b6 For #1975 & #1627: Refactors getSessionById in BrowserFragment 2019-04-25 16:51:03 -07:00
Sawyer Blatz 4945805e37
For #1954: Resolves QR scanner back press and keyboard issues (#2036) 2019-04-25 12:31:17 -07:00
Jeff Boek 31494a4341 Sets the search engine to the default if no shortcut is used 2019-04-23 17:39:57 -05:00
Sawyer Blatz 8a4995099f For #1205: Adds search term to EditToolbar 2019-04-23 09:59:48 -07:00
Colin Lee 6199d31924 For #1851: QR code scanner doesn't load right after permission grant 2019-04-22 13:56:43 -07:00
Colin Lee d1fd5ec879 For #113: QR Scan 2019-04-19 14:47:53 -07:00
Jeff Boek cb7ad32b62 For #1158 - Add search counts 2019-04-17 10:04:49 -07:00
Sawyer Blatz f48e2b072e No issue: Cleans up SearchShortcut changes 2019-04-17 11:20:59 -05:00