1
0
Fork 0
Commit Graph

68 Commits (d1964d6536f6e911cab96f60d5bf24547efcd1a3)

Author SHA1 Message Date
Jeff Boek 68f5d211d3 For #4326 - Updates codebase to support latest version of detekt 2019-08-21 13:50:51 -07:00
Tiger Oakes ac6c1ec2ee Closes #2690 - Clean up CreateCollection viewmodel (#4731) 2019-08-20 10:45:41 -07:00
Sawyer Blatz 4731977f5d
For #4421: Fixes issues with new glean events (#4816) 2019-08-19 14:49:48 -07:00
Jorge De Los Santos 337ad1e88e For #3424 - Make talkback ignore ImageButton in Collection Sele… (#3792)
For #3424 - Make talkback ignore ImageButton in Collection Selection by removing contentDescription and setting importantForAccessibility=no
2019-08-12 11:49:25 -04:00
Colin Lee ef97173cd9
For #4529, #4427: Resuming after restoring instance state breaks UI (#4571)
* For #4529, #4427: Resuming after restoring instance state breaks UI

* Clear up warnings
2019-08-08 11:05:01 -05:00
Sawyer Blatz 9d65e665e5 No issue: Removes deprecated usage of ViewModelProviders 2019-08-07 19:21:41 -04:00
Nikit Bhandari 671727c3e8 For #4341 use camelCase for views referenced from code 2019-08-03 09:25:55 -07:00
Nikit Bhandari 46de06d132 For #4339 reduce build warnings (#4340) 2019-07-31 11:43:49 -07:00
mihai-adrian 458632f4bf fixes #4237 - Cannot edit the default name of a collection, only replace it
changed setting of text to be done before transition, preventing transition to make textView unclickable;
 added renaming situation to showKeyboard in onResume();
 changed title text when renaming, from: "Name collection" to "Rename collection".
2019-07-30 16:26:10 -04:00
mihai-adrian ef3c813aee fixes #4237 - Cannot edit the default name of a collection, only replace it
changed setting of text to be done before transition, preventing transition to make textView unclickable;
 added renaming situation to showKeyboard in onResume();
 changed title text when renaming, from: "Name collection" to "Rename collection".
2019-07-30 16:26:10 -04:00
mihai-adrian 2e300fc8cf fixes #4237 - Cannot edit the default name of a collection, only replace it
made name_collection_edittext field clickable
2019-07-30 16:26:10 -04:00
Tiger Oakes 88c05a5f43 Use glide-like image loading function 2019-07-29 10:22:23 -07:00
Nikit Bhandari 9d9685625a For #4201 fix app crash on renaming a collection (#4202)
* For #4201 fix app crash on renaming a collection

* update
2019-07-22 10:31:00 -07:00
Sawyer Blatz 13198f56df For #969: Adds telemetry for collections (#3935) 2019-07-18 16:05:42 -07:00
Tiger Oakes 6da6ddb095 Use StateListDrawable & resources w/ TabCollection 2019-07-18 15:29:06 -04:00
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
Tiger Oakes 8cd1a0cb38 Move adapter Job setup code to helper class (#3407) 2019-07-01 13:34:25 -05:00
Sawyer Blatz 7e46e71d00 For #3005: Closes tabs when saving to collection (#3723) 2019-07-01 11:39:48 -05:00
Tiger Oakes 4994554576 No issue: Adds lint exception for when statement (#3685) 2019-06-26 15:52:24 -07:00
Tiger Oakes 30930cdc88 Import variables referred to by path 2019-06-25 13:57:34 -07:00
Tiger Oakes d01bb8c442 Use lifecycleScope for collections fragments 2019-06-25 13:56:15 -07:00
vmbaicu 021900e7ad Fixes #3527 - Set Collection name max length (#3531) 2019-06-24 13:58:04 -07:00
Nikit Bhandari cfefc5632b For #3489: Disables blank collection names (#3490) 2019-06-24 13:44:02 -07:00
Emily Kager 6bd9b82385 No issue: Remove flash of tab adapter updating data in create collection 2019-06-14 11:01:54 -07:00
Emily Kager e28277693b Closes #3428 - Make + in collection creation selection stage clickable 2019-06-13 22:37:47 -07:00
Emily Kager 8b4c2db4e4 For #3433 - Add checkbox hide changes to change payload 2019-06-13 13:01:44 -07:00
Emily Kager edc1422b68 For #3288 - call setChecked after calling setOnCheckedChangeListener (#3357) 2019-06-11 16:38:32 -05:00
Sawyer Blatz decacbfc97 For #3323 Runs PublicSuffixList synchronously 2019-06-11 09:19:51 -07:00
Nikit Bhandari d814e95794 fix crash on renaming a collection 2019-06-08 06:44:15 -07:00
Sawyer Blatz 45c509fbce
For #2648: Updates trimming of url hostname (#3191)
* For #2648: Updates trimming of url hostname

* For #2648: Fix nits
2019-06-07 09:33:07 -07:00
Emily Kager 7368a95d29 No issue: Sets up observers for tab collection changes (#3248) 2019-06-07 09:45:38 -05:00
ekager 87f6268816 For #3101 - Do not show tab selection screen for 1 tab 2019-06-04 10:08:43 -07:00
Emily Kager 0327b1146b For #2977 - Update add new collections flow (#2991)
* For #2977 - Update add new collections flow

* Rename shared elements to be more general

* Make tab list not clickable in other modes

* For #2577 - Stop Flickering in List

* Add extensions function for next step with collections list size
2019-05-31 12:59:51 -05:00
Sawyer Blatz 9e0e5d95d9 For #2931: Show browser snackbar above quick action sheet 2019-05-30 14:52:09 -07:00
Sawyer Blatz 6a53127ef9 For #2948: Adds menu button add tab to collection 2019-05-29 09:08:11 -07:00
Emily Kager 1ef85433b4 For #2891 - Make checkbox invisible so text isn't cut off 2019-05-28 20:57:02 -07:00
Emily Kager a6a72885d2 For #2898 - Adds Deselect All in Collection Creation Select Tabs Step 2019-05-28 14:58:16 -07:00
Harsh Shandilya 7d9c8726c5 treewide: Resolve compilation warnings (#2859)
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-05-27 19:04:17 +02:00
Emily Kager 01c9317be0 For #2843 - Improve Collections UI and UX (#2851) 2019-05-24 17:06:17 -07:00
Sawyer Blatz 549292d06e For #2732: Removes view model usage from collection creation 2019-05-24 10:40:32 -07:00
Sawyer Blatz 87df0a8103 For #2728 & #2729: Uses view model selected tabs for collection creation (#2748) 2019-05-23 10:46:54 -07:00
Sawyer Blatz 93d0982a6f For #1576: Adds tab collection renaming 2019-05-21 10:34:42 -07:00
Sawyer Blatz afbe397f94 For #1575: Enables adding tabs to existing collection 2019-05-21 09:39:55 -07:00
Sebastian Kaspari 291df48c4e Install the "icons" WebExtension to automatically load icons for every visited website. 2019-05-20 19:34:49 -07:00
Sawyer Blatz 7861a80715 For #2205: Truncates tab collection titles 2019-05-20 14:31:17 -07:00
Sawyer Blatz 4e6f9b9ef1 For #1574: Displays previous tab collections when creating 2019-05-20 14:31:17 -07:00
Sawyer Blatz 60e5f8a626 For #2351: Fixes backspace key ignored in collections 2019-05-20 14:31:17 -07:00
Sawyer Blatz 30a643720f For #1574: Adds tab collection creation 2019-05-20 14:31:17 -07:00
Sawyer Blatz 72d29c2a43
For #2205 & #1578: Integrates tab collection storage (#2478)
* For #2205: Adds TabCollectionStorage

* For #1578: Adds delete to TabCollection
2019-05-16 14:02:24 -07:00
Jeff Boek c5e5ef4b25
Teases apart ViewModel dependencies (#2499)
* No Issue - pulls render outside of the viewmodel

* No Issue - Properly subscribes to the changesObservable

* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00