be1fa8df7d
Pre: introduce a RunWhenReadyQueue
...
This replaces the StartupTaskManager we had with a more general class.
New implementation is a thread-safe "gated task executor", which either
runs the task right away if it's marked as 'ready', or queries it to be
executed later on.
This ability to either execute or queue a task will be useful later on in the
commit series.
2020-03-30 21:43:38 -07:00
5bd0369aed
No issue: remove unused HotStartPerformanceMonitor.
...
This monitor for hot start was intended to be used by FNPRMS to measure
hot start. However, hot start was deprioritized so it's now essentially
unused.
2020-03-11 11:28:38 -07:00
e96732604b
For #167 : Improves home to browser animation
2020-02-28 18:04:14 -07:00
9ed43b60b6
For #7781 : instrument visual completeness for top sites.
...
Eyeballing my output in *Debug builds on my P2, this adds approximately 115ms
or slightly less from first frame drawn to visually complete time.
2020-02-28 13:37:06 -08:00
f9b716286a
For #8034 : Create a post-visual completeness executor
...
Create an object that will execute its enqued tasks
when Fenix is visually complete.
2020-02-28 09:15:06 -08:00
f569f48b33
For #5696 - Adds basic share action to text selection context menu
2020-02-25 15:39:01 -08:00
511c36e191
Removes FragmentPreDrawManager changes in BrowserFragment
2020-02-25 13:38:47 -08:00
dfde37baf5
Reverts For #7559 - allows changing locale even after setting theme with
2020-02-24 00:24:07 -08:00
541bcf072a
Reverts all BrowsingModeManager changes
2020-02-24 00:24:07 -08:00
26d1bd70d8
Revert "For #8460 : Prevent multiple back navigation clicks."
...
This reverts commit b030d3ac9f
2020-02-21 09:32:02 -08:00
da0148b8bd
For #8535 #8498 : Allow for multiple browsingModeListeners dispatch
2020-02-20 19:50:35 -08:00
b030d3ac9f
For #8460 : Prevent multiple back navigation clicks.
2020-02-20 19:14:45 -08:00
5fd3894171
For #8354 Fix uppdating theme when coming from external links
2020-02-18 09:34:36 -08:00
cc29c5fe84
For #7896 : integrate text selection search from AC ( #8295 )
2020-02-17 19:20:35 -08:00
2c01022c4b
For #8153 : Allow web-ext to open new tabs in correct browsing mode
2020-02-12 13:41:16 -08:00
834d7e13cd
Remove Tracking protection popup for visual testing ( #8226 )
...
* For #6903 : allow override TP popup for performanceTest
* For #6903 : refactored the code
2020-02-11 11:12:39 -05:00
64a4a7f422
Provide add-on support ( #8064 )
...
Closes #5630 , #6069 , #6092 , #6091 , #6124 , and #6147 .
Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2020-02-04 01:41:51 -05:00
030f75b4df
For #5892 & #6380 : Updates error page template and allows SSL bypassing
2020-02-03 21:01:14 +01:00
1b7cb117ca
For #7559 - allows changing locale even after setting theme with
...
AppCompatDelegate.setDefaultNightMode(mode). The override is necessary because the uiMode needs
to be manually updated after changing theme
2020-02-03 19:24:12 +01:00
40e72a7b28
For #7524 : Remove DeviceConstellation polling from onResume ( #7908 )
2020-01-25 11:04:24 -08:00
622fdadde8
For #7272 : Show info when saved logins list is empty. ( #7891 )
...
* For #7272 : Show info when saved logins list is empty
* For #7272 : Updated unit tests
2020-01-24 18:13:44 -08:00
5e9b753acb
For #7473 , delay inflation of toolbar
...
Improve performance of HomeActivity.onCreate by delaying this inflation.
We use a ViewStub and inflate the first time the actionbar is accessed.
2020-01-24 15:21:42 -08:00
ffc441f12a
For perf-frontend-issues#50: instrument imperfect reportFullyDrawn.
...
We don't capture the second RV draw yet. Unfortunately, I don't know if
it's the best use of my time to capture that as well.
2020-01-21 18:34:38 -08:00
981d19de13
For #6556 : Adds Telemetry counts for Search Access Points
...
Added two new sources to be counted ('widget' and 'shortcut') besides 'action' and
'suggestion'. Also modified/fixed some tests.
2020-01-16 10:23:48 +02:00
a58decd708
For #6304 & #7577 : Persist private mode between app launches
2020-01-09 17:03:36 -08:00
9c28cb632c
Issue #7425 (et al): Cache the list of installed browsers
...
Cache the list of installed browsers. Calling `Browsers.all`
the application directly redundantly recalculates the list.
Accessing the list of installed browsers through this cache
will reduce that overhead.
2020-01-07 18:40:07 -08:00
ea2411a88b
Feature/#220 language menu ( #7070 )
...
* For #220
- Added advanced header + locale settings item in the settings fragment
* For #220
- Added locale selection page with lib state + handling of locale changes
* For #220
- Removed registering for locale changes in the manifest, allow system
to restart activity in that scenario
* For #220
- Added unit tests for locale settings page
* For #220 : fixed an outdated unit test
ga-a
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2020-01-03 18:15:35 -08:00
13f73c2d2c
For issue 7192: move unsetOpenLinksInAPrivateTabIfNecessary off main thread. ( #7246 )
...
Move method to Settings. There are two instances when we want to call this method: either
processing an intent, or within DefaultBrowserPreference
2019-12-30 14:42:13 -08:00
116f7b3d65
No Issue: Create a method to "finish onboarding" in CI
...
If the intent that starts the HomeActivity includes an extra
boolean flag named finishonboarding and it is set to true,
Fenix will "finish onboarding".
2019-12-13 11:28:57 -08:00
c6c827f693
For #4776 : Redesign and refactor the About Page
...
Added new items to be displayed.
2019-12-12 11:34:10 +02:00
e60141e98d
For perf-frontend-issues#33: Add HotStartPerformanceMonitor.
...
As mentioned in the class comment, we could use an alternative
implementation to measure perf from outside the application however
it's more complicated to set up and less consistent with our cold
startup methodology so we'll start with this.
2019-12-09 15:11:52 -08:00
1b1f9348dc
No Issue - Fixes warnings / compiler errors with A-C update
2019-11-28 12:45:45 +01:00
373bd63c40
For #6470 Remove actions from notification, keep just close private tabs
...
Removed NotificationsIntentProcessor because notifications no longer open app
Added new strings
2019-11-27 10:08:00 -08:00
ee3871cd7c
Closes #5678 : Selected session may render in ExternalAppBrowserActivity
2019-10-28 09:43:33 -07:00
4efc661db8
For #5733 - Private mode notification - wrong home screen ( #6188 )
...
- added PRIVATE MODE intent extra to the notification action
(could use also the OPEN_FROM_NOTIFICATION, but I considered this one to
be more explicit. Kept the old one in case other checks will be done
filtering for it)
- added intent? param to the getPrivateModeFromIntent method, because
onNewIntent() method does not set the activities intent, and it was needed
to be used both in onCreate() and onNewIntent()
2019-10-25 21:41:31 -07:00
b0d796ccee
For #5898 : Default browser toggle sends user to SUMO on Android 5&6 ( #5918 )
2019-10-10 11:16:21 -07:00
693034951c
For 4780: rename 'setPrivateModeIfNecessary'
2019-10-08 15:13:17 -07:00
d1d20b544e
For 4780: update HomeActivity to maintain private mode in memory
...
As an added bonus, this makes the temporal coupling between `setPrivateModeIfNecessary` and `setupThemeAndBrowsingMode` explicit. They previously would have broken if called in reverse order, now it will fail to compile.
2019-10-08 15:13:17 -07:00
6484a48147
For #5787 : Fixes shortcuts asking to launch private alias ( #5825 )
2019-10-08 08:40:28 -07:00
371e2ac3d8
For #514 & #5742 : Updates "launch links in private tab" functionality ( #5721 )
...
* For #514 & #5742 : Updates "launch links in private tab" functionality
* Fixes comments
2019-10-03 12:43:33 -07:00
a4097cd380
FxA WebChannels integration
...
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes #4971 )
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2019-09-30 10:33:56 -07:00
c5330c6880
For 5092 - Show a Snackbar with retry option if sharing to devices fails ( #5158 )
...
* For #5092 - Show a Snackbar with retry option if sharing to devices fails
ShareController will contain all the business logic for checking the result
status of the `share to device` operations. When this fails it will show a
snackbar which also offer the possibility to retry the just failed operation.
To allow this even in the event the user has closed the share fragment we'll
use a GlobalScope's coroutine.
Refactored out the TabsSharedCallback from ShareFragment because otherwise we
would have neede to sent through that the just failed operation. After the
refactor the ShareController is solely responsable for showing the right
snackbar and handling the retry actions.
* For #5092 - Refactor ShareControllerTest
* For #5092 : Adds color theming of snackbars
2019-09-26 12:30:28 -07:00
8c30200ced
Only use Context.settings() function (not getter) ( #5335 )
...
Remove unused String extensions
2019-09-24 10:33:46 -07:00
734d4031e2
Extract UriOpened observer from HomeActivity
2019-09-24 09:37:24 -07:00
6f3d7b4ee8
For #5396 : Adds "always launch in private mode" to settings
2019-09-20 08:33:07 -07:00
b3eca65614
Closes #5091 : Refactor Sentry BreadCrumbs to use lib-crash BreadCrumbs
2019-09-11 16:14:42 -07:00
2e2bac4ccd
For #419 : Create launch icon for private browsing ( #4948 )
2019-09-11 10:52:33 -07:00
4485b7f647
Add Tracking Protection Info Panel
2019-09-11 07:47:13 -07:00
a31eb1f371
Code Health #4883 : Refactored accessing settings by using Context extensions ( #4973 )
2019-09-10 10:11:58 -07:00
09dcdb079d
For #4474 : Adds what's new button to home screen menu ( #5088 )
...
* For #4474 : Adds what's new button to home screen menu
* For #4474 : Adds tests for what's new button
2019-09-03 15:16:29 -05:00
d87b8a8a5c
For #4658 : Add some private browsing mode telemetry ( #4968 )
2019-08-28 14:41:37 -07:00
cc5408d717
For #2053 : Add persistent notification to close all private browsing tabs ( #4913 )
2019-08-28 12:55:24 -07:00
66e14959ba
Add custom tab fragment
2019-08-23 16:12:19 -04:00
282c2dc182
No issue: only sync once on startup
2019-08-23 12:08:11 -04:00
b9f6f7fa93
For #4779 : Don't double navigate with global directions in HomeActivity
2019-08-23 12:01:28 -04:00
9f154dc3a0
Extract intent processors from HomeActivity ( #4884 )
2019-08-22 13:31:40 -05:00
c475bc87cf
Move classes out of top-level package
2019-08-21 13:52:30 -07:00
71a2478f4d
Use Mozilla Android Components 10.0.0
2019-08-21 10:06:05 -04:00
95ef312b1e
Issue #1000 - Remove isCustomTab flag ( #4656 )
2019-08-20 10:00:49 -07:00
73e3db8fe0
For #4804 : Resolves issue with crash reporter stack
2019-08-19 16:40:41 -04:00
d4c83f9668
For #4736 : Display search shortcuts only from home or search widget
2019-08-15 12:24:54 -04:00
b7ca520787
For #4421 : Adds Leanplum events and attributes ( #4626 )
...
* For #4421 : Adds Leanplum events and attributes
* For #4421 : Adds Leanplum deep links
2019-08-14 13:48:45 -07:00
f5ffe3734c
For #4457 : Adds telemetry for search widget actions ( #4714 )
2019-08-14 11:39:54 -07:00
3acabeb6c3
Use global navigation action for browser fragment ( #4691 )
2019-08-14 11:58:29 -05:00
1328d686aa
No issue - Autoformatting ( #4715 )
2019-08-14 09:40:46 -05:00
52542708aa
Consodilate private browsing code
2019-08-09 11:00:41 -07:00
00bd26abe3
Remove task flags
2019-08-07 19:17:56 -04:00
f952234c57
Keep CLEAR_TASK
2019-08-07 19:17:56 -04:00
c87468d031
Remove popBackStack
2019-08-07 19:17:56 -04:00
a8526a0606
For #4438 : Fix crash when opening any URL from URL bar w/ long press
2019-08-07 19:17:56 -04:00
da06b0fb15
For #4508 : Treats warnings as errors ( #4543 )
2019-08-07 14:00:53 -07:00
6f962d3376
For #1744 : Open search shortcuts when entering search mode ( #4536 )
2019-08-05 15:07:03 -07:00
83ceec6289
For #201 : Search Widget
2019-08-02 11:26:48 -07:00
4922e5d09d
No issue: Move PublicSuffixList to root component
...
With the PublicSuffixList class in Utilities, the first instantiation
of it (prefetching in onCreate), causes the Utilities to instantiate
and thus slowing down startup by needing the SearchEngineManager from
instantiating as well.
Moving this back to the root component fixes the immediate perf issue.
Co-authored-by: Will Hawkins <whh8b@obs.cr>
2019-07-31 17:01:14 -07:00
87d8f3b037
Remove redundant super calls
2019-07-29 10:22:53 -07:00
945b1ee274
[ #4089 ] Moved PublicSuffixList to a sub-component(Utilities) class.
2019-07-25 14:36:36 -04:00
be10d427e8
For #4127 - Converts Exceptions to LibState and adds tests
2019-07-22 17:21:06 -04:00
9b5baa2358
For #3360 - Adds empty state for TP Exceptions
2019-07-22 17:21:06 -04:00
e25ceafd1f
No issue: Removes unnecessary fragment transitions from accounts
...
Co-authored-by: ekager <emilykager@gmail.com>
2019-07-18 19:56:25 -04:00
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
fe51bbcf7b
Update FxA integration to new APIs
2019-07-11 13:19:37 +02:00
21c75ca1bb
For #3478 - Add Tab sent snackbar confirmation for device sharing
2019-07-10 14:13:10 -04:00
55f5c5d049
Use lifecycleScope for settings fragments
2019-06-25 13:56:33 -07:00
ea7841b8c5
No issue: Add Sentry breadcrumbs to ease crash investigations
2019-06-24 16:21:43 -07:00
dfe181aa0a
Add application-services fretboard feature flags
2019-06-13 15:29:59 -07:00
decacbfc97
For #3323 Runs PublicSuffixList synchronously
2019-06-11 09:19:51 -07:00
1e6da54263
For #3238 : fixes race condition crash, nav destination unknown
2019-06-06 15:46:34 -07:00
28ecf241f5
For #1301 : Always observe sessions to keep uri_count ( #3172 )
2019-06-06 14:16:31 -05:00
5fb100debd
For #1966 : Up button should cancel multi-selection first ( #3108 )
2019-06-04 10:08:06 -05:00
f48db90716
No issue: Always try to pop to browser when navigating to browser ( #3043 )
2019-05-31 12:57:34 -05:00
209b50016e
For #2723 - Cleans up code formatting
2019-05-30 16:38:31 -07:00
f9d70dbc92
For #2723 - Creates callbacks to wire up the mode and theme manager together
2019-05-30 16:38:31 -07:00
a7d5cdcb9d
For #2723 - Fixes theme manager
2019-05-30 16:38:31 -07:00
18cd9e58f9
Fixes Crash: Pop up to Browser Fragment if exists when coming from Search
2019-05-30 16:30:06 -07:00
72c5cb304c
For #2893 , #2673 , #2916 , #2314 : Fix race condition navigating to browser ( #3023 )
...
Since the Navigation library restores the fragment after memory eviction, if we're already on the BrowserFragment and we deep link navigate to the BrowserFragment, we briefly get two of them. This crashes GeckoView.
2019-05-30 17:43:32 -05:00
b8c04e02e9
For #2327 : Fixes nits
2019-05-30 11:45:39 -07:00
fe50e88fc8
For #2327 : Adds error state syncing
2019-05-30 11:45:39 -07:00
fda0f1de97
No issue: sync and refresh device state on foreground
2019-05-29 09:52:35 -07:00
4e13de3ffd
No issue: Register observers with owner view
2019-05-24 10:53:05 -07:00
895ba021e7
Hide toolbar in activity and remove label from home fragment
2019-05-23 13:41:00 -07:00
Grisha Kruglov