1
0
Fork 0
Commit Graph

2780 Commits (c119070e213ac2f835967f045d13bca36db972b9)

Author SHA1 Message Date
Tiger Oakes 2d066d77ad
Add tests for sync, wifi, and push (#12581) 2020-07-16 12:25:38 -07:00
Tiger Oakes 2291fb07aa
For #12565: Add Locale settings tests & use activity (#12579) 2020-07-16 11:43:27 -07:00
jhugman 3373f8b987
For #12600 - remove AddonInstalled event when the permission dialog is shown (#12601) r=csadilek,sblatz 2020-07-16 19:40:39 +01:00
Mihai Branescu 9373e7fcf4
For #12201 - forced callbacks to be on the main thread (#12543) 2020-07-16 13:39:31 -05:00
Elise Richards 4fe1fb8f4a
No issue: Delete unnecessary to-dos (#12603)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-16 13:38:07 -05:00
Kainalu Hagiwara b867e0de45 Update TabTrayViewHolder with A-C thumbnail changes. 2020-07-16 12:50:33 -04:00
Roger Yang 7923255fda For #12118: Add isSubframeRequest parameter for app links 2020-07-16 12:50:33 -04:00
Christian Sadilek a0d9cdc450 For #12248: Webcompat reporter not active in Nightly 2020-07-16 12:24:21 -04:00
jhugman fb1d7e12e6
For #11704 Add leanplum attributes for tracking protection (#11965) r=sblatz
* For 11657: add LP attribute for tracking protection

* For #11704: added tracking_protection_enabled attribute

* Added docs for the new attributes, linking to data-review to the mma.md

* Rename null to none when no ETP is enabled
2020-07-16 17:09:32 +01:00
James Hugman 798c1bf743 Address review comments 2020-07-16 10:37:03 -04:00
James Hugman 22689a9ff5 Remove need to specify component names for new intents 2020-07-16 10:37:03 -04:00
James Hugman 98a33ea82b Changed home_* style links to urls_* to reflect that the destination is a set of links, rather than where the screen is 2020-07-16 10:37:03 -04:00
James Hugman 1629878a66 Add install_search_widget 2020-07-16 10:37:03 -04:00
James Hugman 8130aaa2cc Add deep links for settings and home screens 2020-07-16 10:37:03 -04:00
Mugurell d449184faa For #12544 - Prevent search engines mixup
Stricter synchronization by always using the same "loadedSearchEngines"
variable.
With "loadedSearchEngines" calling "refreshAsync()" we also get the fallback
engines to contain reddit and youtube (which are programatically added) and
also now we properly remember and display the engines added by user.
2020-07-16 16:49:54 +03:00
Tiger Oakes 6be39aebde
Add tests for StartupReportFullyDrawn (#12560) 2020-07-15 23:31:59 -07:00
Tiger Oakes d4bb432e24
Add helper for underlining text (#12520) 2020-07-15 22:38:46 -07:00
Tiger Oakes a0491b702e
Fix nav graph and theme tests (#12567) 2020-07-15 18:04:36 -07:00
Tiger Oakes d0e9f1f165
Update Kotlin dependency (#10806) 2020-07-15 18:02:58 -07:00
mcarare 800702149b For #12503: Open addon permissions link in app. 2020-07-15 10:04:40 -04:00
ekager 9ed85510ae For #7094 - Adds save login exceptions 2020-07-14 14:47:37 -04:00
Tiger Oakes 69020a1f26
For #12457 - Add MockK matcher for nav directions (#12262) 2020-07-14 10:39:23 -07:00
Tiger Oakes 1ff64cab67
Add tests for search (#12437) 2020-07-14 10:32:04 -07:00
Tiger Oakes e9fb1a61c7
Test viewholders in home.sessioncontrol (#12524) 2020-07-14 10:31:50 -07:00
Hakkı Kaan Çalışkan f424656575 For #12107: Follow ux mock on Settings --> Account screen 2020-07-14 12:25:21 +03:00
Sawyer Blatz 98ad7ace49 For #10466: Put call & email at top of context list 2020-07-13 10:33:55 -07:00
Mugurell ea10d2a872 For #11875 - Prevent mixup of region / locale based search engines
We have two search engine types:
- one based on MLS reported region,
- one based only on Locale.

There are multiple steps involved in returning the default search engine for
example and though at each step we could verify if a certain operation is
completed we are still exposed to concurrency issues.
Simplest and most effective way to make sure the MLS engines do not mix with
Locale based engines is to use the same type of engines for the entire duration
of the app. At the next cold start we'll verify again which engines to use.

Using the Locale based engines (fallbacks) is expected to only happen once, at
the first run of the application after being installed.
2020-07-13 13:41:34 +03:00
jhugman 9df13ae121
For #11655: add leanplum event for installing an addon (#12136) r=elise
* For #11655: add leanplum event for installing an addon

* Add link to data-review request in PR

* Addressed CI comments
2020-07-12 23:47:34 +01:00
Grisha Kruglov 31248b835c Synced Tabs: make sure to stop 'loading' when we encounter an error 2020-07-10 19:02:55 -07:00
ekager 0add94e353 For #11324 - Adds trash icon to swipe to delete 2020-07-10 20:16:57 -04:00
Nazım Can Altınova 7319f77114 Add profiler markers for HomeActivity.load and DefaultTabTrayController.onNewTabTapped 2020-07-10 16:43:06 -07:00
Sawyer Blatz 5d9fdd6266 Update app/src/main/java/org/mozilla/fenix/HomeActivity.kt
Co-authored-by: Tiger Oakes <contact@tigeroakes.com>
2020-07-10 18:44:14 -04:00
Sawyer Blatz bab0f9d95b No issue: Update AC version 2020-07-10 18:44:14 -04:00
Grisha Kruglov 806f6031ae For #12433 - Allow synced tabs pull-to-refresh for non-critical account errors 2020-07-09 16:18:54 -07:00
ekager ad265be672 For #11303 - Change copy login origin to open in browser 2020-07-09 18:09:41 -04:00
Tiger Oakes c99a8f5cfa
Fixes #9832 - Change targetSdkVersion to Android 10 (#11014) 2020-07-09 10:50:51 -07:00
Sebastian Kaspari a2a7b11425 Issue #12311: BrowserToolbarController: Stop SessionFeature and release session from EngineView. 2020-07-09 12:36:56 -04:00
David Walsh 85cebf8796 For 11889 - Fix snackbar for collection creation in browser fragment 2020-07-09 08:50:12 +03:00
ekager 38657bbfc6 For #11431 - Scroll to restored tab in tab tray 2020-07-08 17:18:16 -04:00
Christian Sadilek 216396d979 For #12353: URL copied to clipboard should not be extension/reader URL 2020-07-08 16:55:32 -04:00
Tiger Oakes 9ae1aa6f16 Add tests for exceptions 2020-07-08 15:52:37 -04:00
MickeyMoz 236b981881 Update Android Components version to 50.0.20200708130551. 2020-07-08 12:44:51 -04:00
Tiger Oakes 67ce5ad5d9
Add tests for onboarding viewholders (#11522) 2020-07-08 07:53:22 -07:00
Tiger Oakes 720a590902
Add tests for browser helper classes (#12370) 2020-07-07 19:46:25 -07:00
Christian Sadilek 27c608d956 Update built-in extensions for new AC/GV API
New API (installBuiltIn/ensureBuiltin) requires
- Gecko IDs and new permissions
- Extension will only be re-installed if it has a new version

This includes a gradle task to automatically generate a
new version in manifest.json for every build so we don't
forget to update the version and end up with changes that
are never applied.
2020-07-07 18:41:12 -04:00
ekager bceb07a05b For #12312 - Disable settings that navigate while authenticating 2020-07-07 16:46:14 -04:00
Michael Comella 3e617245b5 For #12345: catch SecurityException when calling reportFullyDrawn.
That's amazing! I've got the same combination on my luggage.
2020-07-07 13:44:09 -07:00
Tiger Oakes 65637e9e2b
Use A-C version of Resources.getSpanned (#12358) 2020-07-07 13:36:29 -07:00
Mihai Eduard Badea eeb8719fa1 For issue #12126 - Tab counter consumeFrom update
Added a direct call to the updateTabCounter method to account for changes made to the BrowserState while the tabCounter view is not visible.
2020-07-07 11:12:55 -04:00
Tiger Oakes 8e8e5aea36
Extract radio group logic into helper (#11493) 2020-07-06 17:09:42 -07:00
ValentinTimisica e39d5b6de7 For #11763: Shows confirmation dialog when deleting last tab from collection 2020-07-06 17:06:10 -04:00
ValentinTimisica c3acde438a For #11889: Changes collection creation confirmation snackbar strings
Also I changed the adding tabs to collection confirmation string from
tabtray to take into account the number of tabs.
Example: 1 tab-"Tab saved!"; multiple tabs-"Tabs saved!"
2020-07-06 17:02:02 -04:00
Tiger Oakes 1ab5fe3eb9
Add method to test fragments in roboletric (#12261) 2020-07-06 13:04:43 -07:00
Hakkı Kaan Çalışkan 331090d1e6 For #12007: Fix add search engine items using wrap content for height 2020-07-06 15:37:28 -04:00
MickeyMoz da39a7e671 Update Android Components version to 49.0.20200705130154. 2020-07-06 15:21:40 -04:00
mcarare 94273bc274 For #12125: Handle visibility updates for add to collection button. 2020-07-06 14:37:39 -04:00
Tiger Oakes fd18687ac9 Switch to any calls 2020-07-06 20:38:08 +03:00
Tiger Oakes 41452e945b Move SearchProviderModel extension to class 2020-07-06 20:38:08 +03:00
Mugurell 0fb6bbc175 For #10401 - Hide Shortcuts if just one search engine is installed
Otherwise, the Shortcuts option which allows to choose with what search engines
to search would be redundant.
2020-07-06 14:36:04 +03:00
Sebastian Kaspari 388c144a62 SearchFragmentStore: Remove Session reference from state and read values from BrowserStore. 2020-07-03 21:01:59 +02:00
ekager f863c341e8 Updates AC to 49.0.20200702190156 and fixes breaking changes 2020-07-03 06:40:06 -04:00
ekager 8533d96ee2 For #11320 - Expose login autofill setting to beta dimension 2020-07-03 06:40:06 -04:00
liuche 6ec0aeb843
Issue #12207 - Update "new nightly" link to point to org.mozilla.fenix (#12209) 2020-07-02 12:39:44 -07:00
Sawyer Blatz 8583cac8f8 Revert "For #11183: Redirect user to homescreen after widget added"
This reverts commit a8ed913654.
2020-07-02 11:22:18 -07:00
Sawyer Blatz 3cbab45566 For #12157: Don't show two search widget dialogs 2020-07-02 11:22:18 -07:00
Mihai Adrian Carare daecbd348b
For #11996: Open all links from add-on details in Fenix. (#12080)
* For #11996: Open add-on homepage link in Fenix.

* For #11996: Open add-on details links in Fenix.
2020-07-01 19:13:23 -07:00
Sawyer Blatz 306505fee0
No issue: Remove feature flag for tips (#12172) 2020-07-01 14:47:40 -07:00
Johan Lorenzo 4bc1cb94c5
Bug 1649400 - part 1: ship org.mozilla.fenix as a nightly product (#12127) 2020-07-01 11:03:10 +02:00
Jeff Boek fb4822498f For #12081 - Properly installs searchengines when MLS completes 2020-06-30 13:35:08 -07:00
ekager 70f90e71e8 For #11991 - Show tab count during onboarding 2020-06-29 17:59:19 -04:00
Tiger Oakes 6bde0378a2
Add tests for StrictModeManager (#12013) 2020-06-29 08:17:07 -07:00
ekager 60069395eb Update AC to 48.0.20200627130132 and fix breaking changes 2020-06-27 20:11:31 -04:00
Tiger Oakes ed334788e8 For #11903: Enforce private theme in custom tabs 2020-06-26 22:59:43 -04:00
Jeff Boek b1a8c0f483 For #9935 - Use the searchengine deferred 2020-06-26 19:07:36 -07:00
Jeff Boek 40977a93a0 For #9935 - Fallback region selection on first load 2020-06-26 19:07:36 -07:00
Michael Comella 5ef6b49aa1
For #8795: remove redundant ConstraintLayout around BrowserToolbar. (#12014)
This is functionally equivalent to the code before this patch but should
be slightly more performant in theory because ConstraintLayout is
expensive to inflate.

The elevation and layoutParams set dynamically appeared to have no effect
with the wrapping view but broke the view when used by itself so I had
to remove them. I also updated a few other unnecessary params.

Theoretically this may have some perf benefits but I didn't see anything
outside noise levels after I took the numbers (but I didn't try very
hard).
2020-06-26 21:31:02 -04:00
David Walsh c4a4beb6b9 For 11468 - Show tab tray after opening links from history and bookmarks 2020-06-26 18:28:31 -07:00
Kate Glazko 2ac8496315 For #12025: Set Search Shortcuts Off By Default 2020-06-26 18:21:58 -07:00
Jeff Boek a18c1befd1
For #11044 - Sets the anchorView of the snackbar to be the new tab fab (#11930) 2020-06-26 17:56:56 -07:00
Sachin 4b9cc954fa
for #11830 added new metric for collecting startup method from all startup phases (#11940)
* for #11830 added new metric for collecting startup method

move all source startup telemetry into its own logic and added an UNKOWN state

* switched back to onNewIntent solution

* renamed the metric
2020-06-26 17:38:08 -07:00
Sawyer Blatz 61b1b5a895
No issue: update experiments when experiments updated (#12032) 2020-06-26 17:19:58 -07:00
Sawyer Blatz 8a08cb941e
For #11479: Record open tabs count in metrics ping (#12024) 2020-06-26 17:15:43 -07:00
Jonathan Almeida b7d989a588 Fix breaking API in WebNotificationFeature 2020-06-26 19:59:57 -04:00
Marc Leclair ff5d00362b Added A-C version 48.0.20200626213814 2020-06-26 19:59:57 -04:00
Sawyer Blatz 101ecfbf66
For #11273: Add tabs tray telemetry (#12036) 2020-06-26 16:37:07 -07:00
Tiger Oakes 7287b5579f
Test settings about/advanced (#12023) 2020-06-26 15:53:30 -07:00
Tiger Oakes 4f6f0785c5
For #11943: Fix intermittent coroutine failure (#12027) 2020-06-26 15:42:53 -07:00
ekager df49db6adb For #11294 - Enable Synced Tabs for all builds 2020-06-26 18:36:37 -04:00
Gabriel Luong e6a56aec36
For #12026 - Update default top sites for new users (#12028) 2020-06-26 17:51:18 -04:00
Grisha Kruglov f8cb1d6b48 Closes #11909: Metrics for recording number of recently used PWAs 2020-06-26 14:13:41 -07:00
Elise Richards eeabcb10ff
Fix illegal arguments for onboarding keys (#12033) 2020-06-26 16:12:18 -05:00
Tiger Oakes bcb2ef10ac
Add tests for PhoneFeature (#12021) 2020-06-26 12:12:52 -07:00
MarcLeclair f3b44c06e4
For #11841: Removed topsite bug on private browsing (#12020) 2020-06-26 14:54:20 -04:00
Gabriel Luong 005ad6ff2a
Update Android Components version to 48.0.20200626130049. (#12006)
Co-authored-by: MickeyMoz <sebastian@mozilla.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2020-06-26 14:16:57 -04:00
Tiger Oakes 80de3851f3
Add tests for OnSharedPreferenceChangeListener (#12019) 2020-06-26 11:04:46 -07:00
ValentinTimisica 9f5c8819d3 For #11892: Remove dynamic calls to setupNavigationToolbar
This is a speculative fix for 11892 crash.
The side effect is that the back button will be visible in bookmarks root.
2020-06-26 07:54:11 -04:00
Mihai Branescu 93247e0b2f For #9425 - SearchFragment now reacts to undo operation for base engines 2020-06-26 13:21:00 +03:00
Mihai Branescu e6e3166d2d For #9425 - SearchFragment now reacts to undo operation for custom engines
When you remove a search engine from our list, an undo snackbar that outlives the fragment is shown. If you go back to the search fragment and press undo, now the shortcut list gets updated
2020-06-26 13:21:00 +03:00
Mihai Branescu 46c1c130da For #9425 - Handle undo for custom search engines
On undo, get the template that the user entered for that engine and then
re-add it to the `CustomSearchEngineStore`
2020-06-26 13:21:00 +03:00
Sawyer Blatz c5034fa770 No issue: Allow us to run experiments on nightly if needed 2020-06-26 09:16:38 +03:00
mcarare 216da0c64b For #10285: Add a custom TextView for links with a11y improvements. 2020-06-26 09:15:44 +03:00
Kainalu Hagiwara b84f55c980 For #11677 - Adjust tab counter menu item order. 2020-06-25 15:48:10 -07:00
person808 ad90625b48 For #2165 - Add swipe to refresh gesture to bookmarks view. 2020-06-25 14:50:24 -07:00
Christian Sadilek 64440409b0 For #9100: Follow-up to fix memory leak in NotificationSessionObserver
The observer was moved and is now bound to the activity and its
context. If the activity is re-created we leak the observer and
therefore the activity itself.

With this we make sure to stop the observer and also don't use
the activity context to begin with.
2020-06-25 16:17:38 -04:00
ekager c77ddd8d26 For #11866 - Update back press logic for SearchFragment 2020-06-25 14:40:31 -04:00
Christian Sadilek 7be56ce4fa For #11798: Allow sharing of reader view pages 2020-06-25 14:39:21 -04:00
Sawyer Blatz 04aee11d82
For #9625: Add telemetry for Tracking Protection CFR (#11923) 2020-06-25 11:24:55 -07:00
Elise Richards 665fb8d60c
#10824: Onboarding telemetry (#11867)
* Onboarding events and tracking

* Rename metrics for consistency

* Add reference to PR for the data review

* Add default values to onboarding events
2020-06-25 13:21:31 -05:00
Sawyer Blatz 2d65faf232
For #11392: Rename Installation ping to FirstSession (#11869) 2020-06-25 10:06:26 -07:00
ekager d3de9e517e Remove ThumbnailsUseCases 2020-06-25 12:51:18 -04:00
Tiger Oakes c958cc048a Update customtabs service 2020-06-24 23:26:49 -04:00
Sawyer Blatz 13c8abe3dc For #11613: Expand toolbar onUrlChanged 2020-06-24 21:50:06 -04:00
Mihai Branescu be5213e944 For #11727 - added content description 2020-06-24 21:42:38 -04:00
Hakkı Kaan Çalışkan 9068c96ab3 don't animate unnecessarily
Fixes #11672, #11727: Empty default tab text and add padding to infinite character

Fixes #11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily

don't animate unnecessarily

Fixes #11739: Fix flicker

Update TabCounter.kt

squash commits

don't animate unnecessarily

Fixes #11672, #11727: Empty default tab text and add padding to infinite character

Fixes #11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily
2020-06-24 21:42:38 -04:00
Hakkı Kaan Çalışkan 3dc6c438f4 Fixes #11739: Fix flicker 2020-06-24 21:42:38 -04:00
Hakkı Kaan Çalışkan b95804c33b Fixes #11672, #11727: Empty default tab text and add padding to infinite character 2020-06-24 21:42:38 -04:00
Sawyer Blatz a8ed913654 For #11183: Redirect user to homescreen after widget added
Co-authored-by:  hakkikaancaliskan <caliskanhkaan@gmail.com>
2020-06-24 21:41:42 -04:00
David Walsh 77ed670558 For #11860 - Conditionally show add to collection button on Home screen 2020-06-24 21:41:19 -04:00
Sawyer Blatz 872c179cf4 For #11825: Removing the last pretty animation 😞
Goodbye, sweet summer child.
2020-06-24 21:38:28 -04:00
mcarare a056e86e4f For #8080: Dismiss menu when swiping away from its anchor. 2020-06-24 21:37:57 -04:00
mcarare b961fdcf02 For #11901: Use safe call for collection item info. 2020-06-24 21:37:24 -04:00
Mihai Branescu 49b617c999
For #9100 - Private browsing notification fixes
Co-authored-by: Seef <Saif Dara>
2020-06-24 21:35:11 -04:00
Mihai Branescu 632b64971f For #10467 - removed unused tests and resources related to blue dot notification 2020-06-24 21:33:32 -04:00
Mihai Branescu 3c2c7f705c For #10467 - blue dot doesn't disappear on menu dismiss 2020-06-24 21:33:32 -04:00
Tiger Oakes 0b781ae3b7 Add tests for collection creation controller 2020-06-24 21:21:02 -04:00
Jeff Boek 177e7a400f For #11406 - Scrolls to selected tab when switching modes 2020-06-24 21:16:48 -04:00
Tiger Oakes 4415702fa8 Add tests for share sheet 2020-06-24 20:33:47 -04:00
Tiger Oakes 183ba1bce0 For #11903: fix custom tab private gradient 2020-06-24 20:33:16 -04:00
ekager f39313d908 For #8374 - On external session removed, handle back press 2020-06-24 20:17:26 -04:00
person808 5f7e0e4dd6 Followup for #11442 - Add tab counter menu metrics to home fragment. 2020-06-24 10:20:51 -07:00
Tiger Oakes 9a8b800a76 For #8621 - fix intermittent test failures 2020-06-23 17:43:24 -04:00
Jeff Boek 621da0c4c1
For #9935 - Adds fallback searchengine provider for long MLS lookups (#11863) 2020-06-23 14:00:18 -07:00
mcarare fe97dc9d2e For #11542: Update tabs positions in tab tray reported by screen readers 2020-06-23 11:28:24 -07:00
ekager 06e6cfa696 For #5636 - Unregisters wifiConnectedListener when setting changes, sets default blocked 2020-06-23 12:28:52 -04:00
Jeff Boek 8ce7cf59c8
For #11261 - Dismisses menu when rotating to landscape (#11845) 2020-06-23 10:50:20 -05:00
Jeff Boek 2861421312 For #11112 - Adds save tabs to collection button to the no collections message 2020-06-23 08:17:55 -07:00
Tiger Oakes ccb532bb77
For #11534 - Don't check lastUsed mode for screenshots (#11827) 2020-06-22 17:38:58 -07:00
Jeff Boek c7b1f215c8
No Issue - Fixes flash when toggling tab tray (#11826) 2020-06-22 16:49:07 -05:00
Tiger Oakes 18cc4c95c1
Add tests for ContextKt (#11824)
Migrated from an old branch by Kate

Co-authored-by: Kate Glazko <katglazko@gmail.com>
2020-06-22 14:00:43 -07:00
Hakkı Kaan Çalışkan c8d36ddc36 For #8649: No bookmarks here strings are close to the top 2020-06-22 16:04:20 -04:00
ekager 88765c348b Update A-C version, add synced tabs empty state 2020-06-22 15:13:13 -04:00
mcarare 721e290734 For #10049: Provide correct seek bar value to screen readers. 2020-06-22 13:58:33 -04:00
ValentinTimisica c75ab3f720
For #10462: Removes back button from bookmarks and history fragments (#11721) 2020-06-22 13:15:33 -04:00
ekager 635c30510d No issue: refactor tabs tray to use interactor/controller, add tests 2020-06-22 13:01:35 -04:00
Mugurell 0ba1d266b3 For #9144 - Ignore previous Intent if activity is started from Recents
We'll now clearly differentiate between cold / hot starts of HomeActivity.kt.
This is needed because Android will resend the original Intent which initially
started the Activity whenever it is restarted from the Recents Screen if the
activity is already destroyed at that time. So in the event that the activity
was before started with an Intent to open a webpage for example whenever the
activity is restarted from Recents it will receive the same Intent to open a
webpage even though that Intent has already been consumed.

Activity's onCreate() will only use the intent processors when the activity is
cold started so that we'll only initially act upon Intents configured for
different behaviors inside the app.
If the activity is destroyed while in background and opened from Recents it
will not act upon the original Intent which is now resent by Android.

Activity's onNewIntent() will be called to act upon a new Intent if the
activity is hot started since we are declared as singleTask and it now has the
responsibility to delegate various intent processors to consume that Intent.
2020-06-22 12:08:24 -04:00
ValentinTimisica 0b57f5e71b Fixes #10551: Removes the increased touch target for learn more link 2020-06-22 16:40:15 +03:00
Mihai Eduard Badea eb45b37207 For issue #10727 - Hide saved logins details
Removed the clearFlags call from the HomeActivity that was causing this issue and removed the now redundant call to update the flag from the redirectToReAuth method
2020-06-22 13:19:02 +03:00
ValentinTimisica e9bb11e22d Fixes #9205: Changes add-ons and 'Open links in apps' icons from menus 2020-06-22 12:09:19 +03:00
Sachin 988513aa89
for #10568 moved awesomebar and toolbar into fragment_search (#11744) 2020-06-21 14:56:49 -07:00
Sachin 9269a53b21
for #11615 allowed strictMode disk read for violations made by the OS. (#11658) 2020-06-21 14:54:49 -07:00
Antti Vainikka cb129231ae Closes #11500: Remove wrong activity title 2020-06-19 18:17:35 +03:00
mcarare a0fe1a452a For #11756: Fix bottom toolbar preference reference. 2020-06-19 11:20:08 +03:00
mcarare 4bebc56c50 For #9229: Remember options for delete browsing data. 2020-06-19 09:32:37 +03:00
MarcLeclair b52091ed34
For #11660: added prefetch for topsites and update in onCreateView() (#11668)
* For #11660:added prefetch for topsites

TopSites will be prefetched with observerOnce (wrapper around observerForever).
Also, the SessionControlView.update() is called right away instead of waiting from consumeFrom
in the HomeFragment.onCreateView() which will allow the UI to render all at once on its first
perform traversal

* Removed the submitList(null) since it retriggered a drawing on lower end device
2020-06-18 19:43:20 -04:00
Emily Kager 44ff29bdc0 Revert "For issue #9949 - Bookmarks/History deletion inconsistencies"
This reverts commit 3feab90b19.
2020-06-18 19:31:49 -04:00
ekager df63c5a4bc For #11708 - Remove setMargins in CustomTabsIntegration 2020-06-18 17:02:34 -04:00
Jeff Boek 82cbafabaf
For #11625 - Fixes tab tray staying open when opening from another app (#11740) 2020-06-18 12:32:14 -05:00
mcarare 5f1c9449f3 For #8114: Restore normal UI when a library fragment is detached. 2020-06-18 17:42:06 +03:00
Tiger Oakes c503798cd6 Replace PhoneFeature.getPreferenceKey 2020-06-18 09:02:58 -04:00
Tiger Oakes 596c579bbb Replace nullable findPreference 2020-06-18 09:02:58 -04:00
Tiger Oakes 45ef88f6b9 Replace requireNotNull(findPreference()) 2020-06-18 09:02:58 -04:00
Tiger Oakes 3e03439259 Add requirePreference helper 2020-06-18 09:02:58 -04:00
codrut.topliceanu 0eb2f328dc For #11371 - Fix for Dynamic Download Dialog 2020-06-18 09:00:55 -04:00
David Walsh 3feab90b19 For issue #9949 - Bookmarks/History deletion inconsistencies
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.

 - Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in #8648.
2020-06-17 14:42:51 -04:00
Tiger Oakes f6efb386d6 Add tests for addon details 2020-06-17 14:38:50 -04:00
Hakkı Kaan Çalışkan 8cbdce58e6 Update FxaServer.kt 2020-06-16 23:30:57 -04:00
Hakkı Kaan Çalışkan 670e03c3b2 Update app/src/main/java/org/mozilla/fenix/components/FxaServer.kt
Co-authored-by: Tiger Oakes <contact@tigeroakes.com>
2020-06-16 23:30:57 -04:00
Hakkı Kaan Çalışkan bd85a9c399 remove suppress and unnecessary otherwise = private 2020-06-16 23:30:57 -04:00
Hakkı Kaan Çalışkan 87a65d2445 For #9782: Clean up unused FeatureFlags
I've currently found out this ones unused.
webPushIntegration removed because looks like all fatal bugs solved as it said from note.
2020-06-16 23:30:57 -04:00
Sören Hentzschel 396cd61efa For #9712 - show "AC: " before AC version on "About" screen 2020-06-16 15:29:00 -04:00
Sachin 36b1c710e7
for #11617 added a resetPoliciesAfter ext function for StrictMode, and replaced all existing calls to "resetAfter" with "resetPoliciesAfter" (#11619) 2020-06-16 11:12:18 -07:00
Tiger Oakes d81aa62683 Fix PIP toolbar 2020-06-15 15:34:06 -04:00
Tiger Oakes d3d5c8934f Cleanup tests for toolbar controller 2020-06-15 15:25:33 -04:00
person808 9e3e95e351 For #11442 - Telemetry for tab counter menu. 2020-06-15 11:48:12 -07:00
Mihai Branescu 4f870e9251 For #6126 - moved the sessionObserver init to the onCreate
This helps because we will always need the observer to be initiated, not only when the `openToBrowser` method gets called. Example: Opening a tab from the tab tray had it's own method for opening the browser, causing this to not be called.
2020-06-15 08:01:32 +03:00
Jonathan Almeida e6da2bd910 Fix breaking APIs in TabsAdapter and ViewHolder 2020-06-13 16:02:31 -04:00
Tiger Oakes 704fc6f983 Use updated webapphidetoolbarfeature 2020-06-12 19:21:34 -04:00
Tiger Oakes fc96e188ab Convert flow from AC to livedata 2020-06-12 19:21:34 -04:00
David Walsh 149efc1683
For 9640 - Focus on last selected tab in tab tray with a11y turned on (#11487) 2020-06-12 18:15:13 -05:00
David Walsh 8b24cdec42
For 11428 - Focus on home screen address bar when tab tray new tab is tapped (#11429) 2020-06-12 17:55:07 -05:00
David Walsh 063cf457ba
For #11291 - Provide New Tab button when accessibility enabled (#11441) 2020-06-12 17:52:06 -05:00
liuche 35fa445165
Issue #11112 - Update empty collections string + tests. (#11538) 2020-06-12 18:01:38 -04:00
Arturo Mejia a36ec7279e No issue: Decrease the frequency for checking for new supported add-ons 2020-06-12 17:19:07 -04:00
Tiger Oakes 294f29768d Test logins settings 2020-06-12 15:30:50 -04:00
Sawyer Blatz 0a9afbed42 For #11380: Update migration tip text 2020-06-12 15:17:53 -04:00
Sawyer Blatz fffbadbfca
For #11118: Add browsing history suggestion in metrics (#11525) 2020-06-12 11:40:04 -07:00
Sawyer Blatz 13d077eb66
For #11269: Telemetry for new reader mode position (#11385) 2020-06-12 11:39:35 -07:00
Sawyer Blatz d1cd877374 For #11118: Add missing telemetry 2020-06-12 10:29:05 -07:00
mcarare 0ebfa4f947 For #11497: Disable pull to refresh in error states. 2020-06-12 14:09:16 +03:00
Jeff Boek 1639b1d3a1 For #11342 - Fixes missing space for the FAB 2020-06-11 18:25:57 -04:00
Tiger Oakes 651b2831fe Fix tests in toolbar controller 2020-06-11 18:15:09 -04:00
Sachin cd26ba9a9c
for #11364 added a exception list for manufacturers violating strict mode policies on startup (#11407)
for #11364 changed blackList -> exceptionList, added one plus to the list

change magic strings into const Val
2020-06-11 11:50:07 -07:00
person808 d14b39a56e For #2165 - Implement pull-to-refresh gesture to sync history. 2020-06-11 10:23:27 -07:00
mcarare 4b04a140fc For #11229: Update etp strict option title content description. 2020-06-11 10:20:01 +03:00
Sawyer Blatz 932a2f3703 For #11063: Update telemetry for etp settings 2020-06-10 22:51:21 -04:00
Tiger Oakes f0295048fa Remove Mockito 2020-06-10 21:19:50 -04:00
Jeff Boek cd3b6181b3 For #10374 - Adds quick contextual menu to tab switcher
Co-authored-by: person808 <kainaluh808@gmail.com>
2020-06-10 16:50:28 -07:00
Elise Richards 137d66a511
For 10172: Set edit text listeners (#11196)
* Set edit text listeners

* Set clearable icons and change with error states

* Clear text buttons show and hide

* Move error checks to afterTextChanged. Refactor. Remove unused color.
2020-06-10 16:52:47 -05:00
Tiger Oakes 31edbc924c
Fixes #9056 - Start Fenix activity on search in external app (#10932) 2020-06-10 10:25:53 -07:00
Tiger Oakes 4b064afb81
Add tests for ext package (#11334) 2020-06-10 09:14:18 -07:00
Christian Sadilek d16c70d8be Wire up UI to make add-on installation cancelable 2020-06-10 18:52:06 +03:00
ValentinTimisica bc53296603 For #11365: Reorganizes 'SettingsFragment' items
Moved all the functionality form 'DefaultBrowserSettingsFragment' to
'SettingsFragment'.
2020-06-10 11:09:03 +03:00
ekager 11697c1363 For #11390 - Removes redundant session observer init for ETP overlay 2020-06-10 08:37:49 +03:00
Sawyer Blatz 27c7ef5ad4 For #8775: Removes feature flag for dynamic bottom toolbar 2020-06-09 20:58:17 -07:00
ValentinTimisica f937c96c12 For #5148: Switch to the correct tab on media notification clicked
Processing the intent in OpenSpecificTabIntentProcessor to be able to switch
to the tab where audio/video is playing
2020-06-09 22:39:39 -04:00
David Walsh 1356b3e426 For 11271 - Provide useful tab counter message for accessibility 2020-06-09 22:37:46 -04:00
Tiger Oakes 96d2307df0 Add tests for widget 2020-06-09 22:31:12 -04:00
ValentinTimisica 3a28704fa6 For #11132: Replaces wrong icons from menus 2020-06-09 22:19:43 -04:00
ValentinTimisica dc37baff0b For #11132: Rearranges home menu items 2020-06-09 22:19:43 -04:00
Jeff Boek f41ca2f424 No Issue - Moves from being a tabstray observer to overriding tab use cases 2020-06-09 19:13:08 -07:00
Christian Sadilek 05496faa66 Clear speculative session on engine settings change 2020-06-09 18:55:43 -04:00
Sawyer Blatz 5445d34ac4 For #11357: Use AppCompatResources for reader mode icon 2020-06-09 18:04:13 -04:00
Jeff Boek 4ee1cd6716 For #11361 - Nulls out tabsFeature in the correct spot 2020-06-09 15:34:00 -04:00
Jeff Boek d8ef0722e3 For #11175 - Moves tab tray strings to be translated, fixes description of the fab string 2020-06-09 13:06:02 -04:00
ekager 6d4a673c6f For #8967 - Expose autofill logins setting in nightly 2020-06-09 12:21:48 -04:00
Mozilla L10n Automation Bot 5373a75f57 For #10502 - Show snackbar after adding tabs to collection from tab tray 2020-06-09 08:29:06 -07:00
Grisha Kruglov 8769d98e71 Pass crashReporter instance to RustLog 2020-06-08 17:38:30 -07:00
Sachin 8fdc28010d
for #10839 added IO coroutine to check onboarding stat from sharedpref (#11338)
changed coroutine scope to fragments lifecycle
2020-06-08 15:52:10 -07:00
Jeff Boek e4e7cc5108 For #11260 - Fixes lifecycle issues with the tabs tray
- Also check to make sure the fragment manager is still valid before trying to show the tabs tray

Co-authored-by: Emily Kager <emilykager@gmail.com>
2020-06-08 18:42:46 -04:00
Sawyer Blatz e9189dc089 For #11045: Add reader mode to urlView 2020-06-08 15:12:03 -07:00
Tiger Oakes 1a19b06227
Simplify `PhoneFeature` code (#10810) 2020-06-08 13:02:42 -07:00
Sachin 74948cb3f1
for #7225, Changed strictMode thread penalty to dialog on startup and back to logs after startup is done. (#10831)
for #7225, refactored and cleanup the branch.

for #7225, change strict mode policy only on main process.

for #7225, setting thread policy inside a seperate thread to keep it from getting overridden in activities.

for #7225 removed Handler().postAtFrontOfQueue as a solution due to unknown side effects. moved the enableStrictMode function to be static so we can reuse it.

for #7225 lint check

for #7225 created strict mode manager and moved enabledStrictMode function inside it.

for #7225 removed penalty death on network

for #7225 added allow disk access on thread for already existing violation


strict mode running in main process to see if it passes the gitlab check, will revert it if it doesnt

allowed diskread for super.onCreate for home activity

added comments for disk violation oncreate homeactivity

added fragment manager inside strictmode manager

allowed disk read for onboarding

allowed disk read for cachedTopSites
2020-06-08 10:45:33 -07:00
David Walsh d33080571b
For #11267 - Announce "Your open tabs will be shown here (#11272) 2020-06-05 17:27:45 -05:00
mcarare 512aa46224 For #11229: Update ETP cfr string and behaviour. 2020-06-05 14:18:25 -04:00
mcarare 91c27a023e For #11229: Update settings ETP copy. 2020-06-05 14:18:25 -04:00
mcarare a0d9189321 For #11229: Update onboarding ETP copy. 2020-06-05 14:18:25 -04:00
Jeff Boek 52c2fdb310
Remove tab tray feature flag (#11176)
* For #11171 - Removes feature flag for the new tab tray

* For #11171 - Removes all tab references from homeFragment

* For #11171 - Fixes unit tests

* For #11171 - Gets UI tests to compile and HomeScreenTest to pass

* For #11171 - Fixes `deleteMultipleSelectionTest`

* For #11171 - Fixes `openHistoryItemInNewPrivateTabTest`

* For #11171 - Fixes `openHistoryInPrivateTabTest`

* For #11171 - Fixes `openHistoryInNewTabTest`

* For #11171 - Fixes `openNewPrivateTabTest`

* For #11171 - Fixes tabbedBrowsingTests

* For #11171 - Fixes SettingsPrivacyTest

* For #11171 - Fixes TopSitesTest

* For #11171 - Fixes lint errors

* Ignore
2020-06-05 12:59:08 -05:00
mcarare 2d24369362 For #7725: Increase info button touch target while keeping size.
Also removed unnecessary touch delegate.
2020-06-05 11:57:17 +03:00
person808 8c47b988b8 For #10525 - Remove tab tray item dividers. 2020-06-04 23:17:16 -07:00
Jeff Boek bc53b94feb For #10989 - Fixes memory leak caused by retaining the TabTrayView and TabsFeature 2020-06-04 23:29:14 -04:00
Sawyer Blatz 1be2ec2cbf For #9488: Init widgetExperiment after Experimenter init 2020-06-04 16:22:52 -07:00
mcarare 886c1882c5 For #11230: Set default to false for allow screenshots in private setting 2020-06-04 18:24:26 -04:00
Dennis Schubert e41fc7841a Bug 1643132 - Add WebCompat Reporter feature. 2020-06-04 18:23:11 -04:00
Dennis Schubert d046d908fc Bug 1643132 - Remove native "Report site issue" functionality.
This will be replaced by the WebCompat team's system extension that ships as an android-component.
2020-06-04 18:23:11 -04:00
Sawyer Blatz 42f58a1984 For #9488: Add experimentation support 2020-06-04 14:10:22 -07:00
ekager 54df729fb3 For #8374 - Don't recreate ExternalAppBrowserActivity or finishing activities 2020-06-04 16:44:07 -04:00
Sawyer Blatz 9302d07d13 For #11118: Add toggle states to metrics ping 2020-06-04 10:08:23 -07:00
mcarare 5a23fb33f8 For #11182: Fix back button text update according to save step. 2020-06-04 11:50:29 -04:00
mcarare a910698007 For #11182: Set click listener also to icon button. 2020-06-04 11:50:29 -04:00
Gabriel Luong 9520c9dd32 For #8920 - [Telemetry] Send add-on ids in a metrics ping 2020-06-04 08:15:39 -07:00
mcarare 29f1800021 For #11182: Explicitly clone select tabs on updating SaveCollectionStep. 2020-06-03 23:01:44 -04:00
mcarare 68286d263a For #11182: Set click listener to full layout instead of just icon. 2020-06-03 23:01:44 -04:00
person808 9272026b7e For #10193 - Remove page title when sharing links 2020-06-03 15:54:23 -07:00
Tiger Oakes a7e74e308b
Migrate some SessionManager usage to BrowserStore (#10789) 2020-06-03 11:18:44 -07:00
mcarare 138c12696f For #11153:Add FLAG_SECURE on pause and clear on resume for private session. 2020-06-03 08:56:16 -04:00
David Walsh d862d58051 Scroll to the top of home when using the tab tray 2020-06-02 23:08:20 -07:00
mcarare 2090b11c97 For #10434: Handle cases when proc/$pid/stat is not accessible. 2020-06-02 17:57:39 -07:00
ekager ead3194d86 For #8759 - Allow recently used in share fragment to scroll 2020-06-02 16:46:08 -04:00
Jeff Boek 2dd0a3cb9e
Implement tab tray design improvements and fix close functionality. 2020-06-02 15:03:58 -05:00
Tiger Oakes 6317eea690 Add tests for some of collection creation 2020-06-02 10:06:17 -04:00