6530a45eb9
For issue #11676 : Features phone that doesn't a site permission exception shouldn't be shown ( #12855 )
...
exception shouldn't be shown
2020-07-23 09:12:22 -07:00
8f5a37733d
Create ToolbarPosition enum ( #12747 )
2020-07-22 19:23:38 -07:00
c143f95819
Issue #11333 : Set ContentBlocking settings directly on GeckoRuntime
...
We set the ContentBlockingSettings directly on the GeckoRuntime now to
improve the startup of the engine.
This change has requirements from Android Components and GeckoView, so
we would only see the full perf benefits in Nightly as the changes ride
the train, although we might start to see some of them as we're updating
the GeckoProvider for the `geckoBeta` variant as well.
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2020-07-22 16:28:18 -04:00
b26e39906d
No issue - Fix compilation error caused by removed extension function.
2020-07-22 13:00:07 -07:00
58ccc64386
Fix UI tests.
...
We need to pass a CoordinatorLayout instead of a SwipeGestureLayout to
FenixSnackbar.make() in BaseBrowserFragment to prevent UI tests from
breaking. We also need to remove a few view IDs from the tab preview.
2020-07-22 11:26:15 -07:00
e7dc5580b2
For #3481 - Implement swipe on toolbar to switch tabs.
2020-07-22 11:26:15 -07:00
921b16233b
For #1048 - Add ability to view tab history by long-pressing the back or forward button.
2020-07-22 11:20:47 -07:00
c2d940cf06
Use AC RunWhenReadyQueue ( #12800 )
2020-07-22 09:48:36 -07:00
d9357f1e32
For #12801 - Extra debug menu trigger, disable if already triggered
2020-07-22 19:28:48 +03:00
d5fbc17ccf
Update to Android Components 52.0.20200722023149
...
Fixes breaking APIs in SyncedTabsFeature and
BookmarksStorageSuggestionProvider
2020-07-22 10:52:14 -04:00
2ae88aec81
No issue: add missing newline.
2020-07-21 15:52:34 -07:00
6e06c7fda1
No issue: clean up initVisualCompletenessQueue... method.
...
A no-op clean up.
2020-07-21 15:52:34 -07:00
633bc4f2f2
No issue: extract initVisualCompletenessQueueAndQueueTasks.
...
This refactor, done entirely by IDE, is a no-op cleanup.
2020-07-21 15:52:34 -07:00
169071ac61
No issue: extract startMetricsIfEnabled function.
...
This refactor, done entirely by IDE, is a no-op clean-up of this file.
2020-07-21 15:52:34 -07:00
11e2137fab
For #12806 - Adds unit tests to cover `ToolbarView.update()` ( #12807 )
2020-07-21 14:34:07 -07:00
99354174a9
For #12797 : Use measured height/width for loading a thumbnail
...
Using `onNextLayout` has the side-effect of showing the thumbnail with
the tab.id from a recycled view.
The root cause of needing that call is to retrieve the measured
height/width from the view first before requesting. A simpler solution
to avoid the complexity is to retrieve these values from the dimen
resources.
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2020-07-21 16:38:49 -04:00
b483067bd9
For #12461 : Update content description for tabs tray open tab count
2020-07-21 15:48:38 -04:00
96121a79fa
Issue #7877 : Add SearchActionProvider for faster responses that mirror entered text.
2020-07-21 14:41:00 -04:00
c08d375c18
Move settings in components ( #12675 )
2020-07-21 10:47:10 -07:00
c3041bcb64
For issue #12387 - Display tab tray using .show
...
Replaced the global navigation action used for displaying the tab tray with the .show() function.
2020-07-21 10:31:24 -07:00
8826f99ef7
For #9722 : Refactor onboarding buttons with text.
...
Add title and description to button text, remove extra Textviews.
2020-07-21 10:28:45 -07:00
0abb2c4f8b
Add tests for web push integration
2020-07-21 10:12:06 -07:00
7e7d69cb8e
Bug 1652979 - Stop producing fennecNightly, fenixNightly and fenixBeta ( #12225 )
2020-07-21 16:42:08 +02:00
e809df0858
Pass settings and metrics to CFR
2020-07-21 09:01:09 +03:00
02a929a926
No issue - Suppress new warnings from detekt update
2020-07-20 17:01:50 -07:00
284ec7b58f
For #12461 : Add tab count to tab tray
2020-07-20 19:16:47 -04:00
f73411b924
For #5499 - Unify CFR drawables and dimens ( #12749 )
2020-07-20 16:00:57 -07:00
cd2532349d
For #12551 - Implement swipe to delete for bookmarks.
2020-07-20 14:54:20 -07:00
313e5abf6a
Rename tab_tray_background.xml
2020-07-20 14:54:20 -07:00
fcb84d940a
No issue: correct position of StartupTimeline; add warning.
2020-07-20 14:27:41 -07:00
445593b719
For #10466 : Add search privately to top of list ( #12744 )
2020-07-20 13:25:36 -07:00
51937e73fc
Closes #10924 - Cleanup SavedLoginsAuthFragment ( #10930 )
2020-07-20 13:25:24 -07:00
afbb039a08
For #11851 : Close tab tray when last tab closed ( #12615 )
2020-07-20 11:05:32 -07:00
1dc0ad39f4
For #10784 - Fixes memory leak in BrowserAnimator
2020-07-20 13:50:18 -04:00
f0c6bc0226
For #12735 : Fixes issue with tab deletion undo ( #12737 )
2020-07-20 10:48:16 -07:00
3f25a28cf7
For #12554 : Helper class for password reveal on logins
2020-07-20 13:45:46 -04:00
16b6776938
Update Android Components to 51.0.20200717190031
2020-07-17 19:32:02 -04:00
499f185fc0
Fix lint issues ( #12683 )
2020-07-17 16:20:08 -07:00
13949d6968
Test migration classes ( #12677 )
2020-07-17 14:35:13 -07:00
67fda80453
Add tests for login exceptions ( #12681 )
2020-07-17 14:25:45 -07:00
9c1b586e45
For #7966 : Update toolbar content description. ( #12667 )
2020-07-17 16:22:13 -05:00
1823fdb66d
For issue #9949 - Bookmarks/History deletion inconsistencies ( #12630 )
...
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.
- Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in #8648 .
Co-authored-by: Mihai Eduard Badea <mihai.badea@softvision.ro>
2020-07-17 15:13:18 -05:00
eed20b43b9
Test session control controller ( #12652 )
2020-07-17 13:07:01 -07:00
aa7655f4d6
For #12509 : Set height of remove add on button to 36dp
2020-07-17 12:55:36 -07:00
455e7b8f99
Update ContextMenuUseCases to just take a store
2020-07-17 14:49:10 -04:00
e1ef5f55ec
For #12453 - Sets secure flags on private tab of tabs tray
2020-07-17 13:24:25 -04:00
e358f95eed
For #12364 - Only show PWA prompt the third time a user visits installable site
2020-07-17 12:37:03 -04:00
ac3df6bc5e
Add tests for adapters in collections ( #12649 )
2020-07-17 09:04:16 -07:00
023a4983fa
For #10173 : login duplicates and save ( #11208 )
...
* Extract controller into it's own class. Implement find dupes and filter based on username.
Create edit login controller. Add text watchers and check for duplicates.
Edit controller test
* Find duplicates and save to store
* Retrieve duplicates from AC and check list on username text changed
Move duplicates logic into the controller
* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.
* Use correct threads in controller. Enable save button when applicable.
Save enabled in datastore.
Move login data to datastore
Rebase with password error states
Update metrics to be more specific for edit
* Create logins controller for AC calls
* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.
Inflate view in edit fragment. Double layout showing up.
Edit view
Controller tests
Controller tests passing
Interactor tests
Lint and detekt cleanup
* Remove datastore and use storage controller for all logins calls to password storage.
Addressed comments
Lint
:
Rebase - 1
2020-07-16 17:08:04 -05:00
e1fc0cc038
Ensure logins deletion ( #12507 )
...
* For #11227 - Cleanup saved logins list when one is selected
Selecting a saved login will open a detail screen for it from where users can
change details or even delete that particular login.
After the change is made the user is brought back to the list of saved logins
where for a brief moment (< 1s) until we get a new response from
passwordsStorage.list() the user can see and even interact with the old list
of items, which may still contain the just deleted one.
To avoid users seeing obsolete logins or even interacting with them (selecting
a previosuly deleted item will result in a crash) we will clean the list of
logins just before the selected login is opened in the detailed view.
When returning for a brief moment the users may see the "loading" UX until
passwordsStorage.list() returns the up-to-date list of logins to display.
* For #11227 - Refactor SavedLoginsView to be closer to MVI
- Interactors should only get passed other Interactors or Controllers as
dependencies to which they should delegate user actions.
- Controllers should hold most of the business logic and get passed all final
dependencies they need to do their job.
2020-07-16 14:40:08 -05:00
2d066d77ad
Add tests for sync, wifi, and push ( #12581 )
2020-07-16 12:25:38 -07:00
2291fb07aa
For #12565 : Add Locale settings tests & use activity ( #12579 )
2020-07-16 11:43:27 -07:00
3373f8b987
For #12600 - remove AddonInstalled event when the permission dialog is shown ( #12601 ) r=csadilek,sblatz
2020-07-16 19:40:39 +01:00
9373e7fcf4
For #12201 - forced callbacks to be on the main thread ( #12543 )
2020-07-16 13:39:31 -05:00
4fe1fb8f4a
No issue: Delete unnecessary to-dos ( #12603 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-16 13:38:07 -05:00
b867e0de45
Update TabTrayViewHolder with A-C thumbnail changes.
2020-07-16 12:50:33 -04:00
7923255fda
For #12118 : Add isSubframeRequest parameter for app links
2020-07-16 12:50:33 -04:00
a0d9cdc450
For #12248 : Webcompat reporter not active in Nightly
2020-07-16 12:24:21 -04:00
fb1d7e12e6
For #11704 Add leanplum attributes for tracking protection ( #11965 ) r=sblatz
...
* For 11657: add LP attribute for tracking protection
* For #11704 : added tracking_protection_enabled attribute
* Added docs for the new attributes, linking to data-review to the mma.md
* Rename null to none when no ETP is enabled
2020-07-16 17:09:32 +01:00
798c1bf743
Address review comments
2020-07-16 10:37:03 -04:00
22689a9ff5
Remove need to specify component names for new intents
2020-07-16 10:37:03 -04:00
98a33ea82b
Changed home_* style links to urls_* to reflect that the destination is a set of links, rather than where the screen is
2020-07-16 10:37:03 -04:00
1629878a66
Add install_search_widget
2020-07-16 10:37:03 -04:00
8130aaa2cc
Add deep links for settings and home screens
2020-07-16 10:37:03 -04:00
d449184faa
For #12544 - Prevent search engines mixup
...
Stricter synchronization by always using the same "loadedSearchEngines"
variable.
With "loadedSearchEngines" calling "refreshAsync()" we also get the fallback
engines to contain reddit and youtube (which are programatically added) and
also now we properly remember and display the engines added by user.
2020-07-16 16:49:54 +03:00
6be39aebde
Add tests for StartupReportFullyDrawn ( #12560 )
2020-07-15 23:31:59 -07:00
d4bb432e24
Add helper for underlining text ( #12520 )
2020-07-15 22:38:46 -07:00
a0491b702e
Fix nav graph and theme tests ( #12567 )
2020-07-15 18:04:36 -07:00
d0e9f1f165
Update Kotlin dependency ( #10806 )
2020-07-15 18:02:58 -07:00
800702149b
For #12503 : Open addon permissions link in app.
2020-07-15 10:04:40 -04:00
9ed85510ae
For #7094 - Adds save login exceptions
2020-07-14 14:47:37 -04:00
69020a1f26
For #12457 - Add MockK matcher for nav directions ( #12262 )
2020-07-14 10:39:23 -07:00
1ff64cab67
Add tests for search ( #12437 )
2020-07-14 10:32:04 -07:00
e9fb1a61c7
Test viewholders in home.sessioncontrol ( #12524 )
2020-07-14 10:31:50 -07:00
f424656575
For #12107 : Follow ux mock on Settings --> Account screen
2020-07-14 12:25:21 +03:00
98ad7ace49
For #10466 : Put call & email at top of context list
2020-07-13 10:33:55 -07:00
ea10d2a872
For #11875 - Prevent mixup of region / locale based search engines
...
We have two search engine types:
- one based on MLS reported region,
- one based only on Locale.
There are multiple steps involved in returning the default search engine for
example and though at each step we could verify if a certain operation is
completed we are still exposed to concurrency issues.
Simplest and most effective way to make sure the MLS engines do not mix with
Locale based engines is to use the same type of engines for the entire duration
of the app. At the next cold start we'll verify again which engines to use.
Using the Locale based engines (fallbacks) is expected to only happen once, at
the first run of the application after being installed.
2020-07-13 13:41:34 +03:00
9df13ae121
For #11655 : add leanplum event for installing an addon ( #12136 ) r=elise
...
* For #11655 : add leanplum event for installing an addon
* Add link to data-review request in PR
* Addressed CI comments
2020-07-12 23:47:34 +01:00
31248b835c
Synced Tabs: make sure to stop 'loading' when we encounter an error
2020-07-10 19:02:55 -07:00
0add94e353
For #11324 - Adds trash icon to swipe to delete
2020-07-10 20:16:57 -04:00
7319f77114
Add profiler markers for HomeActivity.load and DefaultTabTrayController.onNewTabTapped
2020-07-10 16:43:06 -07:00
5d9fdd6266
Update app/src/main/java/org/mozilla/fenix/HomeActivity.kt
...
Co-authored-by: Tiger Oakes <contact@tigeroakes.com>
2020-07-10 18:44:14 -04:00
bab0f9d95b
No issue: Update AC version
2020-07-10 18:44:14 -04:00
806f6031ae
For #12433 - Allow synced tabs pull-to-refresh for non-critical account errors
2020-07-09 16:18:54 -07:00
ad265be672
For #11303 - Change copy login origin to open in browser
2020-07-09 18:09:41 -04:00
c99a8f5cfa
Fixes #9832 - Change targetSdkVersion to Android 10 ( #11014 )
2020-07-09 10:50:51 -07:00
a2a7b11425
Issue #12311 : BrowserToolbarController: Stop SessionFeature and release session from EngineView.
2020-07-09 12:36:56 -04:00
85cebf8796
For 11889 - Fix snackbar for collection creation in browser fragment
2020-07-09 08:50:12 +03:00
38657bbfc6
For #11431 - Scroll to restored tab in tab tray
2020-07-08 17:18:16 -04:00
216396d979
For #12353 : URL copied to clipboard should not be extension/reader URL
2020-07-08 16:55:32 -04:00
9ae1aa6f16
Add tests for exceptions
2020-07-08 15:52:37 -04:00
236b981881
Update Android Components version to 50.0.20200708130551.
2020-07-08 12:44:51 -04:00
67ce5ad5d9
Add tests for onboarding viewholders ( #11522 )
2020-07-08 07:53:22 -07:00
720a590902
Add tests for browser helper classes ( #12370 )
2020-07-07 19:46:25 -07:00
27c608d956
Update built-in extensions for new AC/GV API
...
New API (installBuiltIn/ensureBuiltin) requires
- Gecko IDs and new permissions
- Extension will only be re-installed if it has a new version
This includes a gradle task to automatically generate a
new version in manifest.json for every build so we don't
forget to update the version and end up with changes that
are never applied.
2020-07-07 18:41:12 -04:00
bceb07a05b
For #12312 - Disable settings that navigate while authenticating
2020-07-07 16:46:14 -04:00
3e617245b5
For #12345 : catch SecurityException when calling reportFullyDrawn.
...
That's amazing! I've got the same combination on my luggage.
2020-07-07 13:44:09 -07:00
65637e9e2b
Use A-C version of Resources.getSpanned ( #12358 )
2020-07-07 13:36:29 -07:00
eeb8719fa1
For issue #12126 - Tab counter consumeFrom update
...
Added a direct call to the updateTabCounter method to account for changes made to the BrowserState while the tabCounter view is not visible.
2020-07-07 11:12:55 -04:00
8e8e5aea36
Extract radio group logic into helper ( #11493 )
2020-07-06 17:09:42 -07:00
e39d5b6de7
For #11763 : Shows confirmation dialog when deleting last tab from collection
2020-07-06 17:06:10 -04:00
c3acde438a
For #11889 : Changes collection creation confirmation snackbar strings
...
Also I changed the adding tabs to collection confirmation string from
tabtray to take into account the number of tabs.
Example: 1 tab-"Tab saved!"; multiple tabs-"Tabs saved!"
2020-07-06 17:02:02 -04:00
1ab5fe3eb9
Add method to test fragments in roboletric ( #12261 )
2020-07-06 13:04:43 -07:00
331090d1e6
For #12007 : Fix add search engine items using wrap content for height
2020-07-06 15:37:28 -04:00
da39a7e671
Update Android Components version to 49.0.20200705130154.
2020-07-06 15:21:40 -04:00
94273bc274
For #12125 : Handle visibility updates for add to collection button.
2020-07-06 14:37:39 -04:00
fd18687ac9
Switch to any calls
2020-07-06 20:38:08 +03:00
41452e945b
Move SearchProviderModel extension to class
2020-07-06 20:38:08 +03:00
0fb6bbc175
For #10401 - Hide Shortcuts if just one search engine is installed
...
Otherwise, the Shortcuts option which allows to choose with what search engines
to search would be redundant.
2020-07-06 14:36:04 +03:00
388c144a62
SearchFragmentStore: Remove Session reference from state and read values from BrowserStore.
2020-07-03 21:01:59 +02:00
f863c341e8
Updates AC to 49.0.20200702190156 and fixes breaking changes
2020-07-03 06:40:06 -04:00
8533d96ee2
For #11320 - Expose login autofill setting to beta dimension
2020-07-03 06:40:06 -04:00
6ec0aeb843
Issue #12207 - Update "new nightly" link to point to org.mozilla.fenix ( #12209 )
2020-07-02 12:39:44 -07:00
8583cac8f8
Revert "For #11183 : Redirect user to homescreen after widget added"
...
This reverts commit a8ed913654
2020-07-02 11:22:18 -07:00
3cbab45566
For #12157 : Don't show two search widget dialogs
2020-07-02 11:22:18 -07:00
daecbd348b
For #11996 : Open all links from add-on details in Fenix. ( #12080 )
...
* For #11996 : Open add-on homepage link in Fenix.
* For #11996 : Open add-on details links in Fenix.
2020-07-01 19:13:23 -07:00
306505fee0
No issue: Remove feature flag for tips ( #12172 )
2020-07-01 14:47:40 -07:00
4bc1cb94c5
Bug 1649400 - part 1: ship org.mozilla.fenix as a nightly product ( #12127 )
2020-07-01 11:03:10 +02:00
fb4822498f
For #12081 - Properly installs searchengines when MLS completes
2020-06-30 13:35:08 -07:00
70f90e71e8
For #11991 - Show tab count during onboarding
2020-06-29 17:59:19 -04:00
6bde0378a2
Add tests for StrictModeManager ( #12013 )
2020-06-29 08:17:07 -07:00
60069395eb
Update AC to 48.0.20200627130132 and fix breaking changes
2020-06-27 20:11:31 -04:00
ed334788e8
For #11903 : Enforce private theme in custom tabs
2020-06-26 22:59:43 -04:00
b1a8c0f483
For #9935 - Use the searchengine deferred
2020-06-26 19:07:36 -07:00
40977a93a0
For #9935 - Fallback region selection on first load
2020-06-26 19:07:36 -07:00
5ef6b49aa1
For #8795 : remove redundant ConstraintLayout around BrowserToolbar. ( #12014 )
...
This is functionally equivalent to the code before this patch but should
be slightly more performant in theory because ConstraintLayout is
expensive to inflate.
The elevation and layoutParams set dynamically appeared to have no effect
with the wrapping view but broke the view when used by itself so I had
to remove them. I also updated a few other unnecessary params.
Theoretically this may have some perf benefits but I didn't see anything
outside noise levels after I took the numbers (but I didn't try very
hard).
2020-06-26 21:31:02 -04:00
c4a4beb6b9
For 11468 - Show tab tray after opening links from history and bookmarks
2020-06-26 18:28:31 -07:00
2ac8496315
For #12025 : Set Search Shortcuts Off By Default
2020-06-26 18:21:58 -07:00
a18c1befd1
For #11044 - Sets the anchorView of the snackbar to be the new tab fab ( #11930 )
2020-06-26 17:56:56 -07:00
4b9cc954fa
for #11830 added new metric for collecting startup method from all startup phases ( #11940 )
...
* for #11830 added new metric for collecting startup method
move all source startup telemetry into its own logic and added an UNKOWN state
* switched back to onNewIntent solution
* renamed the metric
2020-06-26 17:38:08 -07:00
61b1b5a895
No issue: update experiments when experiments updated ( #12032 )
2020-06-26 17:19:58 -07:00
8a08cb941e
For #11479 : Record open tabs count in metrics ping ( #12024 )
2020-06-26 17:15:43 -07:00
b7d989a588
Fix breaking API in WebNotificationFeature
2020-06-26 19:59:57 -04:00
ff5d00362b
Added A-C version 48.0.20200626213814
2020-06-26 19:59:57 -04:00
101ecfbf66
For #11273 : Add tabs tray telemetry ( #12036 )
2020-06-26 16:37:07 -07:00
7287b5579f
Test settings about/advanced ( #12023 )
2020-06-26 15:53:30 -07:00
4f6f0785c5
For #11943 : Fix intermittent coroutine failure ( #12027 )
2020-06-26 15:42:53 -07:00
df49db6adb
For #11294 - Enable Synced Tabs for all builds
2020-06-26 18:36:37 -04:00
e6a56aec36
For #12026 - Update default top sites for new users ( #12028 )
2020-06-26 17:51:18 -04:00
f8cb1d6b48
Closes #11909 : Metrics for recording number of recently used PWAs
2020-06-26 14:13:41 -07:00
eeabcb10ff
Fix illegal arguments for onboarding keys ( #12033 )
2020-06-26 16:12:18 -05:00
bcb2ef10ac
Add tests for PhoneFeature ( #12021 )
2020-06-26 12:12:52 -07:00
f3b44c06e4
For #11841 : Removed topsite bug on private browsing ( #12020 )
2020-06-26 14:54:20 -04:00
005ad6ff2a
Update Android Components version to 48.0.20200626130049. ( #12006 )
...
Co-authored-by: MickeyMoz <sebastian@mozilla.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2020-06-26 14:16:57 -04:00
80de3851f3
Add tests for OnSharedPreferenceChangeListener ( #12019 )
2020-06-26 11:04:46 -07:00
9f5c8819d3
For #11892 : Remove dynamic calls to setupNavigationToolbar
...
This is a speculative fix for 11892 crash.
The side effect is that the back button will be visible in bookmarks root.
2020-06-26 07:54:11 -04:00
93247e0b2f
For #9425 - SearchFragment now reacts to undo operation for base engines
2020-06-26 13:21:00 +03:00
e6e3166d2d
For #9425 - SearchFragment now reacts to undo operation for custom engines
...
When you remove a search engine from our list, an undo snackbar that outlives the fragment is shown. If you go back to the search fragment and press undo, now the shortcut list gets updated
2020-06-26 13:21:00 +03:00
46c1c130da
For #9425 - Handle undo for custom search engines
...
On undo, get the template that the user entered for that engine and then
re-add it to the `CustomSearchEngineStore`
2020-06-26 13:21:00 +03:00
c5034fa770
No issue: Allow us to run experiments on nightly if needed
2020-06-26 09:16:38 +03:00
216da0c64b
For #10285 : Add a custom TextView for links with a11y improvements.
2020-06-26 09:15:44 +03:00
b84f55c980
For #11677 - Adjust tab counter menu item order.
2020-06-25 15:48:10 -07:00
ad90625b48
For #2165 - Add swipe to refresh gesture to bookmarks view.
2020-06-25 14:50:24 -07:00
64440409b0
For #9100 : Follow-up to fix memory leak in NotificationSessionObserver
...
The observer was moved and is now bound to the activity and its
context. If the activity is re-created we leak the observer and
therefore the activity itself.
With this we make sure to stop the observer and also don't use
the activity context to begin with.
2020-06-25 16:17:38 -04:00
c77ddd8d26
For #11866 - Update back press logic for SearchFragment
2020-06-25 14:40:31 -04:00
7be56ce4fa
For #11798 : Allow sharing of reader view pages
2020-06-25 14:39:21 -04:00
04aee11d82
For #9625 : Add telemetry for Tracking Protection CFR ( #11923 )
2020-06-25 11:24:55 -07:00
665fb8d60c
#10824 : Onboarding telemetry ( #11867 )
...
* Onboarding events and tracking
* Rename metrics for consistency
* Add reference to PR for the data review
* Add default values to onboarding events
2020-06-25 13:21:31 -05:00
2d65faf232
For #11392 : Rename Installation ping to FirstSession ( #11869 )
2020-06-25 10:06:26 -07:00
d3de9e517e
Remove ThumbnailsUseCases
2020-06-25 12:51:18 -04:00
c958cc048a
Update customtabs service
2020-06-24 23:26:49 -04:00
13c8abe3dc
For #11613 : Expand toolbar onUrlChanged
2020-06-24 21:50:06 -04:00
be5213e944
For #11727 - added content description
2020-06-24 21:42:38 -04:00
9068c96ab3
don't animate unnecessarily
...
Fixes #11672 , #11727 : Empty default tab text and add padding to infinite character
Fixes #11739 : Fix flicker
Update TabCounter.kt
make lint happy
don't animate unnecessarily
don't animate unnecessarily
Fixes #11739 : Fix flicker
Update TabCounter.kt
squash commits
don't animate unnecessarily
Fixes #11672 , #11727 : Empty default tab text and add padding to infinite character
Fixes #11739 : Fix flicker
Update TabCounter.kt
make lint happy
don't animate unnecessarily
2020-06-24 21:42:38 -04:00
3dc6c438f4
Fixes #11739 : Fix flicker
2020-06-24 21:42:38 -04:00
b95804c33b
Fixes #11672 , #11727 : Empty default tab text and add padding to infinite character
2020-06-24 21:42:38 -04:00
a8ed913654
For #11183 : Redirect user to homescreen after widget added
...
Co-authored-by: hakkikaancaliskan <caliskanhkaan@gmail.com>
2020-06-24 21:41:42 -04:00
77ed670558
For #11860 - Conditionally show add to collection button on Home screen
2020-06-24 21:41:19 -04:00
872c179cf4
For #11825 : Removing the last pretty animation 😞
...
Goodbye, sweet summer child.
2020-06-24 21:38:28 -04:00
a056e86e4f
For #8080 : Dismiss menu when swiping away from its anchor.
2020-06-24 21:37:57 -04:00
b961fdcf02
For #11901 : Use safe call for collection item info.
2020-06-24 21:37:24 -04:00
49b617c999
For #9100 - Private browsing notification fixes
...
Co-authored-by: Seef <Saif Dara>
2020-06-24 21:35:11 -04:00
632b64971f
For #10467 - removed unused tests and resources related to blue dot notification
2020-06-24 21:33:32 -04:00
3c2c7f705c
For #10467 - blue dot doesn't disappear on menu dismiss
2020-06-24 21:33:32 -04:00
0b781ae3b7
Add tests for collection creation controller
2020-06-24 21:21:02 -04:00
177e7a400f
For #11406 - Scrolls to selected tab when switching modes
2020-06-24 21:16:48 -04:00
4415702fa8
Add tests for share sheet
2020-06-24 20:33:47 -04:00
183ba1bce0
For #11903 : fix custom tab private gradient
2020-06-24 20:33:16 -04:00
f39313d908
For #8374 - On external session removed, handle back press
2020-06-24 20:17:26 -04:00
5f7e0e4dd6
Followup for #11442 - Add tab counter menu metrics to home fragment.
2020-06-24 10:20:51 -07:00
9a8b800a76
For #8621 - fix intermittent test failures
2020-06-23 17:43:24 -04:00
621da0c4c1
For #9935 - Adds fallback searchengine provider for long MLS lookups ( #11863 )
2020-06-23 14:00:18 -07:00
fe97dc9d2e
For #11542 : Update tabs positions in tab tray reported by screen readers
2020-06-23 11:28:24 -07:00
06e6cfa696
For #5636 - Unregisters wifiConnectedListener when setting changes, sets default blocked
2020-06-23 12:28:52 -04:00
8ce7cf59c8
For #11261 - Dismisses menu when rotating to landscape ( #11845 )
2020-06-23 10:50:20 -05:00
2861421312
For #11112 - Adds save tabs to collection button to the no collections message
2020-06-23 08:17:55 -07:00
ccb532bb77
For #11534 - Don't check lastUsed mode for screenshots ( #11827 )
2020-06-22 17:38:58 -07:00
c7b1f215c8
No Issue - Fixes flash when toggling tab tray ( #11826 )
2020-06-22 16:49:07 -05:00
18cc4c95c1
Add tests for ContextKt ( #11824 )
...
Migrated from an old branch by Kate
Co-authored-by: Kate Glazko <katglazko@gmail.com>
2020-06-22 14:00:43 -07:00
c8d36ddc36
For #8649 : No bookmarks here strings are close to the top
2020-06-22 16:04:20 -04:00
88765c348b
Update A-C version, add synced tabs empty state
2020-06-22 15:13:13 -04:00
721e290734
For #10049 : Provide correct seek bar value to screen readers.
2020-06-22 13:58:33 -04:00
c75ab3f720
For #10462 : Removes back button from bookmarks and history fragments ( #11721 )
2020-06-22 13:15:33 -04:00
635c30510d
No issue: refactor tabs tray to use interactor/controller, add tests
2020-06-22 13:01:35 -04:00
0ba1d266b3
For #9144 - Ignore previous Intent if activity is started from Recents
...
We'll now clearly differentiate between cold / hot starts of HomeActivity.kt.
This is needed because Android will resend the original Intent which initially
started the Activity whenever it is restarted from the Recents Screen if the
activity is already destroyed at that time. So in the event that the activity
was before started with an Intent to open a webpage for example whenever the
activity is restarted from Recents it will receive the same Intent to open a
webpage even though that Intent has already been consumed.
Activity's onCreate() will only use the intent processors when the activity is
cold started so that we'll only initially act upon Intents configured for
different behaviors inside the app.
If the activity is destroyed while in background and opened from Recents it
will not act upon the original Intent which is now resent by Android.
Activity's onNewIntent() will be called to act upon a new Intent if the
activity is hot started since we are declared as singleTask and it now has the
responsibility to delegate various intent processors to consume that Intent.
2020-06-22 12:08:24 -04:00
0b57f5e71b
Fixes #10551 : Removes the increased touch target for learn more link
2020-06-22 16:40:15 +03:00
eb45b37207
For issue #10727 - Hide saved logins details
...
Removed the clearFlags call from the HomeActivity that was causing this issue and removed the now redundant call to update the flag from the redirectToReAuth method
2020-06-22 13:19:02 +03:00
e9bb11e22d
Fixes #9205 : Changes add-ons and 'Open links in apps' icons from menus
2020-06-22 12:09:19 +03:00
988513aa89
for #10568 moved awesomebar and toolbar into fragment_search ( #11744 )
2020-06-21 14:56:49 -07:00
9269a53b21
for #11615 allowed strictMode disk read for violations made by the OS. ( #11658 )
2020-06-21 14:54:49 -07:00
Arturo Mejia