1
0
Fork 0
Commit Graph

36 Commits (a07a77c01ad3e75ff1c4c4d4f678d1e42ef7b61d)

Author SHA1 Message Date
mcarare 41ccb02933 For #6516 On browsing mode change empty tab list before displaying new list 2019-12-02 16:15:54 +00:00
Severin Rudie aa8642f534
#4596 migrate collections (#5911)
* For #4596: move code from CollectionCreationComponent to CollectionCreationStore

Other than adding comments, no changes were made. The code will be updated in a following commit. This is in order to make the commit diff more readable.

* For 4596: update CollectionCreateStore to libstate

* For 4596: copied CollectionCreationUIView into CollectionCreationView

Otherwise, no code was changed. The next commit will update this code. This is in order to make the commit diff more readable.

* For 4596: update CollectionCreationView to LibState

Note that the minimal changes possible to enable migration were made.  Refactoring will happen in a later commit.

* For 4596: updated CollectionCreationTabListAdapter to work with the new View

* For 4596: updated SaveCollectionListAdapter to work with the new View

* For 4596: implemented CollectionCreationController

For now, it has an identical interface to the interactor. In a later commit several of its responsibilities will be moved around, some to the interactor and some to the reducer

* For 4596: copied over previous reducer code

No other changes were made. The code will be updated in the following commit. This is done to make changes more readable for the reviewer

* For 4596: update reducer code param names

Otherwise, no changes at this time

* For 4596: add arguments to CreateCollectionFragment in nav_graph

These will be used to replace the current CreateCollectionViewModel, which shares data between fragments in a way that doesn't fit within our architecture.

* For 4596: pass arguments to collection via transaction instead of VM

The VM will be removed in a later commit

* For 4596: update BrowserToolbarController to share state to collection via its Direction

* For 4596: removed CreateCollectionViewModel

* For 4596: test tab retrieval in CreateCollectionFragment

* For 4596: fix crashing CreateCollectionFragmentTest

* For 4596: removed classes create collection classes used by old architecture

* For 4596: collection interactor rename + kdoc

* For 4596: moved collection interactor interface

* For 4596: renamed CreateCollectionFragment

All related classes followed the pattern of CollectionCreationX

* For 4596: kdoc CollectionCreationController

There's no effective difference between these calls and their interactor equivalent, so I linked to them

* For 4596: fix bug that caused rename to not work

* For 4596: removed unused collection actions

These were unused before the LibState refactor

* For 4596: kdoc StepChanged

* For 4596: removed todos about moving logic to the reducer

saveTabsToCollection: this could be moved, but that would involve creating a new action. SaveCollectionStep should probably be refactored out, so adding this layer of indirection seemed counterproductive

handleBackPress: needs to be able to call dismiss(). The reducer doesn't (and shouldn't) be able to do that, so this needs to live here

stepBack: called by handleBackPress. See above

* For 4596: wrote tests for CollectionCreationController#stepback

* For 4596: fixed tests broken by changes to collections

* For 4596: small readability refactor for CollectionController#stepBack

No change to functionality (see tests)

* For 4596: broke apart CollectionView#update

There's probably a lot more that could be done here, but smaller changes were made to reduce scope

* For 4596: remove unnecessary todos

It looks like we don't follow the suggested pattern in this project

* For 4596: test CollectionCreationController#normalSessionSize

* For 4596: updated naming in CollectionCreationController per review
2019-10-22 17:33:54 -07:00
ekager f6285ad5f8 For #3846 - Pass in updated session icon to tabs 2019-10-07 09:38:43 -07:00
Jeff Boek 00d1be97ac For #561 - Wires up add tab button inside the bottom bar 2019-09-25 10:06:38 -07:00
Tiger Oakes cb7701584f No issue: Extract home fragment mode (#5343) 2019-09-23 09:33:55 -07:00
Sawyer Blatz 999d3cb963 For #1114: Show playing tab 2019-09-11 15:45:22 -07:00
Sebastian Kaspari 3a35233ac0 Remove ThumbnailsFeature. (#5127)
We currently do not use thumbnails anywhere in the app. Not using the feature means we are
not taking thumbnails on every page load which means we are saving memory and CPU cycles.
2019-09-05 11:05:37 -05:00
Tiger Oakes c475bc87cf Move classes out of top-level package 2019-08-21 13:52:30 -07:00
Tiger Oakes 52542708aa Consodilate private browsing code 2019-08-09 11:00:41 -07:00
Grisha Kruglov ae33234bbc Closes #2593: FxA automatic sign-in integration 2019-08-01 17:03:45 -07:00
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
Emily Kager acea0d5668 For #2785 - Adds back item animator session control (#3233) 2019-06-06 16:54:49 -05:00
Emily Kager 704f1e6a3d For #3004 - Restore MotionLayout on Home View only in onCreateView 2019-06-05 14:46:38 -07:00
Emily Kager 40f2fe5166 For #1287 - Create animation for opening and closing tab from home 2019-05-23 13:41:00 -07:00
Jeff Boek bf28462c47 For #2717 - Hides onboarding card when signed into a firefox account 2019-05-23 10:26:55 -07:00
Grisha Kruglov f4f35bdde0 Closes #2713: Weave in "onboarding state" and split adapter items accordingly
we're ensuring that it has been initialized.

I wonder if we could just make background services load eagerly (they're lazy init now), instead.
2019-05-23 10:26:55 -07:00
Sawyer Blatz 0080e7d701 For #2584: Adds opening a single tab from tab collection 2019-05-21 09:42:40 -07:00
Sawyer Blatz afbe397f94 For #1575: Enables adding tabs to existing collection 2019-05-21 09:39:55 -07:00
Jeff Boek 9a76c11dae For #2389 - Save state on homeview when switching themes 2019-05-20 23:32:58 -07:00
Sawyer Blatz 4e6f9b9ef1 For #1574: Displays previous tab collections when creating 2019-05-20 14:31:17 -07:00
Sawyer Blatz 72d29c2a43
For #2205 & #1578: Integrates tab collection storage (#2478)
* For #2205: Adds TabCollectionStorage

* For #1578: Adds delete to TabCollection
2019-05-16 14:02:24 -07:00
Jeff Boek 95af2ddcc6 For #2390 - Adds the start browser button 2019-05-15 23:18:37 -07:00
Jeff Boek b14d0fa80c For #2390 - Applies onboarding mode on start 2019-05-15 23:18:37 -07:00
Jeff Boek b3a3c94169
Small refactor before we add onboarding cards (#2541)
* For #2390 - Cleans up the toAdapterList method before we add onboarding

* For #2514 - Hide tabs menu when no tabs are open
2019-05-15 17:06:49 -07:00
Jeff Boek c5e5ef4b25
Teases apart ViewModel dependencies (#2499)
* No Issue - pulls render outside of the viewmodel

* No Issue - Properly subscribes to the changesObservable

* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
Colin Lee 49ac62ab85 Fix ViewModel States (#2457)
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
2019-05-14 13:49:02 -07:00
Colin Lee cfccb997fd For #1909: Tabs disappear intermittently (#2426) 2019-05-10 15:20:45 -07:00
Colin Lee ccbc14a71f For #1994: Re-architect state handling code (#2382) 2019-05-09 23:06:12 +00:00
Sawyer Blatz 7d577e5953
For #2205: Adds collections view to home fragment (#2249)
* For #1574: Adds collections to home view

* Adds colored icons and expansion

* Adds state change

* Adds more styling

* Adds ItsNotBrokenSnacks

* Adds chevron

* Improves styling of swipe to delete and adds delete action

* Fix nits

* Try to add real saving
2019-05-06 11:20:19 -07:00
Emily Kager 0e44921e08 For #1573 - Update tabs header menu (#2141) 2019-04-29 17:03:40 -05:00
Emily Kager 1041500869 For #1573 - Long pressing tab selects that tab in save collections 2019-04-29 12:57:34 -07:00
Jeff Boek f19a773ab9
Merge pull request #1842 from boek/i1840-collections_featureflag
For #1840 - Adds a save tab group button and puts it behind a feature  flag
2019-04-20 14:15:18 -07:00
Jeff Boek 4ea54252b0 For #1830 - Adds the ability to share a tab 2019-04-19 15:31:12 -07:00
Jeff Boek 774c5c0e0c For #1830 - Updates the tab visual style 2019-04-19 15:31:12 -07:00
Jeff Boek 5ca9040702 For #1696 - Removes sessions from session control 2019-04-17 22:41:59 -07:00
Jeff Boek e34d163034 Combines the Tab and Session component 2019-04-06 12:38:46 -05:00