Tiger Oakes
e8bd090a8e
No issue: Use ImageView rather than rebuilding drawable ( #3616 )
...
HomeFragment's onboarding items included drawableStart values, but also
built drawables in the view holders to replace them. Instead, we should
just use ImageViews so that work isn't duplicated.
2019-06-26 16:03:06 -07:00
Tiger Oakes
4994554576
No issue: Adds lint exception for when statement ( #3685 )
2019-06-26 15:52:24 -07:00
Tiger Oakes
d01bb8c442
Use lifecycleScope for collections fragments
2019-06-25 13:56:15 -07:00
Emily Kager
ddebc98718
No issue: Follow up on optional filter style
2019-06-24 17:03:38 -07:00
Emily Kager
718ac5612c
For #3593 For #3581 - Pass sessions to delete to delete all with undo ( #3594 )
2019-06-24 15:41:38 -07:00
Sawyer Blatz
07516f47c3
For #3215 : Adds collection restoration with unique IDs ( #3635 )
2019-06-24 14:12:51 -07:00
Mihai Tabara
ccc5b91992
Import PR 3500 from ekager
2019-06-14 18:52:27 -07:00
Stefan Arentz
6e6e662c47
Update HomeFragment.kt
2019-06-14 18:34:58 -07:00
Jeff Boek
90bdbd04e0
No Issue - Capture session manager in scope before creating the delete operation
2019-06-14 18:34:58 -07:00
Jeff Boek
7ebdfcc87b
For #1116 - Uses alias link for help
2019-06-14 15:33:34 -07:00
Jeff Boek
5540230e3d
For #1116 - Changes help link ( #3491 )
2019-06-14 15:29:10 -05:00
Jeff Boek
f323c38be0
For #981 - Adds missing Leanplum events
2019-06-14 13:27:50 -07:00
Colin Lee
d5c5587a0c
For #3209 : Disable shared element animations for crash temporarily ( #3482 )
2019-06-14 12:13:13 -05:00
Sawyer Blatz
041eaa2a5c
For #3275 : Cleans up feedback from James ( #3398 )
2019-06-14 08:59:57 -07:00
Emily Kager
1f1320920f
For #3275 - Invoke pending single session delete job on close all ( #3438 )
2019-06-13 12:58:45 -05:00
Emily Kager
510b6f7373
For #2899 - Improve collections scroll and highlight animations
2019-06-13 09:21:12 -07:00
Emily Kager
186983b786
For #3275 - Adds PendingSessionDeletion data class to handle multiple emit session calls ( #3393 )
2019-06-12 10:49:20 -07:00
Colin Lee
66a836cf3a
For #3314 : Toolbar and QAB unresponsive after Android 6 perms check ( #3373 )
2019-06-12 10:08:39 -05:00
Gabriel Luong
f05eb032d4
For #2684 : Add an extension function Session.toTab to map Session to Tab and clean up their usage
2019-06-11 13:14:23 -07:00
Emily Kager
82cf81242f
For #3331 - Delay restoring layout while list restores ( #3354 )
2019-06-11 12:27:32 -05:00
Sawyer Blatz
decacbfc97
For #3323 Runs PublicSuffixList synchronously
2019-06-11 09:19:51 -07:00
Emily Kager
e57e7b50ee
For #2899 - Scroll to Collections on change, animate new collections ( #3279 )
...
* For #2899 - Scroll to Collections on change, animate new collections
* For #2899 - Scroll to tabs when tabs opened from collection
2019-06-11 09:01:00 -05:00
Sawyer Blatz
ab000d2e51
For #3280 : Revert "For #3215 : Restores collections properly" ( #3320 )
...
This reverts commit 3e9ee79c00f4a6b34af74ce7c179e0cbe37decf5.
2019-06-10 13:54:03 -07:00
Sawyer Blatz
45c509fbce
For #2648 : Updates trimming of url hostname ( #3191 )
...
* For #2648 : Updates trimming of url hostname
* For #2648 : Fix nits
2019-06-07 09:33:07 -07:00
Emily Kager
7368a95d29
No issue: Sets up observers for tab collection changes ( #3248 )
2019-06-07 09:45:38 -05:00
Colin Lee
1e6da54263
For #3238 : fixes race condition crash, nav destination unknown
2019-06-06 15:46:34 -07:00
Emily Kager
acea0d5668
For #2785 - Adds back item animator session control ( #3233 )
2019-06-06 16:54:49 -05:00
Sawyer Blatz
8537ff10a8
For #3215 : Restores collections properly ( #3219 )
2019-06-06 14:26:05 -05:00
Emily Kager
4954aadd84
For #3156 - If only one tab adding to collection make it selected ( #3222 )
2019-06-06 14:24:25 -05:00
Emily Kager
704f1e6a3d
For #3004 - Restore MotionLayout on Home View only in onCreateView
2019-06-05 14:46:38 -07:00
Emily Kager
14c581c012
For #3004 - Do not restore motionlayout state in ReloadData
2019-06-05 09:33:07 -07:00
ekager
87f6268816
For #3101 - Do not show tab selection screen for 1 tab
2019-06-04 10:08:43 -07:00
ekager
388581f76f
For #3056 - Filter sessions on invoke for pending delete all job
2019-05-31 18:52:02 -07:00
Emily Kager
d5a9627273
For #2941 - Remove Delete Dialog, Theme Dialogs ( #3052 )
2019-05-31 16:26:34 -05:00
Jeff Boek
a7d5cdcb9d
For #2723 - Fixes theme manager
2019-05-30 16:38:31 -07:00
Emily Kager
8dbed67f7f
No issue: Simplify and speed up shared element transitions
2019-05-30 16:30:06 -07:00
Emily Kager
4c970a545d
For #2230 - Fix theme selection radio button for Android 6 ( #3019 )
2019-05-30 17:06:46 -05:00
Sawyer Blatz
b8c04e02e9
For #2327 : Fixes nits
2019-05-30 11:45:39 -07:00
Sawyer Blatz
fe50e88fc8
For #2327 : Adds error state syncing
2019-05-30 11:45:39 -07:00
Emily Kager
caa36c31cd
For #2979 - Prevent double navigation to Create Collection Fragment
2019-05-30 10:58:56 -07:00
Grisha Kruglov
5f42a65c2a
No issue: improve allowUndo
...
This patch fixes a few issues:
- it was an extension on a CoroutineScope, but that was quite misleading
since the Main dispatcher would be always used regardless of what dispatcher
the owning CoroutineScope was configured with.
- timing was reliant on exact value of the undocumented Snackbar.LENGTH_LONG duration
- coroutine cancellation relied on cooperation of the 'operation' suspend function,
which we can't depend on
New 'allowUndo' fully controls its timing, doesn't imply a dispatcher to its consumers,
and doesn't rely on cooperation of passed-in suspend blocks for cancellation to work.
2019-05-30 10:48:59 -07:00
Emily Kager
e61cebf38d
No issue: Check search engine icon exists before setting drawable
2019-05-30 08:33:30 -07:00
Denys M
8bed44819d
Fixes #2254/#2709. Observe browser sessions changes on `HomeFragment`.
2019-05-29 15:13:15 -07:00
Emily Kager
d6c1f65d72
Start MotionLayout animation to end while navigating to search fragment
2019-05-29 12:27:48 -07:00
ekager
dee3c059dc
Adds Shared Transition between Home and Search
2019-05-29 12:27:48 -07:00
Sawyer Blatz
6a53127ef9
For #2948 : Adds menu button add tab to collection
2019-05-29 09:08:11 -07:00
Jonathan Almeida
3da6cfd98a
For #2886 : Fix sending multiple tabs to another device ( #2923 )
...
* For #2886 : Fix sending multiple tabs to another device
* Update share methods to use new API
2019-05-28 15:05:16 -07:00
Emily Kager
506f332b85
For #2919 - Invoke Pending Delete Jobs in onPause
2019-05-28 14:59:05 -07:00
Emily Kager
7d65e21b83
For #2941 - Creates delete dialog style
2019-05-28 13:41:38 -07:00
Emily Kager
250548a72f
For #2823 - Invoke pending jobs with context on switch to private mode
2019-05-28 12:48:02 -07:00
Tiger Oakes
207a8d6772
Use a ListAdapter for SessionControl
2019-05-24 13:13:52 -07:00
Emily Kager
4e13de3ffd
No issue: Register observers with owner view
2019-05-24 10:53:05 -07:00
Emily Kager
f51e221a99
Remove unused import
2019-05-23 13:41:00 -07:00
Emily Kager
895ba021e7
Hide toolbar in activity and remove label from home fragment
2019-05-23 13:41:00 -07:00
Emily Kager
c7af502db7
Restore progress
2019-05-23 13:41:00 -07:00
ekager
0e64ead75c
Try to pop up to home if it exists on stack from browserfragment
2019-05-23 13:41:00 -07:00
Emily Kager
40f2fe5166
For #1287 - Create animation for opening and closing tab from home
2019-05-23 13:41:00 -07:00
Sawyer Blatz
832fd71afc
For #2784 : Removes undo from collection deletion ( #2786 )
2019-05-23 12:16:40 -07:00
Jonathan Almeida
eb7646f073
Add custom share sheet and send tab support ( #2757 )
...
* Closes #2751 : Add custom app share sheet
* Closes #2753 : Add send tab devices to share sheet
* Closes #2752 : Add build flag for send tab
* Replace Context.share with ShareFragment
2019-05-23 10:48:22 -07:00
Jeff Boek
bf28462c47
For #2717 - Hides onboarding card when signed into a firefox account
2019-05-23 10:26:55 -07:00
Grisha Kruglov
f4f35bdde0
Closes #2713 : Weave in "onboarding state" and split adapter items accordingly
...
we're ensuring that it has been initialized.
I wonder if we could just make background services load eagerly (they're lazy init now), instead.
2019-05-23 10:26:55 -07:00
Sawyer Blatz
a1d32127ab
For #2655 : Adds undo snackbar for closing all tabs
2019-05-23 07:26:00 -07:00
Jeff Boek
5ec783f6e5
For #2719 - Fixes crash by registering to observer with a lifecycle owner
2019-05-21 21:43:33 -07:00
Sawyer Blatz
e7ecd49353
For #1578 : Adds delete collection with undo
2019-05-21 14:02:56 -07:00
Emily Kager
394a207fea
Revert "For #1578 : Adds delete collection with undo"
...
This reverts commit 63a4567521
.
2019-05-21 13:04:47 -07:00
Sawyer Blatz
63a4567521
For #1578 : Adds delete collection with undo
2019-05-21 11:03:44 -07:00
Sawyer Blatz
93d0982a6f
For #1576 : Adds tab collection renaming
2019-05-21 10:34:42 -07:00
Emily Kager
0c022f6646
For #1826 - Create ViewModel for Restoring Home Scroll Position
2019-05-21 10:29:15 -07:00
Emily Kager
4b186eb86d
No issue: Save/Restore State in HomeFragment
2019-05-21 10:29:15 -07:00
Sawyer Blatz
0080e7d701
For #2584 : Adds opening a single tab from tab collection
2019-05-21 09:42:40 -07:00
Sawyer Blatz
a3f25b9f77
For #2584 : Adds opening tab collections
2019-05-21 09:42:40 -07:00
Sawyer Blatz
afbe397f94
For #1575 : Enables adding tabs to existing collection
2019-05-21 09:39:55 -07:00
Sawyer Blatz
7e7edc8b7a
For #2377 : Adds share to tabs and tab collections
2019-05-21 09:37:04 -07:00
Jeff Boek
1cd50ba9cb
No Issue - Fixes nits in #2669
2019-05-20 23:32:58 -07:00
Jeff Boek
a041d9ef74
For #2391 - Dismiss tour when navigating to search or settings
2019-05-20 23:32:58 -07:00
Jeff Boek
479c00bc5f
No Issue - Always complete motionLayout transition on restore
2019-05-20 23:32:58 -07:00
Jeff Boek
9a76c11dae
For #2389 - Save state on homeview when switching themes
2019-05-20 23:32:58 -07:00
Emily Kager
ba790c5dd3
No issue: remove unused restore state code
2019-05-20 19:29:28 -07:00
Sawyer Blatz
3619f1417d
For #1574 : Cleans up unused code and refactors
2019-05-20 14:31:17 -07:00
Sawyer Blatz
4e6f9b9ef1
For #1574 : Displays previous tab collections when creating
2019-05-20 14:31:17 -07:00
Sawyer Blatz
30a643720f
For #1574 : Adds tab collection creation
2019-05-20 14:31:17 -07:00
Sawyer Blatz
72d29c2a43
For #2205 & #1578 : Integrates tab collection storage ( #2478 )
...
* For #2205 : Adds TabCollectionStorage
* For #1578 : Adds delete to TabCollection
2019-05-16 14:02:24 -07:00
Jeff Boek
95af2ddcc6
For #2390 - Adds the start browser button
2019-05-15 23:18:37 -07:00
Jeff Boek
dfe14e1751
For #2390 - Adds the onboarding welcome message
2019-05-15 23:18:37 -07:00
Jeff Boek
b14d0fa80c
For #2390 - Applies onboarding mode on start
2019-05-15 23:18:37 -07:00
Jeff Boek
c5e5ef4b25
Teases apart ViewModel dependencies ( #2499 )
...
* No Issue - pulls render outside of the viewmodel
* No Issue - Properly subscribes to the changesObservable
* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
Colin Lee
49ac62ab85
Fix ViewModel States ( #2457 )
...
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
2019-05-14 13:49:02 -07:00
Colin Lee
917399d897
For #2436 : TransactionTooLargeException saving many tabs ( #2453 )
2019-05-13 21:03:51 -05:00
Colin Lee
155353f0ee
For #2449 : App crashes when switching themes ( #2450 )
2019-05-13 10:59:05 -05:00
Emily Kager
4070941657
No issue: Refactor dialogs to use nav graph
2019-05-10 19:58:48 -07:00
Colin Lee
cfccb997fd
For #1909 : Tabs disappear intermittently ( #2426 )
2019-05-10 15:20:45 -07:00
Colin Lee
ccbc14a71f
For #1994 : Re-architect state handling code ( #2382 )
2019-05-09 23:06:12 +00:00
Emily Kager
eb4e159101
For #2329 , For #2332 : Invoke pending delete session job on navigate ( #2333 )
2019-05-08 12:27:38 -05:00
Emily Kager
37bae3bb38
For #2289 - Null out pending job on undo ( #2303 )
2019-05-06 16:38:53 -05:00
Sawyer Blatz
7d577e5953
For #2205 : Adds collections view to home fragment ( #2249 )
...
* For #1574 : Adds collections to home view
* Adds colored icons and expansion
* Adds state change
* Adds more styling
* Adds ItsNotBrokenSnacks
* Adds chevron
* Improves styling of swipe to delete and adds delete action
* Fix nits
* Try to add real saving
2019-05-06 11:20:19 -07:00
Emily Kager
0000d6a782
For #2277 - Clean up threading for session control with undo ( #2281 )
2019-05-05 09:54:45 -05:00
Emily Kager
e5e448ac8f
For #1694 - Show Snackbar with Undo When Tab is Closed ( #2246 )
2019-05-03 09:41:44 -05:00
Emily Kager
73de0cd2e8
Closes #2239 - emit session changes in onstart ( #2240 )
2019-05-02 15:13:59 -05:00
Emily Kager
8fd937669b
Closes #2182 - Do not invoke sessionmanager callbacks ( #2236 )
2019-05-02 14:35:38 -05:00
Emily Kager
2953b54a84
For #1573 - Polish Collections UI Component ( #2212 )
...
* Adds Keyboard resuming, Snackbar verification, layout edits to collections
Adds Keyboard resuming, Snackbar verification, layout edits to collections
* Adds new strings for collections/tabs management
* Adds constraintsets, hides checkboxes, adds scrim
* Update strings to plurals
2019-05-02 10:53:40 -05:00
Will Hawkins
0bcff089d6
Feature #2088 : Async load the default search engine icon at startup ( #2113 )
2019-04-30 19:45:56 -05:00
Sawyer Blatz
70486039c0
Closes #2147 : Refactors usage of openToBrowserAndLoad
2019-04-29 15:49:22 -07:00
Emily Kager
0e44921e08
For #1573 - Update tabs header menu ( #2141 )
2019-04-29 17:03:40 -05:00
Emily Kager
1041500869
For #1573 - Long pressing tab selects that tab in save collections
2019-04-29 12:57:34 -07:00
Sawyer Blatz
46924544b6
For #1975 & #1627 : Refactors getSessionById in BrowserFragment
2019-04-25 16:51:03 -07:00
Jeff Boek
d39c15402e
For #1843 - Adds a better theme for the creation fragment
2019-04-24 14:29:23 -07:00
Jeff Boek
ba90b58d32
For #1843 - Displays tabs on the tab selection screen
2019-04-24 14:29:23 -07:00
Jeff Boek
63574cc359
For #1843 - Adds a create collections fragment and navigates to it
2019-04-24 14:29:23 -07:00
Sawyer Blatz
e2198f19ad
Fixes #1868 : Corrects private browsing myths link ( #1930 )
2019-04-23 14:26:56 -07:00
Emily Kager
534d88f629
Closes #1894 - Fixes Help Page Navigation
2019-04-23 00:22:46 -05:00
Jeff Boek
f19a773ab9
Merge pull request #1842 from boek/i1840-collections_featureflag
...
For #1840 - Adds a save tab group button and puts it behind a feature flag
2019-04-20 14:15:18 -07:00
Jeff Boek
4ea54252b0
For #1830 - Adds the ability to share a tab
2019-04-19 15:31:12 -07:00
Jeff Boek
774c5c0e0c
For #1830 - Updates the tab visual style
2019-04-19 15:31:12 -07:00
Jeff Boek
5ca9040702
For #1696 - Removes sessions from session control
2019-04-17 22:41:59 -07:00
Jeff Boek
6183e82264
For #1696 - Removes sessions from the bottomsheetfragment
2019-04-17 22:41:59 -07:00
Sawyer Blatz
29832c5e84
For #724 : Consolidates colors
2019-04-15 12:22:03 -05:00
Colin Lee
bc1b7e0b43
For #1539 : Add bookmark multi-select features
2019-04-12 13:35:28 -05:00
Jeff Boek
e98db8bfb8
For #1430 - Adds a changelog entry
2019-04-10 09:58:00 -07:00
Jeff Boek
5acd386ecd
For #1430 - Handle more text in a more graceful way
2019-04-10 09:58:00 -07:00
Jeff Boek
b306bc502a
For #1430 - Adjust snackbar colors for darkmode
2019-04-10 09:58:00 -07:00
Jeff Boek
9434f01b42
Fixes #1204 - Fixes the home screen animation
2019-04-08 16:16:28 -05:00
Jeff Boek
e34d163034
Combines the Tab and Session component
2019-04-06 12:38:46 -05:00
Jeff Boek
4a385068e0
Updates ConstraintLayout to alpha4
2019-04-05 10:09:02 -07:00
Jeff Boek
756634bc6c
For #1181 - Use appName in string locations
2019-03-26 14:32:53 -07:00
Jeff Boek
786592e8d0
For #959 - Adds telemetry for when the search bar is tapped
2019-03-22 17:14:35 -07:00
Colin Lee
df40ec970e
Simplify ItsNotBrokenSnack() and make resilient
...
Co-authored by: Emily Kager <ekager@mozilla.com>
2019-03-22 15:00:38 -05:00
Emily Kager
4963f7ccdb
Add Snackbar to link testers to Github issue for features
2019-03-22 15:00:38 -05:00
Emily Kager
bb3ebbdbe2
Closes #932 - Home Page UI polish
2019-03-20 19:55:29 -05:00
Colin Lee
0ac3e5369d
Fixes #1050 : Fenix sessions save and close upon opening
2019-03-18 08:21:30 -07:00
Colin Lee
6e1655e935
Fix #1032 : Crash altering sessions DB on main thread
2019-03-15 10:41:02 -07:00
Sawyer Blatz
463ab8bf79
No issue: Fixes compilation errors with a-c 47.0
2019-03-14 09:49:35 -07:00
Emily Kager
8d442c062d
Closes #884 - Set and use default search engine
2019-03-12 11:11:24 -07:00
Jeff Boek
79395631d7
Fixes #870 - Fixes logic for the session bottom sheet fragment for private mode
...
Also fixes #871
2019-03-11 16:02:06 -07:00
Sawyer Blatz
b1d0233b04
Closes #814 : Scrolls to top after session restore
2019-03-08 12:55:52 -08:00
Sawyer Blatz
d6ebd88186
Closes #804 : Adds disable private browsing content description ( #851 )
2019-03-08 08:37:35 -08:00
Emily Kager
d15e4bb3fa
Closes #877 - Add Search Engine Settings
2019-03-06 16:20:35 -08:00
Sawyer Blatz
a79134fdc3
Closes #823 & Closes #835 : Refactors openToBrowserAndLoad to include fromFragment ( #833 )
2019-03-06 14:53:49 -08:00
Emily Kager
58b32e944b
Revert "Closes #811 - Clear stack after switching to private browsing" ( #876 )
...
This reverts commit 8b793cd43e
.
2019-03-06 11:48:00 -08:00
Emily Kager
8b793cd43e
Closes #811 - Clear stack after switching to private browsing
2019-03-05 14:34:56 -08:00
Jeff Boek
d413b7228f
Fixes compiler error for new version of A-C
2019-03-05 09:34:49 -08:00
Colin Lee
9d3ef76929
For #747 : Fix memory leak with HomeMenu
2019-03-04 09:02:20 -08:00
Jeff Boek
27c5570b43
For #673 - Dismiss bottom sheet on archive. Remove boolean logic
2019-03-01 08:03:51 -06:00
Jeff Boek
e05f0894e8
For #673 - Modifies Session Bottom Sheet to work for current and archived sessions
2019-02-28 18:46:46 -06:00
Jeff Boek
22c915b5a4
For #673 - Trigger session overflow menu on session item menu
2019-02-28 18:46:46 -06:00
Jeff Boek
1aa3d7e1ad
For #673 - Pulls out the session overflow action
2019-02-28 18:46:46 -06:00
Sawyer Blatz
e9e74122b5
Closes #736 & Closes #722 : Adds delete session button to private browsing
2019-02-28 14:00:01 -08:00
Jeff Boek
77189a00a0
Fixes #741 - Dont show the current session in the previous session list
2019-02-28 14:51:31 -06:00
Sawyer Blatz
84a2b24554
Closes #510 : Adds private browsing myths SUMO link
2019-02-28 13:38:08 -06:00
Jeff Boek
1d4be1b665
For #633 - Remove only normal sessions, add a11y for glyphs
2019-02-27 15:21:55 -08:00
Jeff Boek
416382c3ad
For #633 - Gives the user the ability to save their session
2019-02-27 15:21:55 -08:00