Emma Malysz
13f73c2d2c
For issue 7192: move unsetOpenLinksInAPrivateTabIfNecessary off main thread. ( #7246 )
...
Move method to Settings. There are two instances when we want to call this method: either
processing an intent, or within DefaultBrowserPreference
2019-12-30 14:42:13 -08:00
Michael Comella
cf143489e1
For #6464 : Replace use of BuildConfig.DEBUG with ReleaseChannel.channel.isDebug.
...
This fixes performance issues where StrictMode would greatly slow down
startup in the forPerformanceTest variants.
2019-12-30 10:31:33 -08:00
Michael Comella
ac97dd72b1
For #6464 : Set "forPerformanceTest" to ReleaseChannel.FenixProduction.
...
This fixes a perf measurement issue where Sentry would capture an event when
using the forPerformanceTest variants.
2019-12-30 10:31:33 -08:00
Michael Comella
37bafda602
For #6464 : Add ReleaseChannel test to document assumptions.
2019-12-30 10:31:33 -08:00
Michael Comella
f11ddf8038
For #6464 : Add ReleaseChannel.isDebug.
2019-12-30 10:31:33 -08:00
Severin Rudie
f562c81fb2
For 5334: test NotificationSessionObserver
2019-12-30 11:40:07 +02:00
Severin Rudie
a8c47c8805
For #5334 : disable notification for private custom tabs
2019-12-30 11:40:07 +02:00
Richard Pappalardo
a441f55d7a
Temp disable UI test verifyAboutFirefoxPreview ( #7390 )
2019-12-27 15:46:55 -08:00
Sawyer Blatz
9a693f6c11
For #7000 : Fix inverted media telemetry ( #7368 )
2019-12-27 13:46:47 -08:00
Severin Rudie
26b7909214
For #7352 : integrate highlightable browser menu changes ( #7353 )
...
* For #7352 : integrate highlightable browser menu changes
* For 7352: invalidate menu when reader mode availability changes
* For 7352: removed highlight from reader mode appearance per UX
2019-12-27 12:15:21 -08:00
Kadeem M
e22d092f5d
Added UI tests for the About Settings page ( #6161 )
2019-12-27 07:55:35 -08:00
isabelrios
491a198fae
For #5074 - Add UI tests for logins and passwords setting menu ( #7291 )
...
* For #5074 - Add UI tests for logins and passwords setting menu
* fix detekt failure
* remove old file
* fix scroll small screens
* fix reviewer comments
2019-12-26 14:22:40 -08:00
Sawyer Blatz
faa4136685
For #7347 : Fixes background of search field
2019-12-23 10:07:54 -08:00
Sawyer Blatz
4fd3eb53d1
For #6666 : Adds back button to search screen
2019-12-23 10:07:02 -08:00
Mihai Adrian
4fa6edc86e
For #7122 Fix icons for saved logins screen ( #7268 )
2019-12-23 12:46:52 -05:00
Suraj Shah
6344a8892d
For #7041 - Respect current mode when opening library items ( #7311 )
...
* Fixes #7041
Consumes `browserMode` from home activity for tap method of bookmark
* Fixes spaces
* Cleaning tests
* Cleaning tests
2019-12-23 12:26:47 -05:00
mozilla-l10n-automation-bot
a50d8552ac
Import l10n. ( #7009 )
2019-12-20 14:01:18 -05:00
Roger Yang
dd1433733a
Closes #7156 : Update app links feature usage to include app links interceptor ( #7275 )
2019-12-20 08:27:19 -05:00
Richard Pappalardo
f85961d9a9
Temp disable flaky UI testDownloadPrompt ( #7304 )
2019-12-20 10:31:43 +02:00
Josh
593981fa4b
Fix parameterized message in search engine ( #7302 )
2019-12-20 10:27:05 +02:00
Jeff Boek
740572b6d9
For #5334 - Override custom tab styling in private mode ( #7305 )
2019-12-19 18:17:52 -08:00
Josh
a40af5b134
Closes #7254 - Replace Anko applyConstraintSet ( #7286 )
...
* For #7254 : Replace anko applyConstraintSet
* Anko has been deprecated and will not be continued
* Refactor ConstraintSet changes
* Replace applyConstraintSet in SearchLayouts
* Refactor HomeFragment ConstraintSet
* Define anonymous ConstraintSet
* Remove ConstraintSet prefix from PARENT_ID
2019-12-19 18:16:50 -08:00
Mihai Adrian
c5a142aa14
For #6992 , for #6897 , for #6889 : Disable multitouch in app ( #6999 )
2019-12-19 19:32:47 -05:00
Tiger Oakes
b85673acac
Clean up settings fragments
2019-12-19 14:29:28 -08:00
Josh Vocal
43354489a1
For #7253 - Replace anko setters
2019-12-19 13:42:50 -08:00
Jeffrey Starke
59a021f3a3
Consolidate duplicate mock initialization in intent processor tests. ( #6374 )
...
* Consolidate duplicate code in intent processor tests
* Resolve ktlint errors
2019-12-19 12:33:59 -05:00
Mihai Adrian
33ac75d166
For #3574 Allow all screen readers to read onboarding items one-by one ( #7292 )
2019-12-19 09:53:53 -05:00
Tiger Oakes
76c83ba805
For #7085 - Remove anko px2dip ( #7252 )
2019-12-19 00:05:51 -08:00
Tiger Oakes
7c9a5c1f14
For #768 - Add PWA install option to menu ( #6882 )
2019-12-18 23:59:30 -08:00
mcarare
907d96e39f
For #6709 , for #6849 Handle default engine deletion and undo operation
...
Uninstall engine immediately and allow reinstall in onCancel.
Set previous list with default engine in onCancel.
Keep default engine change in operation and remove now unnecessary view refresh.
2019-12-18 23:00:42 -08:00
Tiger Oakes
f439c8110e
For #7183 - Fix bottom margin in PWAs
2019-12-18 22:57:54 -08:00
Rushab Kumar
562eb89356
For #7250 - Replace anko.dimen
2019-12-18 15:39:14 -08:00
Sebastian Kaspari
e789d8ebe3
Issue #4978 : Reuse widget package name of Fennec.
2019-12-18 15:23:43 -08:00
Emily Kager
5ac79f59a3
For #7219 - Polish Download Notification Dialog. ( #7224 )
...
* For #7219 - Use accent color for downloads dialog positive button
* For #7219 - Fixes gap beneath download notification dialog
* switch to setimageresource
2019-12-18 12:26:41 -05:00
Roger Yang
1a739db5b1
Closes #7260 : Pass in GeckoView version information to MozillaSocorroservice
2019-12-18 10:45:57 +01:00
Grisha Kruglov
52334f9121
Closes #6937 : Disable runStorageMaintenance during startup
...
This call will acquire a "write" lock at the storage layer (sqlite's reserved+),
which may interfere with migrations that run during startup as well (they need to
write to storage, and so also need to acquire a lock). If these operations clash,
we get a SQLITE_BUSY crash. For now, just disable the maintenance operation.
2019-12-17 14:24:30 -08:00
Tiger Oakes
ea486d7c66
Split out CustomTabToolbarIntegration ( #7107 )
2019-12-17 12:26:46 -08:00
David Walsh
b4e10965b7
Use localized strings in the quick settings panel ( #7249 )
2019-12-17 10:47:21 -08:00
Colin Lee
c0b9ad77be
For #4064 : Update R8/ProGuard config for new Kotlin coroutines library ( #7218 )
2019-12-17 10:41:54 -06:00
Sebastian Kaspari
16b4680c06
Closes #4976 : Use dynamic launcher entry in manifest.
2019-12-17 16:00:15 +01:00
Suraj Shah
6cb3879caf
For #7048 : Network info migration ( #7091 )
...
* Fixes #7048 .
Adds extension function to check if online or not based on capabilities
Modified `buildDeviceList`
Modifies tests
* Fixing lint error for max length
Fixing test in AppRequestInterceptorTest.kt
* Adds suppression for deprecation
Moving away from using anko for ConnectivityManager instance
* Creates ConnectivityManager extension component
* Fixes #7180
Refactors test cases to fix static mocks
2019-12-16 22:03:11 -08:00
David Walsh
e727ae5d7e
Fix 5366 - Use VectorDrawableCompat for all imagery ( #7221 )
...
* Fix 5366 - Use VectorDrawableCompat for all imagery
* Fix detekt lint issues
* Restore previous comment contents
2019-12-16 20:35:36 -08:00
Severin Rudie
cd53e9778a
For 6795: expands toolbar whenever a new session is selected
...
This ensures that the bar is expanded when opening a link in a new tab
2019-12-16 14:09:29 -08:00
Jeff Boek
49f07554e7
No Issue - Removes some search engines
2019-12-16 14:09:14 -08:00
mcarare
90c77519a6
For #7194 Set snackbar anchor depending on browser toolbar position
2019-12-16 12:21:54 -08:00
Aaron Train
757c9577e0
No issue: Fixes breakage with unused import in 4a2cb91
( #7205 )
2019-12-16 11:55:44 -05:00
Aaron Train
4a2cb91ad9
For #6697 : Add Tracking Protection UI Tests ( #6825 )
...
Add tests for verifying basic UI functionality of Enhanced Tracking Protection
2019-12-16 10:12:43 -05:00
Patrick Martin
71880705df
For #5711 - Onboarding colours have contrast issues
2019-12-13 17:52:55 -08:00
Afzal Najam
b9656a978e
Hide add folder option when in Desktop Bookmarks folder
2019-12-13 17:51:15 -08:00
Ryan Kelly
31f2e80ab0
Use feature-accounts-push, which replaces feature-sendtab.
2019-12-13 16:42:28 -08:00
mcarare
bc6b7725e9
For #6968 Close response stream to allow use of caching
2019-12-13 12:35:25 -08:00
mcarare
d2abac78eb
For #7075 Update passwords preference visibility and string
...
Set visibility for feature flags before settings screen it's displayed.
Change string for preference to match existing header string.
Update UI Tests
2019-12-13 12:19:14 -08:00
mcarare
ef53e1ff8e
Reverts #6925 : Make home screen full screen
2019-12-13 11:29:53 -08:00
Colin Lee
a8f895cb5c
For #4064 : Replace prerelease R8 with improved Kotlin coroutines library ( #7153 )
2019-12-13 13:29:27 -06:00
Will Hawkins
116f7b3d65
No Issue: Create a method to "finish onboarding" in CI
...
If the intent that starts the HomeActivity includes an extra
boolean flag named finishonboarding and it is set to true,
Fenix will "finish onboarding".
2019-12-13 11:28:57 -08:00
Emily Kager
686facffc6
For #6946 - Get engine margins without assuming top/bottom toolbar
2019-12-13 11:09:30 -08:00
Emily Kager
dcb39b0a44
For #7124 - Match toolbar location for ETP/security panel gravity
2019-12-13 11:09:30 -08:00
Vlad Filippov
a3f2f55548
Closes #5913 : Add new sessionToken scope ( #6155 )
2019-12-12 12:00:20 -08:00
Emily Kager
558f90da00
No issue: Scroll to remote debugging text in UI Tests ( #7117 )
2019-12-12 12:00:02 -08:00
Tiger Oakes
32985af882
For #6830 - Fix "Open in" text size for custom tab ( #7010 )
2019-12-12 11:49:54 +02:00
ValentinTimisica
8b8f3d1b56
For #4776 : Refactored UI tests.
...
After removing the 'Privacy notice' and 'Help' items from the Settings screen
the UI tests for them became unneeded.
2019-12-12 11:34:10 +02:00
ValentinTimisica
b819cb11c9
For #4776 : Added Unit tests for About Page.
2019-12-12 11:34:10 +02:00
ValentinTimisica
c6c827f693
For #4776 : Redesign and refactor the About Page
...
Added new items to be displayed.
2019-12-12 11:34:10 +02:00
Grisha Kruglov
72d8dfb976
Enable Fennec settings (telemetry) migration
2019-12-11 19:16:55 -08:00
mcarare
1c9c8f590a
For #7066 Increase space below checkbox preference
2019-12-11 11:23:14 -08:00
Mihai Adrian
bfc65e0614
For #6710 Update custom search engine images with better resolution ( #7084 )
2019-12-11 16:09:32 +02:00
Sawyer Blatz
de6469e198
For #7073 : Makes logo on about page not important for accessibi… ( #7074 )
2019-12-10 12:15:11 -08:00
Mihai Branescu
c46bf84ac9
For #6330 Collections Numbering ( #6453 )
...
* For #6330 - Added logic for getting the recommended default collection name
* For #6330 - Added unit test for default collection number method
2019-12-10 12:10:01 -08:00
Tiger Oakes
fe034226a3
For #5783 - Web Share with Fenix share sheet ( #6883 )
2019-12-10 10:57:06 -08:00
Mihai Adrian
6e9769a81b
For #7031 - Hide progress bar when leaving DeleteBrowsingDataFragment ( #7056 )
2019-12-10 11:17:45 -05:00
isabelrios
1d04736884
Re-enable Screenshots tests ( #6617 )
...
disabling setting test options due to different screen sizes
name screenshots according to robots
fix kotlin style
update settings tests with new Toolbar option
screenshots tests in different package than ui tests
2019-12-10 13:05:47 +02:00
Sebastian Kaspari
a83717dd7b
Run migration in background service.
...
In order to avoid a half done migration we are moving the migration to a background service (that is
running in the "foreground").
This is the Fenix part of:
https://github.com/mozilla-mobile/android-components/issues/4879
2019-12-10 11:31:32 +01:00
Tiger Oakes
3f7205e3cb
Extract IntentProcessorType to its own file and add tests ( #7012 )
2019-12-10 00:02:23 -08:00
Severin Rudie
7477de83e9
For #4844 : fix file prefix url shortening
2019-12-10 05:07:53 +01:00
Severin Rudie
957ed8aa88
For #5334 : fix ETP shield coloring on custom private tabs
2019-12-10 03:22:55 +01:00
Mihai Adrian
45ae8cb35a
For #6997 Avoid overwriting empty_search_string error ( #6998 )
...
Setting error twice also clips error message
2019-12-09 18:10:24 -08:00
Emily Kager
76e9200304
For #6922 - Check current destination is logins fragment before navigation ( #6924 )
2019-12-09 15:42:40 -08:00
Michael Comella
2a4aa24195
For perf-frontend-issues#33: Clarify VERBOSE logging motivation.
2019-12-09 15:11:52 -08:00
Michael Comella
eef080a46c
For perf-frontend-issues#33: Add HotStartPerformanceMonitorTest.
...
We really don't want our startup tests to subtlely change so I thought
it was worth writing some quick tests.
2019-12-09 15:11:52 -08:00
Michael Comella
e60141e98d
For perf-frontend-issues#33: Add HotStartPerformanceMonitor.
...
As mentioned in the class comment, we could use an alternative
implementation to measure perf from outside the application however
it's more complicated to set up and less consistent with our cold
startup methodology so we'll start with this.
2019-12-09 15:11:52 -08:00
ekager
1647e07481
For #5771 - Don't force landscape mode on fullscreen
2019-12-09 23:47:57 +01:00
mcarare
b6ba1a1611
For #4107 Make home screen fullscreen.
...
Add/Remove fullscreen flags in home fragment's onResume / onPause
Change homeLayout padding to include system bars height (status&navigation).
Change homeMenu orientation to UP to properly display menu.
Change home bottomBar background to transparent.
2019-12-09 23:45:02 +01:00
mcarare
17731620e6
For #7026 Dispatch ModeChange on hideOnboarding
2019-12-09 23:44:33 +01:00
ekager
e6d4c5b417
No issue: Remove unnecessary back slashes from curly apostrophe strings
2019-12-09 23:16:00 +01:00
Grisha Kruglov
42d6915699
Fennec migration: enable logins migration
2019-12-09 13:35:22 -08:00
Jeff Boek
45c6e3a784
For #1607 - Passes "custom" as the search engine identifier for custom engines
2019-12-09 11:47:05 -08:00
Severin Rudie
dfea877fb7
No issue: small installedSearchEngineIdentifiers readability refactor
2019-12-09 10:58:19 -08:00
Severin Rudie
2aa80eff95
No issue: tests installedSearchEngineIdentifiers
2019-12-09 10:58:19 -08:00
Severin Rudie
d3ff98816d
No issue: begin moving FenixSearchEngineProvider into a testing harness
2019-12-09 10:58:19 -08:00
Oana Horvath
46439930c0
Fixed flaky History UI tests by adding an extra verification step that ( #6894 )
...
the page is loaded.
Enabled all tests
2019-12-09 11:52:55 +02:00
Aaron Train
e1fd53c718
Closes #6873 : Support many more Content-Type in MockWebServer (UI tests) ( #7001 )
...
Ensure our MockResponse can handle different Content-Type e.g, images, to help support other tests
2019-12-06 14:53:18 -05:00
Severin Rudie
5f393bd5d4
For #5334 : added private custom tab processor ( #6845 )
...
* For #5334 : added private custom tab processor
* For #5334 - Fixes up IntentReceiverActivity for handling intents
* For 5334: update styling for private custom tabbs
* For 5334: update tests to account for new processors
Note that two are still failing. These appear to be true failures, and will be corrected in a later commit.
* For 5334: fixes bug introduced by changes to IntentReceiverActivity
RCA: intent className and extra were previously set based on which processors matched, not which successfully processed. This patch reintroduces that behavior.
* For 5334: add tests for custom tabs processing
2019-12-06 10:57:54 -08:00
Jeff Boek
4fb26a0601
For #4664 - Updates search_with string. ( #6909 )
2019-12-06 10:36:19 -08:00
Mozilla L10n Automation Bot
9feb0480bf
Import l10n.
2019-12-06 08:53:22 -08:00
kglazko
300d8317e1
Issue 5366 Vector Drawable Compat ( #6904 )
2019-12-05 19:54:32 -08:00
Richard Pappalardo
2225b7154a
Disable flaky testDownloadNotification - API28 ( #6982 )
2019-12-05 18:00:21 -08:00
Mihai Adrian
6998fc1cf8
Temporarily fix lint issues with bad translation of string ( #6963 )
2019-12-05 13:57:57 -08:00
mcarare
45b9ffd66e
For #6917 Emit mode change only when new mode is different from current
2019-12-05 11:10:14 -08:00
Mihai Adrian
3283d6ed0b
For #6910 Align shortcuts in private onboarding panel style to… ( #6950 )
...
Divider only shows when both panel and "Search with" are visible
2019-12-05 09:37:20 -08:00
Mihai Adrian
cbdf83c12a
For #6943 Hide supportActionBar in onResume, not onCreate ( #6978 )
2019-12-05 09:36:39 -08:00