blallo
/
fenix
1
0
Fork 0
Code Releases Activity

For #6464: Set "forPerformanceTest" to ReleaseChannel.FenixProduction. 

This fixes a perf measurement issue where Sentry would capture an event when
using the forPerformanceTest variants.
master
Michael Comella 2019-12-20 13:13:45 -08:00 committed by Michael Comella
parent 37bafda602
commit ac97dd72b1
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
app/src/main/java/org/mozilla/fenix/Config.kt
View File

@ -4,8 +4,6 @@
package org.mozilla.fenix
import io.sentry.Sentry
enum class ReleaseChannel {
FenixDebug, FenixNightly, FenixBeta, FenixProduction, FennecProduction;
@ -47,10 +45,15 @@ object Config {
"fenixNightly" -> ReleaseChannel.FenixNightly
"debug" -> ReleaseChannel.FenixDebug
"fennecProduction" -> ReleaseChannel.FennecProduction
// Builds for local performance analysis, recording benchmarks, automation, etc.
// This should be treated like a released channel because we want to test
// what users experience and there are performance-impacting changes in debug
// release channels (e.g. logging) that are never intended to be shipped.
"forPerformanceTest" -> ReleaseChannel.FenixProduction
else -> {
Sentry.capture("BuildConfig.BUILD_TYPE ${BuildConfig.BUILD_TYPE} did not match expected channels")
// Performance-test builds should test production behaviour
ReleaseChannel.FenixProduction
throw IllegalStateException("Unknown build type: ${BuildConfig.BUILD_TYPE}")
}
}
}