1
0
Fork 0
Commit Graph

1611 Commits (5f393bd5d4655d4e1ca0163e46d96eb3e8a89fbe)

Author SHA1 Message Date
Severin Rudie 5f393bd5d4
For #5334: added private custom tab processor (#6845)
* For #5334: added private custom tab processor

* For #5334 - Fixes up IntentReceiverActivity for handling intents

* For 5334: update styling for private custom tabbs

* For 5334: update tests to account for new processors

Note that two are still failing. These appear to be true failures, and will be corrected in a later commit.

* For 5334: fixes bug introduced by changes to IntentReceiverActivity

RCA: intent className and extra were previously set based on which processors matched, not which successfully processed. This patch reintroduces that behavior.

* For 5334: add tests for custom tabs processing
2019-12-06 10:57:54 -08:00
kglazko 300d8317e1
Issue 5366 Vector Drawable Compat (#6904) 2019-12-05 19:54:32 -08:00
mcarare 45b9ffd66e For #6917 Emit mode change only when new mode is different from current 2019-12-05 11:10:14 -08:00
Mihai Adrian 3283d6ed0b For #6910 Align shortcuts in private onboarding panel style to… (#6950)
Divider only shows when both panel and "Search with" are visible
2019-12-05 09:37:20 -08:00
Mihai Adrian cbdf83c12a For #6943 Hide supportActionBar in onResume, not onCreate (#6978) 2019-12-05 09:36:39 -08:00
Gabriel 56b21426eb
For #5574 - Migrate SessionControl to LibState (#6651)
* For #5574 - Part 1: Port TabAction.SaveTabGroup to TabSessionInteractor and SessionControlController. (#6651)

- Introduces the TabSessionInteractor, SessionControlInteractor and SessionControlController classes.
- Removes the TabAction.SaveTabGroup.

* For #5574 - Part 2: Port TabAction.PrivateBrowsingLearnMore to TabSessionInteractor and SessionControlController (#6651)

* For #5574 - Part 3: Port TabAction.ShareTabs to TabSessionInteractor and SessionControlController (#6651)

* For #5574 - Part 4: Remove unused TabAction.Share and TabItemMenu (#6651)

In #2205, the tab overflow button was removed which would have shown the
TabItemMenu when clicked. So, we can remove TabItemMenu since it is not
used and as a result, we can also remove TabAction.Share since there are
no consumers.

* For #5574 - Part 5: Port TabAction.PlayMedia and TabAction.PauseMedia to TabSessionInteractor and SessionControlController (#6651)

* For #5574 - Part 6: Port TabAction.Select to TabSessionInteractor and SessionControlController (#6651)

* For #5574 - Part 7: Port Onboarding.Finish to OnboardingInteractor and SessionControlController (#6651)

* For #5574 - Part 8: Port TabAction.Close and TabAction.CloseAll to TabSessionInteractor and SessionControlController (#6651)

- Removes TabAction

* For #5574 - Part 9: Port CollectionAction.Delete to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 10: Port CollectionAction.ShareTabs to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 11: Port CollectionAction.AddTab and CollectionAction.Rename to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 12: Port CollectionAction.RemoveTab to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 13: Port CollectionAction.OpenTab to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 14: Port CollectionAction.CloseTabs to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 15: Introduce a HomeFragmentStore (#6651)

- We will hook up the HomeFragmentStore in later parts.
- Removes List<Tab>.toSessionBundle(context: Context) since it is unused.

* For #5574 - Part 16: Port CollectionAction.Collapse and CollectionAction.Expand to CollectionInteractor and SessionControlController (#6651)

- We assume the store is hooked up to the SessionControlController in this part,
but this work will be done in a later part.
- Removes CollectionAction.

* For #5574 - Part 20: Remove the architecture module. (#6651)

* For #5574 - Part 17:  Remove duplicate subscribeToTabCollections in BrowserFragment.kt (#6651)

There is a duplicate call of subscribeToTabCollections() in both HomeFragment and BrowserFragment.
In this patch, we remove the call in BrowserFragment to avoid passing the HomeFragmentStore to
BrowserFragment in order to dispatch the CollectionsChange event.

* For #5574 - Part 18: Delete SessionControlComponent and fix TabCollection and Tab imports (#6651)

* For #5574 - Part 19: Use the new HomeFragmentStore in the HomeFragment (#6651)

- Renames SessionControlUIView to SessionControlView

* For #5574 - Part 21: Fix white screen on home fragment (#6651)

* For #5574 - Part 22: Fix formatting in SessionControlInteractor and replace See with @see in SessionControlController (#6651)

* For #5574 - Part 23: Move to metrics.track call to the beginning of handleCollectionRemoveTab (#6651)

This ensures that the metrics.track will be called immediately before the tab is removed from the collection.

* For #5574 - Part 24: Use the sessionManager getter in SessionControlController (#6651)

* For #5574 - Part 25: Use mapNotNull in List<Tab>.toSessionBundle (#6651)

* For #5574 - Part 26: Simplify closeTab and closeAllTabs functions by assigning a deletionJob constant (#6651)

* For #5574 - Part 27: Replace listOf() with emptyList() in removeAllTabsWithUndo (#6651)

* For #5574 - Part 28: Replace the Context parameter with the HomeActivity in SessionControlController (#6651)

* For #5574 - Part 29: Add test for HomeFragmentStore, DefaultSessionControlController and SessionControlInteractor (#6651)

* For #5574 - Removes running CI against the architecture debug build varient
2019-12-04 22:06:05 -05:00
Jeff Boek d4e3a2037f For #6855 - Filter out duplicated bundled search engines
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 17:10:02 -08:00
mcarare c3389dcdb5 For #6070 Adds telemetry for enabling search suggestions in private 2019-12-04 16:44:01 -08:00
Jeff Boek 781b141bc7 For #6849 - Properly select a new default search engine when you delete the current one
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 16:10:26 -08:00
Jeff Boek eb6e6b774f For #6848 - Sorts the search engine list without case sensitivity
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 16:10:26 -08:00
Jeff Boek 1cc496a683 For #6847 - Properly rebuilds the SearchEngineList on undo
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 16:10:26 -08:00
Emily Kager d1b134c2ff For #6908 - Set null anchors for snackbars with top toolbar (#6911) 2019-12-04 15:01:04 -08:00
Jeff Boek e8972bb47d For #6795 - Auto shows toolbar when loading a new URL (#6955)
Co-authored-by: Severin <Baron-Severin@users.noreply.github.com>
2019-12-04 15:00:51 -08:00
ekager 3df32edff0 No issue: Fix search suggestions strings 2019-12-02 21:39:10 +00:00
ekager f227acc9f0 For #6791 - Inflate SavedLoginsListItemViewHolder layout explicitly 2019-12-02 10:40:58 -08:00
ekager d8babadf7f For #6889 - Check current destination before navigating from settings 2019-12-02 10:40:21 -08:00
ekager f5cf0b7e2a For #6890 - Don't crash with no connection when adding custom search engine 2019-12-02 10:37:31 -08:00
Severin Rudie 2a95a82e32
For #5540: updates error page copy when no internet is available (#6803) 2019-12-02 10:26:06 -08:00
cesar 6cda430cdd nested loop removed 2019-12-02 16:18:48 +00:00
cesar 4422e3ed39 Closes #6731 - fixed BookmarkNode minus operator and deleteOperation 2019-12-02 16:18:48 +00:00
mcarare 41ccb02933 For #6516 On browsing mode change empty tab list before displaying new list 2019-12-02 16:15:54 +00:00
Tiger Oakes a16aedb680 For #6827, #6811 - Cast layoutParams to MarginLayoutParams 2019-12-02 14:52:31 +00:00
Tiger Oakes d5e01384d8
Suppress upcoming deprecation (#6765) 2019-11-28 16:17:56 -08:00
Gabriel Luong 85111f538a For #6857 - Replace BackHandler with UserInteractionHandler in InflationAwareFeature and InflationAwareFeatureTest 2019-11-28 15:58:07 -05:00
Jeff Boek 1b1f9348dc No Issue - Fixes warnings / compiler errors with A-C update 2019-11-28 12:45:45 +01:00
mcarare c5f18e0f96 For #6629 Align Private Browsing mode to UX specs 2019-11-27 11:13:20 -08:00
ekager 7cd1d55e00 For #5586 - Track all login copy events 2019-11-27 10:59:36 -08:00
Will Hawkins a69253cf22 Issue #5183: Initialize megazord asynchronously
Thanks to the work of the team at application-services, it is possible
to asynchronously initialize the Http client and logger used by megazord
Use that power to hide the time necessary to complete this initialization
within the time that it takes to warmup the gecko runtime.
2019-11-27 10:51:57 -08:00
mcarare f69eb83141 For #4219 Set url view not important for accessibility
Talkback rectangle for url view selection will include parent view
2019-11-27 10:11:16 -08:00
mcarare 373bd63c40 For #6470 Remove actions from notification, keep just close private tabs
Removed NotificationsIntentProcessor because notifications no longer open app
Added new strings
2019-11-27 10:08:00 -08:00
Mihai Branescu 7cf71c8ef3
For #6396 - Added metrics for tracking history/bookmarks account sync toggles (#6601) 2019-11-27 11:16:23 +02:00
Mihai Adrian 4fd3aa8649
For #2570: Hide 3-dots menu for all library items when in select mode. (#6736)
notifyDataSetChanged to avoid not displayed but created items not being redrawn
2019-11-27 10:40:38 +02:00
Jeff Boek 5f7b3bd4d7
For #5972 - Fixes bugs when launching in private mode on Android 5 (#6702) 2019-11-26 14:53:03 -08:00
Sawyer Blatz db02fc6ef8
For #6821: Fixes issues with custom tabs and dynamic toolbar (#6822) 2019-11-26 13:02:52 -08:00
Mihai Adrian 33b49ff7fd For #6430 Private browsing hint width should not exceed screen dimensions (#6786)
Renamed ambiguous pop-up window name.
Adjusted code to match max line length.
2019-11-26 10:07:31 -08:00
Sawyer Blatz 769c1e422d For #5694 & #6054: Allows users to change toolbar position (#6608)
* For #5694 & #6054: Adds preference screen for toolbar

* For #5694: Adds changing toolbar position functionality

* No issue: Updates telemetry links to actually work lol 😬

* For #6054: Adds toolbar position to core ping
2019-11-25 16:43:32 -08:00
Tiger Oakes 422faaf7c0 Add toolbar helpers (#6531) 2019-11-25 15:36:47 -05:00
Tiger Oakes 7e8f079269
Use ShareData with ShareFragment (#6698) 2019-11-25 11:07:21 -08:00
Christian Sadilek 8271f0f55a Fix for A-C 23.0.0: onDownloadCompleted renamed to onDownloadStopped 2019-11-23 20:25:21 -05:00
Tiger Oakes cd3e077bc9 For #6763 - Fix early view access 2019-11-23 10:55:29 -05:00
Daphne Liu 4cfbaf2dc4 Switched to AC string extensions (#6258)
* Switched to AC string extensions

* Clean up imports
2019-11-22 23:15:51 -08:00
ekager 45071d6fc1 For #6573 - Fixes anchor view for tab switching snackbar 2019-11-22 14:15:17 -08:00
Sawyer Blatz bcf80d0e0b
For #6436: Adds snackbar for failed download (#6648) 2019-11-22 12:46:57 -08:00
Tiger Oakes a5e9439c6e Clean up tracking protection fragment (#6532)
* Clean up exceptions fragment

* Clean up tracking protection fragment

* Move saved logins to list adapter
2019-11-22 10:38:13 -05:00
Sebastian Kaspari 8a330d413c Closes #4982: Migrate Gecko files before initializing engine. (#6738) 2019-11-22 08:18:50 -05:00
Stephen Tsimicalis 9869408fb4 For #4824 - Fixes onboarding telemetry events from being sent a… (#6659) 2019-11-21 17:51:55 -08:00
Mihai Adrian e07d09afb8 Update app/src/main/java/org/mozilla/fenix/home/HomeMenu.kt
Co-Authored-By: Tiger Oakes <contact@tigeroakes.com>
2019-11-21 15:34:01 -08:00
mcarare 9258df2c69 For #3523 Add Firefox Sync error states also to Settings in Home menu 2019-11-21 15:34:01 -08:00
matthewcmckenna afac413c98 Add ETP accessibility labels 2019-11-21 15:27:35 -08:00
Tiger Oakes 0a86676563 For #6523 - Remove close button in library 2019-11-21 15:27:18 -08:00