1
0
Fork 0
Commit Graph

278 Commits (5839f5891c2c3e1a6621cfc99794417619404373)

Author SHA1 Message Date
Tiger Oakes cbd811dcfb Closes #1657 - Use Gecko for downloads (#4296) 2019-08-02 17:28:30 -07:00
Christian Sadilek 9887945296 For #4412: Only consume state change when UI initialized 2019-08-01 11:51:32 -04:00
Christian Sadilek 59c0005979 For #4412: SiteSecurityClickedListener set incorrectly 2019-07-31 19:52:53 -04:00
Christian Sadilek 76ed07bd5d Closes #4412: BrowserInteractor has not been initialized (#4414) 2019-07-31 09:14:05 -07:00
Sawyer Blatz 385dfd2f15
For #4376: Removes usage of selectedSessionOrThrow (#4381) 2019-07-30 12:39:58 -07:00
Colin Lee 9bc0122ce3
For #4359: findBookmarkedUrl blocks the main thread (#4362) 2019-07-29 17:01:02 -05:00
Sawyer Blatz 6fa022c2f8
For #4124: Migrate BrowserToolbar to Libstate (#4279)
* For #4124: Migrate BrowserToolbar to Libstate

* Restores QuickActionSheetReducer

* Improve tests

* Make QuickActionSheetController

* Finalize tests

* Breaks out QuickActionSheetState

* Fix comments

* Adds BrowserStoreTest
2019-07-29 12:39:36 -07:00
Tiger Oakes 87d8f3b037 Remove redundant super calls 2019-07-29 10:22:53 -07:00
Tiger Oakes c2e6e25bef Fixes #4005 - Move getColorFromAttr to Context 2019-07-26 16:44:11 -04:00
Christian Sadilek 1846a61475 For #4096: Use new A-C API to observe store / state changes
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
2019-07-26 10:40:33 -04:00
Sawyer Blatz 7588251f8b
Closes #3986 & Closes #3661: Migrate QuickActionSheet to LibState & add tests (#4058)
* Closes #3986: Migrate QuickActionSheet to LibState

* Closes #3661: Add tests for QuickActionSheet

Co-authored-by: boek <jeff@jeffboek.com>

* For #3986: Fix feedback
2019-07-22 10:31:31 -07:00
Emily Kager fc2bff0fde For #4145 - Remove anchor view from fullscreen snackbar (#4160) 2019-07-19 11:18:47 -07:00
Emily Kager 9f40c25c75 For #4143 - Allow user to rotate to other landscape orientation 2019-07-19 14:12:33 -04:00
Jonathan Almeida d298b5f2f5 Closes #4075: Add Feature Flag class (#4077) 2019-07-18 17:20:12 -07:00
Sawyer Blatz e544827e83 For #2267: Adds telemetry for reader mode (#3941) 2019-07-18 15:17:15 -07:00
Tiger Oakes 981b6b5b02 For #4124 - Remove browser toolbar editing code 2019-07-18 15:40:33 -04:00
James Hugman 62850430b7 Closes AC#3695 - Add UI to open current page in external app 2019-07-18 15:33:31 -04:00
Emily Kager 9ab67557cf For #4078 - Request landscape mode when entering fullscreen 2019-07-17 16:06:37 -07:00
James Hugman 90dd0ab469 Closes #4114 - Re-enable app-links 2019-07-17 10:39:17 -07:00
Colin Lee 8855af2234
For #3615: Long pressing the address bar should not copy link (#4083) 2019-07-16 13:42:05 -05:00
Sebastian Kaspari 9b1e63224c Closes #4052: Remove pending intent workaround. (#4059)
Previously we needed to set a static launch function to be invoked when the find in page
integration should be launched. Now we can access the integration class directly and
can avoid the static property that caused issues when used by multiple activities.
2019-07-15 14:15:59 -05:00
Sebastian Kaspari e4e0d45c1b Closes #3996: Remove workaround for opening custom tab in browser.
`EngineView` now allows releasing the `Session` so that it can be rendered by an
other `EngineView` instance.
2019-07-15 10:52:57 +02:00
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
Emily Kager 21c75ca1bb For #3478 - Add Tab sent snackbar confirmation for device sharing 2019-07-10 14:13:10 -04:00
ekager 57ca75139b For #3201 - Update bookmark state when session selected 2019-07-03 11:38:14 -07:00
Emily Kager ce2d597af3 For #203 - Adds find in page and request desktop site to custom tab menu (#3835) 2019-07-02 14:41:29 -07:00
Sawyer Blatz ece0e30655
For #2054: Collapses quick action bar when opening find in page (#3837) 2019-07-02 08:22:34 -07:00
Sawyer Blatz 7e46e71d00 For #3005: Closes tabs when saving to collection (#3723) 2019-07-01 11:39:48 -05:00
ekager 7fa4cf4487 Use sessionId in FIP Integration, use pendingIntent for startActivity 2019-06-28 14:00:59 -07:00
ekager 6d0a4fdb4d Revert "For #3609 - Remove FIP Integration, Use FIP Feature"
This reverts commit 428643d598e938f58a2fe4abfee417c46edec167.
2019-06-28 14:00:59 -07:00
Sawyer Blatz 66eb4fd03b No issue: Fixes master compilation 2019-06-27 09:05:57 -07:00
Tiger Oakes d01bb8c442 Use lifecycleScope for collections fragments 2019-06-25 13:56:15 -07:00
Emily Kager 084fab77d4 For #3609 - Remove FIP Integration, Use FIP Feature (#3637) 2019-06-24 15:31:32 -07:00
Emily Kager ac5c4a0f79 Closes #3493 - Show tab saved to collection snackbar in BrowserFragment 2019-06-14 15:49:56 -07:00
Jeff Boek 7ebdfcc87b For #1116 - Uses alias link for help 2019-06-14 15:33:34 -07:00
Jeff Boek 5540230e3d For #1116 - Changes help link (#3491) 2019-06-14 15:29:10 -05:00
Colin Lee d5c5587a0c
For #3209: Disable shared element animations for crash temporarily (#3482) 2019-06-14 12:13:13 -05:00
Sawyer Blatz 381a5e6089 For #3403: Subscribes to tab collections in BrowserFragment 2019-06-12 16:44:35 -07:00
Colin Lee 66a836cf3a
For #3314: Toolbar and QAB unresponsive after Android 6 perms check (#3373) 2019-06-12 10:08:39 -05:00
Emily Kager 71f2b0bdaa For #2253 - Use toolbar as anchorView with fullscreen snackbar 2019-06-11 15:09:07 -07:00
Christian Sadilek ccc7c70967 For #3252: Reader mode appearance buttons are not visible in PB
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2019-06-11 18:02:29 -04:00
jhugman 26d0ddda98 Fixes #3358 - disable feature-app-links (#3359) 2019-06-11 16:34:28 -05:00
Gabriel Luong f05eb032d4 For #2684: Add an extension function Session.toTab to map Session to Tab and clean up their usage 2019-06-11 13:14:23 -07:00
Sawyer Blatz decacbfc97 For #3323 Runs PublicSuffixList synchronously 2019-06-11 09:19:51 -07:00
Emily Kager 975975e789 For #3326 - Remove open image in tab from context menu (#3327) 2019-06-11 08:59:00 -05:00
Tiger Oakes 82d2a0661b Remove deprecatd support-ktx methods (#3305) 2019-06-10 09:12:11 -05:00
Emily Kager bf4916418a For #1998 - Removes stable flag in entering fullscreen navigation 2019-06-07 15:20:30 -07:00
Sawyer Blatz 45c509fbce
For #2648: Updates trimming of url hostname (#3191)
* For #2648: Updates trimming of url hostname

* For #2648: Fix nits
2019-06-07 09:33:07 -07:00
Colin Lee 1e6da54263 For #3238: fixes race condition crash, nav destination unknown 2019-06-06 15:46:34 -07:00
Jonathan Almeida 0a3b001abe For #3167: Show help page in browser menu (#3230) 2019-06-06 16:55:15 -05:00
Emily Kager 93a5456785 For #2253 - Shorten Fullscreen snackbar length (#3190) 2019-06-05 20:36:13 -05:00
Sawyer Blatz 0b3a8b7a54 For #2316: Adds confirmation dialog to delete bookmark 2019-06-04 14:47:11 -07:00
Emily Kager ef0618a3d1 For #3103 - Exit fullscreen on pause (#3112) 2019-06-04 10:36:16 -05:00
Colin Lee 04a759f0b0
For #2693: Launching Fenix via adb with URL crashes (#3099) 2019-06-03 16:24:37 -05:00
Tiger Oakes 94c4013810 Closes #3091 - Hide Pull to Refresh under flag (#3092)
This was merged in after feature freeze so we're pulling it out for
now. Pull to refresh will continue to work in debug mode so that the
design can be iterated on easily.
2019-06-03 14:10:53 -05:00
Colin Lee 04bbeb5ae6 For #3073 'Open in Firefox Preview' no longer opens in app
Saving and restoring the custom tab session ID fixed one problem while causing another. I added code to only restore the ID if the session has a customTabConfig associated.
2019-06-03 10:04:17 -07:00
ekager d285e799b9 Clean up logic to return margin pairs for readability 2019-06-03 10:00:00 -04:00
ekager 14fe356d62 For #2794 - Adjust engine margins when enter/exit fullscreen 2019-06-03 10:00:00 -04:00
ekager 98a40aabd7 For #2223 , For #371 - Replace Toolbar with FIP when opened 2019-06-01 10:24:55 -07:00
Colin Lee 532483498a
No issue: Store the Custom Tab Session ID to avoid a crash (#3062) 2019-05-31 17:03:58 -05:00
Emily Kager 0327b1146b For #2977 - Update add new collections flow (#2991)
* For #2977 - Update add new collections flow

* Rename shared elements to be more general

* Make tab list not clickable in other modes

* For #2577 - Stop Flickering in List

* Add extensions function for next step with collections list size
2019-05-31 12:59:51 -05:00
James Hugman 060cd646c8 Fixes #1570 - Enable app-links feature 2019-05-31 10:39:47 -07:00
Emily Kager 1bb4d72fd1 For #3027, For #2858 Pass in Fenix Snackbar for Context Menu Candidate (#3028) 2019-05-31 10:16:08 -05:00
Jonathan Almeida ab39a5088a For #2052: Fix BrowserToolbar overlapping web content 2019-05-30 20:40:56 -04:00
Jeff Boek f9d70dbc92 For #2723 - Creates callbacks to wire up the mode and theme manager together 2019-05-30 16:38:31 -07:00
Jeff Boek a7d5cdcb9d For #2723 - Fixes theme manager 2019-05-30 16:38:31 -07:00
Emily Kager 18cd9e58f9 Fixes Crash: Pop up to Browser Fragment if exists when coming from Search 2019-05-30 16:30:06 -07:00
Emily Kager 8dbed67f7f No issue: Simplify and speed up shared element transitions 2019-05-30 16:30:06 -07:00
Emily Kager 43a961fe73 For #1973 - Toggle QR button on deny permissions, fix engineView crashes 2019-05-30 16:06:37 -07:00
Tiger Oakes 74dd2a5f23 Issue #103 - Pull to refresh (#3020) 2019-05-30 17:05:49 -05:00
Sawyer Blatz 9e0e5d95d9 For #2931: Show browser snackbar above quick action sheet 2019-05-30 14:52:09 -07:00
Emily Kager 3685b05586 For #3011 - Size EngineView for Custom Tab Fixed Toolbar 2019-05-30 12:40:54 -07:00
Emily Kager c027feecd0 For #3011 - Size EngineView for Custom Tab Fixed Toolbar 2019-05-30 12:40:54 -07:00
Emily Kager 3560e1793c For #2980 - Pop to home if no session exists in Browser Fragment 2019-05-30 09:05:10 -07:00
Emily Kager 8181705b58 Init Toolbar in edit mode so we don't see the flash 2019-05-29 12:27:48 -07:00
Emily Kager 039990f608 For #2972 - Call session feature back press before custom tab back press 2019-05-29 09:40:52 -07:00
Emily Kager 6290d7b890 For #2110 - Pressing back on external link should close the tab 2019-05-28 17:55:17 -07:00
Emily Kager cae95c0ee1 For #2952 - Delete All Tabs should run on Main Thread 2019-05-28 16:25:39 -07:00
Arturo Mejia b5d1d04d88 Closes #2900: Fix crash when trying to show site info panel with
a null session.
2019-05-28 15:05:49 -07:00
Arturo Mejia ba6bb916e4 Closes #2789: Custom tabs is not covering the full screen size. 2019-05-28 15:01:18 -07:00
Emily Kager 2ad6875f09 No issue: Correct material dependency and anchor snackbar above toolbar 2019-05-24 17:38:20 -07:00
Emily Kager 4e13de3ffd No issue: Register observers with owner view 2019-05-24 10:53:05 -07:00
Emily Kager a676e964b5 For #966 - Preserve CustomTab history when opening in browser 2019-05-24 10:50:20 -07:00
ekager 2f46345954 Cancel pending findBookmarkJob if another is started 2019-05-24 09:42:22 -07:00
Emily Kager 4b7c8a7db1 For #2228 - Update Bookmark Status in onUrlChanged 2019-05-24 09:42:22 -07:00
Emily Kager 074eec7006 For #2815 - Use RootView for displaying snackbar in browserfragment (#2816) 2019-05-23 23:35:05 -07:00
Emily Kager 40f2fe5166 For #1287 - Create animation for opening and closing tab from home 2019-05-23 13:41:00 -07:00
Jonathan Almeida eb7646f073 Add custom share sheet and send tab support (#2757)
* Closes #2751: Add custom app share sheet

* Closes #2753: Add send tab devices to share sheet

* Closes #2752: Add build flag for send tab

* Replace Context.share with ShareFragment
2019-05-23 10:48:22 -07:00
Sawyer Blatz 87df0a8103 For #2728 & #2729: Uses view model selected tabs for collection creation (#2748) 2019-05-23 10:46:54 -07:00
Sawyer Blatz 763c8be815 For #2689: Turns dynamic toolbar into fixed toolbar 2019-05-23 08:37:00 -07:00
Sawyer Blatz afbe397f94 For #1575: Enables adding tabs to existing collection 2019-05-21 09:39:55 -07:00
Emily Kager e534dad199 For #2028 - Pass Session ID for Custom Tab Prompts, Theme Dialogs 2019-05-20 19:24:48 -07:00
Jeff Boek b54628210b For #2414 - Fixes custom tab crash 2019-05-20 16:09:37 -07:00
Jonathan Almeida 2035be8cc6 Closes #2097: Stop video playback when custom tab closes 2019-05-17 16:24:40 -07:00
Sören Hentzschel 6bc577eecd For #1800 - "report site issue" should open in a new tab 2019-05-16 22:28:02 -07:00
Sawyer Blatz 72d29c2a43
For #2205 & #1578: Integrates tab collection storage (#2478)
* For #2205: Adds TabCollectionStorage

* For #1578: Adds delete to TabCollection
2019-05-16 14:02:24 -07:00
Emily Kager 43843b0fb3 For #2561 - Dynamically set EngineView behavior in BrowserFragment 2019-05-16 11:22:14 -07:00
Sawyer Blatz 0b7df74731
For #2315 & For #2494: Adds scrolling to custom tabs (#2521) 2019-05-15 09:37:05 -07:00
Jeff Boek c5e5ef4b25
Teases apart ViewModel dependencies (#2499)
* No Issue - pulls render outside of the viewmodel

* No Issue - Properly subscribes to the changesObservable

* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
Emily Kager c2a3c844b8 For #2035 - Register Accessibility Manager Listener (#2462) 2019-05-14 14:34:01 -07:00