1
0
Fork 0
Commit Graph

3554 Commits (3e8836f71a96ffd17fa689877d4c621a6ca64c1b)

Author SHA1 Message Date
Codrut Topliceanu 8c43935ba3
For #7978 - Put views above button in scrollView (#8819) 2020-04-02 10:13:32 -07:00
Gabriel Luong dc6d479da3
For #6174 - Add telemetry for WebExtensions (#8318) 2020-04-02 10:12:31 -07:00
Mihai Adrian 7043f9ee4e
For #9604: Swap and adjust margin with padding to avoid text being cut (#9617) 2020-04-02 09:40:29 -07:00
Gregory Mierzwinski b4a20f658d
Bug 1625971 - Add google-search-restaurants to pageload tests in browsertime. (#9622)
* Add google-search-restaurants to pageload tests in browsertime.

* Temporarily change the activity to pass tests.

* Change Raptor Fenix activity name.

* Remove test trigger for browsertime test.
2020-04-02 18:29:23 +02:00
MickeyMoz 0c0b7b30a8 Update Android Components version to 38.0.20200402130113. 2020-04-02 11:44:11 -04:00
Michael Comella f1159f3558 No issue: remove assertJ.
It was only used for 3 checks so it's not worth having a dependency on
it.
2020-04-02 07:57:19 -07:00
Michael Comella c15a005ca8 No issue: remove unused FirefoxTestRunner.
It would be used for on device tests but it doesn't seem to hooked up
currently.
2020-04-02 07:57:09 -07:00
MickeyMoz 34fb49aac8 Update Android Components version to 38.0.20200401130040. 2020-04-02 13:43:34 +03:00
Mozilla L10n Automation Bot 202172cd04 Import l10n. 2020-04-02 13:42:58 +03:00
mcarare fac61fbb41 For #9422: Nit: Fix xml indenting 2020-04-02 09:11:31 +03:00
mcarare 4d0b37a3b8 For #9422: Align widget text to viewStart to support RTL layouts 2020-04-02 09:11:31 +03:00
Emily Kager 327009efc4
For #768: Add first time PWA dialog (#9308)
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
2020-04-01 22:56:12 -04:00
Sebastian Kaspari 045b4a5715 Use same configuration for "forPerformanceTest" builds like we do for "fennec" flavor builds. 2020-04-01 17:51:32 -07:00
Aaron Train 8b34f372b0
Closes #9433: Update Flank version in ui-tests Dockerfile (#9466)
fix: flank_snapshot requires direct shard value

-1 shards -> 50 shards

fix: adjust flank-x86.yml shard value

try old results generator in flank-x86.yml

fix: legacy-junit-report -> legacy-junit-result

revert to modern reporting
2020-04-01 15:43:45 -07:00
David Walsh 26137f63a2
Prevent favicons from flashing when items are selected in History (#9233) 2020-04-01 15:43:21 -07:00
Emily Kager b94ac93ce9
Upgrade to detekt 1.6.0 (#9306)
Changelog:

https://arturbosch.github.io/detekt/changelog.html

Fixes #7360.  Also use more exact test glob.

Co-authored-by: Andrew Gaul <andrew@gaul.org>
2020-04-01 15:42:46 -07:00
Mihai Adrian 8cd6d7460c
For #9336 Check current destination before navigating (#9353)
* For #9336 Check current destination before navigating

* For #9336 Update unit test to check for navigateSafe
2020-04-01 15:36:56 -07:00
Mihai Adrian 90787cf630
For #9423: Align preference title and summary to viewStart (#9426)
* For #9423: Align preference title and summary to viewStart

* Update checkbox_left_preference_etp.xml

Co-authored-by: Jeff Boek <jeff@jeffboek.com>
2020-04-01 15:36:01 -07:00
ekager fd60270da8 For #9533 - Switch to using enum for Library Item Selected Telemetry 2020-04-01 15:29:08 -07:00
Grisha Kruglov 8d3d030feb Closes #9553: Only update account UI state once when creating SettingsFragment 2020-04-01 15:28:39 -07:00
ekager 96c6401457 For #8125 - Send top sites count with metrics ping 2020-04-01 15:27:39 -07:00
mcarare 8c398c86ef For #9365: Partially reverse menu items order when using top toolbar 2020-04-01 15:21:22 -07:00
mcarare b119700820 For #9365: Update naming to reflect history item 2020-04-01 15:21:22 -07:00
Kate Glazko cca3dae290 NoIssueFixMetropolisAccountPref 2020-04-01 15:13:03 -07:00
Sawyer Blatz 208a58bc58
Issue #9598 & #8697: Fixes force expand crash (#9599) 2020-04-01 12:32:00 -07:00
codrut.topliceanu 3d1d146c94 For #9549 - Scrolling to top sites now includes header. 2020-04-01 10:28:04 -07:00
mcarare a2ea53d8f2 For #9574: Remove category layout from LeakCanary SwitchPreference 2020-04-01 10:17:21 -07:00
ekager 4159cd3da7 Closes #9564 : Fixes cut off strings in ETP panel 2020-04-01 10:16:51 -07:00
Johan Lorenzo 44432d281e
Bug 1622339 - Move android-sdk installation into a toolchain task (#9394) 2020-04-01 18:29:35 +02:00
Mihai Branescu 24596fd3cd For #9109 - remove the sync error highlight from three-dot menu 2020-04-01 10:42:00 +03:00
Kate Glazko d9d5de98c9 For 3687 Use Metropolis Font for Header 2020-03-31 19:31:15 -07:00
Mozilla L10n Automation Bot 9043120dd7 Import l10n. 2020-03-31 17:52:51 -07:00
Grisha Kruglov 54b7fd8834 Make sure reconnect item is displayed in HomeMenu in case of account problems
AccountObserver listeners were being triggered correctly, however, during every time
we open HomeFragment, home menu gets re-created, which causes us to re-run the initialization
block. Before this patch, the init block would never touch the account manager.
After this patch, it will query it if account manager has already been initialized.
2020-03-31 16:07:35 -07:00
Grisha Kruglov 60943df6d9 Closes #9561: Fix initialization order in HomeMenu
`init` blocks are executed before `val` initialization which is declared afterwards
in the class. In this case, we had `quitItem` and `reconnectToSyncItem` as lazy,
but declared after the `init` block which may need them. And so, while this compiles
just fine, in practice we run into an NPE as the `init` block tries to get the lazy's value.

Simply re-ordering initialization fixes the problem.
2020-03-31 16:07:35 -07:00
Arturo Mejia 804eb0f5ba For issue #8520: Polish Add-on manager UIs 2020-03-31 17:20:20 -04:00
Sawyer Blatz 1a2b65d854
Issue #9472: ForceExpand browser toolbar when navigating (#9552) 2020-03-31 11:16:40 -07:00
Oana Horvath 5f68d6cb29
Updated the method to verify system notifications and added new tests for media notifications (#9330) 2020-03-31 21:11:41 +03:00
ValentinTimisica cee34893ed
For #8412: Passes error handling function to 'CustomTabWindowFeature' (#8903)
* For #8412: Passes error handling function to 'CustomTabWindowFeature'

Change required for showing error message when the app can't handle a specific
scheme. Implemented in AC:
https://github.com/mozilla-mobile/android-components/pull/6122

* Upgrade AC version

Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2020-03-31 10:17:29 -07:00
Grisha Kruglov f76acc5db1 Closes #9530: Don't crash on failed avatar fetches 2020-03-31 09:17:17 -07:00
Mozilla L10n Automation Bot fd263d8329 Import l10n. 2020-03-30 22:00:19 -07:00
Grisha Kruglov 6c38b77315 Part 6: Kick-off account manager initialization after visual completeness
In order to hide the time it takes for the account manager to be initialized
(which always involves disk IO, and often network IO), let's kick it off
after "visual completeness".
This makes sure that for most users, by the time they interact with the account
manager-related functionality (e.g. in Settings), it's ready to go.

Also, for signed-in users, this will establish background sync workers.
2020-03-30 21:43:38 -07:00
Grisha Kruglov 057e28d4e4 Part 5: Refactor HomeMenu<->HomeFragment interaction
This refactor "reverses" relationship between these two classes, allowing
HomeMenu to inform its parent, HomeFragment, of any changes to the menu.

Once that's in place, we start observing account manager changes (once its ready)
for account problems.

This solves two problems:
- initialization of the account manager is no longer necessary to build a home menu
- home menu now starts observing changes to the account manager's state (before it was static)
2020-03-30 21:43:38 -07:00
Grisha Kruglov 029fae4559 Part 4: Make sure 'sync is on' snackbar does not initialize account manager 2020-03-30 21:43:38 -07:00
Grisha Kruglov eb98df4edd Part 3: Mark accountManager as 'lazy' in Mode.kt
This is enough to cause it to be initialized only if we're going through onboarding.
2020-03-30 21:43:38 -07:00
Grisha Kruglov 3efaa516ca Part 2: Do not eagerly initilize account manager within HomeActivity
Instead of always kicking off accountManager's init and telling it to sync right away in
'onResume', we move these tasks to some abstract point later on, whenever account manager
is available.
2020-03-30 21:43:38 -07:00
Grisha Kruglov 0677fc35de Part 1: Add 'accountManagerReady' queue to BackgroundServices
This gives us an ability to perform tasks against 'accountManager' without
causing its immediate initialization.
2020-03-30 21:43:38 -07:00
Grisha Kruglov be1fa8df7d Pre: introduce a RunWhenReadyQueue
This replaces the StartupTaskManager we had with a more general class.
New implementation is a thread-safe "gated task executor", which either
runs the task right away if it's marked as 'ready', or queries it to be
executed later on.

This ability to either execute or queue a task will be useful later on in the
commit series.
2020-03-30 21:43:38 -07:00
Aaron Train 4d139d52c4
Closes #9189: Fixes "static asset not found" error in doNotSaveLoginFromPromptTest, saveLoginFromPromptTest UI tests (#9439)
AndroidAssetDispatcher class dispatcher was attempting to open a local asset with a query suffix from the request. If query suffix is found, remove it. Re-enable saveLoginFromPromptTest() and doNotSaveLoginFromPromptTest()
2020-03-30 18:01:58 -04:00
David Walsh 9679b91e82 For #9525 - Add bottom margin to top sites header 2020-03-30 14:48:45 -07:00
Sawyer Blatz 4ac29530cd
Issue #9132: Update to search animation for top toolbar (#9524)
* let animation in top toolbar mode play nicely.

* remove duplicate methods, make code readable.

* migrate getToolbarNavOptions method to BrowserAnimator, one method to rule them all.

* Update linting

Co-authored-by: ahmedmamdouh13 <ahmedmamdouh13196@gmail.com>
2020-03-30 12:07:00 -07:00