blallo
/
fenix
1
0
Fork 0
Code Releases Activity

No issue: remove assertJ. 

It was only used for 3 checks so it's not worth having a dependency on
it.
master
Michael Comella 2020-04-01 17:32:25 -07:00 committed by Michael Comella
parent c15a005ca8
commit f1159f3558
3 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
buildSrc/src/main/java/Dependencies.kt
View File

@ -39,7 +39,6 @@ object Versions {
const val installreferrer = "1.0"
const val junit = "5.5.2"
const val assertJ = "3.13.2"
const val mockito = "2.24.5"
const val mockk = "1.9.kotlin12"
const val assertk = "0.19"
@ -207,6 +206,5 @@ object Deps {
const val detektTest = "io.gitlab.arturbosch.detekt:detekt-test:${Versions.detekt}"
const val junitApi = "org.junit.jupiter:junit-jupiter-api:${Versions.junit}"
const val junitParams = "org.junit.jupiter:junit-jupiter-params:${Versions.junit}"
const val assertJ = "org.assertj:assertj-core:${Versions.assertJ}"
const val junitEngine = "org.junit.jupiter:junit-jupiter-engine:${Versions.junit}"
}

1
mozilla-detekt-rules/build.gradle
View File

@ -8,7 +8,6 @@ dependencies {
implementation Deps.kotlin_stdlib
testImplementation Deps.junitApi
testImplementation Deps.junitParams
testImplementation Deps.assertJ
testRuntimeOnly Deps.junitEngine
}

11
mozilla-detekt-rules/src/test/java/org/mozilla/fenix/detektrules/MozillaBannedPropertyAccessTest.kt
View File

@ -6,7 +6,8 @@ package org.mozilla.fenix.detektrules
import io.gitlab.arturbosch.detekt.test.lint
import io.gitlab.arturbosch.detekt.api.YamlConfig
import org.assertj.core.api.Assertions.assertThat
import org.junit.jupiter.api.Assertions.assertEquals
import org.junit.jupiter.api.Assertions.assertTrue
import org.junit.jupiter.api.DisplayName
import org.junit.jupiter.api.Test
import org.junit.jupiter.params.ParameterizedTest
@ -22,8 +23,8 @@ internal class MozillaBannedPropertyAccessTest {
MozillaBannedPropertyAccess(YamlConfig.loadResource(this.javaClass.getResource("/config.yml"))).lint(
NONCOMPLIANT_ACCESS.trimIndent()
)
assertThat(findings).hasSize(1)
assertThat(findings[0].issue.description).isEqualTo(DESCR)
assertEquals(1, findings.size)
assertEquals(DESCR, findings[0].issue.description)
}
@DisplayName("compliant ")
@ -34,7 +35,7 @@ internal class MozillaBannedPropertyAccessTest {
MozillaBannedPropertyAccess(YamlConfig.loadResource(this.javaClass.getResource("/config.yml"))).lint(
source
)
assertThat(findings).isEmpty()
assertTrue(findings.isEmpty())
}
companion object {
@ -78,4 +79,4 @@ const val COMPLIANT_ACCESS = """
}
}
}
"""
"""