Kainalu Hagiwara
1ad9da09b0
Remove selection holder from bookmark viewholder constructors.
...
Now that we're passing the mode to the viewholders in their bind
methods, there's no real need to pass them into their constructors. This
also allows us to remove the indirection of having the adapter implement
the SelectionHolder interface and have the mode implement it directly.
2020-08-14 13:03:08 -07:00
Kainalu Hagiwara
b1db1cf976
Add tests for Bookmarks DiffUtil and ViewHolders.
2020-08-14 13:03:08 -07:00
Kainalu Hagiwara
6d8cfe1a50
For #13156 , #13280 - Use payloads to bind bookmark viewholders.
...
Change the DiffUtil callback for bookmarks to use the generated equals()
method instead of only checking the title and url fields. This prevents
the BookmarkNode in our state from getting out of sync with the
BookmarkNode the viewholder is bound to.
2020-08-14 13:03:08 -07:00
ankur
dd5bb94f8c
For #13301 , #13038 : hide overflow menu for all bookmark items in selected mode
2020-08-06 09:51:56 -07:00
Kainalu Hagiwara
cd2532349d
For #12551 - Implement swipe to delete for bookmarks.
2020-07-20 14:54:20 -07:00
Afzal Najam
b9656a978e
Hide add folder option when in Desktop Bookmarks folder
2019-12-13 17:51:15 -08:00
Tiger Oakes
284cbab9ea
Use .orEmpty()
2019-09-17 11:09:21 -07:00
Sebastian Kaspari
76063e307a
Rename BookmarkStore/State/Action to BookmarkFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Emily Kager
8194e0778e
For #4026 - Update BookmarkDiffUtil to update on Title or URL change
2019-08-07 00:37:16 -04:00
Tiger Oakes
3c1ce90f6f
Fixes #2379 - Generic library selection
2019-08-06 11:10:50 -07:00
Tiger Oakes
6e2ea0750e
Issue #2379 - Use LibrarySiteItemView in history
2019-08-02 17:15:41 -07:00
Colin Lee
33e881ca8a
For #1539 : Only allow delete when folders multi-selected ( #4062 )
2019-08-02 10:11:21 -07:00
Tiger Oakes
2467588c4a
Create shared custom view for library items
2019-07-30 12:26:15 -04:00
Tiger Oakes
88c05a5f43
Use glide-like image loading function
2019-07-29 10:22:23 -07:00
Colin Lee
3dc20543e3
For #4128 : Migrate Bookmarks to LibState ( #4254 )
2019-07-25 21:55:51 -05:00
Tiger Oakes
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
Emily Kager
9e7282cf18
For #1949 - Fixes bookmark separator appearance, removes menu ( #3957 )
2019-07-10 14:23:35 -05:00
Colin Lee
15d887e41f
For #2251 - Add bookmark adapter diffutil ( #3936 )
...
* For #2251 - Add bookmark adapter diffutil
* For #2251 - Fix unit tests for bookmark adapter diffutil
2019-07-08 14:00:25 -05:00
Tiger Oakes
8cd1a0cb38
Move adapter Job setup code to helper class ( #3407 )
2019-07-01 13:34:25 -05:00
Tiger Oakes
606e66219c
No issue: Use chains for bookmark items ( #3696 )
...
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2019-06-27 13:47:42 -07:00
Tiger Oakes
4994554576
No issue: Adds lint exception for when statement ( #3685 )
2019-06-26 15:52:24 -07:00
Colin Lee
22bcd70edc
For #3213 : Fix multi-select bookmarks on return to fragment ( #3413 )
2019-06-24 10:10:49 -07:00
Arturo Mejia
5df726715f
Revert "For #3008 , For #2162 Add Simple Logic for Menu Orientation" ( #3310 )
...
#3114
2019-06-10 10:58:18 -05:00
Emily Kager
dc0d153580
For #3008 , For #2162 Add Simple Logic for Menu Orientation ( #3114 )
...
* For #3008 - Adjust orientation of collections menu based on view location
* For #2162 - Add simple menu orientation logic to bookmark menu
2019-06-04 10:37:57 -05:00
Jeff Boek
a7d5cdcb9d
For #2723 - Fixes theme manager
2019-05-30 16:38:31 -07:00
Harsh Shandilya
7d9c8726c5
treewide: Resolve compilation warnings ( #2859 )
...
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-05-27 19:04:17 +02:00
Sören Hentzschel
04e28096b2
fixed wrongly named variable
2019-05-23 08:22:34 -07:00
Sören Hentzschel
56dec1ebfb
fixed linting issues
2019-05-23 08:22:34 -07:00
Sören Hentzschel
cc03aeb9f0
For #2435 - adds URL to bookmarks in library
2019-05-23 08:22:34 -07:00
Sebastian Kaspari
291df48c4e
Install the "icons" WebExtension to automatically load icons for every visited website.
2019-05-20 19:34:49 -07:00
Colin Lee
a4c201f2ee
For #1870 : Copy bookmark folder does nothing ( #2193 )
2019-05-01 12:21:13 -05:00
Emily Kager
41bbc1ad2b
Closes #2163 - Check if bookmark title is null or blank
2019-04-30 14:33:42 -07:00
Colin Lee
688cae33c3
For #1877 : Crash on edit or delete the default bookmark folders
2019-04-25 13:01:45 -07:00
Emily Kager
2162e74f76
Closes #1948 - Shows bookmark url if title is null
2019-04-23 16:05:01 -07:00
Sawyer Blatz
41e8acf05f
For #724 : Adds contrastText color for buttons using accent backgrounds
2019-04-23 09:57:54 -07:00
Colin Lee
12614e0142
For #1555 : Bookmark Overflow menu tap area should be larger
2019-04-19 08:09:26 -07:00
Sawyer Blatz
3b3d4c3de5
Fixes #1646 : Changes bookmarks toolbar color ( #1651 )
2019-04-16 08:03:22 -07:00
Colin Lee
bc1b7e0b43
For #1539 : Add bookmark multi-select features
2019-04-12 13:35:28 -05:00
Colin Lee
b54d4d1d58
Closes #1312 , #1236 , #1237 , #1238 , #1239 : Creating, Editing, and Deleting Bookmarks and Bookmark Folders
2019-04-08 14:48:36 -05:00
Jeff Boek
31bfba3bd8
No issue - update to A-C 50
2019-04-02 15:35:23 -07:00
Colin Lee
bd81e72239
Fixes #916 , fixes #917 , fixes #920 : Save, share, and delete bookmarks
2019-04-01 16:16:08 -05:00