f728cdaf05
Bug 7189 - Provide page title in website information dialog ( #7255 )
...
* Bug 7189 - Provide page title in website information dialog
* Update QSFS test
* Fix Tiger's nits
2020-01-30 11:24:53 -08:00
94447657c4
No issue: Fixes strings for data migration
2020-01-30 11:29:50 +01:00
24396d174f
For #6980 : Add What's new card ( #7952 )
2020-01-29 08:50:11 -08:00
b3d99c6bba
For #7679 - Replaced comparison by reference with value, added check for default in order to avoid double checkmark (example: default + English) ( #7729 )
2020-01-28 19:22:04 +02:00
8a7c7fd06f
For #7730 - always show "Add private browsing shortcut" in sett… ( #7943 )
2020-01-27 08:44:28 -08:00
154e11841a
Fixes #7881 : Send telemetry event when custom search engine is deleted
2020-01-27 12:04:28 +02:00
18244cef51
Closes #7762 : Initialize Glean later in Fennec builds.
2020-01-26 11:53:26 +01:00
40e72a7b28
For #7524 : Remove DeviceConstellation polling from onResume ( #7908 )
2020-01-25 11:04:24 -08:00
622fdadde8
For #7272 : Show info when saved logins list is empty. ( #7891 )
...
* For #7272 : Show info when saved logins list is empty
* For #7272 : Updated unit tests
2020-01-24 18:13:44 -08:00
5e9b753acb
For #7473 , delay inflation of toolbar
...
Improve performance of HomeActivity.onCreate by delaying this inflation.
We use a ViewStub and inflate the first time the actionbar is accessed.
2020-01-24 15:21:42 -08:00
f93e141d52
For #7525 - Add telemetry for opening a top site in normal and private mode and removing a top site
2020-01-24 15:18:25 -08:00
192eecdf5b
For #6758 - Part 7: Add menu for opening a top site in private tab and removing a top site
2020-01-24 15:18:25 -08:00
9ecb67e783
For #6758 - Part 6: Add top site view
2020-01-24 15:18:25 -08:00
f68f89f2bf
For #6758 - Part 5: Add top sites to the HomeFragmentStore
2020-01-24 15:18:25 -08:00
e1863dd3c2
For #6758 - Part 4: Implement "Add to Firefox Home" browser menu item
...
- The "Add to Firefox Home" browser menu item adds a top site to the top site storage.
- Refactors the FenixSnackbar from BaseBrowserFragment into BrowserToolbarController
since there are multiple menu items that need to show a FenixSnackbar.
- Adds metrics for the new browser menu item.
2020-01-24 15:18:25 -08:00
9ddf93eb7d
For #6758 - Part 3: Add TopSiteStorage wrapper around AC's TopSiteStorage
...
This follows the existing pattern around TabCollectionStorage.
2020-01-24 15:18:25 -08:00
9a15103a20
Issue #7762 : Enable glean based on setting for non-fennec builds.
2020-01-23 16:32:15 +01:00
44e4d8e12c
No issue: clarify naming for showing a prompt to allow search suggestions ( #7870 )
2020-01-22 19:08:07 -08:00
a39a9e5b4e
No issue: Enable about:config in beta builds
2020-01-22 16:34:51 -08:00
1ee0243efa
Fix 4021 - Provide tab title during share
2020-01-22 14:42:27 -08:00
c556e819bd
For #5586 - Add telemetry for save logins setting
2020-01-22 14:19:12 -08:00
7adb5b6084
For #6812 - Navigate via openToBrowser to selected session from search
2020-01-22 14:13:16 -08:00
e1722b95b3
No issue: Fixes ErrorResponse instantiation
2020-01-22 11:47:51 -08:00
310da6c1ea
No Issue: Add support for deleting individual tracking protection
...
exceptions on nightly.
2020-01-22 11:47:51 -08:00
f726b03792
Fix breaking changes from new TrackingProtectionException
2020-01-22 11:47:51 -08:00
20396f78a9
For #7698 : Adds search back button animation ( #7840 )
...
* For #7698 : Adds search back button animation
* Refactor for searchController
2020-01-22 11:15:30 -08:00
e25ee98d7d
No issue: fix typo in Performance.instrumentColdStartup... ( #7848 )
2020-01-22 02:36:16 -05:00
08cce8cf58
for #7421 :removed collection from clear browsing history
2020-01-21 19:00:59 -08:00
ffc441f12a
For perf-frontend-issues#50: instrument imperfect reportFullyDrawn.
...
We don't capture the second RV draw yet. Unfortunately, I don't know if
it's the best use of my time to capture that as well.
2020-01-21 18:34:38 -08:00
e5164e3670
For #6980 - Pre-land string changes to onboarding cards.
2020-01-21 16:28:36 -08:00
cd853d0d8f
For #7029 : Navigate to Search Fragment when pressing Start browsing
2020-01-21 16:26:43 -08:00
e291c6905c
For #3813 - Create a save button for bookmark editing
2020-01-21 16:03:33 -08:00
2dc5b397b6
For #7506 : show highlight on home 3-dot button ( #7665 )
2020-01-21 13:02:14 -08:00
355cb35cb6
For #7574 : Send toolbar position metrics in English. ( #7712 )
2020-01-21 08:24:18 -08:00
02b4582c8d
No issue: Update Migration UI with new API
2020-01-20 18:08:38 +01:00
af3726a505
Fennec home screen bookmarks: Select new tab.
2020-01-20 15:17:58 +01:00
80eb19294b
AboutFragment: Use SupportUtils.getWhatsNewUrl().
2020-01-20 14:15:58 +01:00
a1cbbba4ea
For #7423 : remove unnecessary wordmark_spacer view.
...
Co-authored-by: Emma Malysz <emalysz@mozilla.com>
2020-01-17 16:59:03 -08:00
053e5b8065
For #6396 For #6553 - Update sync engine checkboxes and send telemetry once
2020-01-17 16:39:24 -08:00
dbf711e112
For #4904 : Pressing back external link doesn't go back
2020-01-17 16:08:58 -08:00
509fa112d0
For #6308 : Remove unecessary telemetry & bump expiry date ( #7793 )
...
* For #6308 : Remove unecessary telemetry
* For #6308 : Bump expiry date on telemetry
2020-01-17 15:13:20 -08:00
904098387a
Issue #7093 - Pre-land strings for new onboarding cards. ( #7747 )
2020-01-16 18:20:41 -08:00
6789df55a5
For #220 - Puts language picker behind a feature flag
2020-01-16 15:45:05 -08:00
ea22f6d69b
For #1607 - Fixes SearchShortcutSelected to not leak any custom identifiers
2020-01-16 14:07:38 -08:00
f4b583fc0b
For #ac-5601: Lock migration UI screen orientation
2020-01-16 13:46:01 -05:00
c106d89285
For #7751 : Remove 'SearchWithCustomEngine' telemetry event
2020-01-16 10:14:07 -08:00
3a1292911d
Update list of tabs after onboarding screen was dismissed.
2020-01-16 18:47:33 +01:00
981d19de13
For #6556 : Adds Telemetry counts for Search Access Points
...
Added two new sources to be counted ('widget' and 'shortcut') besides 'action' and
'suggestion'. Also modified/fixed some tests.
2020-01-16 10:23:48 +02:00
261a6162af
Review comments, fix build failure and targetActivity
2020-01-15 21:41:01 -08:00
b89afe7b7c
For #7092 : Add initial Migration UI
2020-01-15 21:41:01 -08:00
29d9ba472c
Always initialize glean. Set upload flag after migration. ( #7717 )
2020-01-15 15:31:51 -08:00
0777fb3bbe
For #5545 For #5542 Closes #6696 Integrate logins API, adds Settings for Autofilling/Saving Logins
2020-01-15 12:14:08 -08:00
f93437c509
Fix GleanMetricsService to use the new Glean APIs
2020-01-15 16:38:48 +02:00
61570b5238
Closes #7645 : Disable push service when migrating
2020-01-15 02:10:56 -05:00
a952d0858c
For #5884 : Fixed Unit tests.
2020-01-13 12:31:23 -08:00
7c5c9355ce
For #5884 : Adds user-specified search engines telemetry
...
Created events for adding and deleting a custom search engine and for searches
performed with a custom search engine.
2020-01-13 12:31:23 -08:00
cf220427d7
Fix #7649 : Fix missing NOT in asFeatureWebChannelsDisabled check ( #7650 )
2020-01-13 13:37:13 -06:00
7baf54f566
For #5182 : Loading experiments on startup is slow, remove Fretboard ( #7510 )
...
This removes Fretboard. The goal is to reduce cold startup costs associated with loading the experiments on the main thread. We currently have two experiments frameworks in use and should only require one.
2020-01-13 12:38:32 -06:00
6419d0cf13
Open "migration FAQ" when selecting "What's new" in a Fennec build.
2020-01-13 17:08:48 +01:00
55c1b01d7b
For #7431 : Remove extra share button
2020-01-11 11:48:51 -08:00
cf05840c0f
Move experiments initialization and fix ktlint errors
2020-01-10 13:57:12 -08:00
1f5bfff025
Issue #6898 : Allow empty adjust token for fennecNightly builds.
2020-01-10 13:48:20 -08:00
47c13136f7
No issue: Fix dynamic theming to accommodate lazily inflated readerview
2020-01-10 13:23:46 -08:00
a72620ae07
For #7522 Catch IllegalArgumentException when validating search string
2020-01-10 11:26:11 -08:00
a58decd708
For #6304 & #7577 : Persist private mode between app launches
2020-01-09 17:03:36 -08:00
0a412a1a6a
For #6992 Always hide toolbar when showing find in page bar ( #7567 )
2020-01-09 13:26:33 -08:00
666b3d9627
For #7343 : Handle sharing to multiple devices ( #7409 )
...
* For #7343 Do not allow multiple share to same device
* For #7343 Check current destination before dismissing share
2020-01-09 10:40:14 -08:00
718c211a86
For #1718 : Sets accessibility users to top toolbar by default ( #7486 )
2020-01-09 09:15:02 -08:00
6d44ceceda
For #6836 - Limit Leanplum depending on current locale.
2020-01-09 13:02:21 +02:00
9449cb4437
Fix truncated tracking protection info text
...
* Allow tracking protection titles to wrap instead of being cut off
* Refactor view ids to match the layout
2020-01-08 20:17:22 -08:00
e3408b12b4
Update Mozilla Android Components to 28.0.0-SNAPSHOT.
2020-01-08 18:57:31 -05:00
e6791b5c08
For #7154 - Fix crash when tapping on "Blocked" in the site info panel ( #7404 )
2020-01-08 13:51:45 -08:00
2bdde48986
For #7522 Ensure correct protocol is used in search string
2020-01-08 11:13:49 -08:00
569b7670d3
For 6832: update implementation/comment to align w existing AC code
2020-01-08 12:04:14 -07:00
65f5ff6b36
For #6832 : fix unattached context crash in HomeFragment
2020-01-08 12:04:14 -07:00
b115a00589
For #7155 Align custom tabs overflow menu to original mocks
...
Reverse menu items order when toolbar position is top
2020-01-08 11:50:17 -07:00
6aa8c98e00
For #7519 Navigate up from search fragment to handle all entry points
2020-01-08 11:49:17 -07:00
a2e0af3194
Only close tab on back press if it has a parent tab
2020-01-08 11:33:49 -07:00
8ed14ac062
Issue 5736 Improve pop behavior after deleting tabs in settings ( #7478 )
2020-01-08 10:27:14 -08:00
7d613b72ae
For #7181 - Adjust ETP onboarding for toolbar positions
2020-01-08 11:06:38 -07:00
9c28cb632c
Issue #7425 (et al): Cache the list of installed browsers
...
Cache the list of installed browsers. Calling `Browsers.all`
the application directly redundantly recalculates the list.
Accessing the list of installed browsers through this cache
will reduce that overhead.
2020-01-07 18:40:07 -08:00
8454f208af
For #4977 : Migrate fennec shortcuts ( #7251 )
...
* For #4977 - Support opening Fennec pinned website shortcuts in Fenix
Fennec's pinned website shortcuts are set to open the BrowserApp activity.
So we need a new activity alias to actually catch such Intents. Otherwise they
would open "org.mozilla.firefox/.App" without any way to inform that this is
the result of the user clicking on a pinned shortcut.
For actually checking if the newly received Intent is of a Fennec pinned
shortcut we introduce a new FennecBookmarkShortcutsIntentProcessor which will
prepare the Intent to open the shortcut's URL in a new tab.
* For #4977 - Don't keep IntentReceiverActivity on the back stack
For successive Fennec pinned shortcuts to create a new IntentReceiverActivity
and be processed as normal we need to not keep this as our task root.
* For #4977 - Test the FennecBookmarkShortcutsIntentProcessor
2020-01-07 09:07:51 -08:00
fdb1f505cc
For #5552 - Reverts temporary fix for #5552
2020-01-07 12:24:20 +02:00
75b87334fa
Change type for OnboardingAutomaticSignIn ( #7474 )
2020-01-06 14:25:52 -08:00
4bab493487
No issue: remove useless @MenuRes annotation in History Fragment.
...
This annotation was not applied correctly and lint was unable to ensure
it was used properly: it declared an error in lint saying so but that
error was ignored. I did not know how to apply the annotation - and I
felt it had limited utility - so I removed it entirely in order to
permit the lint baseline file to be removed (it was the only error).
2020-01-06 18:27:51 +02:00
ea2411a88b
Feature/#220 language menu ( #7070 )
...
* For #220
- Added advanced header + locale settings item in the settings fragment
* For #220
- Added locale selection page with lib state + handling of locale changes
* For #220
- Removed registering for locale changes in the manifest, allow system
to restart activity in that scenario
* For #220
- Added unit tests for locale settings page
* For #220 : fixed an outdated unit test
ga-a
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2020-01-03 18:15:35 -08:00
9cbc3f7a4a
7410 remove rxjava ( #7426 )
...
* For #7410 : rewrite updateBookmarkFromObservableInput with coroutines
* For 7410: remove RxJava from project. :(
* For 7410: converted updateBookmarkFromTextChanges to Flow per review
2020-01-03 14:37:12 -08:00
0768fde945
No issue: Use SendTabFeature and FxaPushSupportFeature
2020-01-03 10:20:53 -05:00
c7c4ad051a
For #6413 : Adds more snackbar positioning logic ( #7444 )
...
* For #6413 : Adds more snackbar positioning logic
* Refactor
2020-01-02 14:31:52 -08:00
f6e286fd9c
Closes #7346 : Enable dynamic app links in Fenix ( #7361 )
2020-01-02 13:08:11 -05:00
3fb060f682
For #6413 : Fixes snackbar positionining for bottom toolbar ( #7415 )
...
* For #6413 : Fixes snackbar positionining for bottom toolbar
* For #6413 : Cleans up snackbar usage
2019-12-30 14:43:15 -08:00
13f73c2d2c
For issue 7192: move unsetOpenLinksInAPrivateTabIfNecessary off main thread. ( #7246 )
...
Move method to Settings. There are two instances when we want to call this method: either
processing an intent, or within DefaultBrowserPreference
2019-12-30 14:42:13 -08:00
cf143489e1
For #6464 : Replace use of BuildConfig.DEBUG with ReleaseChannel.channel.isDebug.
...
This fixes performance issues where StrictMode would greatly slow down
startup in the forPerformanceTest variants.
2019-12-30 10:31:33 -08:00
ac97dd72b1
For #6464 : Set "forPerformanceTest" to ReleaseChannel.FenixProduction.
...
This fixes a perf measurement issue where Sentry would capture an event when
using the forPerformanceTest variants.
2019-12-30 10:31:33 -08:00
f11ddf8038
For #6464 : Add ReleaseChannel.isDebug.
2019-12-30 10:31:33 -08:00
f562c81fb2
For 5334: test NotificationSessionObserver
2019-12-30 11:40:07 +02:00
a8c47c8805
For #5334 : disable notification for private custom tabs
2019-12-30 11:40:07 +02:00
9a693f6c11
For #7000 : Fix inverted media telemetry ( #7368 )
2019-12-27 13:46:47 -08:00
26b7909214
For #7352 : integrate highlightable browser menu changes ( #7353 )
...
* For #7352 : integrate highlightable browser menu changes
* For 7352: invalidate menu when reader mode availability changes
* For 7352: removed highlight from reader mode appearance per UX
2019-12-27 12:15:21 -08:00
faa4136685
For #7347 : Fixes background of search field
2019-12-23 10:07:54 -08:00
4fd3eb53d1
For #6666 : Adds back button to search screen
2019-12-23 10:07:02 -08:00
6344a8892d
For #7041 - Respect current mode when opening library items ( #7311 )
...
* Fixes #7041
Consumes `browserMode` from home activity for tap method of bookmark
* Fixes spaces
* Cleaning tests
* Cleaning tests
2019-12-23 12:26:47 -05:00
dd1433733a
Closes #7156 : Update app links feature usage to include app links interceptor ( #7275 )
2019-12-20 08:27:19 -05:00
593981fa4b
Fix parameterized message in search engine ( #7302 )
2019-12-20 10:27:05 +02:00
740572b6d9
For #5334 - Override custom tab styling in private mode ( #7305 )
2019-12-19 18:17:52 -08:00
a40af5b134
Closes #7254 - Replace Anko applyConstraintSet ( #7286 )
...
* For #7254 : Replace anko applyConstraintSet
* Anko has been deprecated and will not be continued
* Refactor ConstraintSet changes
* Replace applyConstraintSet in SearchLayouts
* Refactor HomeFragment ConstraintSet
* Define anonymous ConstraintSet
* Remove ConstraintSet prefix from PARENT_ID
2019-12-19 18:16:50 -08:00
b85673acac
Clean up settings fragments
2019-12-19 14:29:28 -08:00
43354489a1
For #7253 - Replace anko setters
2019-12-19 13:42:50 -08:00
76c83ba805
For #7085 - Remove anko px2dip ( #7252 )
2019-12-19 00:05:51 -08:00
7c9a5c1f14
For #768 - Add PWA install option to menu ( #6882 )
2019-12-18 23:59:30 -08:00
907d96e39f
For #6709 , for #6849 Handle default engine deletion and undo operation
...
Uninstall engine immediately and allow reinstall in onCancel.
Set previous list with default engine in onCancel.
Keep default engine change in operation and remove now unnecessary view refresh.
2019-12-18 23:00:42 -08:00
f439c8110e
For #7183 - Fix bottom margin in PWAs
2019-12-18 22:57:54 -08:00
562eb89356
For #7250 - Replace anko.dimen
2019-12-18 15:39:14 -08:00
e789d8ebe3
Issue #4978 : Reuse widget package name of Fennec.
2019-12-18 15:23:43 -08:00
5ac79f59a3
For #7219 - Polish Download Notification Dialog. ( #7224 )
...
* For #7219 - Use accent color for downloads dialog positive button
* For #7219 - Fixes gap beneath download notification dialog
* switch to setimageresource
2019-12-18 12:26:41 -05:00
1a739db5b1
Closes #7260 : Pass in GeckoView version information to MozillaSocorroservice
2019-12-18 10:45:57 +01:00
52334f9121
Closes #6937 : Disable runStorageMaintenance during startup
...
This call will acquire a "write" lock at the storage layer (sqlite's reserved+),
which may interfere with migrations that run during startup as well (they need to
write to storage, and so also need to acquire a lock). If these operations clash,
we get a SQLITE_BUSY crash. For now, just disable the maintenance operation.
2019-12-17 14:24:30 -08:00
ea486d7c66
Split out CustomTabToolbarIntegration ( #7107 )
2019-12-17 12:26:46 -08:00
6cb3879caf
For #7048 : Network info migration ( #7091 )
...
* Fixes #7048 .
Adds extension function to check if online or not based on capabilities
Modified `buildDeviceList`
Modifies tests
* Fixing lint error for max length
Fixing test in AppRequestInterceptorTest.kt
* Adds suppression for deprecation
Moving away from using anko for ConnectivityManager instance
* Creates ConnectivityManager extension component
* Fixes #7180
Refactors test cases to fix static mocks
2019-12-16 22:03:11 -08:00
e727ae5d7e
Fix 5366 - Use VectorDrawableCompat for all imagery ( #7221 )
...
* Fix 5366 - Use VectorDrawableCompat for all imagery
* Fix detekt lint issues
* Restore previous comment contents
2019-12-16 20:35:36 -08:00
cd53e9778a
For 6795: expands toolbar whenever a new session is selected
...
This ensures that the bar is expanded when opening a link in a new tab
2019-12-16 14:09:29 -08:00
49f07554e7
No Issue - Removes some search engines
2019-12-16 14:09:14 -08:00
90c77519a6
For #7194 Set snackbar anchor depending on browser toolbar position
2019-12-16 12:21:54 -08:00
71880705df
For #5711 - Onboarding colours have contrast issues
2019-12-13 17:52:55 -08:00
b9656a978e
Hide add folder option when in Desktop Bookmarks folder
2019-12-13 17:51:15 -08:00
31f2e80ab0
Use feature-accounts-push, which replaces feature-sendtab.
2019-12-13 16:42:28 -08:00
bc6b7725e9
For #6968 Close response stream to allow use of caching
2019-12-13 12:35:25 -08:00
d2abac78eb
For #7075 Update passwords preference visibility and string
...
Set visibility for feature flags before settings screen it's displayed.
Change string for preference to match existing header string.
Update UI Tests
2019-12-13 12:19:14 -08:00
ef53e1ff8e
Reverts #6925 : Make home screen full screen
2019-12-13 11:29:53 -08:00
116f7b3d65
No Issue: Create a method to "finish onboarding" in CI
...
If the intent that starts the HomeActivity includes an extra
boolean flag named finishonboarding and it is set to true,
Fenix will "finish onboarding".
2019-12-13 11:28:57 -08:00
686facffc6
For #6946 - Get engine margins without assuming top/bottom toolbar
2019-12-13 11:09:30 -08:00
dcb39b0a44
For #7124 - Match toolbar location for ETP/security panel gravity
2019-12-13 11:09:30 -08:00
a3f2f55548
Closes #5913 : Add new sessionToken scope ( #6155 )
2019-12-12 12:00:20 -08:00
32985af882
For #6830 - Fix "Open in" text size for custom tab ( #7010 )
2019-12-12 11:49:54 +02:00
b819cb11c9
For #4776 : Added Unit tests for About Page.
2019-12-12 11:34:10 +02:00
c6c827f693
For #4776 : Redesign and refactor the About Page
...
Added new items to be displayed.
2019-12-12 11:34:10 +02:00
c46bf84ac9
For #6330 Collections Numbering ( #6453 )
...
* For #6330 - Added logic for getting the recommended default collection name
* For #6330 - Added unit test for default collection number method
2019-12-10 12:10:01 -08:00
fe034226a3
For #5783 - Web Share with Fenix share sheet ( #6883 )
2019-12-10 10:57:06 -08:00
6e9769a81b
For #7031 - Hide progress bar when leaving DeleteBrowsingDataFragment ( #7056 )
2019-12-10 11:17:45 -05:00
3f7205e3cb
Extract IntentProcessorType to its own file and add tests ( #7012 )
2019-12-10 00:02:23 -08:00
7477de83e9
For #4844 : fix file prefix url shortening
2019-12-10 05:07:53 +01:00
957ed8aa88
For #5334 : fix ETP shield coloring on custom private tabs
2019-12-10 03:22:55 +01:00
45ae8cb35a
For #6997 Avoid overwriting empty_search_string error ( #6998 )
...
Setting error twice also clips error message
2019-12-09 18:10:24 -08:00
76e9200304
For #6922 - Check current destination is logins fragment before navigation ( #6924 )
2019-12-09 15:42:40 -08:00
2a4aa24195
For perf-frontend-issues#33: Clarify VERBOSE logging motivation.
2019-12-09 15:11:52 -08:00
eef080a46c
For perf-frontend-issues#33: Add HotStartPerformanceMonitorTest.
...
We really don't want our startup tests to subtlely change so I thought
it was worth writing some quick tests.
2019-12-09 15:11:52 -08:00
e60141e98d
For perf-frontend-issues#33: Add HotStartPerformanceMonitor.
...
As mentioned in the class comment, we could use an alternative
implementation to measure perf from outside the application however
it's more complicated to set up and less consistent with our cold
startup methodology so we'll start with this.
2019-12-09 15:11:52 -08:00
1647e07481
For #5771 - Don't force landscape mode on fullscreen
2019-12-09 23:47:57 +01:00
b6ba1a1611
For #4107 Make home screen fullscreen.
...
Add/Remove fullscreen flags in home fragment's onResume / onPause
Change homeLayout padding to include system bars height (status&navigation).
Change homeMenu orientation to UP to properly display menu.
Change home bottomBar background to transparent.
2019-12-09 23:45:02 +01:00
17731620e6
For #7026 Dispatch ModeChange on hideOnboarding
2019-12-09 23:44:33 +01:00
David Walsh