Mihai Adrian
a31eb1f371
Code Health #4883 : Refactored accessing settings by using Context extensions ( #4973 )
2019-09-10 10:11:58 -07:00
Sawyer Blatz
2653b5966e
For #964 : Adds ability to disable each suggestion provider ( #5096 )
...
* For #964 : Adds ability to disable each suggestion provider
* Fix nit
2019-09-05 14:45:44 -07:00
Sebastian Kaspari
38d97fda8b
Stores: Reduce visibility of reducer functions.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
61e84c161d
Rename SearchStore/State/Action to SearchFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Christian Sadilek
4cf03be236
For #2088 : Use new async API to load default search engine in HomeFragment
2019-08-30 17:56:18 -04:00
Will Hawkins
3abffd5d77
Use new async API to load and access search engines
...
Use the new asynchronous features of the search engine
manager from a-c to avoid the latency required to load
the default search engine.
2019-08-29 18:16:02 -07:00
Emily Kager
b9f6f7fa93
For #4779 : Don't double navigate with global directions in HomeActivity
2019-08-23 12:01:28 -04:00
Emily Kager
416e25e8a5
No issue: Don't show session provider in private mode
2019-08-20 16:09:55 -07:00
Sourabh
1afc0eacd8
For #4399 : Create LibState Controller for Search ( #4673 )
...
* For #4399 : Create LibState Controller for Search
* fix code format
* add unit tests for DefaultSearchController
* add more test
* fix unit tests
2019-08-20 09:07:00 -07:00
Yeon Taek Jeong
d4c83f9668
For #4736 : Display search shortcuts only from home or search widget
2019-08-15 12:24:54 -04:00
Yeon Taek Jeong
2f265eccbd
For #4732 : Fix search engine display issue ( #4735 )
2019-08-14 11:03:14 -07:00
Tiger Oakes
52542708aa
Consodilate private browsing code
2019-08-09 11:00:41 -07:00
Emily Kager
0b98d43c23
Closes #4602 - Add back transitions
2019-08-07 16:56:21 -07:00
Sawyer Blatz
da06b0fb15
For #4508 : Treats warnings as errors ( #4543 )
2019-08-07 14:00:53 -07:00
ValentinTimisica
59c60ef189
Fixes #4354 : Updated SearchFragment state after returning from SearchEngineFragment.
...
The user has the option to go to 'Shortcuts' -> 'Search engine settings' to
modify the default search engine. When returning from that settings screen we
need to update it to account for any changes.
For this we will check the current default engine against a previously stored
value in a newly added 'defaultEngineSource' property from SearchState class.
Also, I modified 'SearchStoreTest' by adding the new parameter to the
'SearchState' constructor.
2019-08-07 13:19:53 -07:00
Yeon Taek Jeong
6f962d3376
For #1744 : Open search shortcuts when entering search mode ( #4536 )
2019-08-05 15:07:03 -07:00
Nikit Bhandari
671727c3e8
For #4341 use camelCase for views referenced from code
2019-08-03 09:25:55 -07:00
Yeon Taek Jeong
83ceec6289
For #201 : Search Widget
2019-08-02 11:26:48 -07:00
Nikit Bhandari
46de06d132
For #4339 reduce build warnings ( #4340 )
2019-07-31 11:43:49 -07:00
Amaan Marfatia
4c13f45e9e
Fixes #4192 : Private keyboard in private browsing ( #4345 )
...
Sets compliant keyboards to private mode when in private browsing.
2019-07-29 18:00:48 -04:00
Sawyer Blatz
6fa022c2f8
For #4124 : Migrate BrowserToolbar to Libstate ( #4279 )
...
* For #4124 : Migrate BrowserToolbar to Libstate
* Restores QuickActionSheetReducer
* Improve tests
* Make QuickActionSheetController
* Finalize tests
* Breaks out QuickActionSheetState
* Fix comments
* Adds BrowserStoreTest
2019-07-29 12:39:36 -07:00
Tiger Oakes
c2e6e25bef
Fixes #4005 - Move getColorFromAttr to Context
2019-07-26 16:44:11 -04:00
Colin Lee
48aeb19db1
For #3695 : Make SessionSuggestionProvider link to existing tab ( #4280 )
2019-07-26 09:49:25 -05:00
Christian Sadilek
1846a61475
For #4096 : Use new A-C API to observe store / state changes
...
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
2019-07-26 10:40:33 -04:00
Sawyer Blatz
28eb5c541a
For #1944 & #1750 : Updates private & night mode colors ( #4232 )
2019-07-23 09:35:24 -07:00
Tiger Oakes
edb0a3ed08
For #3633 - Update StoreProvider to use a callback
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2019-07-18 18:16:49 -04:00
Christian Sadilek
c04dcec03f
Closes #4096 : IllegalStateException in SearchFragment ( #4131 )
2019-07-17 15:10:24 -05:00
Jeff Boek
ec099a6e11
For #3633 - Creates generic store provider ( #4060 )
2019-07-15 15:54:13 -07:00
Christian Sadilek
e91a2e61a2
For #3633 : Add unit tests for SearchStore
2019-07-15 13:47:01 -04:00
Jeff Boek
e4ff70c542
For #3633 - Refactors the search screen to use lib-state
...
* For #3633 - Adds SearchStore
* For #3633 - Refactors AwesomeBarUIView
* For #3633 - Refactors ToolbarUIView to use lib-state
* For #3633 - Fixes a couple of state bugs
* For #3633 - Moves all user interaction to SearchInteractor
* For #3633 - Adds kdocs to SearchStore and SearchInteractor
* For #3633 - Adds documentation for the properties on SearchState
Also removes uneccessary property
* For #3633 - Creates `StateViewModel` to handle state restoration
* For #3633 - Adds a test for onTextChanged
* For #3633 - Adds tests for SearchInteractor
* For #3633 - Fixes bugs and adds documentation
2019-07-12 16:32:00 -07:00
Emily Kager
867067537a
For #3568 - Use correct styling for QR and Share Alert Dialogs
2019-07-12 11:40:33 -07:00
Tiger Oakes
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
Colin Lee
161e7b3b57
No issue: Fix master builds ( #3825 )
2019-07-01 14:15:54 -05:00
ekager
61a8795576
For #1211 - Hide keyboard on fling suggestions list
2019-06-26 16:44:35 -07:00
Emily Kager
427bc5c1e6
Revert "For #1211 - Hide keyboard on fling suggestions list"
...
This reverts commit cb6fd83c9879c268cb739fb768187d5276c5af66.
2019-06-26 11:19:09 -07:00
Tiger Oakes
30930cdc88
Import variables referred to by path
2019-06-25 13:57:34 -07:00
Emily Kager
6e3197f61c
For #3622 - Add ID to engine shortcut suggestions ( #3636 )
2019-06-24 15:30:27 -07:00
Emily Kager
b1102c2e76
For #3544 - Set SearchSuggestions preference value from settings
2019-06-18 16:56:34 -07:00
Jeff Boek
f323c38be0
For #981 - Adds missing Leanplum events
2019-06-14 13:27:50 -07:00
Colin Lee
d5c5587a0c
For #3209 : Disable shared element animations for crash temporarily ( #3482 )
2019-06-14 12:13:13 -05:00
Emily Kager
5eb2bc6d55
For #3138 - Sets height of toolbar in SearchFragment to match_parent ( #3400 )
2019-06-12 19:44:44 -05:00
Colin Lee
66a836cf3a
For #3314 : Toolbar and QAB unresponsive after Android 6 perms check ( #3373 )
2019-06-12 10:08:39 -05:00
Tiger Oakes
82d2a0661b
Remove deprecatd support-ktx methods ( #3305 )
2019-06-10 09:12:11 -05:00
Denys M
c9570fd6ff
Use `Drawable.toBitmap()` from androidx-ktx. ( #3286 )
2019-06-10 08:50:37 -04:00
Sawyer Blatz
86aac3e313
For #3176 : Hides camera options on devices without cameras ( #3273 )
2019-06-07 19:37:43 -05:00
Jonathan Almeida
f7bd39da77
For #3138 : Fix white background on search bar
2019-06-06 17:11:06 -07:00
Denys M
605a552f16
For #1366 . Update toolbar search state when typing. ( #2908 )
2019-06-06 08:16:22 -07:00
Emily Kager
ca186c8776
Closes #1618 - Add fade to awesome bar list instead of shadow ( #3110 )
...
* Closes #1618 - Add fade to awesome bar list instead of shadow
* For #1211 - Hide keyboard on fling suggestions list
2019-06-04 10:35:47 -05:00
Jeff Boek
a7d5cdcb9d
For #2723 - Fixes theme manager
2019-05-30 16:38:31 -07:00
Emily Kager
8dbed67f7f
No issue: Simplify and speed up shared element transitions
2019-05-30 16:30:06 -07:00
Emily Kager
43a961fe73
For #1973 - Toggle QR button on deny permissions, fix engineView crashes
2019-05-30 16:06:37 -07:00
Christian Sadilek
0b00c0ce9b
No issue: ClipboardProvider no longer needs to be added/removed based on input
2019-05-30 13:03:50 -07:00
Emily Kager
8181705b58
Init Toolbar in edit mode so we don't see the flash
2019-05-29 12:27:48 -07:00
ekager
dee3c059dc
Adds Shared Transition between Home and Search
2019-05-29 12:27:48 -07:00
Emily Kager
a80053547e
For #2806 - navigate up from SearchFragment instead of activity back press ( #2812 )
2019-05-23 21:30:05 -07:00
Sebastian Kaspari
291df48c4e
Install the "icons" WebExtension to automatically load icons for every visited website.
2019-05-20 19:34:49 -07:00
Emily Kager
e534dad199
For #2028 - Pass Session ID for Custom Tab Prompts, Theme Dialogs
2019-05-20 19:24:48 -07:00
Emily Kager
028c6cad70
For #2025 - Create and theme Dialog for deleting all history
2019-05-20 19:24:48 -07:00
Sawyer Blatz
9e50b55340
For #1857 : Adds telemetry for QR scanner
2019-05-17 10:46:53 -07:00
Jeff Boek
c5e5ef4b25
Teases apart ViewModel dependencies ( #2499 )
...
* No Issue - pulls render outside of the viewmodel
* No Issue - Properly subscribes to the changesObservable
* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
Colin Lee
49ac62ab85
Fix ViewModel States ( #2457 )
...
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
2019-05-14 13:49:02 -07:00
Denys M
24f15c8b77
Closes #1083 . Don't print sensitive data to logs in the production app. ( #2437 )
2019-05-11 22:01:41 -07:00
Colin Lee
ccbc14a71f
For #1994 : Re-architect state handling code ( #2382 )
2019-05-09 23:06:12 +00:00
Emily Kager
e4b4934f53
For #2393 - SearchTermsTapped even on URL should search ( #2398 )
2019-05-09 16:21:33 -05:00
Sawyer Blatz
70486039c0
Closes #2147 : Refactors usage of openToBrowserAndLoad
2019-04-29 15:49:22 -07:00
Colin Lee
5b7e297adf
For #1955 : Add prompt before loading QR code ( #2096 )
2019-04-28 01:00:55 -05:00
Emily Kager
97e4f43fda
No issue: null check context on permission granted ( #2104 )
2019-04-26 22:02:50 -07:00
Sawyer Blatz
29238d6e5f
For #1954 : Hides keyboard when requesting camera permission
2019-04-26 15:53:38 -07:00
Sawyer Blatz
11918d45f4
For #1619 : Hides clipboard provider when text is entered ( #2081 )
2019-04-26 11:37:02 -07:00
Sawyer Blatz
46924544b6
For #1975 & #1627 : Refactors getSessionById in BrowserFragment
2019-04-25 16:51:03 -07:00
Sawyer Blatz
4945805e37
For #1954 : Resolves QR scanner back press and keyboard issues ( #2036 )
2019-04-25 12:31:17 -07:00
Sawyer Blatz
36cd275eed
For #1917 : Hides search suggestions in shortcuts when needed ( #1988 )
2019-04-24 13:50:55 -07:00
Jeff Boek
31494a4341
Sets the search engine to the default if no shortcut is used
2019-04-23 17:39:57 -05:00
Sawyer Blatz
8a4995099f
For #1205 : Adds search term to EditToolbar
2019-04-23 09:59:48 -07:00
Harsh Shandilya
e20fa5dc32
AwesomeBarUIView: Rename variable to prevent name shadowing
...
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-04-23 09:59:36 -07:00
Colin Lee
6199d31924
For #1851 : QR code scanner doesn't load right after permission grant
2019-04-22 13:56:43 -07:00
Colin Lee
d1fd5ec879
For #113 : QR Scan
2019-04-19 14:47:53 -07:00
Emily Kager
bf056b73c1
For #1375 - Add Bookmarks Suggestion Provider
2019-04-18 19:21:12 -05:00
Jeff Boek
cb7ad32b62
For #1158 - Add search counts
2019-04-17 10:04:49 -07:00
Sawyer Blatz
f48e2b072e
No issue: Cleans up SearchShortcut changes
2019-04-17 11:20:59 -05:00
Sawyer Blatz
353270a5c7
Fixes #1610 : Gives unique identifier to shortcut engine picker suggestions
2019-04-15 13:32:34 -05:00
Sawyer Blatz
29832c5e84
For #724 : Consolidates colors
2019-04-15 12:22:03 -05:00
Emily Kager
5f0fe216cb
For #1375 - Suppress history suggestions in awesome bar via setting
2019-04-10 16:45:02 -05:00
Emily Kager
9cb252da40
For #1421 - Fix Shortcut ToggleButton states
2019-04-05 16:29:36 -07:00
Emily Kager
5d1738e011
For #208 - Dark Mode UX edits
2019-04-04 19:35:36 -07:00
Sawyer Blatz
471b08d97a
Closes #1194 : Adds shortcut telemetry
2019-04-03 11:12:17 -05:00
Emily Kager
a2200b6335
For #208 - Dark/Night Theme
2019-04-02 22:18:11 -05:00
Sawyer Blatz
36af5107c6
Closes #875 : Adds search shortcuts ( #882 )
...
* Closes #875 : Adds shortcuts
* Refactor and clean up
* Remove TODO
* Removes local
* Fix nits
* Refactors to add ShortcutEngineManager
2019-03-29 13:49:50 -07:00
Jeff Boek
edb197d10b
Adds search engine icon to the toolbar
2019-03-25 14:42:13 -07:00
Jeff Boek
32f8e06e98
For #959 - Adds search related telemetry
2019-03-22 17:14:35 -07:00
Colin Lee
df40ec970e
Simplify ItsNotBrokenSnack() and make resilient
...
Co-authored by: Emily Kager <ekager@mozilla.com>
2019-03-22 15:00:38 -05:00
Emily Kager
4963f7ccdb
Add Snackbar to link testers to Github issue for features
2019-03-22 15:00:38 -05:00
Sebastian Kaspari
8f11ab6fcf
AwesomeBar: Limit number of search engine suggestions.
2019-03-22 11:19:05 -05:00
Sebastian Kaspari
52e9394324
Pass BrowserIcons instance to SessionSuggestionProvider and HistoryStorageSuggestionProvider.
2019-03-22 11:18:43 -05:00
Grisha Kruglov
8eb113fa32
Bump A-C snapshot version to 0.48
...
This is necessary to pick up an application-services dependency bump, and unbreak master.
AwesomeBarUIView changes are needed because, evidently, a new parameter was introduced, and
not at the end.
2019-03-21 23:30:00 -05:00
Grisha Kruglov
1e1c8a7b46
Pre: fix an IDE warning
2019-03-13 19:07:28 -05:00
Sawyer Blatz
9d18bbad12
Closes #847 : Implement onCancelEditing to handle keyboard backPress ( #929 )
2019-03-13 11:12:58 -07:00
Emily Kager
f66bae0801
Closes #963 - Hooks up show search suggestion pref
2019-03-12 11:12:03 -07:00
Arturo Mejia
fd4acf6e92
Upgrade AC dependency to 0.47.0-SNAPSHOT and GV to 67.0.20190312095443 ( #958 )
...
* Upgrade AC dependency to 0.47.0-SNAPSHOT and GV to 67.0.20190312095443
* Fix compliation errors
2019-03-12 08:49:22 -07:00
Emily Kager
d15e4bb3fa
Closes #877 - Add Search Engine Settings
2019-03-06 16:20:35 -08:00