blallo
/
fenix
1
0
Fork 0
Code Releases Activity

Fixes nits in mozilla-mobile/fenix#158

master
Jeff Boek 2019-01-11 13:48:19 -08:00 committed by Colin Lee
parent 9d80049fa6
commit cefa12224f
3 changed files with 20 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
View File

@ -77,7 +77,7 @@ private class SessionsAdapter(val context: Context) : RecyclerView.Adapter<Sessi
return ViewHolder(textView) return ViewHolder(textView)
} }
override fun getItemCount(): Int = 0 override fun getItemCount(): Int = 100
override fun onBindViewHolder(holder: ViewHolder, position: Int) { override fun onBindViewHolder(holder: ViewHolder, position: Int) {
holder.textView.text = "Cell: ${position}" holder.textView.text = "Cell: ${position}"

23
app/src/main/res/layout/fragment_home.xml
View File

@ -17,21 +17,20 @@
<ImageButton <ImageButton
android:id="@+id/menuButton" android:id="@+id/menuButton"
android:src="@drawable/ic_menu" android:src="@drawable/ic_menu"
android:layout_width="48dp" android:layout_width="@dimen/glyph_button_height"
android:layout_height="@dimen/glyph_button_height"
android:layout_height="48dp"
android:layout_marginTop="16dp" android:layout_marginTop="16dp"
android:background="?android:attr/selectableItemBackgroundBorderless" android:background="?android:attr/selectableItemBackgroundBorderless"
app:layout_constraintRight_toRightOf="parent" app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toTopOf="parent" /> app:layout_constraintTop_toTopOf="parent" />
<ImageButton <ImageButton
android:id="@+id/privateBrowsingButton" android:id="@+id/privateBrowsingButton"
android:src="@drawable/ic_private_browsing" android:src="@drawable/ic_private_browsing"
android:layout_width="48dp" android:layout_width="@dimen/glyph_button_height"
android:layout_height="48dp" android:layout_height="@dimen/glyph_button_height"
android:background="?android:attr/selectableItemBackgroundBorderless" android:background="?android:attr/selectableItemBackgroundBorderless"
app:layout_constraintRight_toLeftOf="@id/menuButton" app:layout_constraintEnd_toStartOf="@id/menuButton"
app:layout_constraintTop_toTopOf="@id/menuButton" /> app:layout_constraintTop_toTopOf="@id/menuButton" />
<ImageView <ImageView
@ -41,7 +40,7 @@
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginLeft="16dp" android:layout_marginLeft="16dp"
android:layout_marginTop="42dp" android:layout_marginTop="42dp"
app:layout_constraintLeft_toLeftOf="parent" app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@id/menuButton" /> app:layout_constraintTop_toBottomOf="@id/menuButton" />
<FrameLayout <FrameLayout
@ -53,8 +52,8 @@
android:layout_marginRight="16dp" android:layout_marginRight="16dp"
android:background="@drawable/home_search_background" android:background="@drawable/home_search_background"
app:layout_constraintTop_toBottomOf="@id/wordmark" app:layout_constraintTop_toBottomOf="@id/wordmark"
app:layout_constraintLeft_toLeftOf="parent" app:layout_constraintStart_toStartOf="parent"
app:layout_constraintRight_toRightOf="parent" app:layout_constraintEnd_toEndOf="parent"
android:outlineProvider="paddedBounds" android:outlineProvider="paddedBounds"
android:clipToPadding="false" android:clipToPadding="false"
android:elevation="5dp"> android:elevation="5dp">
@ -74,8 +73,8 @@
android:layout_height="0dp" android:layout_height="0dp"
android:layout_margin="16dp" android:layout_margin="16dp"
app:layout_constraintTop_toBottomOf="@id/toolbar_wrapper" app:layout_constraintTop_toBottomOf="@id/toolbar_wrapper"
app:layout_constraintLeft_toLeftOf="parent" app:layout_constraintStart_toStartOf="parent"
app:layout_constraintRight_toRightOf="parent" app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintBottom_toBottomOf="parent"/> app:layout_constraintBottom_toBottomOf="parent"/>
</androidx.constraintlayout.motion.widget.MotionLayout> </androidx.constraintlayout.motion.widget.MotionLayout>

8
app/src/main/res/values/dimens.xml 100644
View File

@ -0,0 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<resources>
<dimen name="glyph_button_height">48dp</dimen>
<dimen name="glyph_button_width">48dp</dimen>
</resources>