1
0
Fork 0

For #7556: fix intermittent failure in BookmarkNodeTest

master
Severin Rudie 2020-01-08 17:12:18 -08:00 committed by Mihai Adrian
parent 6d44ceceda
commit b23ee38082
1 changed files with 5 additions and 10 deletions

View File

@ -4,18 +4,11 @@
package org.mozilla.fenix.ext package org.mozilla.fenix.ext
import org.junit.Assert.assertEquals
import org.junit.Test
import org.junit.runner.RunWith
import org.mozilla.fenix.TestApplication
import org.robolectric.RobolectricTestRunner
import org.robolectric.annotation.Config
import mozilla.components.concept.storage.BookmarkNode import mozilla.components.concept.storage.BookmarkNode
import mozilla.components.concept.storage.BookmarkNodeType import mozilla.components.concept.storage.BookmarkNodeType
import java.util.UUID import org.junit.Assert.assertEquals
import org.junit.Test
@RunWith(RobolectricTestRunner::class)
@Config(application = TestApplication::class)
class BookmarkNodeTest { class BookmarkNodeTest {
private val bookmarkChild1 = newBookmarkNode("Child 1", 1, null) private val bookmarkChild1 = newBookmarkNode("Child 1", 1, null)
@ -23,6 +16,8 @@ class BookmarkNodeTest {
private val bookmarkChild3 = newBookmarkNode("Child 3", 3, null) private val bookmarkChild3 = newBookmarkNode("Child 3", 3, null)
private val allChildren = listOf(bookmarkChild1, bookmarkChild2) private val allChildren = listOf(bookmarkChild1, bookmarkChild2)
private var uniqueId = 0
@Test @Test
fun `GIVEN a bookmark node with children WHEN minusing a sub set of children THEN the children subset is removed and rest remains`() { fun `GIVEN a bookmark node with children WHEN minusing a sub set of children THEN the children subset is removed and rest remains`() {
val bookmarkNode = newBookmarkNode("Parent 1", 0, allChildren) val bookmarkNode = newBookmarkNode("Parent 1", 0, allChildren)
@ -85,7 +80,7 @@ class BookmarkNodeTest {
private fun newBookmarkNode(title: String, position: Int, children: List<BookmarkNode>?) = BookmarkNode( private fun newBookmarkNode(title: String, position: Int, children: List<BookmarkNode>?) = BookmarkNode(
type = BookmarkNodeType.ITEM, type = BookmarkNodeType.ITEM,
guid = UUID.randomUUID().toString(), guid = uniqueId++.toString(),
parentGuid = "12", parentGuid = "12",
position = position, position = position,
title = title, title = title,