1
0
Fork 0

For #5884: Fixed Unit tests.

master
ValentinTimisica 2019-12-04 11:48:22 +02:00 committed by Jeff Boek
parent 7c5c9355ce
commit a952d0858c
2 changed files with 29 additions and 3 deletions

View File

@ -6,6 +6,7 @@ package org.mozilla.fenix.components.searchengine
import android.content.Context import android.content.Context
import android.content.SharedPreferences import android.content.SharedPreferences
import androidx.annotation.VisibleForTesting
import mozilla.components.browser.icons.IconRequest import mozilla.components.browser.icons.IconRequest
import mozilla.components.browser.search.SearchEngine import mozilla.components.browser.search.SearchEngine
import mozilla.components.browser.search.SearchEngineParser import mozilla.components.browser.search.SearchEngineParser
@ -126,5 +127,6 @@ object CustomSearchEngineStore {
} }
private const val PREF_KEY_CUSTOM_SEARCH_ENGINES = "pref_custom_search_engines" private const val PREF_KEY_CUSTOM_SEARCH_ENGINES = "pref_custom_search_engines"
private const val PREF_FILE_SEARCH_ENGINES = "custom-search-engines" @VisibleForTesting
const val PREF_FILE_SEARCH_ENGINES = "custom-search-engines"
} }

View File

@ -13,8 +13,8 @@ import io.mockk.Runs
import io.mockk.every import io.mockk.every
import io.mockk.just import io.mockk.just
import io.mockk.mockk import io.mockk.mockk
import io.mockk.mockkObject
import io.mockk.verify import io.mockk.verify
import io.mockk.mockkObject
import mozilla.components.browser.search.SearchEngine import mozilla.components.browser.search.SearchEngine
import mozilla.components.browser.search.SearchEngineManager import mozilla.components.browser.search.SearchEngineManager
import mozilla.components.browser.session.Session import mozilla.components.browser.session.Session
@ -23,9 +23,10 @@ import org.junit.Test
import org.junit.runner.RunWith import org.junit.runner.RunWith
import org.mozilla.fenix.BrowserDirection import org.mozilla.fenix.BrowserDirection
import org.mozilla.fenix.FenixApplication import org.mozilla.fenix.FenixApplication
import org.mozilla.fenix.TestApplication
import org.mozilla.fenix.HomeActivity import org.mozilla.fenix.HomeActivity
import org.mozilla.fenix.R import org.mozilla.fenix.R
import org.mozilla.fenix.TestApplication import org.mozilla.fenix.components.searchengine.CustomSearchEngineStore.PREF_FILE_SEARCH_ENGINES
import org.mozilla.fenix.ext.metrics import org.mozilla.fenix.ext.metrics
import org.mozilla.fenix.ext.searchEngineManager import org.mozilla.fenix.ext.searchEngineManager
import org.mozilla.fenix.ext.settings import org.mozilla.fenix.ext.settings
@ -52,6 +53,13 @@ class SearchInteractorTest {
every { state.session } returns null every { state.session } returns null
every { state.searchEngineSource } returns searchEngine every { state.searchEngineSource } returns searchEngine
every {
context.getSharedPreferences(
PREF_FILE_SEARCH_ENGINES,
Context.MODE_PRIVATE
)
} returns mockk(relaxed = true)
val searchController: SearchController = DefaultSearchController( val searchController: SearchController = DefaultSearchController(
context, context,
store, store,
@ -121,12 +129,21 @@ class SearchInteractorTest {
val context: HomeActivity = mockk() val context: HomeActivity = mockk()
val store: SearchFragmentStore = mockk() val store: SearchFragmentStore = mockk()
val state: SearchFragmentState = mockk() val state: SearchFragmentState = mockk()
val searchEngine = SearchEngineSource.Default(mockk(relaxed = true))
every { context.metrics } returns mockk(relaxed = true) every { context.metrics } returns mockk(relaxed = true)
every { context.openToBrowserAndLoad(any(), any(), any()) } just Runs every { context.openToBrowserAndLoad(any(), any(), any()) } just Runs
every { store.state } returns state every { store.state } returns state
every { state.session } returns null every { state.session } returns null
every { state.searchEngineSource } returns searchEngine
every {
context.getSharedPreferences(
PREF_FILE_SEARCH_ENGINES,
Context.MODE_PRIVATE
)
} returns mockk(relaxed = true)
val searchController: SearchController = DefaultSearchController( val searchController: SearchController = DefaultSearchController(
context, context,
@ -162,6 +179,13 @@ class SearchInteractorTest {
every { state.session } returns null every { state.session } returns null
every { state.searchEngineSource } returns searchEngine every { state.searchEngineSource } returns searchEngine
every {
context.getSharedPreferences(
PREF_FILE_SEARCH_ENGINES,
Context.MODE_PRIVATE
)
} returns mockk(relaxed = true)
val searchController: SearchController = DefaultSearchController( val searchController: SearchController = DefaultSearchController(
context, context,
store, store,