blallo
/
fenix
1
0
Fork 0
Code Releases Activity

For #4776: Refactored UI tests. 

After removing the 'Privacy notice' and 'Help' items from the Settings screen
the UI tests for them became unneeded.
master
ValentinTimisica 2019-11-25 16:05:37 +02:00
parent b819cb11c9
commit 8b8f3d1b56
3 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/src/androidTest/java/org/mozilla/fenix/ui/SettingsAboutTest.kt
View File

@ -52,7 +52,6 @@ class SettingsAboutTest {
}.openSettings { }.openSettings {
// ABOUT // ABOUT
verifyAboutHeading() verifyAboutHeading()
verifyHelp()
verifyRateOnGooglePlay() verifyRateOnGooglePlay()
verifyAboutFirefoxPreview() verifyAboutFirefoxPreview()
} }

1
app/src/androidTest/java/org/mozilla/fenix/ui/SettingsPrivacyTest.kt
View File

@ -103,7 +103,6 @@ class SettingsPrivacyTest {
verifyDeleteBrowsingDataButton() verifyDeleteBrowsingDataButton()
verifyDeleteBrowsingDataOnQuitButton() verifyDeleteBrowsingDataOnQuitButton()
verifyDataCollectionButton() verifyDataCollectionButton()
verifyPrivacyNoticeButton()
verifyLeakCanaryButton() verifyLeakCanaryButton()
} }
} }

11
app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsRobot.kt
View File

@ -47,7 +47,6 @@ class SettingsRobot {
fun verifyDeleteBrowsingDataButton() = assertDeleteBrowsingDataButton() fun verifyDeleteBrowsingDataButton() = assertDeleteBrowsingDataButton()
fun verifyDeleteBrowsingDataOnQuitButton() = assertDeleteBrowsingDataOnQuitButton() fun verifyDeleteBrowsingDataOnQuitButton() = assertDeleteBrowsingDataOnQuitButton()
fun verifyDataCollectionButton() = assertDataCollectionButton() fun verifyDataCollectionButton() = assertDataCollectionButton()
fun verifyPrivacyNoticeButton() = assertPrivacyNoticeButton()
fun verifyLeakCanaryButton() = assertLeakCanaryButton() fun verifyLeakCanaryButton() = assertLeakCanaryButton()
fun verifySettingsView() = assertSettingsView() fun verifySettingsView() = assertSettingsView()
@ -59,7 +58,6 @@ class SettingsRobot {
// ABOUT SECTION // ABOUT SECTION
fun verifyAboutHeading() = assertAboutHeading() fun verifyAboutHeading() = assertAboutHeading()
fun verifyHelp() = assertHelp()
fun verifyRateOnGooglePlay() = assertRateOnGooglePlay() fun verifyRateOnGooglePlay() = assertRateOnGooglePlay()
fun verifyAboutFirefoxPreview() = assertAboutFirefoxPreview() fun verifyAboutFirefoxPreview() = assertAboutFirefoxPreview()
@ -191,9 +189,6 @@ private fun assertDeleteBrowsingDataOnQuitButton() {
private fun assertDataCollectionButton() = onView(ViewMatchers.withText("Data collection")) private fun assertDataCollectionButton() = onView(ViewMatchers.withText("Data collection"))
.check(matches(withEffectiveVisibility(Visibility.VISIBLE))) .check(matches(withEffectiveVisibility(Visibility.VISIBLE)))
private fun assertPrivacyNoticeButton() = onView(ViewMatchers.withText("Privacy notice"))
.check(matches(withEffectiveVisibility(Visibility.VISIBLE)))
private fun assertLeakCanaryButton() = onView(ViewMatchers.withText("LeakCanary")) private fun assertLeakCanaryButton() = onView(ViewMatchers.withText("LeakCanary"))
.check(matches(withEffectiveVisibility(Visibility.VISIBLE))) .check(matches(withEffectiveVisibility(Visibility.VISIBLE)))
@ -214,12 +209,6 @@ private fun assertAboutHeading() {
.check(matches(withEffectiveVisibility(Visibility.VISIBLE))) .check(matches(withEffectiveVisibility(Visibility.VISIBLE)))
} }
private fun assertHelp() {
TestHelper.scrollToElementByText("About Firefox Preview")
onView(ViewMatchers.withText("Help"))
.check(matches(withEffectiveVisibility(Visibility.VISIBLE)))
}
private fun assertRateOnGooglePlay() { private fun assertRateOnGooglePlay() {
TestHelper.scrollToElementByText("About Firefox Preview") TestHelper.scrollToElementByText("About Firefox Preview")
onView(ViewMatchers.withText("Rate on Google Play")) onView(ViewMatchers.withText("Rate on Google Play"))