Closes #1717: Removes search button from library
parent
d1c2ed2052
commit
85245d7b40
|
@ -18,7 +18,6 @@ import kotlinx.android.synthetic.main.fragment_library.*
|
||||||
import mozilla.appservices.places.BookmarkRoot
|
import mozilla.appservices.places.BookmarkRoot
|
||||||
import org.mozilla.fenix.R
|
import org.mozilla.fenix.R
|
||||||
import org.mozilla.fenix.library.bookmarks.BookmarkFragmentArgs
|
import org.mozilla.fenix.library.bookmarks.BookmarkFragmentArgs
|
||||||
import org.mozilla.fenix.utils.ItsNotBrokenSnack
|
|
||||||
|
|
||||||
class LibraryFragment : Fragment() {
|
class LibraryFragment : Fragment() {
|
||||||
|
|
||||||
|
@ -67,11 +66,6 @@ class LibraryFragment : Fragment() {
|
||||||
Navigation.findNavController(requireActivity(), R.id.container).navigateUp()
|
Navigation.findNavController(requireActivity(), R.id.container).navigateUp()
|
||||||
true
|
true
|
||||||
}
|
}
|
||||||
R.id.librarySearch -> {
|
|
||||||
// TODO Library Search
|
|
||||||
ItsNotBrokenSnack(context!!).showSnackbar(issueNumber = "1118")
|
|
||||||
true
|
|
||||||
}
|
|
||||||
else -> super.onOptionsItemSelected(item)
|
else -> super.onOptionsItemSelected(item)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -314,10 +314,6 @@ class BookmarkFragment : Fragment(), CoroutineScope, BackHandler, AccountObserve
|
||||||
.popBackStack(R.id.libraryFragment, true)
|
.popBackStack(R.id.libraryFragment, true)
|
||||||
true
|
true
|
||||||
}
|
}
|
||||||
R.id.librarySearch -> {
|
|
||||||
// TODO Library Search
|
|
||||||
true
|
|
||||||
}
|
|
||||||
R.id.open_bookmarks_in_new_tabs_multi_select -> {
|
R.id.open_bookmarks_in_new_tabs_multi_select -> {
|
||||||
getSelectedBookmarks().forEach { node ->
|
getSelectedBookmarks().forEach { node ->
|
||||||
node.url?.let {
|
node.url?.let {
|
||||||
|
|
|
@ -25,7 +25,6 @@ import mozilla.components.concept.storage.VisitType
|
||||||
import mozilla.components.support.base.feature.BackHandler
|
import mozilla.components.support.base.feature.BackHandler
|
||||||
import org.mozilla.fenix.BrowserDirection
|
import org.mozilla.fenix.BrowserDirection
|
||||||
import org.mozilla.fenix.HomeActivity
|
import org.mozilla.fenix.HomeActivity
|
||||||
import org.mozilla.fenix.utils.ItsNotBrokenSnack
|
|
||||||
import org.mozilla.fenix.R
|
import org.mozilla.fenix.R
|
||||||
import org.mozilla.fenix.ext.requireComponents
|
import org.mozilla.fenix.ext.requireComponents
|
||||||
import org.mozilla.fenix.mvi.ActionBusFactory
|
import org.mozilla.fenix.mvi.ActionBusFactory
|
||||||
|
@ -128,11 +127,6 @@ class HistoryFragment : Fragment(), CoroutineScope, BackHandler {
|
||||||
.popBackStack(R.id.libraryFragment, true)
|
.popBackStack(R.id.libraryFragment, true)
|
||||||
true
|
true
|
||||||
}
|
}
|
||||||
R.id.librarySearch -> {
|
|
||||||
// TODO Library Search #1118
|
|
||||||
ItsNotBrokenSnack(context!!).showSnackbar(issueNumber = "1118")
|
|
||||||
true
|
|
||||||
}
|
|
||||||
else -> super.onOptionsItemSelected(item)
|
else -> super.onOptionsItemSelected(item)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -5,13 +5,6 @@
|
||||||
<menu xmlns:android="http://schemas.android.com/apk/res/android"
|
<menu xmlns:android="http://schemas.android.com/apk/res/android"
|
||||||
xmlns:app="http://schemas.android.com/apk/res-auto"
|
xmlns:app="http://schemas.android.com/apk/res-auto"
|
||||||
xmlns:tools="http://schemas.android.com/tools">
|
xmlns:tools="http://schemas.android.com/tools">
|
||||||
<item
|
|
||||||
android:id="@+id/librarySearch"
|
|
||||||
android:icon="@drawable/ic_search"
|
|
||||||
android:iconTint="?primaryText"
|
|
||||||
android:title="@string/library_search"
|
|
||||||
app:showAsAction="ifRoom"
|
|
||||||
tools:targetApi="o" />
|
|
||||||
<item
|
<item
|
||||||
android:id="@+id/libraryClose"
|
android:id="@+id/libraryClose"
|
||||||
android:icon="@drawable/ic_close"
|
android:icon="@drawable/ic_close"
|
||||||
|
|
Loading…
Reference in New Issue