From 85245d7b40fd94d4a7318f2074ecf6bcc3814324 Mon Sep 17 00:00:00 2001 From: Sawyer Blatz Date: Thu, 18 Apr 2019 11:27:30 -0700 Subject: [PATCH] Closes #1717: Removes search button from library --- .../main/java/org/mozilla/fenix/library/LibraryFragment.kt | 6 ------ .../mozilla/fenix/library/bookmarks/BookmarkFragment.kt | 4 ---- .../org/mozilla/fenix/library/history/HistoryFragment.kt | 6 ------ app/src/main/res/menu/library_menu.xml | 7 ------- 4 files changed, 23 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/library/LibraryFragment.kt b/app/src/main/java/org/mozilla/fenix/library/LibraryFragment.kt index 6761d5e50..2d0703dc9 100644 --- a/app/src/main/java/org/mozilla/fenix/library/LibraryFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/library/LibraryFragment.kt @@ -18,7 +18,6 @@ import kotlinx.android.synthetic.main.fragment_library.* import mozilla.appservices.places.BookmarkRoot import org.mozilla.fenix.R import org.mozilla.fenix.library.bookmarks.BookmarkFragmentArgs -import org.mozilla.fenix.utils.ItsNotBrokenSnack class LibraryFragment : Fragment() { @@ -67,11 +66,6 @@ class LibraryFragment : Fragment() { Navigation.findNavController(requireActivity(), R.id.container).navigateUp() true } - R.id.librarySearch -> { - // TODO Library Search - ItsNotBrokenSnack(context!!).showSnackbar(issueNumber = "1118") - true - } else -> super.onOptionsItemSelected(item) } } diff --git a/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkFragment.kt b/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkFragment.kt index 2ddb10e7d..182850267 100644 --- a/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkFragment.kt @@ -314,10 +314,6 @@ class BookmarkFragment : Fragment(), CoroutineScope, BackHandler, AccountObserve .popBackStack(R.id.libraryFragment, true) true } - R.id.librarySearch -> { - // TODO Library Search - true - } R.id.open_bookmarks_in_new_tabs_multi_select -> { getSelectedBookmarks().forEach { node -> node.url?.let { diff --git a/app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt b/app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt index efccc1347..5306c72ad 100644 --- a/app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt @@ -25,7 +25,6 @@ import mozilla.components.concept.storage.VisitType import mozilla.components.support.base.feature.BackHandler import org.mozilla.fenix.BrowserDirection import org.mozilla.fenix.HomeActivity -import org.mozilla.fenix.utils.ItsNotBrokenSnack import org.mozilla.fenix.R import org.mozilla.fenix.ext.requireComponents import org.mozilla.fenix.mvi.ActionBusFactory @@ -128,11 +127,6 @@ class HistoryFragment : Fragment(), CoroutineScope, BackHandler { .popBackStack(R.id.libraryFragment, true) true } - R.id.librarySearch -> { - // TODO Library Search #1118 - ItsNotBrokenSnack(context!!).showSnackbar(issueNumber = "1118") - true - } else -> super.onOptionsItemSelected(item) } } diff --git a/app/src/main/res/menu/library_menu.xml b/app/src/main/res/menu/library_menu.xml index 29f37dd54..ec0b6816b 100644 --- a/app/src/main/res/menu/library_menu.xml +++ b/app/src/main/res/menu/library_menu.xml @@ -5,13 +5,6 @@ -