From 77e7c6d33c2e3cb4256493f873b7beecc9b41c02 Mon Sep 17 00:00:00 2001 From: Grisha Kruglov Date: Thu, 21 Mar 2019 11:26:02 -0700 Subject: [PATCH] A-C breaking change: FindInPageIntegration needs an engineView --- .../main/java/org/mozilla/fenix/browser/BrowserFragment.kt | 4 +++- .../org/mozilla/fenix/components/FindInPageIntegration.kt | 6 ++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt b/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt index 22d5adbe1..a487bbd88 100644 --- a/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt @@ -163,7 +163,9 @@ class BrowserFragment : Fragment(), BackHandler { view = view) findInPageIntegration.set( - feature = FindInPageIntegration(requireComponents.core.sessionManager, view.findInPageView), + feature = FindInPageIntegration( + requireComponents.core.sessionManager, view.findInPageView, view.engineView + ), owner = this, view = view) diff --git a/app/src/main/java/org/mozilla/fenix/components/FindInPageIntegration.kt b/app/src/main/java/org/mozilla/fenix/components/FindInPageIntegration.kt index 26c636982..84bcd1f0c 100644 --- a/app/src/main/java/org/mozilla/fenix/components/FindInPageIntegration.kt +++ b/app/src/main/java/org/mozilla/fenix/components/FindInPageIntegration.kt @@ -10,6 +10,7 @@ import android.view.View import androidx.coordinatorlayout.widget.CoordinatorLayout import mozilla.components.browser.session.SessionManager import mozilla.components.browser.toolbar.BrowserToolbar +import mozilla.components.concept.engine.EngineView import mozilla.components.feature.findinpage.FindInPageFeature import mozilla.components.feature.findinpage.view.FindInPageBar import mozilla.components.feature.findinpage.view.FindInPageView @@ -18,9 +19,10 @@ import mozilla.components.support.base.feature.LifecycleAwareFeature class FindInPageIntegration( private val sessionManager: SessionManager, - private val view: FindInPageView + private val view: FindInPageView, + engineView: EngineView ) : LifecycleAwareFeature, BackHandler { - private val feature = FindInPageFeature(sessionManager, view, ::onClose) + private val feature = FindInPageFeature(sessionManager, view, engineView, ::onClose) override fun start() { feature.start()