Update LongParameterList baseline

app/src/main/java/org/mozilla/fenix/collections/TabDiffUtil.kt

@@ -10,7 +10,6 @@ import org.mozilla.fenix.home.Tab
 /**
  * Diff callback for comparing tab lists with selected state.
  */
-@Suppress("LongParameterList")
 internal class TabDiffUtil(
     private val old: List<Tab>,
     private val new: List<Tab>,

app/src/main/java/org/mozilla/fenix/components/BackgroundServices.kt

@@ -47,6 +47,7 @@ import org.mozilla.fenix.utils.Settings
  * background worker.
  */
 @Mockable
+@Suppress("LongParameterList")
 class BackgroundServices(
     private val context: Context,
     private val push: Push,

app/src/main/java/org/mozilla/fenix/components/IntentProcessors.kt

@@ -25,6 +25,7 @@ import org.mozilla.fenix.utils.Mockable
  * Component group for miscellaneous components.
  */
 @Mockable
+@Suppress("LongParameterList")
 class IntentProcessors(
     private val context: Context,
     private val sessionManager: SessionManager,

app/src/main/java/org/mozilla/fenix/components/UseCases.kt

@@ -27,6 +27,7 @@ import org.mozilla.fenix.utils.Mockable
  * modules and can be triggered by UI interactions.
  */
 @Mockable
+@Suppress("LongParameterList")
 class UseCases(
     private val context: Context,
     private val engine: Engine,

app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt

@@ -42,7 +42,7 @@ import org.mozilla.fenix.theme.ThemeManager
  * @param lifecycleOwner View lifecycle owner used to determine when to cancel UI jobs.
  * @param bookmarksStorage Used to check if a page is bookmarked.
  */
-@Suppress("LargeClass")
+@Suppress("LargeClass", "LongParameterList")
 class DefaultToolbarMenu(
     private val context: Context,
     private val sessionManager: SessionManager,

app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarIntegration.kt

@@ -68,7 +68,6 @@ abstract class ToolbarIntegration(
     }
 }
 
-@Suppress("LongParameterList")
 class DefaultToolbarIntegration(
     context: Context,
     toolbar: BrowserToolbar,

app/src/main/java/org/mozilla/fenix/downloads/DynamicDownloadDialog.kt

@@ -21,8 +21,8 @@ import org.mozilla.fenix.ext.settings
  * [DynamicDownloadDialog] is used to show a view in the current tab to the user, triggered when
  *  downloadFeature.onDownloadStopped gets invoked. It uses [DynamicDownloadDialogBehavior] to
  *  hide when the users scrolls through a website as to not impede his activities.
- * */
+ */
-
+@Suppress("LongParameterList")
 class DynamicDownloadDialog(
     private val container: ViewGroup,
     private val downloadState: DownloadState?,

app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt

@@ -43,7 +43,7 @@ import mozilla.components.feature.tab.collections.Tab as ComponentTab
  * [HomeFragment] controller. An interface that handles the view manipulation of the Tabs triggered
  * by the Interactor.
  */
-@SuppressWarnings("TooManyFunctions")
+@Suppress("TooManyFunctions")
 interface SessionControlController {
     /**
      * @see [CollectionInteractor.onCollectionAddTabTapped]
@@ -146,7 +146,7 @@ interface SessionControlController {
     fun handleCreateCollection()
 }
 
-@SuppressWarnings("TooManyFunctions", "LargeClass", "LongParameterList")
+@Suppress("TooManyFunctions", "LargeClass")
 class DefaultSessionControlController(
     private val activity: HomeActivity,
     private val engine: Engine,

app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlView.kt

@@ -20,7 +20,7 @@ import org.mozilla.fenix.home.OnboardingState
 
 // This method got a little complex with the addition of the tab tray feature flag
 // When we remove the tabs from the home screen this will get much simpler again.
-@SuppressWarnings("LongParameterList", "ComplexMethod")
+@Suppress("ComplexMethod")
 private fun normalModeAdapterItems(
     topSites: List<TopSite>,
     collections: List<TabCollection>,

app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkController.kt

@@ -28,7 +28,7 @@ import org.mozilla.fenix.ext.nav
  * [BookmarkFragment] controller.
  * Delegated by View Interactors, handles container business logic and operates changes on it.
  */
-@SuppressWarnings("TooManyFunctions")
+@Suppress("TooManyFunctions")
 interface BookmarkController {
     fun handleBookmarkChanged(item: BookmarkNode)
     fun handleBookmarkTapped(item: BookmarkNode)
@@ -47,7 +47,7 @@ interface BookmarkController {
     fun handleBackPressed()
 }
 
-@SuppressWarnings("TooManyFunctions", "LongParameterList")
+@Suppress("TooManyFunctions")
 class DefaultBookmarkController(
     private val activity: HomeActivity,
     private val navController: NavController,

app/src/main/java/org/mozilla/fenix/tabtray/TabTrayController.kt

@@ -53,7 +53,7 @@ interface TabTrayController {
  * @param showChooseCollectionDialog callback allowing saving a list of sessions to an existing collection.
  * @param showAddNewCollectionDialog callback allowing for saving a list of sessions to a new collection.
  */
-@Suppress("TooManyFunctions", "LongParameterList")
+@Suppress("TooManyFunctions")
 class DefaultTabTrayController(
     private val activity: HomeActivity,
     private val navController: NavController,

build.gradle

@@ -147,7 +147,6 @@ detekt {
     version = "1.9.1"
     input = files("$projectDir/app/src")
     config = files("$projectDir/config/detekt.yml")
-    baseline = file("$projectDir/config/detekt-baseline.xml")
 
     reports {
         html {

config/detekt.yml

@@ -76,9 +76,12 @@ complexity:
     # https://github.com/mozilla-mobile/fenix/issues/4861
     threshold: 75
   LongParameterList:
-    active: true
+    active: trued
-    threshold: 6
+    excludes: "**/*Controller.kt, **/*Integration.kt"
+    functionThreshold: 6
+    constructorThreshold: 7
     ignoreDefaultParameters: false
+    ignoreDataClasses: true
   MethodOverloading:
     active: false
     threshold: 6