From 29f089c414b3c24989345477c2649b8b145aacb9 Mon Sep 17 00:00:00 2001
From: Sawyer Blatz <sdblatz@gmail.com>
Date: Thu, 1 Aug 2019 09:25:46 -0700
Subject: [PATCH] For #2203: Polishes BrowserToolbarMenu

---
 .../mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt | 3 ++-
 .../res/drawable/sync_error_background_with_ripple.xml     | 7 +++++++
 app/src/main/res/layout/fragment_browser.xml               | 1 +
 app/src/main/res/values/dimens.xml                         | 2 +-
 4 files changed, 11 insertions(+), 2 deletions(-)
 create mode 100644 app/src/main/res/drawable/sync_error_background_with_ripple.xml

diff --git a/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt b/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt
index b3356d1aa..6988f60da 100644
--- a/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt
+++ b/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt
@@ -116,7 +116,8 @@ class DefaultToolbarMenu(
                 highlight = if (hasAccountProblem) {
                     BrowserMenuHighlightableItem.Highlight(
                         imageResource = R.drawable.ic_alert,
-                        backgroundResource = R.color.sync_error_background_color
+                        backgroundResource = R.drawable.sync_error_background_with_ripple,
+                        colorResource = R.color.sync_error_background_color
                     )
                 } else null
             ) {
diff --git a/app/src/main/res/drawable/sync_error_background_with_ripple.xml b/app/src/main/res/drawable/sync_error_background_with_ripple.xml
new file mode 100644
index 000000000..5d7bb6628
--- /dev/null
+++ b/app/src/main/res/drawable/sync_error_background_with_ripple.xml
@@ -0,0 +1,7 @@
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+<ripple xmlns:android="http://schemas.android.com/apk/res/android"
+        android:color="?colorControlHighlight">
+    <item android:drawable="@color/sync_error_background_color" />
+</ripple>
diff --git a/app/src/main/res/layout/fragment_browser.xml b/app/src/main/res/layout/fragment_browser.xml
index a974bb66f..33a5ca52e 100644
--- a/app/src/main/res/layout/fragment_browser.xml
+++ b/app/src/main/res/layout/fragment_browser.xml
@@ -39,6 +39,7 @@
         android:background="?foundation"
         android:clickable="true"
         android:visibility="gone"
+        android:elevation="5dp"
         app:findInPageNoMatchesTextColor="?attr/destructive"
         mozac:findInPageButtonsTint="?primaryText"
         mozac:findInPageResultCountTextColor="?primaryText" />
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
index 48659067f..398f858ed 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -41,7 +41,7 @@
     <dimen name="bottom_sheet_top_padding">8dp</dimen>
 
     <!-- Browser Toolbar -->
-    <dimen name="browser_toolbar_height">56dp</dimen>
+    <dimen name="browser_toolbar_height">57dp</dimen>
     <dimen name="toolbar_and_qab_height">67dp</dimen>
 
     <!-- SignIn Component -->