For #9798: Disable buttons on hiding and enable on showing.
This is triggered on collection expanding or shrinking that is animated. The animation has android:fillEnabled="true" android:fillAfter="true". This interferes with set visibility to gone and the click still triggers. Disabling button avoids changing animation or force clearing it.master
parent
de311aef85
commit
177baf58a8
|
@ -17,7 +17,9 @@ import mozilla.components.browser.menu.item.SimpleBrowserMenuItem
|
||||||
import mozilla.components.feature.tab.collections.TabCollection
|
import mozilla.components.feature.tab.collections.TabCollection
|
||||||
import org.mozilla.fenix.R
|
import org.mozilla.fenix.R
|
||||||
import org.mozilla.fenix.ext.getIconColor
|
import org.mozilla.fenix.ext.getIconColor
|
||||||
|
import org.mozilla.fenix.ext.hideAndDisable
|
||||||
import org.mozilla.fenix.ext.increaseTapArea
|
import org.mozilla.fenix.ext.increaseTapArea
|
||||||
|
import org.mozilla.fenix.ext.showAndEnable
|
||||||
import org.mozilla.fenix.home.sessioncontrol.CollectionInteractor
|
import org.mozilla.fenix.home.sessioncontrol.CollectionInteractor
|
||||||
import org.mozilla.fenix.theme.ThemeManager
|
import org.mozilla.fenix.theme.ThemeManager
|
||||||
|
|
||||||
|
@ -78,11 +80,11 @@ class CollectionViewHolder(
|
||||||
|
|
||||||
view.isActivated = expanded
|
view.isActivated = expanded
|
||||||
if (expanded) {
|
if (expanded) {
|
||||||
view.collection_share_button.visibility = View.VISIBLE
|
view.collection_share_button.showAndEnable()
|
||||||
view.collection_overflow_button.visibility = View.VISIBLE
|
view.collection_overflow_button.showAndEnable()
|
||||||
} else {
|
} else {
|
||||||
view.collection_share_button.visibility = View.GONE
|
view.collection_share_button.hideAndDisable()
|
||||||
view.collection_overflow_button.visibility = View.GONE
|
view.collection_overflow_button.hideAndDisable()
|
||||||
}
|
}
|
||||||
|
|
||||||
view.collection_icon.colorFilter = createBlendModeColorFilterCompat(
|
view.collection_icon.colorFilter = createBlendModeColorFilterCompat(
|
||||||
|
|
Loading…
Reference in New Issue