blallo
/
fenix
1
0
Fork 0
Code Releases Activity

For #11380: Update migration tip text

master
Sawyer Blatz 2020-06-11 12:46:38 -07:00 committed by Emily Kager
parent a2f087b816
commit 0a9afbed42
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/org/mozilla/fenix/components/tips/providers/MigrationTipProvider.kt
View File

@ -36,7 +36,7 @@ class MigrationTipProvider(private val context: Context) : TipProvider {
private fun firefoxPreviewMovedTip(): Tip = private fun firefoxPreviewMovedTip(): Tip =
Tip( Tip(
type = TipType.Button( type = TipType.Button(
text = context.getString(R.string.tip_firefox_preview_moved_button), text = context.getString(R.string.tip_firefox_preview_moved_button_2),
action = ::getFirefoxMovedButtonAction action = ::getFirefoxMovedButtonAction
), ),
identifier = getIdentifier(), identifier = getIdentifier(),

4
app/src/main/res/values/strings.xml
View File

@ -900,8 +900,8 @@
<string name="tip_firefox_preview_moved_description"> <string name="tip_firefox_preview_moved_description">
Firefox Nightly gets updated every night and has experimental new features. Firefox Nightly gets updated every night and has experimental new features.
However, it may be less stable. Download our beta browser for a more stable experience.</string> However, it may be less stable. Download our beta browser for a more stable experience.</string>
<!-- text for firefox preview moving tip button. "Mozilla Firefox Browser" is intentionally hardcoded --> <!-- text for firefox preview moving tip button. "Firefox for Android Beta" is intentionally hardcoded -->
<string name="tip_firefox_preview_moved_button">Get Mozilla Firefox Browser</string> <string name="tip_firefox_preview_moved_button_2">Get Firefox for Android Beta</string>
<!-- text for firefox preview moving tip header. "Firefox Nightly" is intentionally hardcoded --> <!-- text for firefox preview moving tip header. "Firefox Nightly" is intentionally hardcoded -->
<string name="tip_firefox_preview_moved_header_preview_installed">Firefox Nightly has moved</string> <string name="tip_firefox_preview_moved_header_preview_installed">Firefox Nightly has moved</string>

2
app/src/test/java/org/mozilla/fenix/components/tips/providers/MigrationTipProviderTest.kt
View File

@ -69,7 +69,7 @@ class MigrationTipProviderTest {
val tip = provider.tip!! val tip = provider.tip!!
val button = tip.type as TipType.Button val button = tip.type as TipType.Button
assertEquals( assertEquals(
context.getString(R.string.tip_firefox_preview_moved_button), context.getString(R.string.tip_firefox_preview_moved_button_2),
button.text button.text
) )
assertEquals( assertEquals(