From d2dff6a821a6da55bfbd21155f91cae915a0e4c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jens=20Lechtenb=C3=B6rger?= Date: Sun, 8 Nov 2020 17:39:04 +0100 Subject: [PATCH] Fix target for click on progress bar The progress bar shows how many slides have been passed in total. However, when clicking on the progress bar, the target slide is computed among the subset of /horizontal/ slides. Thus, when the new slide is displayed, the progress bar has usually changed to a point that is unrelated to the clicked one, which I find surprising. With this change, the target slide is computed from the number of total slides. Thus, after a click on the progress bar, the resulting progress is close to the clicked point, which seems more natural to me. --- js/controllers/progress.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/js/controllers/progress.js b/js/controllers/progress.js index e806e38..82a370a 100644 --- a/js/controllers/progress.js +++ b/js/controllers/progress.js @@ -88,14 +88,16 @@ export default class Progress { event.preventDefault(); - let slidesTotal = this.Reveal.getHorizontalSlides().length; + let slides = this.Reveal.getSlides(); + let slidesTotal = slides.length; let slideIndex = Math.floor( ( event.clientX / this.getMaxWidth() ) * slidesTotal ); if( this.Reveal.getConfig().rtl ) { slideIndex = slidesTotal - slideIndex; } - this.Reveal.slide( slideIndex ); + let targetIndices = this.Reveal.getIndices(slides[slideIndex]); + this.Reveal.slide( targetIndices.h, targetIndices.v ); }