1
0
Fork 0
fenix/app/src/main/java/org/mozilla/fenix/components
Severin Rudie 6909a76bcb
4281 remove qab (#6310)
* For #4281: small ToolbarMenu refactor

This makes it easier to see how items are ordered in the menuItems list

* For 4281: add QAB buttons to menu

* For 4281: removed menu back button per mocks

I double checked with UX, and we'll be relying on the hardware back button for its functionality

* For 4281: add content descriptions for bookmarking

* For 4281: updated BrowserToolbarController for new functionality

* For 4281: provided simple dependencies to browser controller

More complex changes will be in a following commit, for review readability

* For 4281: move toolbar controller dependencies up to BaseBrowserFragment

The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones

* For 4281: removed (now unused) code related to QAB

* For 4281: fix test compilation after QAB removal

Tests still need to be expanded to include added functionality

* For 4281: updated menu to show if url is bookmarked

This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.

https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.

* For 4281: update reader mode switch

* For 4281: selectively show/hide menu items

* For 4281: add reader mode appearance

* For 4281: update bookmark button when it is clicked

* For 4281: removed unused QAB code

* For 4281: removed QAB robot, updated UI tests

* For 4281: removed QuickActionSheet metrics

Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped

* For 4281: fixed lint errors

* For 4281: add new strings for buttons added to menu

This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages

* For 4281: remove outdated TODOs

* For 4281: removed QAB container

* For 4281: removed back button reference from UI test

This button no longer exists

* For 4821: Fixes a visual defect (extra padding on top of toolbar)

* For 4281: update copy on reader mode

* For 4281: fixed review nits
2019-11-11 17:10:14 -08:00
..
history For #4137 - Adds pagination to the history view 2019-07-31 14:35:33 -07:00
metrics 4281 remove qab (#6310) 2019-11-11 17:10:14 -08:00
toolbar 4281 remove qab (#6310) 2019-11-11 17:10:14 -08:00
AccountAbnormalities.kt For #6490 - track abnormal FxA behaviour via Sentry 2019-11-07 15:11:41 -08:00
Analytics.kt For #235 - Add Glean crash count + docs. 2019-09-30 08:32:33 -07:00
BackgroundServices.kt For #6490 - track abnormal FxA behaviour via Sentry 2019-11-07 15:11:41 -08:00
Components.kt For #6490 - track abnormal FxA behaviour via Sentry 2019-11-07 15:11:41 -08:00
Core.kt Use ManifestUpdateFeature 2019-11-07 14:50:24 -08:00
FenixSnackbar.kt For 5092 - Show a Snackbar with retry option if sharing to devices fails (#5158) 2019-09-26 12:30:28 -07:00
FindInPageIntegration.kt For #778: Follow-up to fix find in page 2019-10-09 17:14:14 -04:00
FirebasePush.kt Revert "For #373 - Integrate leanplum-fcm" 2019-10-25 10:24:40 -04:00
FxaServer.kt fixing more reviewers comments 2019-10-08 09:56:29 +02:00
InflationAwareFeature.kt Fix #4856 - Propagate LifecycleAwareFeature's onStart() to the inner feature 2019-09-06 14:20:02 -04:00
IntentProcessors.kt Fixes #5225 - Hide AuthCustomTabActivity 2019-10-18 10:56:06 -07:00
NotificationManager.kt Revert "For #373 - Integrate leanplum-fcm" 2019-10-25 10:24:40 -04:00
PermissionStorage.kt No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
PrivateShortcutCreateManager.kt No issue: Fixes string issues for l10n (#6158) 2019-10-24 08:24:19 -07:00
Search.kt Only use Context.settings() function (not getter) (#5335) 2019-09-24 10:33:46 -07:00
Services.kt Add fxa/sync integration tests 2019-10-08 09:56:29 +02:00
StoreProvider.kt No issue: Removes deprecated usage of ViewModelProviders 2019-08-07 19:21:41 -04:00
TabCollectionStorage.kt Closes #3332 - Do not alter text of hosts of tabs in collection 2019-07-17 09:02:30 -07:00
UseCases.kt Use ManifestUpdateFeature 2019-11-07 14:50:24 -08:00