1
0
Fork 0
fenix/app/src/main/java/org/mozilla/fenix/home
MozLando bb22fb3092 Merge #5507 #5846
5507: For #1383 Added tab title to close button content description r=ekager a=mcarare


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

5846: For #3604 Snackbar messages for closing tabs use closed instead of deleted r=sblatz a=mcarare


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
2019-10-11 16:28:36 +00:00
..
intent For #5567: Removes search shortcuts button (#5739) 2019-10-03 08:53:16 -07:00
sessioncontrol Merge #5507 #5846 2019-10-11 16:28:36 +00:00
HomeFragment.kt Merge #5507 #5846 2019-10-11 16:28:36 +00:00
HomeMenu.kt For #5442 - Show Delete Browsing Data on Quit option in home menu 2019-10-04 09:26:59 -07:00
HomeScreenViewModel.kt No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
ImageViewTopCrop.kt No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
Mode.kt No issue: Extract home fragment mode (#5343) 2019-09-23 09:33:55 -07:00
PrivateBrowsingButtonView.kt Move classes out of top-level package 2019-08-21 13:52:30 -07:00
SearchView.kt No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00