1
0
Fork 0
fenix/app/src/main/java/org/mozilla/fenix
Severin Rudie aa8642f534
#4596 migrate collections (#5911)
* For #4596: move code from CollectionCreationComponent to CollectionCreationStore

Other than adding comments, no changes were made. The code will be updated in a following commit. This is in order to make the commit diff more readable.

* For 4596: update CollectionCreateStore to libstate

* For 4596: copied CollectionCreationUIView into CollectionCreationView

Otherwise, no code was changed. The next commit will update this code. This is in order to make the commit diff more readable.

* For 4596: update CollectionCreationView to LibState

Note that the minimal changes possible to enable migration were made.  Refactoring will happen in a later commit.

* For 4596: updated CollectionCreationTabListAdapter to work with the new View

* For 4596: updated SaveCollectionListAdapter to work with the new View

* For 4596: implemented CollectionCreationController

For now, it has an identical interface to the interactor. In a later commit several of its responsibilities will be moved around, some to the interactor and some to the reducer

* For 4596: copied over previous reducer code

No other changes were made. The code will be updated in the following commit. This is done to make changes more readable for the reviewer

* For 4596: update reducer code param names

Otherwise, no changes at this time

* For 4596: add arguments to CreateCollectionFragment in nav_graph

These will be used to replace the current CreateCollectionViewModel, which shares data between fragments in a way that doesn't fit within our architecture.

* For 4596: pass arguments to collection via transaction instead of VM

The VM will be removed in a later commit

* For 4596: update BrowserToolbarController to share state to collection via its Direction

* For 4596: removed CreateCollectionViewModel

* For 4596: test tab retrieval in CreateCollectionFragment

* For 4596: fix crashing CreateCollectionFragmentTest

* For 4596: removed classes create collection classes used by old architecture

* For 4596: collection interactor rename + kdoc

* For 4596: moved collection interactor interface

* For 4596: renamed CreateCollectionFragment

All related classes followed the pattern of CollectionCreationX

* For 4596: kdoc CollectionCreationController

There's no effective difference between these calls and their interactor equivalent, so I linked to them

* For 4596: fix bug that caused rename to not work

* For 4596: removed unused collection actions

These were unused before the LibState refactor

* For 4596: kdoc StepChanged

* For 4596: removed todos about moving logic to the reducer

saveTabsToCollection: this could be moved, but that would involve creating a new action. SaveCollectionStep should probably be refactored out, so adding this layer of indirection seemed counterproductive

handleBackPress: needs to be able to call dismiss(). The reducer doesn't (and shouldn't) be able to do that, so this needs to live here

stepBack: called by handleBackPress. See above

* For 4596: wrote tests for CollectionCreationController#stepback

* For 4596: fixed tests broken by changes to collections

* For 4596: small readability refactor for CollectionController#stepBack

No change to functionality (see tests)

* For 4596: broke apart CollectionView#update

There's probably a lot more that could be done here, but smaller changes were made to reduce scope

* For 4596: remove unnecessary todos

It looks like we don't follow the suggested pattern in this project

* For 4596: test CollectionCreationController#normalSessionSize

* For 4596: updated naming in CollectionCreationController per review
2019-10-22 17:33:54 -07:00
..
browser #4596 migrate collections (#5911) 2019-10-22 17:33:54 -07:00
collections #4596 migrate collections (#5911) 2019-10-22 17:33:54 -07:00
components #4596 migrate collections (#5911) 2019-10-22 17:33:54 -07:00
crashes Closes #5847: Use IO thread when submitting crash report 2019-10-08 18:46:14 -07:00
customtabs Fixes #5225 - Hide AuthCustomTabActivity 2019-10-18 10:56:06 -07:00
downloads Closes #1657 - Use Gecko for downloads (#4296) 2019-08-02 17:28:30 -07:00
exceptions Optimized imports. Closes #5876 2019-10-10 04:17:43 +05:30
ext #4596 migrate collections (#5911) 2019-10-22 17:33:54 -07:00
home #4596 migrate collections (#5911) 2019-10-22 17:33:54 -07:00
lib Remove redundant super calls 2019-07-29 10:22:53 -07:00
library Closes #2435 Change edit icon to share icon on the book… (#6137) 2019-10-22 14:34:05 -07:00
onboarding Only use Context.settings() function (not getter) (#5335) 2019-09-24 10:33:46 -07:00
quickactionsheet For #5568 - Don't pass in Session for QuickActionSheetController 2019-09-25 13:33:38 -07:00
search For #6018 - Added back shortcuts button in awesomebar 2019-10-18 14:48:58 +03:00
session For 4780: add DefaultBrowsingModeManager tests 2019-10-08 15:13:17 -07:00
settings Fixes #5030: Modified Dialog to match the others. (#6022) 2019-10-21 09:59:04 -07:00
share Use the new fragment constructor 2019-10-07 11:07:48 -07:00
shortcut Cleanup shortcut code 2019-10-18 10:57:51 -07:00
theme For 4780: add DefaultBrowsingModeManager tests 2019-10-08 15:13:17 -07:00
trackingprotection For #6063 - changed ETP blocking info title strings (#6082) 2019-10-21 09:58:47 -07:00
utils For 4780: add DefaultBrowsingModeManager tests 2019-10-08 15:13:17 -07:00
whatsnew For #5656: Fixes nightly major version number crash 2019-09-27 15:06:57 -07:00
widget Closes #4711 - Extract VoiceSearchActivity (#5502) 2019-09-27 07:54:29 -07:00
AppRequestInterceptor.kt Only use Context.settings() function (not getter) (#5335) 2019-09-24 10:33:46 -07:00
BrowserDirection.kt For #5898: Default browser toggle sends user to SUMO on Android 5&6 (#5918) 2019-10-10 11:16:21 -07:00
Config.kt Removes legacy nightly automation 2019-10-10 11:13:23 -07:00
Experiments.kt FxA WebChannels integration 2019-09-16 19:44:13 -07:00
ExperimentsManager.kt For #5651 - Set up Standard vs Strict Tracking Protection Experiment 2019-10-05 10:14:09 -07:00
FeatureFlags.kt no issue - removed unused feature flags (#6143) 2019-10-21 09:52:01 -07:00
FenixApplication.kt For 4780: add DefaultBrowsingModeManager tests 2019-10-08 15:13:17 -07:00
FenixViewModelProvider.kt For #4529, #4427: Resuming after restoring instance state breaks UI (#4571) 2019-08-08 11:05:01 -05:00
GlobalDirections.kt For #4779 : Don't double navigate with global directions in HomeActivity 2019-08-23 12:01:28 -04:00
HomeActivity.kt For #5898: Default browser toggle sends user to SUMO on Android 5&6 (#5918) 2019-10-10 11:16:21 -07:00
IntentReceiverActivity.kt Cleanup shortcut code 2019-10-18 10:57:51 -07:00