1
0
Fork 0
fenix/app/src/test/java/org/mozilla/fenix
Severin Rudie 6909a76bcb
4281 remove qab (#6310)
* For #4281: small ToolbarMenu refactor

This makes it easier to see how items are ordered in the menuItems list

* For 4281: add QAB buttons to menu

* For 4281: removed menu back button per mocks

I double checked with UX, and we'll be relying on the hardware back button for its functionality

* For 4281: add content descriptions for bookmarking

* For 4281: updated BrowserToolbarController for new functionality

* For 4281: provided simple dependencies to browser controller

More complex changes will be in a following commit, for review readability

* For 4281: move toolbar controller dependencies up to BaseBrowserFragment

The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones

* For 4281: removed (now unused) code related to QAB

* For 4281: fix test compilation after QAB removal

Tests still need to be expanded to include added functionality

* For 4281: updated menu to show if url is bookmarked

This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.

https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.

* For 4281: update reader mode switch

* For 4281: selectively show/hide menu items

* For 4281: add reader mode appearance

* For 4281: update bookmark button when it is clicked

* For 4281: removed unused QAB code

* For 4281: removed QAB robot, updated UI tests

* For 4281: removed QuickActionSheet metrics

Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped

* For 4281: fixed lint errors

* For 4281: add new strings for buttons added to menu

This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages

* For 4281: remove outdated TODOs

* For 4281: removed QAB container

* For 4281: removed back button reference from UI test

This button no longer exists

* For 4821: Fixes a visual defect (extra padding on top of toolbar)

* For 4281: update copy on reader mode

* For 4281: fixed review nits
2019-11-11 17:10:14 -08:00
..
browser For #4456: Adds total_uri_count to metrics core ping (#6003) 2019-10-30 11:02:33 -07:00
collections #4596 migrate collections (#5911) 2019-10-22 17:33:54 -07:00
components 4281 remove qab (#6310) 2019-11-11 17:10:14 -08:00
crashes Closes #5847: Use IO thread when submitting crash report 2019-10-08 18:46:14 -07:00
customtabs For #6153 - Add powered by notification 2019-10-31 16:39:58 -07:00
exceptions Rename ExceptionsStore/State/Action to ExceptionsFragmentStore/State/Action. 2019-09-03 10:09:06 -07:00
ext For #4556: Removed redundant code in few tests. (#6367) 2019-11-07 13:20:51 -08:00
home Optimized imports. Closes #5876 2019-10-10 04:17:43 +05:30
library Optimized imports. Closes #5876 2019-10-10 04:17:43 +05:30
logins For #5544: Bare Minimum Logins UI 2019-10-24 10:29:03 -07:00
search For #6018 - Added unit tests for interactor and controller 2019-10-18 15:43:39 +03:00
settings For #6354 - Removes ETP Experiment, Removes Feature Flags, Sets Strict Default 2019-11-08 08:37:15 -08:00
share Removed ObsoleteCoroutinesApi from share tests. Closes #5876 2019-10-10 06:40:20 +05:30
trackingprotection For #5281 - Use TrackerLog for reporting ETP categories (#5556) 2019-09-25 10:48:06 -07:00
utils 4281 remove qab (#6310) 2019-11-11 17:10:14 -08:00
whatsnew Optimized imports. Closes #5876 2019-10-10 04:17:43 +05:30
widget Optimized imports. Closes #5876 2019-10-10 04:17:43 +05:30
AppRequestInterceptorTest.kt No issue: Refactor errors to risk level conversion. (#5710) 2019-10-30 11:08:45 -07:00
HomeActivityTest.kt Optimized imports. Closes #5876 2019-10-10 04:17:43 +05:30
IntentReceiverActivityTest.kt Optimized imports. Closes #5876 2019-10-10 04:17:43 +05:30
TestApplication.kt Remove @ObsoleteCoroutinesApi from TestCore 2019-10-08 15:49:40 -07:00
TestUtils.kt No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00