1
0
Fork 0
fenix/app/src/main/java/org/mozilla/fenix
Severin Rudie 6909a76bcb
4281 remove qab (#6310)
* For #4281: small ToolbarMenu refactor

This makes it easier to see how items are ordered in the menuItems list

* For 4281: add QAB buttons to menu

* For 4281: removed menu back button per mocks

I double checked with UX, and we'll be relying on the hardware back button for its functionality

* For 4281: add content descriptions for bookmarking

* For 4281: updated BrowserToolbarController for new functionality

* For 4281: provided simple dependencies to browser controller

More complex changes will be in a following commit, for review readability

* For 4281: move toolbar controller dependencies up to BaseBrowserFragment

The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones

* For 4281: removed (now unused) code related to QAB

* For 4281: fix test compilation after QAB removal

Tests still need to be expanded to include added functionality

* For 4281: updated menu to show if url is bookmarked

This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.

https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.

* For 4281: update reader mode switch

* For 4281: selectively show/hide menu items

* For 4281: add reader mode appearance

* For 4281: update bookmark button when it is clicked

* For 4281: removed unused QAB code

* For 4281: removed QAB robot, updated UI tests

* For 4281: removed QuickActionSheet metrics

Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped

* For 4281: fixed lint errors

* For 4281: add new strings for buttons added to menu

This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages

* For 4281: remove outdated TODOs

* For 4281: removed QAB container

* For 4281: removed back button reference from UI test

This button no longer exists

* For 4821: Fixes a visual defect (extra padding on top of toolbar)

* For 4281: update copy on reader mode

* For 4281: fixed review nits
2019-11-11 17:10:14 -08:00
..
browser 4281 remove qab (#6310) 2019-11-11 17:10:14 -08:00
collections Fixes #6341: Initialize 'selectedTabs' based on opened/selected tabs. 2019-10-31 16:22:14 -07:00
components 4281 remove qab (#6310) 2019-11-11 17:10:14 -08:00
crashes Closes #5847: Use IO thread when submitting crash report 2019-10-08 18:46:14 -07:00
customtabs 4281 remove qab (#6310) 2019-11-11 17:10:14 -08:00
downloads For #5958: Adds in app download notifications (#6506) 2019-11-11 14:08:51 -08:00
exceptions Use new API for ETP Exceptions 2019-11-05 12:45:58 -08:00
ext For #5848 Wrong toolbar colour - edit bookmark fragment (#6047) 2019-10-25 21:41:48 -07:00
home For #6342 Clicking add tab button from home screen finishes onboarding 2019-10-31 16:04:02 -07:00
lib Remove redundant super calls 2019-07-29 10:22:53 -07:00
library Fixes #6408: Pop stack to homeFragment when opening bookmarks from homeFragment 2019-11-07 16:00:48 -08:00
logins For #5547 - Add top level auth when accessing passwords 2019-11-07 13:45:41 -08:00
onboarding Only use Context.settings() function (not getter) (#5335) 2019-09-24 10:33:46 -07:00
search For #1211 Hide the keyboard when scrolling through engine suggestions (#6474) 2019-11-08 14:36:39 -08:00
session For #5733 - Private mode notification - wrong home screen (#6188) 2019-10-25 21:41:31 -07:00
settings Added Vibration Effect On Scanning QR Code (#6129) 2019-11-08 13:37:36 -08:00
share Use the new fragment constructor 2019-10-07 11:07:48 -07:00
shortcut Cleanup shortcut code 2019-10-18 10:57:51 -07:00
theme For 4780: add DefaultBrowsingModeManager tests 2019-10-08 15:13:17 -07:00
trackingprotection For #5709 Do not animate switch for ETP panel 2019-11-08 08:36:30 -08:00
utils 4281 remove qab (#6310) 2019-11-11 17:10:14 -08:00
whatsnew For #5656: Fixes nightly major version number crash 2019-09-27 15:06:57 -07:00
widget Closes #4711 - Extract VoiceSearchActivity (#5502) 2019-09-27 07:54:29 -07:00
AppRequestInterceptor.kt Use new API for ETP Exceptions 2019-11-05 12:45:58 -08:00
BrowserDirection.kt For #5898: Default browser toggle sends user to SUMO on Android 5&6 (#5918) 2019-10-10 11:16:21 -07:00
Config.kt For #6441: Fix variant build type matching (#6462) 2019-11-05 12:28:14 -08:00
Experiments.kt FxA WebChannels integration 2019-09-16 19:44:13 -07:00
FeatureFlags.kt For #6354 - Removes ETP Experiment, Removes Feature Flags, Sets Strict Default 2019-11-08 08:37:15 -08:00
FenixApplication.kt For #6354 - Removes ETP Experiment, Removes Feature Flags, Sets Strict Default 2019-11-08 08:37:15 -08:00
FenixViewModelProvider.kt For #4529, #4427: Resuming after restoring instance state breaks UI (#4571) 2019-08-08 11:05:01 -05:00
GlobalDirections.kt For #4779 : Don't double navigate with global directions in HomeActivity 2019-08-23 12:01:28 -04:00
HomeActivity.kt Closes #5678: Selected session may render in ExternalAppBrowserActivity 2019-10-28 09:43:33 -07:00
IntentReceiverActivity.kt For #5737: Adds telemetry for open links in a private tab (#5975) 2019-10-24 17:16:49 -07:00