1
0
Fork 0
fenix/app/src/main/res/layout
Severin Rudie 6909a76bcb
4281 remove qab (#6310)
* For #4281: small ToolbarMenu refactor

This makes it easier to see how items are ordered in the menuItems list

* For 4281: add QAB buttons to menu

* For 4281: removed menu back button per mocks

I double checked with UX, and we'll be relying on the hardware back button for its functionality

* For 4281: add content descriptions for bookmarking

* For 4281: updated BrowserToolbarController for new functionality

* For 4281: provided simple dependencies to browser controller

More complex changes will be in a following commit, for review readability

* For 4281: move toolbar controller dependencies up to BaseBrowserFragment

The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones

* For 4281: removed (now unused) code related to QAB

* For 4281: fix test compilation after QAB removal

Tests still need to be expanded to include added functionality

* For 4281: updated menu to show if url is bookmarked

This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.

https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.

* For 4281: update reader mode switch

* For 4281: selectively show/hide menu items

* For 4281: add reader mode appearance

* For 4281: update bookmark button when it is clicked

* For 4281: removed unused QAB code

* For 4281: removed QAB robot, updated UI tests

* For 4281: removed QuickActionSheet metrics

Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped

* For 4281: fixed lint errors

* For 4281: add new strings for buttons added to menu

This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages

* For 4281: remove outdated TODOs

* For 4281: removed QAB container

* For 4281: removed back button reference from UI test

This button no longer exists

* For 4821: Fixes a visual defect (extra padding on top of toolbar)

* For 4281: update copy on reader mode

* For 4281: fixed review nits
2019-11-11 17:10:14 -08:00
..
account_auth_error_preference.xml Use tools:text to avoid inflating strings twice (#3619) 2019-07-15 17:01:37 -05:00
account_preference.xml Closes #6236: Fix padding lint issues (#6240) 2019-10-24 10:52:30 -07:00
account_share_list_item.xml For #4007 - Use camelCase for views referenced from code 2019-08-29 18:12:50 -07:00
activity_home.xml For #225 - Deletes data on button press 2019-05-24 17:16:03 -07:00
app_share_list_item.xml For #4007 - Use camelCase for views referenced from code 2019-08-29 18:12:50 -07:00
browser_toolbar_popup_window.xml For #4155: Restyle to custom menu 2019-09-11 09:03:17 -07:00
checkbox_left_preference.xml For #514 & #5742: Updates "launch links in private tab" functionality (#5721) 2019-10-03 12:43:33 -07:00
collection_header.xml For #3004 - Restore MotionLayout on Home View only in onCreateView 2019-06-05 14:46:38 -07:00
collection_home_list_row.xml Fixes #4067 besides snackbar (#4777) 2019-08-27 10:09:55 -07:00
collection_tab_list_row.xml Use tools:listitem with collection creation (#6140) 2019-10-24 10:24:08 -07:00
collections_list_item.xml For #2977 - Update add new collections flow (#2991) 2019-05-31 12:59:51 -05:00
component_awesomebar.xml Closes #1618 - Add fade to awesome bar list instead of shadow (#3110) 2019-06-04 10:35:47 -05:00
component_bookmark.xml Issue #4513: add ProgressBar to bookmark component layout 2019-09-26 16:29:14 -07:00
component_collection_creation.xml Use tools:listitem with collection creation (#6140) 2019-10-24 10:24:08 -07:00
component_collection_creation_name_collection.xml Use tools:listitem with collection creation (#6140) 2019-10-24 10:24:08 -07:00
component_collection_creation_select_collection.xml Use tools:listitem with collection creation (#6140) 2019-10-24 10:24:08 -07:00
component_exceptions.xml For #5141 Changed "learn more" link to be accessible to Talkback users 2019-09-20 12:29:02 -07:00
component_history.xml Fixes #5128: Changed history_empty_view to match constraints. 2019-10-28 09:44:03 -07:00
component_permissions_blocked_by_android.xml Use tools:text to avoid inflating strings twice (#3619) 2019-07-15 17:01:37 -05:00
component_saved_logins.xml For #5544: Bare Minimum Logins UI 2019-10-24 10:29:03 -07:00
component_search.xml No issue: Set color for toolbar divider (#5221) 2019-09-11 11:46:00 -07:00
component_session_control.xml For #1287 - Create animation for opening and closing tab from home 2019-05-23 13:41:00 -07:00
component_sign_in.xml No issue: Sign in button style should be ThemeIndependentMaterialGreyButton 2019-10-24 10:32:29 -07:00
component_tracking_protection_panel.xml Closes #6369 - Use padding set from style for protection settings 2019-11-04 10:25:15 -08:00
delete_browsing_category_checkbox.xml For #514 & #5742: Updates "launch links in private tab" functionality (#5721) 2019-10-03 12:43:33 -07:00
delete_browsing_data_item.xml For #3106: Improve granular data deletion margins 2019-09-12 10:25:14 -07:00
delete_exceptions_button.xml Closes #3452 Closes #3553 - Implement one button style for all themes 2019-06-14 09:38:17 -07:00
download_notification_layout.xml For #5958: Adds in app download notifications (#6506) 2019-11-11 14:08:51 -08:00
exception_item.xml Use new API for ETP Exceptions 2019-11-05 12:45:58 -08:00
exceptions_description.xml Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
fenix_snackbar.xml For 5092 - Show a Snackbar with retry option if sharing to devices fails (#5158) 2019-09-26 12:30:28 -07:00
fragment_about.xml For #4474: Adds what's new button to home screen menu (#5088) 2019-09-03 15:16:29 -05:00
fragment_add_new_device.xml Closes #6236: Fix padding lint issues (#6240) 2019-10-24 10:52:30 -07:00
fragment_bookmark.xml Closes mozilla-mobile#4558 Change height of bookmark linearlayout 2019-10-24 09:46:09 -07:00
fragment_browser.xml 4281 remove qab (#6310) 2019-11-11 17:10:14 -08:00
fragment_crash_reporter.xml Extract and test crash reporter code 2019-09-20 11:04:11 -07:00
fragment_create_collection.xml #4596 migrate collections (#5911) 2019-10-22 17:33:54 -07:00
fragment_create_shortcut.xml Closes #6236: Fix padding lint issues (#6240) 2019-10-24 10:52:30 -07:00
fragment_delete_browsing_data.xml For #514 & #5742: Updates "launch links in private tab" functionality (#5721) 2019-10-03 12:43:33 -07:00
fragment_edit_bookmark.xml For #6145: Switch drawableTint to app compat version. (#6151) 2019-10-24 09:38:58 -07:00
fragment_exceptions.xml For #4341 use camelCase for views referenced from code 2019-08-03 09:25:55 -07:00
fragment_history.xml For #4341 use camelCase for views referenced from code 2019-08-03 09:25:55 -07:00
fragment_home.xml for #6008 - fix address bar layout on home fragment for RTL (#6016) 2019-10-21 10:02:13 -07:00
fragment_library.xml Use the new fragment constructor 2019-10-07 11:07:48 -07:00
fragment_manage_site_permissions_exceptions_feature_phone.xml Fixes #1691 - Site permissions' pages are not entirely visible 2019-04-17 15:59:44 -07:00
fragment_manage_site_permissions_feature_phone.xml Fixes #1691 - Site permissions' pages are not entirely visible 2019-04-17 15:59:44 -07:00
fragment_pair.xml For #4341 use camelCase for views referenced from code 2019-08-03 09:25:55 -07:00
fragment_quick_settings_dialog_sheet.xml For #6354 - Removes ETP Experiment, Removes Feature Flags, Sets Strict Default 2019-11-08 08:37:15 -08:00
fragment_saved_login_site_info.xml For #5544: Bare Minimum Logins UI 2019-10-24 10:29:03 -07:00
fragment_saved_logins.xml For #5544: Bare Minimum Logins UI 2019-10-24 10:29:03 -07:00
fragment_search.xml For #6269 Rtl-wrong-search-positioning (#6400) 2019-11-06 11:54:43 -08:00
fragment_select_bookmark_folder.xml Closes #4540 - Set correct tint for select bookmark folder icon (#4541) 2019-08-05 14:54:39 -07:00
fragment_share.xml For #2754 Add tab cards to share sheet (#5493) 2019-09-26 14:25:34 -07:00
fragment_sign_out.xml For #4341 use camelCase for views referenced from code 2019-08-03 09:25:55 -07:00
fragment_site_permissions_exceptions.xml For #5104: Cleanup - Use match_constraint instead of match_parent. 2019-10-25 13:28:38 -07:00
fragment_site_permissions_exceptions_item.xml Use tools:text to avoid inflating strings twice (#3619) 2019-07-15 17:01:37 -05:00
fragment_tracking_protection.xml Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
fragment_tracking_protection_blocking.xml Closes #6236: Fix padding lint issues (#6240) 2019-10-24 10:52:30 -07:00
fragment_turn_on_sync.xml No issue: Clean up preferences code (#4699) 2019-08-21 08:38:14 -07:00
history_list_item.xml Issue #2379 - Use LibrarySiteItemView in history 2019-08-02 17:15:41 -07:00
layout_clear_permission_button.xml For #3906 - Add backgrounds to Permissions Buttons (#3958) 2019-07-10 20:59:47 -05:00
layout_percentage_seek_bar.xml Closes #6236: Fix padding lint issues (#6240) 2019-10-24 10:52:30 -07:00
layout_url_background.xml Closes #6236: Fix padding lint issues (#6240) 2019-10-24 10:52:30 -07:00
library_list_item.xml No issue: Tune Home and Library UI from Updated Mocks 2019-03-21 23:28:52 -05:00
library_site_item.xml Create shared custom view for library items 2019-07-30 12:26:15 -04:00
logins_item.xml For #5544: Bare Minimum Logins UI 2019-10-24 10:29:03 -07:00
mozac_browser_menu_item_switch.xml For #1716 - Consolidate Switch Styles 2019-04-26 15:13:34 -07:00
mozac_ui_tabcounter_layout.xml Minify vector drawables 2019-06-14 09:37:35 -07:00
no_content_message.xml For #6145: Switch drawableTint to app compat version. (#6151) 2019-10-24 09:38:58 -07:00
onboarding_automatic_signin.xml No issue: Fix Crash lower API by setting gradient drawables in onBind 2019-08-02 16:18:34 -07:00
onboarding_finish.xml For #2780 - Fix home screen attributes for API 21-22 (#2844) 2019-05-24 14:03:59 -07:00
onboarding_header.xml No issue: Use ImageView rather than rebuilding drawable (#3616) 2019-06-26 16:03:06 -07:00
onboarding_manual_signin.xml No issue: Fix Crash lower API by setting gradient drawables in onBind 2019-08-02 16:18:34 -07:00
onboarding_privacy_notice.xml No issue: Use ImageView rather than rebuilding drawable (#3616) 2019-06-26 16:03:06 -07:00
onboarding_private_browsing.xml No issue: Use ImageView rather than rebuilding drawable (#3616) 2019-06-26 16:03:06 -07:00
onboarding_section_header.xml No issue: Use ImageView rather than rebuilding drawable (#3616) 2019-06-26 16:03:06 -07:00
onboarding_theme_picker.xml For #4526 Prevent automatic theme summary being cutoff with long text 2019-09-20 09:20:57 -07:00
onboarding_tracking_protection.xml No issue: Use ImageView rather than rebuilding drawable (#3616) 2019-06-26 16:03:06 -07:00
pbm_shortcut_popup.xml For #419: Create launch icon for private browsing (#4948) 2019-09-11 10:52:33 -07:00
preference_default_browser.xml Close #420 - Default Browser Preference reacts to default browser status 2019-02-22 10:56:24 -08:00
preference_search_engine_chooser.xml Closes #877 - Add Search Engine Settings 2019-03-06 16:20:35 -08:00
preference_widget_radiobutton.xml Closes #5573: fix radio-button spacing in settings 2019-10-07 13:07:53 -07:00
preference_widget_radiobutton_with_info.xml For #5709: Align ETP Settings Screen implementation with original mocks 2019-10-14 15:59:43 +03:00
private_browsing_description.xml For #5356 Improves private browsing "common myths" link accessibility (#5479) 2019-09-24 10:46:34 -07:00
quicksettings_permissions.xml For #4126 - Handle all business logic with Interactors and a Controller 2019-10-31 17:08:40 -07:00
quicksettings_tracking_protection.xml For #4126 - Refactor Views and layouts 2019-10-31 17:08:40 -07:00
quicksettings_website_info.xml For #4126 - Refactor Views and layouts 2019-10-31 17:08:40 -07:00
save_tab_group_button.xml For #4262: Updates color and text of buttons (#4250) 2019-07-25 11:01:25 -07:00
search_engine_radio_button.xml For #5142 Removed RadioButton from accessibility keeping one option for Talkback 2019-09-06 14:09:58 +02:00
search_widget_extra_small_v1.xml Fixes #4894: added workaround for SDK<24 vector drawable with gradient color (#4944) 2019-08-29 12:55:51 -07:00
search_widget_extra_small_v2.xml Fixes #4894: added workaround for SDK<24 vector drawable with gradient color (#4944) 2019-08-29 12:55:51 -07:00
search_widget_large.xml Fixes #4894: added workaround for SDK<24 vector drawable with gradient color (#4944) 2019-08-29 12:55:51 -07:00
search_widget_medium.xml Fixes #4894: added workaround for SDK<24 vector drawable with gradient color (#4944) 2019-08-29 12:55:51 -07:00
search_widget_small.xml Fixes #4894: added workaround for SDK<24 vector drawable with gradient color (#4944) 2019-08-29 12:55:51 -07:00
search_widget_small_no_mic.xml Fixes #4894: added workaround for SDK<24 vector drawable with gradient color (#4944) 2019-08-29 12:55:51 -07:00
share_close.xml For #2754 Add tab cards to share sheet (#5493) 2019-09-26 14:25:34 -07:00
share_tab_item.xml For #2754 Add tab cards to share sheet (#5493) 2019-09-26 14:25:34 -07:00
share_to_account_devices.xml For #4007 - Refactor AppShareView in standalone Share Views 2019-08-29 18:12:50 -07:00
share_to_apps.xml For #4007 - Refactor AppShareView in standalone Share Views 2019-08-29 18:12:50 -07:00
sign_in_preference.xml For #5497 Improve sync title/summary settings to support RTL 2019-10-24 10:32:59 -07:00
stub_find_in_page.xml For #4066: Provide lazy inflation of Find In Page View 2019-08-09 11:48:55 -04:00
switch_with_description.xml For #5229, #5228 - Dismiss ETP panel on back press, don't truncate text 2019-09-12 07:40:49 -07:00
tab_header.xml For #6179 - Changed positioning of private mode icons in tab he… (#6189) 2019-10-25 08:09:38 -07:00
tab_in_collection.xml No issue: Top aligns close button for tab in collection (#5161) 2019-09-09 11:08:30 -07:00
tab_list_row.xml For #1383 Added tab title to close button content description 2019-09-25 10:34:02 +03:00
tracking_protection_category.xml Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
tracking_protection_learn_more_preference.xml For #5709: Align ETP Settings Screen implementation with original mocks 2019-10-14 15:59:43 +03:00
tracking_protection_onboarding_popup.xml Merge #6026 2019-10-16 17:49:16 +00:00