1
0
Fork 0
fenix/app/src/main/res/menu
Elise Richards 023a4983fa
For #10173: login duplicates and save (#11208)
* Extract controller into it's own class. Implement find dupes and filter based on username.

Create edit login controller. Add text watchers and check for duplicates.

Edit controller test

* Find duplicates and save to store

* Retrieve duplicates from AC and check list on username text changed

Move duplicates logic into the controller

* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.

* Use correct threads in controller. Enable save button when applicable.

Save enabled in datastore.

Move login data to datastore

Rebase with password error states

Update metrics to be more specific for edit

* Create logins controller for AC calls

* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.

Inflate view in edit fragment. Double layout showing up.

Edit view

Controller tests

Controller tests passing

Interactor tests

Lint and detekt cleanup

* Remove datastore and use storage controller for all logins calls to password storage.

Addressed comments

Lint
:

Rebase - 1
2020-07-16 17:08:04 -05:00
..
add_custom_searchengine_menu.xml Adds custom search engines (#6551) 2019-11-19 16:30:56 -08:00
bookmarks_add_folder.xml For #11504: Rectify action bar button descriptions in bookmarks screen. 2020-06-12 09:33:20 -04:00
bookmarks_edit.xml For #3813 - Create a save button for bookmark editing 2020-01-21 16:03:33 -08:00
bookmarks_menu.xml For #10462: Removes back button from bookmarks and history fragments (#11721) 2020-06-22 13:15:33 -04:00
bookmarks_select_folder.xml For #11504: Rectify action bar button descriptions in bookmarks screen. 2020-06-12 09:33:20 -04:00
bookmarks_select_multi.xml Closes #2435 Change edit icon to share icon on the book… (#6137) 2019-10-22 14:34:05 -07:00
bookmarks_select_multi_not_item.xml For #5213 - Use support library attributes 2019-10-06 16:17:00 -07:00
edit_custom_searchengine_menu.xml Adds custom search engines (#6551) 2019-11-19 16:30:56 -08:00
history_select_multi.xml For #5213 - Use support library attributes 2019-10-06 16:17:00 -07:00
languages_list.xml For #9728: Add actionbar search for language list. 2020-04-29 11:20:18 -07:00
library_menu.xml For #10462: Removes back button from bookmarks and history fragments (#11721) 2020-06-22 13:15:33 -04:00
login_delete.xml Fixes #9504: Edit logins (#9693) 2020-05-12 17:32:01 -05:00
login_list.xml For #7087 - Add SearchView to Logins Fragment 2020-03-10 23:01:51 -07:00
login_options_menu.xml Closes #10629 - Update Content Description of Edit Login Menu Item 2020-06-05 08:12:43 +03:00
login_save.xml For #10173: login duplicates and save (#11208) 2020-07-16 17:08:04 -05:00
tab_tray_menu.xml For #10148 - Add basic tab tray implementation without exposing to rest of app (#9934) 2020-04-23 15:38:35 -05:00